consul

History

Derek Menteer 0ac958f27b Fix xDS missing endpoint race condition. (#19866 ) This fixes the following race condition: - Send update endpoints - Send update cluster - Recv ACK endpoints - Recv ACK cluster Prior to this fix, it would have resulted in the endpoints NOT existing in Envoy. This occurred because the cluster update implicitly clears the endpoints in Envoy, but we would never re-send the endpoint data to compensate for the loss, because we would incorrectly ACK the invalid old endpoint hash. Since the endpoint's hash did not actually change, they would not be resent. The fix for this is to effectively clear out the invalid pending ACKs for child resources whenever the parent changes. This ensures that we do not store the child's hash as accepted when the race occurs. An escape-hatch environment variable `XDS_PROTOCOL_LEGACY_CHILD_RESEND` was added so that users can revert back to the old legacy behavior in the event that this produces unknown side-effects. Visit the following thread for some extra context on why certainty around these race conditions is difficult: https://github.com/envoyproxy/envoy/issues/13009 This bug report and fix was mostly implemented by @ksmiley with some minor tweaks. Co-authored-by: Keith Smiley <ksmiley@salesforce.com>		12 months ago
..
accesslogs	catalog,mesh,auth: Bump versions to v2beta1 (#18930 )	1 year ago
config	…
configfetcher	…
extensionruntime	Remove old build tags (#19128 )	1 year ago
naming	…
platform	Remove old build tags (#19128 )	1 year ago
proxystateconverter	Migrate remaining individual resource tests for service mesh to TestAllResourcesFromSnapshot (#19583 )	1 year ago
response	…
testcommon	…
testdata	Migrate remaining individual resource tests for service mesh to TestAllResourcesFromSnapshot (#19583 )	1 year ago
validateupstream-test	…
clusters.go	Use strict DNS for mesh gateways with hostnames (#19268 )	1 year ago
clusters_test.go	Migrate remaining individual resource tests for service mesh to TestAllResourcesFromSnapshot (#19583 )	1 year ago
delta.go	Fix xDS missing endpoint race condition. (#19866 )	12 months ago
delta_envoy_extender_ce_test.go	Remove old build tags (#19128 )	1 year ago
delta_envoy_extender_test.go	…
delta_test.go	Fix xDS missing endpoint race condition. (#19866 )	12 months ago
endpoints.go	[NET-6221] Ensure LB policy set for locality-aware routing (CE) (#19283 )	1 year ago
endpoints_test.go	Migrate individual resource tests for Mesh Gateway to TestAllResourcesFromSnapshot (#19502 )	1 year ago
failover_policy.go	…
failover_policy_ce.go	Remove old build tags (#19128 )	1 year ago
golden_test.go	xds: update golden tests to be deterministic (#18707 )	1 year ago
gw_per_route_filters_ce.go	Remove old build tags (#19128 )	1 year ago
jwt_authn.go	…
jwt_authn_ce.go	[NET-5457] Fix CE code for jwt multiple virtual hosts bug (#19123 )	1 year ago
jwt_authn_test.go	…
listeners.go	Allow connections through Terminating Gateways from peered clusters NET-3463 (#18959 )	1 year ago
listeners_apigateway.go	[NET-5810] CE changes for multiple virtual hosts (#19246 )	1 year ago
listeners_ingress.go	…
listeners_test.go	Migrate remaining individual resource tests for service mesh to TestAllResourcesFromSnapshot (#19583 )	1 year ago
locality_policy.go	…
locality_policy_ce.go	Remove old build tags (#19128 )	1 year ago
protocol_trace.go	NET-5338 - NET-5338 - Run a v2 mode xds server (#18579 )	1 year ago
rbac.go	[APIGW] NET-5017 JWT Cleanup/Status Conditions (#18700 )	1 year ago
rbac_test.go	[NET-4931] xdsv2, sidecarproxycontroller, l4 trafficpermissions: support L7 (#19185 )	1 year ago
resources.go	…
resources_ce_test.go	Remove old build tags (#19128 )	1 year ago
resources_test.go	parse config protocol on write to optimize disco-chain compilation (#19829 )	12 months ago
routes.go	Add CE version of Gateway Upstream Disambiguation (#19860 )	12 months ago
routes_test.go	Migrate individual resource tests for API Gateway to TestAllResourcesFromSnapshot (#19584 )	1 year ago
secrets.go	…
server.go	Watch the ProxyTracker from xDS controller (#18611 )	1 year ago
server_ce.go	Remove old build tags (#19128 )	1 year ago
testing.go	…
xds.go	…
xds_protocol_helpers_test.go	Watch the ProxyTracker from xDS controller (#18611 )	1 year ago
z_xds_packages.go	…
z_xds_packages_test.go	…