consul

History

Paul Banks 74f2a80a42 Fix CA pruning when CA config uses string durations. (#4669 ) * Fix CA pruning when CA config uses string durations. The tl;dr here is: - Configuring LeafCertTTL with a string like "72h" is how we do it by default and should be supported - Most of our tests managed to escape this by defining them as time.Duration directly - Out actual default value is a string - Since this is stored in a map[string]interface{} config, when it is written to Raft it goes through a msgpack encode/decode cycle (even though it's written from server not over RPC). - msgpack decode leaves the string as a `[]uint8` - Some of our parsers required string and failed - So after 1 hour, a default configured server would throw an error about pruning old CAs - If a new CA was configured that set LeafCertTTL as a time.Duration, things might be OK after that, but if a new CA was just configured from config file, intialization would cause same issue but always fail still so would never prune the old CA. - Mostly this is just a janky error that got passed tests due to many levels of complicated encoding/decoding. tl;dr of the tl;dr: Yay for type safety. Map[string]interface{} combined with msgpack always goes wrong but we somehow get bitten every time in a new way :D We already fixed this once! The main CA config had the same problem so @kyhavlov already wrote the mapstructure DecodeHook that fixes it. It wasn't used in several places it needed to be and one of those is notw in `structs` which caused a dependency cycle so I've moved them. This adds a whole new test thta explicitly tests the case that broke here. It also adds tests that would have failed in other places before (Consul and Vaul provider parsing functions). I'm not sure if they would ever be affected as it is now as we've not seen things broken with them but it seems better to explicitly test that and support it to not be bitten a third time! * Typo fix * Fix bad Uint8 usage		6 years ago
..
ae	…
cache	Fixes #4421 : General solution to stop blocking queries with index 0 (#4437 )	6 years ago
cache-types	Fixes #4421 : General solution to stop blocking queries with index 0 (#4437 )	6 years ago
checks	agent/checks: prevent overflow of backoff	6 years ago
config	Implementation of Weights Data structures (#4468 )	6 years ago
connect	Fix CA pruning when CA config uses string durations. (#4669 )	6 years ago
consul	Fix CA pruning when CA config uses string durations. (#4669 )	6 years ago
exec	…
local	Implementation of Weights Data structures (#4468 )	6 years ago
metadata	…
mock	…
pool	…
proxy	Fix unit test TestOperatorAutopilotGetConfigCommand (#4594 )	6 years ago
router	…
structs	Fix CA pruning when CA config uses string durations. (#4669 )	6 years ago
systemd	…
token	…
acl.go	Updated swith case to use same branch for async-cache and extend-cache	6 years ago
acl_endpoint.go	…
acl_endpoint_test.go	BUGFIX: Unit test relying on WaitForLeader() did not work due to wrong test (#4472 )	6 years ago
acl_test.go	BUGFIX: Unit test relying on WaitForLeader() did not work due to wrong test (#4472 )	6 years ago
agent.go	Allow disabling the HTTP API again. (#4655 )	6 years ago
agent_endpoint.go	Ensure that Proxies ARE always cleaned up, event with DeregisterCriticalServiceAfter (#4649 )	6 years ago
agent_endpoint_test.go	Fix more unstable tests in agent and command	6 years ago
agent_test.go	Allow disabling the HTTP API again. (#4655 )	6 years ago
bindata_assetfs.go	Release v1.2.2	6 years ago
blacklist.go	…
blacklist_test.go	…
catalog_endpoint.go	…
catalog_endpoint_test.go	Fix unstable tests in agent, api, and command/watch	6 years ago
check.go	…
config.go	…
connect_ca_endpoint.go	Fix CA pruning when CA config uses string durations. (#4669 )	6 years ago
connect_ca_endpoint_test.go	Fix more unstable tests in agent and command	6 years ago
coordinate_endpoint.go	…
coordinate_endpoint_test.go	Fix more unstable tests in agent and command	6 years ago
dns.go	Add ECS option to EDNS responses where appropriate (#4647 )	6 years ago
dns_test.go	Add ECS option to EDNS responses where appropriate (#4647 )	6 years ago
enterprise_delegate_oss.go	…
event_endpoint.go	Fixes memory leak when blocking on /event/list (#4482 )	6 years ago
event_endpoint_test.go	Fix more unstable tests in agent and command	6 years ago
health_endpoint.go	…
health_endpoint_test.go	Fix more unstable tests in agent and command	6 years ago
http.go	Fixes #4483 : Add support for Authorization: Bearer token Header (#4502 )	6 years ago
http_oss.go	…
http_oss_test.go	…
http_test.go	Fixes #4483 : Add support for Authorization: Bearer token Header (#4502 )	6 years ago
intentions_endpoint.go	agent: 400 error on invalid UUID format, api handles errors properly	7 years ago
intentions_endpoint_test.go	agent: 400 error on invalid UUID format, api handles errors properly	7 years ago
keyring.go	…
keyring_test.go	…
kvs_endpoint.go	…
kvs_endpoint_test.go	Improve reliability of tests with TestAgent (#4525 )	6 years ago
notify.go	Fixes memory leak when blocking on /event/list (#4482 )	6 years ago
notify_test.go	Fixes memory leak when blocking on /event/list (#4482 )	6 years ago
operator_endpoint.go	…
operator_endpoint_test.go	Fix unstable tests in agent, api, and command/watch	6 years ago
prepared_query_endpoint.go	…
prepared_query_endpoint_test.go	Fix unstable tests in agent, api, and command/watch	6 years ago
remote_exec.go	…
remote_exec_test.go	Fix unstable tests in agent, api, and command/watch	6 years ago
retry_join.go	agent: configure k8s go-discover	6 years ago
retry_join_test.go	Vendoring update for go-discover. (#4412 )	6 years ago
session_endpoint.go	…
session_endpoint_test.go	Implementation of Weights Data structures (#4468 )	6 years ago
snapshot_endpoint.go	…
snapshot_endpoint_test.go	…
status_endpoint.go	…
status_endpoint_test.go	…
testagent.go	Fix #4515 : Segfault when serf_wan port was -1 but reconnect_time_wan was set (#4531 )	6 years ago
testagent_test.go	…
translate_addr.go	…
txn_endpoint.go	…
txn_endpoint_test.go	Improve reliability of tests with TestAgent (#4525 )	6 years ago
ui_endpoint.go	agent: ExternalSources instead of Meta	6 years ago
ui_endpoint_test.go	agent: ExternalSources instead of Meta	6 years ago
user_event.go	…
user_event_test.go	…
util.go	…
util_test.go	…
watch_handler.go	…
watch_handler_test.go	…