mirror of https://github.com/hashicorp/consul
20eb0d3e94
In normal operations there is a read/write race related to request
QueryOptions fields. An example race:
WARNING: DATA RACE
Read at 0x00c000836950 by goroutine 30:
github.com/hashicorp/consul/agent/structs.(*ServiceConfigRequest).CacheInfo()
/go/src/github.com/hashicorp/consul/agent/structs/config_entry.go:506 +0x109
github.com/hashicorp/consul/agent/cache.(*Cache).getWithIndex()
/go/src/github.com/hashicorp/consul/agent/cache/cache.go:262 +0x5c
github.com/hashicorp/consul/agent/cache.(*Cache).notifyBlockingQuery()
/go/src/github.com/hashicorp/consul/agent/cache/watch.go:89 +0xd7
Previous write at 0x00c000836950 by goroutine 147:
github.com/hashicorp/consul/agent/cache-types.(*ResolvedServiceConfig).Fetch()
/go/src/github.com/hashicorp/consul/agent/cache-types/resolved_service_config.go:31 +0x219
github.com/hashicorp/consul/agent/cache.(*Cache).fetch.func1()
/go/src/github.com/hashicorp/consul/agent/cache/cache.go:495 +0x112
This patch does a lightweight copy of the request struct so that the
embedded QueryOptions fields that are mutated during Fetch() are scoped
to just that one RPC.
|
||
|---|---|---|
| .. | ||
| ae | ||
| cache | ||
| cache-types | ||
| checks | ||
| config | ||
| connect | ||
| consul | ||
| debug | ||
| exec | ||
| local | ||
| metadata | ||
| mock | ||
| pool | ||
| proxycfg | ||
| router | ||
| structs | ||
| systemd | ||
| token | ||
| xds | ||
| acl.go | ||
| acl_endpoint.go | ||
| acl_endpoint_legacy.go | ||
| acl_endpoint_legacy_test.go | ||
| acl_endpoint_test.go | ||
| acl_test.go | ||
| agent.go | ||
| agent_endpoint.go | ||
| agent_endpoint_test.go | ||
| agent_test.go | ||
| bindata_assetfs.go | ||
| blacklist.go | ||
| blacklist_test.go | ||
| catalog_endpoint.go | ||
| catalog_endpoint_test.go | ||
| check.go | ||
| config.go | ||
| config_endpoint.go | ||
| config_endpoint_test.go | ||
| connect_auth.go | ||
| connect_ca_endpoint.go | ||
| connect_ca_endpoint_test.go | ||
| coordinate_endpoint.go | ||
| coordinate_endpoint_test.go | ||
| discovery_chain_endpoint.go | ||
| discovery_chain_endpoint_test.go | ||
| dns.go | ||
| dns_test.go | ||
| enterprise_delegate_oss.go | ||
| event_endpoint.go | ||
| event_endpoint_test.go | ||
| health_endpoint.go | ||
| health_endpoint_test.go | ||
| http.go | ||
| http_oss.go | ||
| http_oss_test.go | ||
| http_test.go | ||
| intentions_endpoint.go | ||
| intentions_endpoint_test.go | ||
| keyring.go | ||
| keyring_test.go | ||
| kvs_endpoint.go | ||
| kvs_endpoint_test.go | ||
| notify.go | ||
| notify_test.go | ||
| operator_endpoint.go | ||
| operator_endpoint_test.go | ||
| prepared_query_endpoint.go | ||
| prepared_query_endpoint_test.go | ||
| remote_exec.go | ||
| remote_exec_test.go | ||
| retry_join.go | ||
| retry_join_test.go | ||
| service_manager.go | ||
| service_manager_test.go | ||
| session_endpoint.go | ||
| session_endpoint_test.go | ||
| sidecar_service.go | ||
| sidecar_service_test.go | ||
| signal_unix.go | ||
| signal_windows.go | ||
| snapshot_endpoint.go | ||
| snapshot_endpoint_test.go | ||
| status_endpoint.go | ||
| status_endpoint_test.go | ||
| testagent.go | ||
| testagent_test.go | ||
| translate_addr.go | ||
| txn_endpoint.go | ||
| txn_endpoint_test.go | ||
| ui_endpoint.go | ||
| ui_endpoint_test.go | ||
| user_event.go | ||
| user_event_test.go | ||
| util.go | ||
| util_test.go | ||
| watch_handler.go | ||
| watch_handler_test.go | ||