mirror of https://github.com/hashicorp/consul
50ef6a697e
Fix issue with peer stream node cleanup. This commit encompasses a few problems that are closely related due to their proximity in the code. 1. The peerstream utilizes node IDs in several locations to determine which nodes / services / checks should be cleaned up or created. While VM deployments with agents will likely always have a node ID, agentless uses synthetic nodes and does not populate the field. This means that for consul-k8s deployments, all services were likely bundled together into the same synthetic node in some code paths (but not all), resulting in strange behavior. The Node.Node field should be used instead as a unique identifier, as it should always be populated. 2. The peerstream cleanup process for unused nodes uses an incorrect query for node deregistration. This query is NOT namespace aware and results in the node (and corresponding services) being deregistered prematurely whenever it has zero default-namespace services and 1+ non-default-namespace services registered on it. This issue is tricky to find due to the incorrect logic mentioned in #1, combined with the fact that the affected services must be co-located on the same node as the currently deregistering service for this to be encountered. 3. The stream tracker did not understand differences between services in different namespaces and could therefore report incorrect numbers. It was updated to utilize the full service name to avoid conflicts and return proper results. |
||
|---|---|---|
| .. | ||
| health_snapshot.go | ||
| health_snapshot_test.go | ||
| mock_ACLResolver.go | ||
| replication.go | ||
| server.go | ||
| server_test.go | ||
| stream_resources.go | ||
| stream_test.go | ||
| stream_tracker.go | ||
| stream_tracker_test.go | ||
| subscription_blocking.go | ||
| subscription_manager.go | ||
| subscription_manager_test.go | ||
| subscription_state.go | ||
| subscription_state_test.go | ||
| subscription_view.go | ||
| subscription_view_test.go | ||
| testing.go | ||