You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Aestek 5960974db1 [Fix] Services sometimes not being synced with acl_enforce_version_8 = false (#4771) ... Fixes: https://github.com/hashicorp/consul/issues/3676 This fixes a bug were registering an agent with a non-existent ACL token can prevent other services registered with a good token from being synced to the server when using `acl_enforce_version_8 = false`. ## Background When `acl_enforce_version_8` is off the agent does not check the ACL token validity before storing the service in its state. When syncing a service registered with a missing ACL token we fall into the default error handling case (https://github.com/hashicorp/consul/blob/master/agent/local/state.go#L1255) and stop the sync (https://github.com/hashicorp/consul/blob/master/agent/local/state.go#L1082) without setting its Synced property to true like in the permission denied case. This means that the sync will always stop at the faulty service(s). The order in which the services are synced is random since we iterate on a map. So eventually all services with good ACL tokens will be synced, this can however take some time and is influenced by the cluster size, the bigger the slower because retries are less frequent. Having a service in this state also prevent all further sync of checks as they are done after the services. ## Changes This change modify the sync process to continue even if there is an error. This fixes the issue described above as well as making the sync more error tolerant: if the server repeatedly refuses a service (the ACL token could have been deleted by the time the service is synced, the servers were upgraded to a newer version that has more strict checks on the service definition...). Then all services and check that can be synced will, and those that don't will be marked as errors in the logs instead of blocking the whole process.		6 years ago
..
ae	Add -sidecar-for and new /agent/service/:service_id endpoint (#4691)	6 years ago
cache	Quick fix for cache age flakiness in CI	6 years ago
cache-types	merge feedback: fix typos; actually use deliverLatest added previously but not plumbed in	6 years ago
checks	Add -sidecar-for and new /agent/service/:service_id endpoint (#4691)	6 years ago
config	Documentation and changes for `verify_server_hostname` (#5069)	6 years ago
connect	agent: fix formatting	6 years ago
consul	[Travis][UnstableTests] Fixed unstable tests in travis (#5013)	6 years ago
debug	fix comment typos (#4890)	6 years ago
exec	…
local	[Fix] Services sometimes not being synced with acl_enforce_version_8 = false (#4771)	6 years ago
metadata	New ACLs (#4791)	6 years ago
mock	…
pool	…
proxycfg	merge feedback: fix typos; actually use deliverLatest added previously but not plumbed in	6 years ago
proxyprocess	Add -sidecar-for and new /agent/service/:service_id endpoint (#4691)	6 years ago
router	…
structs	acl: add stub hooks to support some plumbing in enterprise (#4951)	6 years ago
systemd	…
token	re-add Connect multi-dc config changes	6 years ago
xds	New ACLs (#4791)	6 years ago
acl.go	New ACLs (#4791)	6 years ago
acl_endpoint.go	Adds documentation for the new ACL APIs (#4851)	6 years ago
acl_endpoint_legacy.go	New ACLs (#4791)	6 years ago
acl_endpoint_legacy_test.go	New ACLs (#4791)	6 years ago
acl_endpoint_test.go	New ACLs (#4791)	6 years ago
acl_test.go	New ACLs (#4791)	6 years ago
agent.go	New ACLs (#4791)	6 years ago
agent_endpoint.go	Doc changes for 1.4 Final (#4870)	6 years ago
agent_endpoint_test.go	connect: remove additional trust-domain validation (#4934)	6 years ago
agent_test.go	[Security] Add finer control over script checks (#4715)	6 years ago
bindata_assetfs.go	Release v1.4.0	6 years ago
blacklist.go	…
blacklist_test.go	…
catalog_endpoint.go	Support multiple tags for health and catalog http api endpoints (#4717)	6 years ago
catalog_endpoint_test.go	dns: implements prefix lookups for DNS TTL (#4605)	6 years ago
check.go	…
config.go	…
connect_auth.go	connect: remove additional trust-domain validation (#4934)	6 years ago
connect_ca_endpoint.go	Fix CA pruning when CA config uses string durations. (#4669)	6 years ago
connect_ca_endpoint_test.go	Fix more unstable tests in agent and command	6 years ago
coordinate_endpoint.go	…
coordinate_endpoint_test.go	Fix more unstable tests in agent and command	6 years ago
dns.go	dns: implements prefix lookups for DNS TTL (#4605)	6 years ago
dns_test.go	Fixed another list of unstable unit tests in travis (#4915)	6 years ago
enterprise_delegate_oss.go	…
event_endpoint.go	Fixes memory leak when blocking on /event/list (#4482)	6 years ago
event_endpoint_test.go	New ACLs (#4791)	6 years ago
health_endpoint.go	Support multiple tags for health and catalog http api endpoints (#4717)	6 years ago
health_endpoint_test.go	Add Proxy Upstreams to Service Definition (#4639)	6 years ago
http.go	ui: serve /robots.txt when UI is enabled. (#5089)	6 years ago
http_oss.go	New ACLs (#4791)	6 years ago
http_oss_test.go	Fixed another list of unstable unit tests in travis (#4915)	6 years ago
http_test.go	New command: consul debug (#4754)	6 years ago
intentions_endpoint.go	agent: 400 error on invalid UUID format, api handles errors properly	7 years ago
intentions_endpoint_test.go	agent: 400 error on invalid UUID format, api handles errors properly	7 years ago
keyring.go	…
keyring_test.go	…
kvs_endpoint.go	…
kvs_endpoint_test.go	Improve reliability of tests with TestAgent (#4525)	6 years ago
notify.go	Fixes memory leak when blocking on /event/list (#4482)	6 years ago
notify_test.go	Fixes memory leak when blocking on /event/list (#4482)	6 years ago
operator_endpoint.go	…
operator_endpoint_test.go	Fix unstable tests in agent, api, and command/watch	6 years ago
prepared_query_endpoint.go	Support Agent Caching for Service Discovery Results (#4541)	6 years ago
prepared_query_endpoint_test.go	Support Agent Caching for Service Discovery Results (#4541)	6 years ago
remote_exec.go	…
remote_exec_test.go	Fix unstable tests in agent, api, and command/watch	6 years ago
retry_join.go	agent: configure k8s go-discover	6 years ago
retry_join_test.go	Vendoring update for go-discover. (#4412)	6 years ago
session_endpoint.go	…
session_endpoint_test.go	Implementation of Weights Data structures (#4468)	6 years ago
sidecar_service.go	merge feedback: fix typos; actually use deliverLatest added previously but not plumbed in	6 years ago
sidecar_service_test.go	[Security] Add finer control over script checks (#4715)	6 years ago
signal_unix.go	cli: forward SIGTERM to child process of 'lock' and 'watch' subcommands (#4737)	6 years ago
signal_windows.go	cli: forward SIGTERM to child process of 'lock' and 'watch' subcommands (#4737)	6 years ago
snapshot_endpoint.go	…
snapshot_endpoint_test.go	…
status_endpoint.go	…
status_endpoint_test.go	Fixed another list of unstable unit tests in travis (#4915)	6 years ago
testagent.go	Fix #4515: Segfault when serf_wan port was -1 but reconnect_time_wan was set (#4531)	6 years ago
testagent_test.go	…
translate_addr.go	…
txn_endpoint.go	…
txn_endpoint_test.go	Improve reliability of tests with TestAgent (#4525)	6 years ago
ui_endpoint.go	agent: ExternalSources instead of Meta	6 years ago
ui_endpoint_test.go	Added SOA configuration for DNS settings. (#4714)	6 years ago
user_event.go	…
user_event_test.go	New ACLs (#4791)	6 years ago
util.go	cli: forward SIGTERM to child process of 'lock' and 'watch' subcommands (#4737)	6 years ago
util_test.go	cli: forward SIGTERM to child process of 'lock' and 'watch' subcommands (#4737)	6 years ago
watch_handler.go	…
watch_handler_test.go	…