consul/resolver at 18831-backport1.14.10 - consul - https://git.xinac.net

Consul is a distributed, highly available, and data center aware solution to connect and configure applications across dynamic, distributed infrastructure.

consul api-gateway kubernetes ecs service-discovery service-mesh vault

Branch: 18831-backport1.14.10

History

R.B. Boyer 9e7b52dd4e [1.14.x] grpc: ensure grpc resolver correctly uses lan/wan addresses on servers (#17286 ) The grpc resolver implementation is fed from changes to the router.Router. Within the router there is a map of various areas storing the addressing information for servers in those areas. All map entries are of the WAN variety except a single special entry for the LAN. Addressing information in the LAN "area" are local addresses intended for use when making a client-to-server or server-to-server request. The client agent correctly updates this LAN area when receiving lan serf events, so by extension the grpc resolver works fine in that scenario. The server agent only initially populates a single entry in the LAN area (for itself) on startup, and then never mutates that area map again. For normal RPCs a different structure is used for LAN routing. Additionally when selecting a server to contact in the local datacenter it will randomly select addresses from either the LAN or WAN addressed entries in the map. Unfortunately this means that the grpc resolver stack as it exists on server agents is either broken or only accidentally functions by having servers dial each other over the WAN-accessible address. If the operator disables the serf wan port completely likely this incidental functioning would break. This PR enforces that local requests for servers (both for stale reads or leader forwarded requests) exclusively use the LAN "area" information and also fixes it so that servers keep that area up to date in the router. A test for the grpc resolver logic was added, as well as a higher level full-stack test to ensure the externally perceived bug does not return. Also backport subtle test fix from #16396		2 years ago
..
registry.go	Update hcp-scada-provider to fix diamond dependency problem with go-msgpack (#15185 ) (#15277 )	2 years ago
resolver.go	[1.14.x] grpc: ensure grpc resolver correctly uses lan/wan addresses on servers (#17286 )	2 years ago
resolver_test.go	[1.14.x] grpc: ensure grpc resolver correctly uses lan/wan addresses on servers (#17286 )	2 years ago