Commit Graph

8 Commits (f87f410e3ab4ca8bd1c6ab6036c4bb842d131f5d)

Author SHA1 Message Date
Pierre Souchay 9dc7194321
Bump version of miekg/dns to 1.0.4
See https://github.com/hashicorp/consul/issues/3977

While trying to improve furthermore #3948 (This pull request is still valid since we are not using Compression to compute the result anyway).

I saw a strange behaviour of dns library.
Basically, msg.Len() and len(msg.Pack()) disagree on Message len.

Thus, calculation of DNS response is false consul relies on msg.Len() instead of the result of Pack()

This is linked to miekg/dns#453 and a fix has been provided with miekg/dns#454

Would it be possible to upgrade miekg/dns to a more recent function ?

Consul might for instance upgrade to a post 1.0 release such as https://github.com/miekg/dns/releases/tag/v1.0.4
2018-03-28 10:23:57 -05:00
Dmytro Kostiuchenko 1a10b08e82 Add gRPC health-check #3073 2018-01-04 16:42:30 -05:00
Frank Schroeder 02ed39cb2f vendor: drop unused deps for old discover code 2017-08-01 11:41:43 +02:00
James Phillips 42f60b04bb Revert "discover: move instance discover code into separate package (#3144)" (#3180)
This reverts commit 26bfb2d00a.
2017-06-23 01:38:55 -07:00
Frank Schröder 26bfb2d00a discover: move instance discover code into separate package (#3144)
This patch moves the code that discovers instances from metadata
information to github.com/hashicorp/go-discover with
sub-packages for each provider.
2017-06-21 10:40:38 +02:00
Kyle Havlovitz 77650c2e6f
vendor: pull in GCE deps 2017-01-12 17:42:06 -05:00
Kyle Havlovitz 4976c05975
Revert "vendor: Add GCE deps"
This reverts commit 4831b6de40.
2017-01-12 17:02:42 -05:00
Chris Marchesi 4831b6de40 vendor: Add GCE deps
Add Google API and related dependencies for GCE discovery.
2016-12-06 17:46:55 -08:00