21469 Commits (eda961f4a2a04f951d15a5a3a73bf75a73c0e649)

 

All Branches   

Search

Author	SHA1	Message	Date
Nick Cellino	5fb6ab6a3a	Move HCP Manager lifecycle management out of Link controller (#20401) ... * Add function to get update channel for watching HCP Link * Add MonitorHCPLink function This function can be called in a goroutine to manage the lifecycle of the HCP manager. * Update HCP Manager config in link monitor before starting This updates HCPMonitorLink so it updates the HCP manager with an HCP client and management token when a Link is upserted. * Let MonitorHCPManager handle lifecycle instead of link controller * Remove cleanup from Link controller and move it to MonitorHCPLink Previously, the Link Controller was responsible for cleaning up the HCP-related files on the file system. This change makes it so MonitorHCPLink handles this cleanup. As a result, we are able to remove the PlacementEachServer placement strategy for the Link controller because it no longer needs to do this per-node cleanup. * Remove HCP Manager dependency from Link Controller The Link controller does not need to have HCP Manager as a dependency anymore, so this removes that dependency in order to simplify the design. * Add Linked prefix to Linked status variables This is in preparation for adding a new status type to the Link resource. * Add new "validated" status type to link resource The link resource controller will now set a "validated" status in addition to the "linked" status. This is needed so that other components (eg the HCP manager) know when the Link is ready to link with HCP. * Fix tests * Handle new 'EndOfSnapshot' WatchList event * Fix watch test * Remove unnecessary config from TestAgent_scadaProvider Since the Scada provider is now started on agent startup regardless of whether a cloud config is provided, this removes the cloud config override from the relevant test. This change is not exactly related to the changes from this PR, but rather is something small and sort of related that was noticed while working on this PR. * Simplify link watch test and remove sleep from link watch This updates the link watch test so that it uses more mocks and does not require setting up the infrastructure for the HCP Link controller. This also removes the time.Sleep delay in the link watcher loop in favor of an error counter. When we receive 10 consecutive errors, we shut down the link watcher loop. * Add better logging for link validation. Remove EndOfSnapshot test. * Refactor link monitor test into a table test * Add some clarifying comments to link monitor * Simplify link watch test * Test a bunch more errors cases in link monitor test * Use exponential backoff instead of errorCounter in LinkWatch * Move link watch and link monitor into a single goroutine called from server.go * Refactor HCP link watcher to use single go-routine. Previously, if the WatchClient errored, we would've never recovered because we never retry to create the stream. With this change, we have a single goroutine that runs for the life of the server agent and if the WatchClient stream ever errors, we retry the creation of the stream with an exponential backoff.	10 months ago
Tauhid Anjum	9d8f9a5470	NET-7783: Fix sameness group expansion to 0 sources error CE (#20584)	10 months ago
John Murret	c8e4cea69c	set up ent and CE specific DNS tests to be able to run v1 and v2 (#20571)	10 months ago
Dan Stough	01001f630e	feat(v2dns): catalog v2 service query support (#20564)	10 months ago
David Yu	e24b73a6dd	docs: Add legacy api gateway deprecation to Consul release notes (#20569) ... * Update v1_16_x.mdx * Update website/content/docs/release-notes/consul/v1_16_x.mdx Co-authored-by: Jeff Boruszak <104028618+boruszak@users.noreply.github.com> * Update v1_2_x.mdx --------- Co-authored-by: Jeff Boruszak <104028618+boruszak@users.noreply.github.com>	10 months ago
R.B. Boyer	6742340878	mesh: add ComputedImplicitDestinations resource for future use (#20547) ... Creates a new controller to create ComputedImplicitDestinations resources by composing ComputedRoutes, Services, and ComputedTrafficPermissions to infer all ParentRef services that could possibly send some portion of traffic to a Service that has at least one accessible Workload Identity. A followup PR will rewire the sidecar controller to make use of this new resource. As this is a performance optimization, rather than a security feature the following aspects of traffic permissions have been ignored: - DENY rules - port rules (all ports are allowed) Also: - Add some v2 TestController machinery to help test complex dependency mappers.	10 months ago
Valeriia Ruban	8c05e57ac1	Cc 7147 link to hcp modal (#20474) ... * add link hcp modal component * integrate modal with SideNav and link to hcp banner --------- Co-authored-by: Chris Hut <tophernuts@gmail.com>	10 months ago
Matt Keeler	6c4b83c119	Allow reuse of cache indexes (#20562) ... Previously calling `index.New` would return an object with the index information such as the Indexer, whether it was required, and the name of the index as well as a radix tree to store indexed data. Now the main `Index` type doesn’t contain the radix tree for indexed data. Instead the `IndexedData` method can be used to combine the main `Index` with a radix tree in the `IndexedData` structure. The cache still only allows configuring the `Index` type and will invoke the `IndexedData` method on the provided indexes to get the structure that the cache can use for actual data management. All of this makes it now safe to reuse the `index.Index` types.	10 months ago
Valeriia Ruban	6708e88ec9	chor: remove temporary CONSUL_HCP_LINK_ENABLED env flag (#20552)	10 months ago
Dan Stough	24e15cc24e	feat(v2dns): prepared query ttls (#20563)	10 months ago
John Murret	7cac918811	NET-7637 / NET-7659/NET-7636/NET-7647/NET-7648/NET-7646/NET-7649/NET-7645 - Multiple DNS v2 fixes (#20556)	10 months ago
skpratt	738dc8c89d	use go 1.21.7 (#20545) ... * 1.21.7 * changelog	10 months ago
Derek Menteer	a1c8d4dd19	Decouple xds capacity controller and raft-autopilot (#20511) ... Decouple xds capacity controller and autopilot This prevents a potential bug where autopilot deadlocks while attempting to execute `AutopilotDelegate.NotifyState()` on an xdscapacity controller that stopped consuming messages.	10 months ago
Chris S. Kim	26661a1c3b	Add default intention policy (#20544)	10 months ago
John Maguire	7c3a379e48	Fixes gatewayproxy controller tests for ent (#20543) ... fix tests for ent	10 months ago
Eric Haberkorn	b26282568f	Move sameness groups to v2beta1 version (#20531)	10 months ago
Joshua Timmons	242b777547	Fix logging when we fail to export metrics to hcp (#20514)	10 months ago
Joshua Timmons	c790740cc6	Fix: avoid redundant logs on failures to export metrics (#20519)	10 months ago
John Murret	8ac54707d6	DNS v2 Multiple fixes. (#20525) ... * DNS v2 Multiple fixes. * add license header * get rid of DefaultIntentionPolicy change that was not supposed to be there.	10 months ago
Mark Campbell-Vincent	27f6fef999	Update cache section for certain API calls (#20464) ... * Update cache section for certain API calls Providing more detail to the cache section to address behavior of API calls using streaming backend. This will help users understand that when '?index' is used and '?cached' is not, caching to servers will be bypassed, causing entry_fetch_max_burst and entry_fetch_rate to not be used in this scenario. * Update website/content/docs/agent/config/config-files.mdx Co-authored-by: Jeff Boruszak <104028618+boruszak@users.noreply.github.com> --------- Co-authored-by: Jeff Boruszak <104028618+boruszak@users.noreply.github.com>	10 months ago
Semir Patel	3c1ee84d0a	fix typos in docs for `consul snapshot agent` (#20522)	10 months ago
Melissa Kam	c95380e3da	[CC-7434] Skip collecting data directory metrics in dev mode (#20521) ... * Skip collecting data directory stats in dev mode In dev mode, the data directory is not set, so this metrics collection would always fail and logs errors. * Log collection errors at DEBUG level There isn't much action a user can take to fix these errors, so logging them as DEBUG rather than ERROR.	10 months ago
John Maguire	2ee32b1980	Add tests for gw proxy controller (#20510) ... * Added basic tests for gatewayproxy controller * add copyright header * Clean up tests	10 months ago
Nathan Coleman	2456fe5148	[NET-7657] Remove proto definitions for GatewayClass + GatewayClassConfig (#20523)	10 months ago
Nathan Coleman	45d645471b	[NET-7414] Reconcile PST for mesh gateway workloads on change to ComputedExportedServices (#20271) ... * Reconcile ProxyStateTemplate on change to ComputedExportedServices * gofmt changeset --------- Co-authored-by: NiniOak <anita.akaeze@hashicorp.com>	10 months ago
skpratt	57bad0df85	add traffic permissions excludes and tests (#20453) ... * add traffic permissions tests * review fixes * Update internal/mesh/internal/controllers/sidecarproxy/builder/local_app.go Co-authored-by: John Landa <jonathanlanda@gmail.com> --------- Co-authored-by: John Landa <jonathanlanda@gmail.com>	10 months ago
Eric Haberkorn	1bd253021b	V1 Compat Exported Services Controller Optimizations (#20517) ... V1 compat exported services controller optimizations * Don't start the v2 exported services controller in v1 mode. * Use the controller cache.	10 months ago
Matt Keeler	3ca4f39fa1	Register the multicluster types for the catalogtest integration tests (#20516) ... In particular the failover controller needs these in Consul Enterprise	10 months ago
wangxinyi7	ab8f23478a	add more integration tests (#20479) ... * add more integration tests	10 months ago
John Maguire	24e9603d9b	Fix Gatewayproxy Controller and Re-Enable APIGW v2 Controller (#20508) ... re-enable apigw controller, fix typo in key name for metadata for gatewayproxy	10 months ago
Matt Keeler	49e6c0232d	Panic for unregistered types (#20476) ... * Panic when controllers attempt to make invalid requests to the resource service This will help to catch bugs in tests that could cause infinite errors to be emitted. * Disable the API GW v2 controller With the previous commit, this would cause a server to panic due to watching a type which has not yet been created/registered. * Ensure that a test server gets the full type registry instead of constructing its own * Skip TestServer_ControllerDependencies * Fix peering tests so that they use the full resource registry.	10 months ago
Dan Stough	fcc43a9a36	feat(v2dns): catalog v2 SOA and NS support (#20480)	10 months ago
John Maguire	54c974748e	[NET-7280] Add APIGW support to the gatewayproxy controller (#20484) ... * Add APIGW support to the gatewayproxy controller * update copywrite headers	10 months ago
John Murret	3bf999e46b	NET-7631 - Fix Node records that point to external/ non-IP addresses (#20491) ... * NET-7630 - Fix TXT record creation on node queries * NET-7631 - Fix Node records that point to external/ non-IP addresses * NET-7630 - Fix TXT record creation on node queries	10 months ago
John Murret	7d4deda640	NET-7630 - Fix TXT record creation on node queries (#20483)	10 months ago
Ashesh Vidyut	cffb5d7c6e	Fix audit-log encoding issue (CC-7337) (#20345) ... * add changes * added changelog * change update * CE chnages * Removed gzip size fix * fix changelog * Update .changelog/20345.txt Co-authored-by: Hans Hasselberg <hans@hashicorp.com> * Adding comments --------- Co-authored-by: Abhishek Sahu <abhishek.sahu@hashicorp.com> Co-authored-by: Hans Hasselberg <hans@hashicorp.com> Co-authored-by: srahul3 <rahulsharma@hashicorp.com>	10 months ago
Tauhid Anjum	88b8a1cc36	NET-6776 - Update Routes controller to use ComputedFailoverPolicy CE (#20496) ... Update Routes controller to use ComputedFailoverPolicy	10 months ago
Tauhid Anjum	0c509a60a4	Exported services CLI and docs (#20331) ... * Exported services CLI and docs * Changelog added * Added format option for pretty print * Update command/exportedservices/exported_services.go Co-authored-by: Ashesh Vidyut <134911583+absolutelightning@users.noreply.github.com> * Addressing PR comments, moving the command under services category * Add consumer peer and partition filter * Adding bexpr filter, change format of data --------- Co-authored-by: Ashesh Vidyut <134911583+absolutelightning@users.noreply.github.com>	10 months ago
Derek Menteer	922844b8e0	Fix issue with persisting proxy-defaults (#20481) ... Fix issue with persisting proxy-defaults This resolves an issue introduced in hashicorp/consul#19829 where the proxy-defaults configuration entry with an HTTP protocol cannot be updated after it has been persisted once and a router exists. This occurs because the protocol field is not properly pre-computed before being passed into validation functions.	10 months ago
John Murret	0d434dafac	Do not parallelize DNS tests because they consume too many ports (#20482)	10 months ago
John Murret	602e3c4fd5	DNS V2 - Revise discovery result to have service and node name and address fields. (#20468) ... * DNS V2 - Revise discovery result to have service and node name and address fields. * NET-7488 - dns v2 add support for prepared queries in catalog v1 data model (#20470) NET-7488 - dns v2 add support for prepared queries in catalog v1 data model.	10 months ago
Dan Stough	9602b43183	feat(v2dns): catalog v2 workload query support (#20466)	10 months ago
R.B. Boyer	deca6a49bd	catalog: improve the bound workload identity encoding on services (#20458) ... The endpoints controller currently encodes the list of unique workload identities referenced by all workload matched by a Service into a special data-bearing status condition on that Service. This allows a downstream controller to avoid an expensive watch on the ServiceEndpoints type just to get this data. The current encoding does not lend itself well to machine parsing, which is what the field is meant for, so this PR simplifies the encoding from: "blah blah: " + strings.Join(ids, ",") + "." to strings.Join(ids, ",") It also provides an exported utility function to easily extract this data.	10 months ago
Nick Ethier	9d4ad74a63	internal/hcp: prevent write loop on telemetrystate resource updates (#20435) ... * internal/hcp: prevent write loop on telemetrystate resource updates * Update controller.go Co-authored-by: Nick Cellino <nick.cellino@hashicorp.com> * internal/hcp: add assertion for looping controller --------- Co-authored-by: Nick Cellino <nick.cellino@hashicorp.com>	10 months ago
R.B. Boyer	c029b20615	v2: ensure the controller caches are fully populated before first use (#20421) ... The new controller caches are initialized before the DependencyMappers or the Reconciler run, but importantly they are not populated. The expectation is that when the WatchList call is made to the resource service it will send an initial snapshot of all resources matching a single type, and then perpetually send UPSERT/DELETE events afterward. This initial snapshot will cycle through the caching layer and will catch it up to reflect the stored data. Critically the dependency mappers and reconcilers will race against the restoration of the caches on server startup or leader election. During this time it is possible a mapper or reconciler will use the cache to lookup a specific relationship and not find it. That very same reconciler may choose to then recompute some persisted resource and in effect rewind it to a prior computed state. Change - Since we are updating the behavior of the WatchList RPC, it was aligned to match that of pbsubscribe and pbpeerstream using a protobuf oneof instead of the enum+fields option. - The WatchList rpc now has 3 alternating response events: Upsert, Delete, EndOfSnapshot. When set the initial batch of "snapshot" Upserts sent on a new watch, those operations will be followed by an EndOfSnapshot event before beginning the never-ending sequence of Upsert/Delete events. - Within the Controller startup code we will launch N+1 goroutines to execute WatchList queries for the watched types. The UPSERTs will be applied to the nascent cache only (no mappers will execute). - Upon witnessing the END operation, those goroutines will terminate. - When all cache priming routines complete, then the normal set of N+1 long lived watch routines will launch to officially witness all events in the system using the primed cached.	10 months ago
Derek Menteer	266f6548f9	Debug failing CICD tests (#20455) ... Fix CICD test flakes by locking container socket.	10 months ago
wangxinyi7	fb2b696c0e	missing prefix / (#20447) ... * missing prefix / and fix typos	10 months ago
Eric Haberkorn	543c6a30af	Trigger the V1 Compat exported-services Controller when V1 Config Entries are Updated (#20456) ... * Trigger the v1 compat exported-services controller when the v1 config entry is modified. * Hook up exported-services config entries to the event publisher. * Add tests to the v2 exported services shim. * Use the local materializer trigger updates on the v1 compat exported services controller when exported-services config entries are modified. * stop sleeping when context is cancelled	10 months ago
Derek Menteer	1fe0a87546	Fix SDK iptables.Config marshalling (#20451) ... This fixes behavior introduced by hashicorp/consul#20232 where a function was added to the iptables configuration struct. Since this struct is actually marshalled into json by consul-k8s, we should not be placing functions inside of it.	10 months ago
Chris Hut	22e6ce0df1	Add nav bar item to show HCP link status and encourage folks to link (#20370) ... * Convert consul-hcp to a simpler component * update existing test to use envStub helper * An hcp link item for the navbar * A method of linking to HCP * Hook up fetching linking status to the nav-item * Hooking up fetching link status to the hcp link friend * Adding some tests * remove a comment - but also fix padding justify-content * Fix the banner tests * Adding permission tests as well * some more sane formatting * Rename function with its now multipurpose use * Feature change: No more NEW Badge since it breaks padding - instead a linked badge * Removing unused class	10 months ago