777 Commits (e617e7df3e7b92b75ce76eba09ddbcf73f76ea95)

Author	SHA1	Message	Date
Michael Klein	65b0faf96b	ui: allow searching services by admin-partition (#13650)	2 years ago
Michael Klein	ef21100435	ui: peering chores (#13636) ... * Update empty state topology downstreams to included peer info * Add filter for filtering for service without ExternalSources	2 years ago
John Cowen	d66f5a6364	ui: Fix up peer ENT tests (#13633) ... * ui: Add missing @nspaces * Reorder peerings to be before any optionals * Merge params instead of overwriting * Reorder int tests	2 years ago
Michael Klein	5de75550d3	ui: feature-flagged peering mvp (#13425) ... * add peers route * add peers to nav * use regular app ui patterns peers template * use empty state in peers UI * mock `v1/peerings` request * implement custom adapter/serializer for `peers`-model * index request for peerings on peers route * update peers list to show as proper list * Use tailwind for easier styling * Unique ids in peerings response mock-api * Add styling peerings list * Allow creating empty tooltip To make it easier to iterate over a set of items where some items should not display a tooltip and others should. * Add tooltip Peerings:Badge * Add undefined peering state badge * Remove imported/exported services count peering This won't be included in the initial version of the API response * Implement Peerings::Search * Make it possible to filter peerings by name * Install ember-keyboard For idiomatic handling of key-presses. * Clear peering search input when pressing `Escape` * use peers.index instead of peers for peerings listing * Allow to include peered services in services-query * update services mock to add peerName * add Consul::Peer component To surface peering information on a resource * add PeerName as attribute to service model * surface peering information in service list * Add tooltip to Consul::Peer * Make services searchable by peer-name * Allow passing optional query-params to href-to * Add peer query-param to dc.services.show * Pass peer as query-param services listing * support option peer route-param * set peer-name undefined in services serializer when empty * update peer route-param when navigating to peered service * request sercice with peer-name if need be * make sure to reset peer route-param when leaving service.show * componentize services.peer-info * surface peer info services.show * make sure to reset peer route-param in main nav * fix services breadcrumb services.intentions we need to reset peer route-param here to not break the app * surface peer when querying for it on service api call * query for peer info service-instance api calls * surface peer info service-instance.show * Camelize peer attributes to match rest of app * Refactor peers.index to reflect camelized attributes for peer * Remove unused query-params services.show * make logo href reset peer route-param * Cleanup optional peer param query service-instance * Use replace decorator instead of serializer for empty peerName * make sure to only send peer info when correct qp is passed * Always send qp for querying peers services request * rename with-imports to with-peers * Use css for peer-icon * Refactor bucket-list component to surface peer-info * Remove Consul::Peer component This info is now displayed via the bucket-list component * Fix bucket-list component to surface service again * Update bucket-list docs to reflect peer-info addition * Remove tailwind related styles * Remove consul-tailwind package We won't be using tailwind for now * Fix typo badge scss * Add with-import handling mock-api nodes * Add peerName to node attributes * include peers when querying nodes * reflect api updates node list mock * Create consul::node::peer-info component * Surface peer-info in nodes list * Mock peer response for node request * Make it possible to add peer-name to node request * Update peer route-param when linking to node * Reset peers route-param when leaving nodes.show We need to reset the route-param to not introduce a bug - otherwise subsequent node show request would request with the old peer query-param * Add sourcePeer intentions api mock * add SourcePeer attr to intentions model * Surface peering info on intentions list * Request peered intentions differently intentions.edit * Handle peer info in intentions/exact mock * Surface peering info intention view * Add randomized peer data topology mock * Surface peer info topology view * fix service/peer-info styling We aren't using tailwind anymore - we need to create a custom scss file * Update peerings api mocks * Update peerings::badge with updated styling * cleanup intentions/exact mock * Create watcher component to declaratively register polling * Poll peers in background when on peers route * use existing colors for peering-badge * Add test for requesting service with `with-peers`-query * add imported/exported count to peers model * update mock-api to surface exported/imported count on peers * Show exported/imported peers count on peers list * Use translations for service import/export UI peers * Make sure to ask for nodes with peers * Add match-url step for easier url testing of service urls * Add test for peer-name on peered services * Add test for service navigation peered service * Implement feature-flag handling * Enable peering feature in test and development * Redirect peers to services.index when feature-flag is disabled * Only query for peers when feature is enabled * Only show peers in nav when feature is enabled * Componentize peering service count detail * Handle non-state Peerings::Badge * Use Peerings::ServiceCount in peerings list * Only send peer query for peered service-instances. * Add step to visit url directly * add test for accessing peered service directly * Remove unused service import peers.index * Only query for peer when peer provided node-adapter * fix tests	2 years ago
John Cowen	7761d0abe4	ui: Fix intl keys in order to render correct messages for empty states (#13409) ... * ui: Fix intl keys in order to render correct messages for empty states * Add a debug only debug log to warn about missing keys	2 years ago
John Cowen	147476c10d	ui: Disable licensing tab if the UI is running via HCP (#12771) ... Co-authored-by: Evan Rowe <ev.rowe@gmail.com>	3 years ago
Michael Klein	4d36e2b08e	ui: upgrade ember composable helper (#13394) ... Upgrade ember-composable-helpers to version 5.x. This version contains the pick-helper which makes composition in the template layer easier with Octane. {{!-- this is usually hard to do with Octane --}} <input {{on "input" (pick "target.value" this.updateText)}} .../> Version 5.x also fixes a regression with sort-by that according to @johncowen was the reason why the version was pinned to 4.0.0 at the moment. Version 5 of ember-composable-helpers removes the contains-helper in favor of includes which I changed all occurences for.	3 years ago
Jasmine W	a2c20518c0	updates ... readded %reset-typo and defined .consul-intention-view h2	3 years ago
Jasmine W	439d9e7f65	removed %reset-typo	3 years ago
John Cowen	a61e5cc08b	ui: Icon related fixups (#13183) ... * ui: Use new icon-size and icon-color for popover-menus * Remove the default currentColor plus add some more defaults * Undo transparency overwrites now we don't need them * Fixup discochain icons * Undo a default icon rule for vert align * Fixup expanded icon for meatball popovers * Fixup intention permission labels/badges/icons * Remove different res icon * Remove icon resolutions	3 years ago
Jasmine W	30f6be389a	ui: Center alignment of L7 permissions	3 years ago
Jasmine W	a52400ade0	Corrected "visualization" typo	3 years ago
Jared Kirschner	e23535deb1	UI: update improve server fault tolerance link	3 years ago
Jake Herschman	d01142a91b	ui:fixed bug where license was showing in oss (#12795) ... Co-authored-by: Evan Rowe <ev.rowe@gmail.com> * fixed bug where license was showing in oss * ui:disable test for license read temporarily	3 years ago
Jared Kirschner	53379015ae	ui: fix overview's renew license link	3 years ago
John Cowen	ca4978010b	ui: Add documentation link to the Server Fault Tolerance panel (#12792)	3 years ago
Evan Rowe	a5dbdba24c	ui: Revert to Services route as default (#12804) ... * ui: Revert to Services route as default * ui: update page navigation tests to match routing change	3 years ago
Evan Rowe	b55a71b073	Merge pull request #12738 from hashicorp/ui/bugfix/safari-icons ... ui: Fixup icons not displaying in Safari	3 years ago
Jake Herschman	aad5547c79	fixed text color and added card hover states (#12790)	3 years ago
John Cowen	9b87e6b61c	ui: Adds support for AWS-IAM Auth Methods (#12786) ... * ui: Adds support for AWS-IAM Auth Methods * Changelog	3 years ago
John Cowen	fbd078616c	ui: Only show optimistic details in Ent (#12788)	3 years ago
John Cowen	aad5359491	ui: Show read-replica health status (#12758)	3 years ago
John Cowen	4c8c163a48	ui: Don't automatically move rz read-replicas out of the rz (#12740)	3 years ago
John Cowen	a148ae660f	ui: Adds licensing overview tab (#12706) ... * Add some utilities/helpers to temporal for formatting etc * Enable the licensing tab * Add licensing page * Add CSS for licensing page * Fixup typo * Remove box shadow from panel	3 years ago
John Cowen	e62275642b	ui: Add more explanatory texts for empty states (#12354) ... * ui: Add more explanatory texts for empty states * Change all template "Read the guide"s * Add missing htmlSafe * Remove the stuff I commented out to try and grok the hairy rebase * Changelog * More rebased yaml weirdness plus added node:read	3 years ago
John Cowen	3bcd93c5e8	Fixup any psuedo elements that don't need currentColor	3 years ago
John Cowen	c36aa48f71	Fallback icons to currentColor	3 years ago
John Cowen	b3c7f44d32	ui: Ignore Service/Node permissions for Overview just use operator (#12693)	3 years ago
John Cowen	6928ea090f	ui: Amend UI branching docs (#12705)	3 years ago
John Cowen	18f55be3c4	ui: Initial Server Status Overview Page (#12599)	3 years ago
John Cowen	78a6b517f9	ui: Tile CSS component (#12570) ... * ui: Tile CSS component * ui: Consul ServerCard component (#12576)	3 years ago
John Cowen	4b8cabce0d	ui: Overview UI Routing (#12493) ... This PR adds routes and an initial landing page for the Cluster Overview page	3 years ago
John Cowen	65ea41a839	ui: DisclosureCard component (#12541)	3 years ago
John Cowen	5ab7e48862	ui: Native CSS Icon Composition (#12461) ... This commit/PR beings to move away from using CSS preprocessing for our icons and towards using native CSS via native CSS property composition	3 years ago
John Cowen	ee0e8bf500	ui: App-ify Lock Sessions (#12482) ... This commit moves our in-app LockSessions code into an external 'app', which can theoretically be side-loaded but for now it just makes for good isolation/code hygiene. Functionally, there is kind of one change here, and that is we only show the 'Lock Session' tab if you have permissions to see them. Currently as our UI authorization endpoint needs to be changed slightly to suit our usecase, you will always have permissions to see Lock Sessions as we hardcode the session:read to true (obvs this is a frontend thing, not a backend thing), so it doesn't really change anything from a user perspective. Also added very bare docs while I was here. Small note here, ideally we need to add the each individual tab depending on whether an 'app' is enabled or not instead of just permissions, ideally it would be done totally from The Outside rather than a can based conditional on the inside, just something else to be thinking about for the future.	3 years ago
John Cowen	2168a44413	ui: Add CustomElement Transform (#12540) ... This PR adds an Ember-Glimmer/Handlebars transform to drop the documentation copy from the CustomElement component out of the build, therefore it is not bundled into the code either at development time or production build time.	3 years ago
John Cowen	0e122479fa	ui: Add license endpoint/datasource (#12506) ... * ui: Add auto-pilot/state endpoint usage (merged into DC models) (#12514) * ui: Catalog Health Overview DataSource (#12520)	3 years ago
John Cowen	ec536340df	ui: Remove Settings Ember Route (#12488)	3 years ago
John Cowen	55851c784f	ui: DistributionMeter Component (#12452)	3 years ago
Evan Rowe	b93401795a	Merge pull request #12400 from chinmaym07/ui/feature/add-tags-tab-to-gateways ... ui: [Bugfix] Added Tags tab to gateways(just like exists for non-gateway services)	3 years ago
John Cowen	7a1c3a8c60	ui: List Primary and Local DCs first in the Datacenter selector (#12478)	3 years ago
John Cowen	bac6c00906	ui: Fix loading icon size (adds a viewbox) (#12479)	3 years ago
John Cowen	25f3ebd66a	ui: CustomElement component (#12451) ... Builds on attach-shadow, adopt-styles and ShadowTemplate, this commit adds ShadowHost and finally CustomElement. CustomElement is a renderless component to help with the creation of native HTML Custom Elements along with runtime type checking and self-documentation for attributes, slots, cssprops and cssparts. As you will probably see there is a little more work to come here. But in the same breath, everything would be fine to go in as is.	3 years ago
John Cowen	9289c9b491	ui: Add docs for `<Action />` component (#12502)	3 years ago
John Cowen	121bd2e0ab	ui: PagedCollection component (#12404) ... * ui: PagedCollection component * ui: Use PagedCollection (#12436) * ui: Integrate PagedCollection into DisclosureMenu * Integrate PageCollection into DC, Nspace and Partition menus	3 years ago
John Cowen	79a07c7a3d	ui: Add new component blueprint (#12421) ... This adds a new component blueprint for all our components. We've been using README.mdx files for quite some time to document our components for other engineers. This adds a default file to help new engineers get started writing useful documentation. These README.mdx file are also very useful for building out components in isolation from scratch and and some point will be used to run automated component testing.	3 years ago
John Cowen	73b6687c5b	ui: Transition App Chrome to use new Disclosure Menus (#12334) ... * Add %panel CSS component * Deprecate old menu-panel component * Various smallish tweaks to disclosure-menu * Move all menus in the app chrome to use new DisclosureMenu * Follow up CSS to move all app chrome menus to new components * Don't prevent default any events from anchors * Add a tick to click steps	3 years ago
chinmaym07	bbf4b8b759	fix: Added Tags tab to gateways(just like exists for non-gateway services) ... Signed-off-by: chinmaym07 <b418020@iiit-bh.ac.in>	3 years ago
John Cowen	360cf89ea5	ui: Fixup displaying a Nspace default policy when expanding the preview pane (#12316)	3 years ago
John Cowen	717621698d	ui: Replace CollapsibleNotices with more a11y focussed Disclosure component (#12305) ... * Delete collapsible notices component and related helper * Add relative t action/helper to our Route component * Replace single use CollapsibleNotices with multi-use Disclosure	3 years ago
John Cowen	9b22300c59	ui: Start using mermaid state diagrams in our docs (#12350)	3 years ago
Florian Apolloner	f01f00fc84	Support for connect native services in topology view. (#12098)	3 years ago
John Cowen	0e730328bd	ui: Disclosure Component amends plus DisclosureMenu Component (#12304) ... * ui: Disclosure amends plus DisclosureMenu Co-authored-by: Jamie White <jamie@jgwhite.co.uk>	3 years ago
John Cowen	0ac32122f1	ui: Make sure saving intentions from topology includes the partition (#12317)	3 years ago
John Cowen	cf98691e85	ui: Stop ember-data overwriting SyncTimes (#12315)	3 years ago
John Cowen	c1b4e33dee	ui: Exclude Service Health from Node listing page (#12248) ... This commit excludes the health of any service instances from the Node Listing page. This means that if you are viewing the Node listing page you will only see failing nodes if there are any Node Checks failing, Service Instance Health checks are no longer taken into account. Co-authored-by: Jamie White <jamie@jgwhite.co.uk>	3 years ago
John Cowen	d49ee8e355	ui: Ensure proxy instance health is taken into account in Service Instance Listings (#12279) ... We noticed that the Service Instance listing on both Node and Service views where not taking into account proxy instance health. This fixes that up so that the small health check information in each Service Instance row includes the proxy instances health checks when displaying Service Instance health (afterall if the proxy instance is unhealthy then so is the service instance that it should be proxying) * Refactor Consul::InstanceChecks with docs * Add to-hash helper, which will return an object keyed by a prop * Stop using/relying on ember-data type things, just use a hash lookup * For the moment add an equivalent "just give me proxies" model prop * Start stitching things together, this one requires an extra HTTP request ..previously we weren't even requesting proxies instances here * Finish up the stitching * Document Consul::ServiceInstance::List while I'm here * Fix up navigation mocks Name > Service	3 years ago
John Cowen	ed5204b6b5	ui: ShadowTemplate component (#12259)	3 years ago
John Cowen	b179f9fa91	ui: aria-menu modifier (#12262) ... aria-menu modifier plus Menu component (#12266)	3 years ago
John Cowen	69596a6433	ui: Disclosure Component (#12263)	3 years ago
John Cowen	39f15306d9	ui: Change approach to loading debug.css (#12242) ... We need a way to load certain CSS based on the environment you are viewing, i.e. we have debug CSS that we use for our Eng Documentation and various other DX utilities that shouldn't be compiled into our production or test builds. Previously we would compile two entirely different CSS files (app and debug) and the load one or the other depending on which environment you were in. This approach just empties out the debug.css file in certain environments (prod/test) which means we can just import that file from app. When in staging/development this imports the contents of debug.css (quite a bit of CSS) whereas when building for production/test this debug.css is emptied out during the build process. There is a slight little hack in order to have this work, we import _debug.scss which imports the debug.scss file. I couldn't for the life of me figure out how to have broccoli empty out a file during the build process, so instead we essentially copy over debug.scss during dev and create an empty file during prod to _debug.scss. When using make build to build an artifact for production CSS remains at ~58kb (during dev its a lot bigger than this)	3 years ago
John Cowen	0f94ce3964	ui: Alias all our Structure Icons to Flight Icons (#12209)	3 years ago
John Cowen	417cb8d838	ui: attach-shadow modifier (#12207) ... * ui: attach-shadow modifier * ui: adopt-styles helper (#12208)	3 years ago
John Cowen	189895e8fa	ui: style-map helper (#12203)	3 years ago
John Cowen	59756e4a88	ui: on-outside modifier (#12206)	3 years ago
John Cowen	de13e207e5	ui: css-prop modifier (#12205) ... Get the value for a single specific CSS Property from the modified element. returns can be specified either as a second parameter or an option.	3 years ago
John Cowen	eac0f5b860	ui: class-map helper (#12202) ... {{class-map}} is used to easily add a list of classes, conditionally, and have them all formatted nicely ready to be printed in a DOM class attribute. For ease, as well as using entries, you can also just provide a simple string without the boolean and that class will always be added.	3 years ago
John Cowen	e6a084807b	ui: Enable theming (#12134) ... plus Themeable icons (#12135)	3 years ago
John Cowen	61d7acd51f	ui: Tweak some code related meta information (#12117) ... * ui: Correct some meta info * Encoder doesn't take an argument whereas decoder does * Math.trunc looks like the closest to parseInt but using the correct type * use a dynamic string when setting things on window	3 years ago
Dan Upton	ca3aca92c4	[OSS] Remove remaining references to master (#11827)	3 years ago
John Cowen	48ace89c6a	ui: Runtime Injectable Components (#11969) ... - Simplifies how we 'import' our configuration files a little in order to make them more grokable. - Starts to exclude files based on explicit configuration rather than convention. - Adds the first instance of us being able to select an implementation (of multiple) of a component at runtime.	3 years ago
John Cowen	cdb8a35501	ui: Fixup KV folder creation then further creation within that folder (#12081) ... The fix here is two fold: - We shouldn't be providing the DataSource (which loads the data) with an id when we are creating from within a folder (in the buggy code we are providing the parentKey of the new KV you are creating) - Being able to provide an empty id to the DataSource/KV repository and that repository responding with a newly created object is more towards the "new way of doing forms", therefore the corresponding code to return a newly created ember-data object. As we changed the actual bug in point 1 here, we need to make sure the repository responds with an empty object when the request id is empty.	3 years ago
John Cowen	9192452885	ui: Adds a notice for non-primary intention creation (#11985)	3 years ago
John Cowen	b50c7cbef9	ui: Fix up wiring or empty state login button (#11981) ... * ui: Some ACL component documentation (#11982)	3 years ago
John Cowen	0ac27ef473	ui: Alter position of dashboard button in the service instance header (#11988)	3 years ago
John Cowen	e424e3dc83	ui: Allow templateName paths to be relative (#11955)	3 years ago
John Cowen	2aaa96bf96	ui: First pass at writing some data layer related Eng docs (#11203)	3 years ago
Kenia	aaace559e2	ui: Adding Partition to topology card (#11805)	3 years ago
John Cowen	78e9c0d2d9	ui: Ensure the partition is passed through to the request for the SSO auth URL (#11979) ... * Make sure the mocks reflect the requested partition/namespace * Ensure partition is passed through to the HTTP adapter * Pass AuthMethod object through to TokenSource in order to use Partition * Change up docs and add potential improvements for future * Pass the query partition back onto the response * Make sure the OIDC callback mock returns a Partition * Enable OIDC provider mock overwriting during acceptance testing * Make sure we can enable partitions and SSO post bootup only required ...for now * Wire up oidc provider mocking * Add SSO full auth flow acceptance tests	3 years ago
John Cowen	d9a315e2a5	ui: Remove KV pre-flight auth check (#11968) ... * ui: Don't even ask whether we are authorized for a KV... ...just let the actual API tell us in the response, thin-client style. * Add some similar commenting for previous PRs related to this problem	3 years ago
John Cowen	6c240fbf2d	ui: Ensure service instance data does not get re-written on blocking refresh (#11903) ... * Add some less fake API data * Rename the models class so as to not be confused with JS Proxies * Rearrange routlets slightly and add some initial outletFor tests * Move away from a MeshChecks computed property and just use a helper * Just use ServiceChecks for healthiness filtering for the moment * Make TProxy cookie configurable * Amend exposed paths and upstreams so they know about meta AND proxy * Slight bit of TaggedAddresses refactor while I was checking for `meta` etc * Document CONSUL_TPROXY_ENABLE	3 years ago
John Cowen	adb0fa38d2	ui: [BUGFIX] Fixes an issue when editing intentions from the service > intentions sub tab (#11937) ... We recently changed the intentions form to take a full model of a dc rather than just the string identifier (so {Name: 'dc', Primary: true} vs just 'dc' in order to know whether the DC is the primary or not. Unfortunately, we only did this on the global intentions page not the per service intentions page. This makes it impossible to save an intention from the per service intention page (whilst you can still save intentions from the global intention page as normal). The fix here pretty much copy/pastes the approach taken in the global intention edit template over to the per service intention edit template. Tests have been added for creation in the per service intention section, which again are pretty much just copied from the global one, unfortunately this didn't exist previously which would have helped prevent this.	3 years ago
John Cowen	6bdb2c2216	ui: Upgrade AuthDialog (#11913) ... - Move AuthDialog to use a Glimmer Component plus native named blocks/slots. - Unravel the Auth* contextual components, there wasn't a lot of point having them as contextual components and now the AuthDialog (non-view-specific state machine component) can be used entirely separately from the view-specific components (AuthForm and AuthProfile). - Move all the ACL related components that are in the main app chrome/navigation (our HashicorpConsul component) in our consul-acls sub package/module (which will eventually be loaded on demand only when ACLs are enabled)	3 years ago
John Cowen	1f8960d74b	ui: Fix dark borders on certain visualizations (#11959)	3 years ago
John Cowen	6d0a73c0eb	ui: Add selective no-console eslint rule (#11938)	3 years ago
John Cowen	31dee2340f	ui: Only allow partition creation with a single datacenter setup (#11817)	3 years ago
John Cowen	64767b53e7	ui: Configure routes in route config rather than classes (#11900)	3 years ago
James Tran	d1ac40e967	ui: Add XML syntax highlighting to key/value editor (#11785) ... * ui: Add XML syntax highlighting to key/value editor * ui: Make explicit options that are specific to XML for clarity	3 years ago
John Cowen	f8b336b9a0	ui: Fix URL params decoding (#11931) ... * ui: Move wildcard param decoding to routlet service	3 years ago
John Cowen	72e5d7e1d4	ui: Ensure disconnect error doesn't appear w/auth change on some pages (#11905)	3 years ago
John Cowen	3949acbc1d	ui: Remove any route level auth checks (#11891)	3 years ago
John Cowen	2f6ae96ccd	ui: Fixup names of Meta for instance search, also add Node (#11774)	3 years ago
John Cowen	2c1eb052e3	ui: Various empty state improvements/fixups (#11892) ... * ui: Add login button to per service intentions for zero results * Add login button and consistent header for when you have zero nodes * `services` doesn't exists use `items` consequently: Previous to this fix we would not show a more tailored message for when you empty result set was due to a user search rather than an empty result set straight from the backend * Fix `error` > `@error` in ErrorState plus code formatting and more docs * Changelog	3 years ago
John Cowen	72cddf4f49	ui: Check for `intention` ACL resources, not `intentions` ACL resources (#11880) ... * ui: Check for `intention` ACL resources, not `intentions` ACL resources * ui: Flip the test assertion to see the create button temporarily	3 years ago
John Cowen	ba70fe5e55	ui: Fix up missing policy delete warning modal (#11868) ... Fixes an issue where the policy detail page delete button would disappear when clicking rather than showing a modal confirmation	3 years ago
John Cowen	20cc028ac0	ui: Fixes an issue with the version footer when scrolling (#11850)	3 years ago
John Cowen	11ab84f840	ui: Add version information back into the footer (#11803)	3 years ago
John Cowen	2ba0e86d6d	ui: Disable setting wildcard partitions for intentions (#11804)	3 years ago
John Cowen	79b25901d7	ui: Change the URL prefix of partitions from `-` to `_` (#11801)	3 years ago
John Cowen	79679da840	ui: Fix a problem showing the default part in a non-primary (#11800) ... When switching to a non-primary datacenter we should only show the word 'default' in place of the partition menu, this fixes up a bug preventing that from happening due to erroneous if/let nesting	3 years ago