4 Commits (df951bd601720fb6bfb8f17ed9e8126ab7024f66)

Author	SHA1	Message	Date
Daniel Nephin	2054402a53	envoy: improve comments	2021-06-01 11:35:32 -04:00
Daniel Nephin	c9bc5f92b7	envoy: fix bootstrap deadlock caused by a full named pipe ... Normally the named pipe would buffer up to 64k, but in some cases when a soft limit is reached, they will start only buffering up to 4k. In either case, we should not deadlock. This commit changes the pipe-bootstrap command to first buffer all of stdin into the process, before trying to write it to the named pipe. This allows the process memory to act as the buffer, instead of the named pipe. Also changed the order of operations in `makeBootstrapPipe`. The new test added in this PR showed that simply buffering in the process memory was not enough to fix the issue. We also need to ensure that the `pipe-bootstrap` process is started before we try to write to its stdin. Otherwise the write will still block. Also set stdout/stderr on the subprocess, so that any errors are visible to the user.	2021-05-31 18:53:17 -04:00
Daniel Nephin	e1b1ab7ef6	envoy: start timeout func after validation ... This removes the need to check arg length in the timeout function.	2021-05-31 17:37:58 -04:00
Paul Banks	9f656a2dc8	Fix envoy 1.10 exec (#5964) ... * Make exec test assert Envoy version - it was not rebuilding before and so often ran against wrong version. This makes 1.10 fail consistenty. * Switch Envoy exec to use a named pipe rather than FD magic since Envoy 1.10 doesn't support that. * Refactor to use an internal shim command for piping the bootstrap through. * Fmt. So sad that vscode golang fails so often these days. * go mod tidy * revert go mod tidy changes * Revert "ignore consul-exec tests until fixed (#5986)" This reverts commit 683262a686. * Review cleanups	2019-06-21 16:06:25 +01:00