2024 Commits (d6649e42af5f2af541fa18e2d3518f71aa9f718b)

Author	SHA1	Message	Date
Pierre Souchay	d6649e42af	Stop all watches before shuting down anything dring shutdown. (#7526) ... This will prevent watches from being triggered. ```changelog * fix(agent): stop all watches before shuting down ```	5 years ago
R.B. Boyer	1b5023cb69	connect: ensure proxy-defaults protocol is used for upstreams (#7938)	5 years ago
Kyle Havlovitz	b14696e32a	Standardize support for Tagged and BindAddresses in Ingress Gateways (#7924) ... * Standardize support for Tagged and BindAddresses in Ingress Gateways This updates the TaggedAddresses and BindAddresses behavior for Ingress to match Mesh/Terminating gateways. The `consul connect envoy` command now also allows passing an address without a port for tagged/bind addresses. * Update command/connect/envoy/envoy.go Co-authored-by: Freddy <freddygv@users.noreply.github.com> * PR comments * Check to see if address is an actual IP address * Update agent/xds/listeners.go Co-authored-by: Freddy <freddygv@users.noreply.github.com> * fix whitespace Co-authored-by: Chris Piraino <cpiraino@hashicorp.com> Co-authored-by: Freddy <freddygv@users.noreply.github.com>	5 years ago
Daniel Nephin	03291943e1	Merge pull request #7933 from hashicorp/dnephin/state-txn-missing-errors ... state: fix unhandled error	5 years ago
Daniel Nephin	04bf0f3490	Update agent/consul/state/catalog.go ... Co-authored-by: Hans Hasselberg <me@hans.io>	5 years ago
Seth Hoenig	44ee818d46	grpc: use default resolver scheme for grpc dialing (#7617) ... Currently checks of type gRPC will emit log messages such as, 2020/02/12 13:48:22 [INFO] parsed scheme: "" 2020/02/12 13:48:22 [INFO] scheme "" not registered, fallback to default scheme Without adding full support for using custom gRPC schemes (maybe that's right long-term path) we can just supply the default scheme as provided by the grpc library. Fixes https://github.com/hashicorp/consul/issues/7274 and https://github.com/hashicorp/nomad/issues/7415	5 years ago
Daniel Nephin	3f607d9ef0	state: use an error to indicate compare failed ... Errors are values. We can use the error value to identify the 'comparison failed' case which makes the function easier to use and should make it harder to miss handle the error case	5 years ago
Pierre Souchay	5c7af90154	tests: added unit test to ensure watches are not re-triggered on consul reload (#7449) ... This ensures no regression about https://github.com/hashicorp/consul/issues/7318 And ensure that https://github.com/hashicorp/consul/issues/7446 cannot happen anymore	5 years ago
Pierre Souchay	e9d176db2a	Allow to restrict servers that can join a given Serf Consul cluster. (#7628) ... Based on work done in https://github.com/hashicorp/memberlist/pull/196 this allows to restrict the IP ranges that can join a given Serf cluster and be a member of the cluster. Restrictions on IPs can be done separatly using 2 new differents flags and config options to restrict IPs for LAN and WAN Serf.	5 years ago
Daniel Nephin	1bbea2751f	consul/state: refactor tnxService to avoid missed cases ... Handling errors at the end of a log switch/case block is somewhat brittle. This block included a couple cases where errors were ignored, but it was not obvious the way it was written. This change moves all error handling into each case block. There is still potentially one case where err is ignored, which will be handled in a follow up.	5 years ago
Daniel Nephin	9f27d61bee	Remove unused var ... The usage was removed in 8e22d80e35, however it seems there may be a bug here because the cluster name is not updated when the target changes.	5 years ago
Daniel Nephin	4f738b462b	Handle error from template.Execute ... Refactored the function to make the problem more obvious, by using a guard.	5 years ago
Daniel Nephin	c662f0f0de	Fix a number of problems found by staticcheck ... Some of these problems are minor (unused vars), but others are real bugs (ignored errors). Co-authored-by: Matt Keeler <mkeeler@users.noreply.github.com>	5 years ago
Daniel Nephin	5c99109dd9	Remove unused var ... The usage of this var was removed in b92f895c23. Found by using staticcheck	5 years ago
Chris Piraino	9d9e23cc44	Add service id context to the proxycfg logger ... This is especially useful when multiple proxies are all querying the same Consul agent.	5 years ago
Chris Piraino	79468793f6	Do not return an error if requested service is not a gateway ... This commit converts the previous error into just a Warn-level log message. By returning an error when the requested service was not a gateway, we did not appropriately update envoy because the cache Fetch returned an error and thus did not propagate the update through proxycfg and xds packages.	5 years ago
Aleksandr Zagaevskiy	a75e3d9051	Preserve ModifyIndex for unchanged entry in KVS TXN (#7832)	5 years ago
Pierre Souchay	cf55e81c06	tests: fix unstable test `TestAgentAntiEntropy_Checks`. (#7594) ... Example of failure: https://circleci.com/gh/hashicorp/consul/153932#tests/containers/2	5 years ago
Kit Patella	ad1d4d4d07	http: migrate from instrumentation in s.wrap() to an s.enterpriseHandler()	5 years ago
Matt Keeler	acccdbe45c	Fix identity resolution on clients and in secondary dcs (#7862) ... Previously this happened to be using the method on the Server/Client that was meant to allow the ACLResolver to locally resolve tokens. On Servers that had tokens (primary or secondary dc + token replication) this function would lookup the token from raft and return the ACLIdentity. On clients this was always a noop. We inadvertently used this function instead of creating a new one when we added logging accessor ids for permission denied RPC requests. With this commit, a new method is used for resolving the identity properly via the ACLResolver which may still resolve locally in the case of being on a server with tokens but also supports remote token resolution.	5 years ago
Chris Piraino	7a7760bfd5	Make new gateway tests compatible with enterprise (#7856)	5 years ago
Daniel Nephin	600645b5f9	Add unconvert linter ... To find unnecessary type convertions	5 years ago
Drew Bailey	c9d0b83277	Value is already an int, remove type cast	5 years ago
Daniel Nephin	9d5ab443a7	Merge pull request #7689 from hashicorp/dnephin/remove-deadcode-1 ... Remove some dead code	5 years ago
Daniel Nephin	47238a693d	Merge pull request #7819 from hashicorp/dnephin/remove-t.Parallel-1 ... test: Remove t.Parallel() from agent/structs tests	5 years ago
R.B. Boyer	1efafd7523	acl: add auth method for JWTs (#7846)	5 years ago
Kit Patella	58ee349a83	Merge pull request #7843 from hashicorp/oss-sync/auditing-config ... agent/config: Fix tests & include Audit struct as a pointer on Config	5 years ago
Kit Patella	10b3478a4d	agent/config: include Audit struct as a pointer on Config, fix tests	5 years ago
Kit Patella	b5564751bf	Merge pull request #7841 from hashicorp/oss-sync/auditing-config ... OSS sync - Auditing config	5 years ago
Kit Patella	f5030957d0	agent/config: add auditing config to OSS and add to enterpriseConfigMap exclusions	5 years ago
Chris Piraino	c21052457b	Return early from updateGatewayServices if nothing to update (#7838) ... * Return early from updateGatewayServices if nothing to update Previously, we returned an empty slice of gatewayServices, which caused us to accidentally delete everything in the memdb table * PR comment and better formatting	5 years ago
Chris Piraino	4d6751bf16	Fix TestInternal_GatewayServiceDump_Ingress (#7840) ... Protocol was added as a field on GatewayServices after GatewayServiceDump PR branch was created.	5 years ago
R.B. Boyer	7414a3fa53	cli: ensure 'acl auth-method update' doesn't deep merge the Config field (#7839)	5 years ago
Chris Piraino	74c0543ef2	PR comment and better formatting	5 years ago
Chris Piraino	fb9ee9d892	Return early from updateGatewayServices if nothing to update ... Previously, we returned an empty slice of gatewayServices, which caused us to accidentally delete everything in the memdb table	5 years ago
Freddy	b3ec383d04	Gateway Services Nodes UI Endpoint (#7685) ... The endpoint supports queries for both Ingress Gateways and Terminating Gateways. Used to display a gateway's linked services in the UI.	5 years ago
Kyle Havlovitz	136549205c	Merge pull request #7759 from hashicorp/ingress/tls-hosts ... Add TLS option for Ingress Gateway listeners	5 years ago
Kyle Havlovitz	8d140ce9af	Disallow the blanket wildcard prefix from being used as custom host	5 years ago
Chris Piraino	a0e1f57ac2	Remove development log line	5 years ago
Chris Piraino	26f92e74f6	Compute all valid DNSSANs for ingress gateways ... For DNSSANs we take into account the following and compute the appropriate wildcard values: - source datacenter - namespaces - alt domains	5 years ago
Daniel Nephin	5655d7f34e	Add outlier_detection check to integration test ... Fix decoding of time.Duration types.	5 years ago
Daniel Nephin	eaa05d623a	xds: Add passive health check config for upstreams	5 years ago
Chris Piraino	429d0cedd2	Restoring config entries updates the gateway-services table (#7811) ... - Adds a new validateConfigEntryEnterprise function - Also fixes some state store tests that were failing in enterprise	5 years ago
Daniel Nephin	e60bb9f102	test: Remove t.Parallel() from agent/structs tests ... go test will only run tests in parallel within a single package. In this case the package test run time is exactly the same with or without t.Parallel() (~0.7s). In generally we should avoid t.Parallel() as it causes a number of problems with `go test` not reporting failure messages correctly. I encountered one of these problems, which is what prompted this change. Since `t.Parallel` is not providing any benefit in this package, this commit removes it. The change was automated with: git grep -l 't.Parallel' | xargs sed -i -e '/t.Parallel/d'	5 years ago
Freddy	c32a4f1ece	Fix up enterprise compatibility for gateways (#7813)	5 years ago
Jono Sosulska	9b363e9f23	Fix spelling of deregister (#7804)	5 years ago
Chris Piraino	f55e20a2f7	Allow ingress gateways to send empty clusters, routes, and listeners (#7795) ... This is useful when updating an config entry with no services, and the expected behavior is that envoy closes all listeners and clusters. We also allow empty routes because ingress gateways name route configurations based on the port of the listener, so it is important we remove any stale routes. Then, if a new listener with an old port is added, we will not have to deal with stale routes hanging around routing to the wrong place. Endpoints are associated with clusters, and thus by deleting the clusters we don't have to care about sending empty endpoint responses.	5 years ago
Chris Piraino	0bd5618cb2	Cleanup proxycfg for TLS ... - Use correct enterprise metadata for finding config entry - nil out cancel functions on config snapshot copy - Look at HostsSet when checking validity	5 years ago
Chris Piraino	5105bf3d67	Require individual services in ingress entry to match protocols (#7774) ... We require any non-wildcard services to match the protocol defined in the listener on write, so that we can maintain a consistent experience through ingress gateways. This also helps guard against accidental misconfiguration by a user. - Update tests that require an updated protocol for ingress gateways	5 years ago
Freddy	b069887b2a	Remove timeout and call to Fatal from goroutine (#7797)	5 years ago