196 Commits (d46b0596739a6977e820ee921cdbc97d0240cdbd)

Author	SHA1	Message	Date
John Cowen	d46b059673	UI: CSS Refactor (#4919) ... - Adds full set of svg icons as CSS/Sass variables to the source - Starts picking out some frame-grays, whilst commenting in possibles - Remove color prefixing The prefixes `ui-` and `brand-` for colors hav been removed. This makes colors slightly easier to type. In order to differentiate between brand colors and 'normal' colors, normal colors are named as 'true colors' i.e. blue, red, green etc etc whereas the brand colors used a more premium sounding name such as 'steel' for vault gray, 'magenta' for consul, 'cobalt' for vagrant etc etc.	6 years ago
John Cowen	3879487ab8	ui: Prefer using `notOk(actual)` instead of `ok(!actual)` in tests (#4925) ... And make sure its consistent throughout the app	6 years ago
John Cowen	d6c1b9ed3f	ui: Move ACL policy and token repos to use the RepositoryService (#4867)	6 years ago
John Cowen	c9fae76b7d	ui: Refactors the code-mirror linting/restrict legacy tokens to HCL (#4866)	6 years ago
John Cowen	65ef2969c7	ui: Async Search (#4859) ... This does several things to make improving the search experience easier moving forwards: 1. Separate searching off from filtering. 'Searching' can be thought of as specifically 'text searching' whilst filtering is more of a boolean/flag search. 2. Decouple the actual searching functionality to almost pure, isolated / unit testable units and unit test. (I still import embers get which, once I upgrade to 3.5, I shouldn't need) 3. Searching rules are now configurable from the outside, i.e. not wrapped in Controllers or Components. 4. General searching itself now can use an asynchronous approach based on events. This prepares for future possibilities of handing off the searching to a web worker or elsewhere, which should aid in large scale searching and prepares the way for other searching methods. 5. Adds the possibility of have multiple searches in one template/route/page. Additionally, this adds a WithSearching mixin to aid linking the searching to ember in an ember-like way in a single place. Plus a WithListeners mixin to aid with cleaning up of event listeners on Controller/Component destruction. Post-initial work I slightly changed the API of create listeners: Returning the handler from a `remover` means you can re-add it again if you want to, this avoids having to save a reference to the handler elsewhere to do the same. The `remove` method itself now returns an array of handlers, again you might want to use these again or something, and its also more useful then just returning an empty array. The more I look at this the more I doubt that you'll ever use `remove` to remove individual handlers, you may aswell just use the `remover` returned from add. I've added some comments to reflect this, but they'll likely be removed once I'm absolutely sure of this. I also added some comments for WithSearching to explain possible further work re: moving `searchParams` so it can be `hung` off the controller object	6 years ago
John Cowen	ae71d6ce96	ui: Custom version of ember-block-slots compatible with ember 3 (#5245) ... The original version of ember-block-slots doesn't support ember 3 and it seems like development has stalled on the original version. This adds a modified version as an in-repo-addon that is compatible with ember 3.	6 years ago
John Cowen	acee937f69	ui: Bump footer date (#5279)	6 years ago
John Cowen	a35fe7c5ba	ui: Removes delete button form pages that show your current token (#5241) ... Tokens can no longer delete themselves see: https://github.com/hashicorp/consul/pull/5210 ...so we remove the button to allow you to do that from the UI	6 years ago
John Cowen	c8386ec0cc	UI: [BUGFIX] Decode/encode urls (#5206) ... In 858b05fc31 (diff-46ef88aa04507fb9b039344277531584) we removed encoding values in pathnames as we thought they were eventually being encoded by `ember`. It looks like this isn't the case. Turns out sometimes they are encoded sometimes they aren't. It's complicated. If at all possible refer to the PR https://github.com/hashicorp/consul/pull/5206. It's related to the difference between `dynamic` routes and `wildcard` routes. Partly related to this is a decision on whether we urlencode the slashes within service names or not. Whilst historically we haven't done this, we feel its a good time to change this behaviour, so we'll also be changing services to use dynamic routes instead of wildcard routes. So service links will then look like /ui/dc-1/services/application%2Fservice rather than /ui/dc-1/services/application/service Here, we define our routes in a declarative format (for the moment at least JSON) outside of Router.map, and loop through this within Router.map to set all our routes using the standard this.route method. We essentially configure our Router from the outside. As this configuration is now done declaratively outside of Router.map we can also make this data available to href-to and paramsFor, allowing us to detect wildcard routes and therefore apply urlencoding/decoding. Where I mention 'conditionally' below, this is detection is what is used for the decision. We conditionally add url encoding to the `{{href-to}}` helper/addon. The reasoning here is, if we are asking for a 'href/url' then whatever we receive back should always be urlencoded. We've done this by reusing as much code from the original `ember-href-to` addon as possible, after this change every call to the `{{href-to}}` helper will be urlencoded. As all links using `{{href-to}}` are now properly urlencoded. We also need to decode them in the correct place 'on the other end', so.. We also override the default `Route.paramsFor` method to conditionally decode all params before passing them to the `Route.model` hook. Lastly (the revert), as we almost consistently use url params to construct API calls, we make sure we re-encode any slugs that have been passed in by the user/developer. The original API for the `createURL` function was to allow you to pass values that didn't need encoding, values that **did** need encoding, followed by query params (which again require url encoding) All in all this should make the entire ember app url encode/decode safe.	6 years ago
John Cowen	66c139ceae	UI: Text change and clarity Node Health > Health Checks (#5115) ... Text change Node Health > Health Checks Also adds an info icon and tooltip to Health Checks column header	6 years ago
Jihoon Chung	d5e28bda56	ui: Fix typo in acl-migration guide link (#5135)	6 years ago
Alvin Huang	5425a86058	add documentation on how to use ember-exam	6 years ago
Alvin Huang	f623b9817e	add test-parallel yarn command	6 years ago
Alvin Huang	c4a837c7b5	change env to test	6 years ago
Alvin Huang	3feb26f30d	adding build-ci yarn target	6 years ago
Alvin Huang	a92fa407d5	output XML test results	6 years ago
Alvin Huang	93490c600b	enable ember-exam	6 years ago
Alvin Huang	5b6ea377b4	update testem with newer conventions	6 years ago
Alvin Huang	45cf7dec4f	adding ember-exam package	6 years ago
Hans Hasselberg	0b4a879203	ui: serve /robots.txt when UI is enabled. (#5089) ... * serve /robots.txt * robots.txt: disallow everything	6 years ago
John Cowen	8433b26b78	ui: Correctly escape an inline svg icon (#5032)	6 years ago
John Cowen	7ecbb63102	ui: Add AWS external-source icon (#5030)	6 years ago
John Cowen	9c11109db4	ui: If a service has no external-source, don't show the icon (#4996)	6 years ago
John Cowen	e1fb21cd4c	ui: Adds the CONSUL_VERSION env var into the HTML source in a comment (#4993)	6 years ago
John Cowen	c6db97b666	UI: Removes success notification on faking a success response for `self` (#4906) ... In order to continue supporting the legacy ACL system, we replace the 500 error from a non-existent `self` endpoint with a response of a `null` `AccessorID` - which makes sense (a null AccessorID means old API) We then redirect the user to the old ACL pages which then gives a 403 if their token was wrong which then redirects them back to the login page. Due to the multiple redirects and not wanting to test the validity of the token before redirecting (thus calling the same API endpoint twice), it is not straightforwards to turn the 'faked' response from the `self` endpoint into an error (flash messages are 'lost' through multiple redirects). In order to make this a slightly better experience, you can now return a `false` during execution of an action requiring success/failure feedback, this essentially skips the notification, so if the action is 'successful' but you don't want to show the notification, you can. This resolves showing a successful notification when the `self` endpoint response is faked. The last part of the puzzle is to make sure that the global 403 catching error in the application Route also produces an erroneous notification. Please note this can only happen with a ui client using the new ACL system when communicating with a cluster using the old ACL system, and only when you enter the wrong token. Lastly, further acceptance tests have been added around this This commit also adds functionality to avoid any possible double notification messages, to avoid UI overlapping	6 years ago
John Cowen	7ddafc45d9	ui: Make empty Rules ('') take priority over a `Legacy: true` (#4899) ... Even if an old style token has a Legacy of true, yet it has an empty set of Rules, treat the token as a new style token, as its essentially the same	6 years ago
John Cowen	f65f001675	UI: Catch 500 error on token endpoint and revert to legacy tokens (#4874) ... In some circumstances a consul 1.4 client could be running in an un-upgraded 1.3 or lower cluster. Currently this gives a 500 error on the new ACL token endpoint. Here we catch this specific 500 error/message and set the users AccessorID to null. Elsewhere in the frontend we use this fact (AccessorID being null) to decide whether to present the legacy or the new ACL UI to the user. Also: - Re-adds in most of the old style ACL acceptance tests, now that we are keeping the old style UI - Restricts code editors to HCL only mode for all `Rules` editing (legacy/'half legacy'/new style) - Adds a [Stop using] button to the old style ACL rows so its possible to logout. - Updates copy and documentation links for the upgrade notices	6 years ago
John Cowen	de6644675d	ui: Brings the new ACLs into line with the new repo folder structure (#4857) ... This PR updates the folder structure and naming of the new ACLs, the same as #4694 .	6 years ago
John Cowen	f1246801b1	ui: Some trivial test additions, support env var passing of port numbers (#4728) ... 1. Unskip some trivial tests that were being tested higher up 2. Istanbul ignore some code for coverage. 1. Things that I didn't write and need to 100% follow 2. The source code checking test that has Istanbul code injected into it 3. Add a few simple test cases 4. Support passing port numbers through to `ember serve` and `ember test` for use cases that would benefit from being able to configure the ports things are served over but still use `yarn run` thus reusing the `yarn run` config in `package.json`	6 years ago
John Cowen	14aa90e309	ui: Move repo services to repository/ folder and standardize naming (#4694) ... Repositories are a class of services to help with CRUD actions, most of the functionality is reused across various Models. This creates a new repository service that centralizes all this reused functionality. Inheritance via ember `Service.extend` is used as opposed to decorating via Mixins. 1. Move all repository services (and their tests) to a services/repository folder 2. Standardize on a singular name format 'node vs nodes' 3. Create a new 'repository' service to centralize functionality. This should be extended by 'repository' services	6 years ago
John Cowen	d98c1242dc	ui: Adds multi syntax linting to the code editor (#4814)	6 years ago
John Cowen	7d89e519a2	UI: New ACLs (#4789) ... UI to accompany the new ACLs APIs	6 years ago
John Cowen	297788408b	ui: Fix freetext searching within the nodes page (#4819) ... Essentially this was missing a call to `super`. The error unfortuantely didn't arise in the tests as it only errors when the node list has 4 items are more (the 4 columns), and the acceptence tests by change were only filling the page with 3 nodes for test purposes. I've bumped the amount of nodes up to 4 in the tests, which then causes the tests to fail, made the fix by adding the `super` call, and the tests now pass. I also tested the UI/text searching on a 10,000 node system, and everything now works as expected.	6 years ago
John Cowen	5f39bfd161	ui: Improve layout of node cards on large and small screens (#4761) ... 1. The grid based unhealthy cards are now clamped to only four wide maximum. This means that on larger screen the cards are much wider meaning you can view more information. Grid gutters are also clamped at a certain ideal width screen, remaining responsive for anything below this. 2. The healthy node columns are finally responsive following the same column rules as unhealthy nodes	6 years ago
John Cowen	461db096ed	ui: Add truncation to the `.Address` (#4760)	6 years ago
John Cowen	b75731aaec	ui: Cope with service names that contain slashes (#4756)	6 years ago
John Cowen	3410f5955a	ui: Reduce the breakpoint at which the smaller footer kicks in (#4723)	6 years ago
John Cowen	8ba1c549a9	ui: Move the text encoding polyfill to a a proper detecting polyfill (#4767)	6 years ago
John Cowen	9da8ad8f3d	UI: Package upgrades (#4740) ... Upgrade all patch and minor upgradeable packages, also uses `only` in ember-cli-build to reduce the included helpers from certain helper packages. Make some major version upgrades for some dev tools - husky - lint-staged - ember-cli-yadda - ember-cli-sass (also moved from node-sass to dart-sass) Minor tweak: spotted css file (instead of scss file), rename The move to `dart-sass`: dart-sass has been the primary implementation of sass for ~6 months and will receive updates earlier than libsass (ruby-sass itself is now deprecated) Other benefits include not having to recompile (via `npm rebuild` or similar) when switching platforms and an 'almost' javascript based solution. This update also alters some media queries that, whilst wouldn't compile anymore with either an updated libsass or dart-sass, where probably a little over complicated anyway, I've therefore made them similar to other breakpoints that made sense.	6 years ago
John Cowen	99c51c9f86	UI: Reduce in-development deprecations (also use toLocaleString) (#4677) ... Various ember addons produced deprecation messages, some in the browser console and some in terminal. Upgrading and replacing some of these has reduced this. Upgrades: - ember-collection - ember-computed-style Replacements: - ember-pluralize replaced with ember-inflector - ember-cli-format-number replaced with custom helper using standard `toLocaleString` Removing ember-cli-format-number also meant some further changes related to decimal places in the tomography graph, done using `toFixed` The ExternalSources background-images have also now been escaped correctly preventing in-development `console` warnings. The only deprecation warnings are now from ember-block-slots, only in terminal, making for a better development experience overall, especially now we have an empty browser console Also adds a `callIfType` 'helper util' which is a util specifically for helpers (it conforms to a helper argument signature) to be expanded upon later.	6 years ago
John Cowen	96508e556b	ui: Layout fix. Small padding additions to tables (#4701) ... 1. The 'Services' header need to be knocked ot the right slightly to line up properly with the service name when there are no external source icons. 2. Add a single space between ServiceName and ServiceID on the Node > [Services] tab table.	6 years ago
John Cowen	ece09e300d	UI: Tooltips and feedback-dialogs are the same thing - merge (#4678)	6 years ago
John Cowen	d0405ba8b9	UI: CSS Additions (mainly %frames) (#4623) ... * Move almost everything to use %frames * Fix pill styles of ACL types * Remove horizontal scrollbars from dom recycling scroller component * Make text areas look ok in Firefox * Remove ember-bulma-css * New form elements, break out %toggle * %button design tweaks * %form-element design tweaks * Better hashicorp logo * Small screen CSS improvements (#4624) 1. Reduce header size when there are no breadcrumbs 2. Make the filters toggleable, closed by default 3. Reduce the size of the footer on small screens 4. Hide all non-primary columns for forms 5. Slightly change the layout of various items, mainly buttons within forms 6. Make some confirmation dialogs work vertically on small screens. Guessing we might be better just using native confirmations on small screens	6 years ago
John Cowen	89620b93c2	ui: Turn off the code editor whilst making an edit during testing (#4668) ... Having the code editor on removes the text area from the DOM, making it more difficult to enter text in the text editor during testing. This turns the code editor off whilst making edits during testing. No changes to UI code	6 years ago
John Cowen	eb218ab93f	ui: Test bugfix. Specifically set deny for intention creation (#4663) ... Make sure we speficially set and test for deny on testing intention creation	6 years ago
John Cowen	5bb38f6ab5	ui: Tests Bugfix. Reflect extra json property `ExternalSources` in mocks (#4662) ... The mocks where using randomly generated `ExternalSources` this change makes sure they are fixed so we can reliably test the values. No change to actual UI code	6 years ago
John Cowen	028875a732	UI: Set the CODE view as the default view for editing KV's (#4651) ... Sets the code toggle on the KV edit/create page to be on by default, we figured most people probably prefer this view. Also, previously we forced the KV toggle back to a default setting for every time you visited a KV form page. We've now changed this so that the KV code toggle button acts as a 'global' toggle. So whatever you set it as will be the same for every KV for the lifetime of your 'ember session' If we are to keep this, then consider saving this into localStorage settings or similar, added some thoughts in comments re: this as it's very likely to happen.	6 years ago
John Cowen	f54fd21946	ui: [BUGFIX] Intentions were showing the wrong notification on creation (#4658) ... The error notification was being shown on creation of an intention. This was as a result of #4572 and/or #4572 and has not been included in a release. This includes a fix, plus tests to try to prevent any further regression.	6 years ago
John Cowen	0757a08684	ui: Adds a `default` view helper for providing a default value (#4650) ... If the first value passed to the helper is an empty string or undefined then return the second value	6 years ago
John Cowen	5ea748005c	UI: External Source markers (#4640) ... 1. Addition of external source icons for services marked as such. 2. New %with-tooltip css component (wip) 3. New 'no healthcheck' icon as external sources might not have healthchecks, also minus icon on node cards in the service detail view 4. If a service doesn't have healthchecks, we use the [Services] tabs as the default instead of the [Health Checks] tab in the Service detail page. 5. `css-var` helper. The idea here is that it will eventually be replaced with pure css custom properties instead of having to use JS. It would be nice to be able to build the css variables into the JS at build time (you'd probably still want to specify in config which variables you wanted available in JS), but that's possible future work. Lastly there is probably a tiny bit more testing edits here than usual, I noticed that there was an area where the dynamic mocking wasn't happening, it was just using the mocks from consul-api-double, the mocks I was 'dynamically' setting happened to be the same as the ones in consul-api-double. I've fixed this here also but it wasn't effecting anything until actually made certain values dynamic.	6 years ago