234 Commits (d459bfd81c8c38284c37b52cd224a18c81f9cd97)

Author	SHA1	Message	Date
Kenia	d459bfd81c	ui: Add blocking queries to gateways (#7967) ... * Remove gateway endpoint adapter, model, and serializer and tests * Update service tests to handle gateway-services-nodes * Upgrade consul-api-double to 2.15.2 * Add a fairly temporary shouldReconcile method Co-authored-by: John Cowen <jcowen@hashicorp.com>	5 years ago
Kenia	c4b2fcbd38	ui: Create Tags & Meta tab (#7954)	5 years ago
Kenia	8077a41f42	ui: Make only existing services in Upstreams linkabled with hover effect (#7943) ... * Create service/exist helper to be used in ListCollection list items * Make only existing services in Upstreams linkabled with hover effect	5 years ago
John Cowen	7e1e6e44c3	ui: remove some components/javascript we are no longer using (#7941)	5 years ago
Kenia	91b22f21ba	ui: Implement EmberTooltips to Upstreams (#7930) ... * Add ember-tooltips addon * Create Tooltip component with styling and test * Implement Tooltip into Upstreams	5 years ago
John Cowen	200945714a	UI Release Merge (1.8-beta-2: ui-staging merge) (#7919) ... * ui: Styling fixes (#7885) * Move cellHeight to ListCollection js file * Fix composite row border-top-color onHover state * Add empty health check icon to CompositeRow styling * ui: Slightly refactor %composite-rows and reuse ConsulServiceList component (#7886) * ui: Move individual component types into a single %composite-list plus 1. Removes all out separate CSS components (that match HTML components) to favour not having those separate for the moemnt at least 2. Reuses <ConsulServiceList /> component for Terminating Gateways > Linked Services * ui: Tweak breadcrumb spacing for '/' separator * Fix up the tests i.e. services per tab so we can call them all services * ui: Misc discovery chain fixes (#7892) 1. Look for a default splitter before looking for a default resolver in order to route to. 2. Delay adding svg listeners until afterRender (fixes split tooltip) 3. Make router id's consistent for highlighting default routers in when clicking the graph * ui: If an error occurs on the server, surface it in the notification (#7893) * ui: Delete old unused CSS (#7909) This commit deletes CSS that we no longer use and we definitely will not ever use. We also dedup all of our imports here as it turns out SASS doesn't dedupe imports. Strangely this increases out CSS weight by ~1kb instead of reducing but we'd rather keep things deduped as that was the intention * ui: Redesign - Exposed Paths (#7912) * Add new exposed paths icons to codebase * Redesign Exposed Paths and create copy-button hover on Composite Row * Refactor FeedbackDialog and CopyButton * Change this.element to use `{{ref }}` now we don't have an element We changed this to a tagless component with an eye to moving this to a glimmer component, without spotting that this would also remove the `this.element` property. This adds an equivalent using the ref modifier. Co-authored-by: John Cowen <jcowen@hashicorp.com> * ui: Remove box-shadow and pointer cursor from metada list hover effect (#7914) Co-authored-by: Kenia <19161242+kaxcode@users.noreply.github.com>	5 years ago
John Cowen	2f7c4cbf86	ui: Quote service names when filtering for intentions (#7888) ... * ui: Quote service names for intention filtering * ui: return null if we ever get an error with anything else	5 years ago
Kenia	6367160c93	ui: Create Upstreams tab for Ingress Gateways (#7865)	5 years ago
Kenia	2adfb42bde	ui: Create Linked Services Tab for Terminating Gateways (#7858) ... * Fix to bottom border not applying to the correct <li> * Create Linked Services tab with styling and tests * Add internal endpoint gateway-services-nodes to the codebase with tests * Upgrade consul-api-double to version 2.15.0	5 years ago
John Cowen	b608ceb815	ui: Test Improvements (#7854) ... * ui: Combine all "see/don't see" steps into one step * Fix up broken tests * Add some test meta data/titles * Test out proxies in the service listing * Remove comments	5 years ago
John Cowen	f469da640e	ui: Renames CopyButtonFeedback to CopyButton and use it everywhere (#7834) ... * ui: Renames CopyButtonFeedback to CopyButton and use it everywhere * Uncapitalize output * Remove the ability to set the contents via an attr, and.. ..change the attribute for the string that gets copied to be called 'value' so it feels like HTML	5 years ago
Kenia	e2ef864b1e	ui: Add and use ProxyFor to get the `connected with proxy` boolean (#7820) ... * Add and use ProxyFor to get the `connected with proxy` boolean * Fix up page-navigation test * Upgrade to @hashicorp/consul-api-double@2.14.7	5 years ago
John Cowen	c4c06c2dab	ui: refactor out the taglist component to use a recursive pattern (#7837) ... * ui: refactor out the taglist component to use a recursive pattern * Make sure simple rendering tests pass	5 years ago
John Cowen	f3adeec093	ui: Remove debugging pause from our acceptance tests (#7852)	5 years ago
John Cowen	f21b17a1f2	UI: Improved Login/Logout flow inc SSO support (#7790) ... * 6 new components for new login/logout flow, plus SSO support UI Components: 1. AuthDialog: Wraps/orchestrates AuthForm and AuthProfile 2. AuthForm: Authorization form shown when logged out. 3. AuthProfile: Simple presentational component to show the users 'Profile' 4. OidcSelect: A 'select' component for selecting an OIDC provider, dynamically uses either a single select menu or multiple buttons depending on the amount of providers Data Components: 1. JwtSource: Given an OIDC provider URL this component will request a token from the provider and fire an donchange event when it has been retrieved. Used by TokenSource. 2. TokenSource: Given a oidc provider name or a Consul SecretID, TokenSource will use whichever method/API requests required to retrieve Consul ACL Token, which is emitted to the onchange event handler. Very basic README documentation included here, which is likely to be refined somewhat. * CSS required for new auth/SSO UI components * Remaining app code required to tie the new auth/SSO work together * CSS code required to help tie the auth/SSO work together * Test code in order to get current tests passing with new auth/SSO flow ..plus extremely basics/skipped rendering tests for the new components * Treat the secret received from the server as the truth Previously we've always treated what the user typed as the truth, this breaks down when using SSO as the user doesn't type anything to retrieve a token. Therefore we change this so that we use the secret in the API response as the truth. * Make sure removing an dom tree from a buffer only removes its own tree	5 years ago
Kenia	b2ecc65d21	ui: Create PopoverSelect, CatalogToolbar, and update tests (#7489) ... * Create PopoverSelect component and styling * Create CatalogToolbar component and Styling * ui: Adds `selectable-key-values` helper (#7472) Preferably we want all copy/text to live in the template. Whilst you can achieve what we've done here with a combination of different helpers, as we will be using this approach in various places it's probably best to make a helper. We also hit an ember bug related to using the `let` helper and trying to access `thingThatWasLet.firstObject` (which can also be worked around using `object-at`). Moving everything to a helper 'sorted' everything. Probably worthwhile noting that if the sort option themselves become dynamic, I'm not sure if the helper here would actually react as you would expect (I'm aware that ember helpers on react on the root arguments, not necesarily sub properties of those arguments). If we get to that point this helper could take the same approach as what I believe ember-composable-helpers does to get around this, or move them to the view controller. If we do ever moved this to the view controller, we can still use the exported function from the new helper here to keep using the same functionality and tests we have here. * Create tests for sorting services with CatalogToolbar * Add rule to print 'ember/no-global-jquery' as a warning Co-authored-by: John Cowen <johncowen@users.noreply.github.com>	5 years ago
Kenia	4b2ff91b45	ui: Redesign - Instance Detail Proxy Info tab (#7745) ... * Fix clickFirstAnchor bug * Create Proxy Info Tab for Instance Detail Page * Create tests for ProxyInfo and update other scenarios with Proxy data * ui: Refactors our app-view/%app-view component (#7752) Co-authored-by: John Cowen <johncowen@users.noreply.github.com>	5 years ago
Kenia	abc43b6a0f	ui: Redesign - Gateway Instances List page (#7796) ... * Hide Nav in Instances page for Gateway services * Fix up tests to have mocked Services with no Kind attribute * Upgrade consul-api-double to 2.14.4	5 years ago
John Cowen	135d22586b	ui: Tab Improvements (animations/branding) (#7772) ... * ui: Adds a tab selection animation to our app tabs 1. Replace all mentions of `magenta` with a themeable CSS property. 2. Add an easy way to inline style DOM nodes 3. Use CSS properties to add tab animation * Fix up rendering test * Avoid DOM noodling as much as possible	5 years ago
Kenia	12e2c93e6b	ui: Redesign - Service List page with Gateways (#7781) ... * Return all services except Proxies * Add Gateway icon to the codebase * Create and implement ConsulExternalSource component * Fix tests to work with new mock data and add a Gateway test * Update consul-api-double to 2.14.3	5 years ago
John Cowen	6d7a95f82d	ui: Model Layer for SSO Support (#7771) ... * ui: Adds model layer required for SSO 1. oidc-provider ember-data triplet plus repo, plus addition of torii addon 2. Make blocking queries support a Cache-Control: no-cache header 3. Tweaks to the token model layer in preparation for SSO work * Fix up meta related Cache-Control tests * Add tests adapter tests for URL shapes * Reset Cache-Control to the original value, return something from logout	5 years ago
John Cowen	ed2444c0b5	ui: Metadata cleanup (#7767) ... * Use new ConsulMetadataList for service > instance > metadata tab * Meta Data vs Metadata everywhere (Metadata is correct) * Fix up wording in tests	5 years ago
John Cowen	00b34ee7f6	ui: Add a way to reliably figure out where the UI is running (#7722) ... * ui: Add a way to reliably figure out where the UI is running The main javascript that we use is at </where/the/ui/is>/ui/assets/consul-ui.js This uses this fact to provide and base path 'environment' variable to be used within the app. This is also overwritable via various methods (testing/development) if we ever need to do that. * Remove BASE_API_URL, the logic here isn't exactly correct Right now the API always _has_ to be at http://domain/v1/ i.e. the root of your domain /v1. If the URL of the ui is set differently to http://root.com/somewhere/else/ui/ then the API is still at http://root.com/v1 There is definitely a plan to add this env var back in at some stage so we can potentially allow this to be configured in other ways, but there isn't a need to do it just yet so we don't need to worry about _how_ to do this right now.	5 years ago
John Cowen	3d9a55c28b	ui: Fixup intention notifications and add SyncTime (#7702) ... * ui: Specifically check for error rather than anything but success * ui: Add SyncTime to intentions for reconciliation	5 years ago
John Cowen	7f3b9d04ba	ui: Use DataSources in ACLs area (#7681) ... * ui: Use Datasource for loading related data in ACLs area * ui: Use more manual cleanup for Controller event-sources * Update reconcile to use nspace and add SyncTime to role/policy * Use the correct value for nspace and dc (the one from the item itself) * Remove the // check, we no longer need it. Add some TODO	5 years ago
Kenia	8643565b30	ui: Instance detail redesign (#7683) ... * Remove Proxy link and add ExternalSource to instance detail page header * Create HealthChecks tab with route and styling * Fix up tests to fit redesign of Service Instances Detail page	5 years ago
John Cowen	2685c5081b	ui: Improved main navigation (#7673) ... * Make datacenter queries use query vs findAll like the rest of the app * Make sure we have an element to pass to isInViewport * Make sure href-mut doesn't error even if the currentRoute === null * More post test cleanup and Safari fix (safari requires http:// URLs) * Reverse order of datasource nspace/dc's and add a namespace source * Rearrange routes/templates/controllers to only use HashicorpConsul once * Add datasources and correct token namespace detection/redirection * Remove old dc findAll adapter method * Add more comments around the 'child route/parent controller' vars	5 years ago
Kenia	51db157fab	ui: Redesign - Service Detail Page (#7655) ... * Create ConsulServiceInstanceList with styling and test * Implement ConsulServiceInstanceList to Service Detail page * Implement ConsulExternalSource to Services Show page header * Update services/show page object * Update the styling of CompositeRow * Refactor ConsulServiceList component and styling * Update ConsulExternalSource to say 'Registered via...' * Upgrade consul-api-double to patch 2.14.1 * Fix up tests to not use Kind in service models * Update ListCollection with clickFirstAnchor action * Add $typo-size-450 to typography base variables	5 years ago
John Cowen	8e9fca9be6	ui: Per Service Intentions Tab (#7615) ... * Add model layer support for filtering intentions by service * Add Route, Controller and template for services.show.intentions tab We are still loading the intentions themselves in the parent Route for the moment * Load the intentions in in the parent route for the moment * Temporarily add support for returning to history -1 Once we have an intention form underneath the service/intention tab this will no longer be needed * Add the new tab and enable blocking queries for it * Add some further acceptance testing around intention listings	5 years ago
Kenia	288316432b	ui: Redesign - Create ConsulExternalSource (#7632) ... * Create ConsulExternalSource with test and styling * Implement ConsulExternalSource to Service list page * Update icons for redesign * Refactor ListCollection and CompositeRow styling	5 years ago
Kenia	f39671d568	ui: Redesign Service List page (#7605) ... * Create GridCollection for nodes page with styling * Update ListCollection styling * Update TagList styling * Create CompositeRow styling component * Update ConsulServiceList component with styling * Create service health-checks helper * Add InstanceCount to the service model * Add tag-svg to codebase * Create and update tests for service-list page * Upgrade @hashicorp/consul-api-double to 2.14.0	5 years ago
John Cowen	4bf1daef0a	ui: Logout button (#7604) ... * ui: Logout button This commit adds an easier way to logout of the UI using a logout button Notes: - Added a Logout button to the main navigation when you are logged in, meaning you have easy access to a way to log out of the UI. - Changed all wording to use 'Log in/out' vocabulary instad of 'stop using'. - The logout button opens a panel to show you your current ACL token and a logout button in order to logout. - When using legacy ACLs we don't show the current ACL token as legacy ACLs tokens only have secret values, whereas the new ACLs use a non-secret ID plus a secret ID (that we don't show). - We also added a new `<EmptyState />` component to use for all our empty states. We currently only use this for the ACLs disabled screen to provide more outgoing links to more readind material/documentation to help you to understand and enable ACLs. - The `<DataSink />` component is the sibling to our `<DataSource />` component and whilst is much simpler (as it doesn't require polling support), its tries to use the same code patterns for consistencies sake. - We had a fun problem with ember-data's `store.unloadAll` here, and in the end went with `store.init` to empty the ember-data store instead due to timing issues. - We've tried to use already existing patterns in the Consul UI here such as our preexisting `feedback` service, although these are likely to change in the future. The thinking here is to add this feature with as little change as possible. Overall this is a precursor to a much larger piece of work centered on auth in the UI. We figured this was a feature complete piece of work as it is and thought it was worthwhile to PR as a feature on its own, which also means the larger piece of work will be a smaller scoped PR also.	5 years ago
John Cowen	32a619ae99	ui: Add tab navigation to the browser history/URLs (#7592) ... * ui: Add tab navigation to the browser history/URLs This commit changes all our tabbed UI interfaces in the catalog to use actual URL changes rather than only updating the content in the page using CSS. Originally we had decided not to add tab clicks into the browser history for a variety of reasons. As the UI has progressed these tabs are a fairly common pattern we are using and as the UI grows and stabilizes around certain UX patterns we've decided to make these tabs 'URL changing'. Pros: - Deeplinking - Potentially smaller Route files with a more concentrated scope of the contents of a tab rather than the entire page. - Tab clicks now go into your history meaning backwards and forwards buttons take you through the tabs not just the pages. - The majority of our partials are now fully fledged templates (Octane 🎉) Cons: - Tab clicks now go into your history meaning backwards and forwards buttons take you through the tabs not just the pages. (Could be good and bad from a UX perspective) - Many more Route and Controller files (yet as mentioned above each of these have a more reduced scope) - Moving around the contents of these tabs, or changing the visual names of them means updates to the URL structure, which then should potentially entail redirects, therefore what things that seem like straightforwards design reorganizations are now a little more impactful. It was getting to the point that the Pros outweight the Cons Apart from moving some files around we made a few more tiny tweaks to get this all working: - Our freetext-filter component now performs the initial search rather than this happening in the Controller (remove of the search method in the Controllers and the new didInsertElement hook in the component) - All of the <TabNav>'s were changed to use its alternative href approach. - <TabPanel>s usage was mostly removed. This is th thing I dislike the most. I think this needs removing, but I'd also like to remove the HTML it creates. You'll see that every new page is wrappe din the HTML for the old <TabPanel>, this is to continue to use the same HTML structure and id's as before to avoid making further changes to any CSS that might use this and being able to target things during testing. We could have also removed these here, but it would have meant a much larger changeset and can just as easily be done at a later date. - We made a new `tabgroup` page-object component, which is almost identical to the previous `radiogroup` one and injected that instead where needed during testing. * Make sure we pick up indexed routes when nspaces are enabled * Move session invalidation to the child (session) route * Revert back to not using didInsertElement for updating the searching This adds a way for the searchable to remember the last search result instead, which changes less and stick to the previous method of searching.	5 years ago
John Cowen	80960c9d54	ui: Add `<State /> and `{{state-matches}}` ember component/helper (#7556) ... This commit adds 2 ember component/helpers and a service to contain the shared functionality for matching/rendering content dependent on state identifiers. Currently a `service.state` method has been added to easily make manual state objects, but these are built towards using `xstate` to manage UI state in some of our future components. We've added some tests here, and we aren't currently using these components anywhere in this commit.	5 years ago
John Cowen	2413244b77	ui: Add DataSource component (#7448) ... * ui: Add data-source component and related services (#6486) * ui: Add data-source component and related services: 1. DataSource component 2. Repository manager for retrieving repositories based on URIs 3. Blocking data service for injection to the data-source component to support blocking query types of data sources 4. 'Once' promise based data service for injection for potential fallback to old style promise based data (would need to be injected via an initial runtime variable) 5. Several utility functions taken from elsewhere - maybeCall - a replication of code from elsewhere for condition calling a function based on the result of a promise - restartWhenAvailable - used for restarting blocking queries when a tab is brought to the front - ifNotBlocking - to check if blocking is NOT enabled * Move to a different organization based on protocols * Don't call open twice when eager * Workaround new ember error for reading and writing at the same time * Add first draft of a README.mdx file	5 years ago
John Cowen	5e98ef3f51	ui: Add Ref component (#7442) ... * ui: Add Ref component	5 years ago
John Cowen	8986b6ad7b	ui: Move to new ember nested file structure for components (#7403) ... * ui: Move components to the new nested structure * Move data-test attribute to the correct HTML element We don't currently rely on this, but was incorrectly placed on the input rather than the label tag * Fix up left over curly bracket components that were causing issues For some reason the combination of: 1. Old style curly bracket components 2. data-test-* attributes 3. Moving to the new component file structure Meant that our data-test-* selectors where no longer being rendered. Whilst this had no effect on the app, it meant our tests suite could no longer select DOM elements in order to assert various things. Moving the old style curly bracket components to the new style XML/Angle bracket format fixes the issue * Update ui-v2/app/templates/dc/nodes/-services.hbs Co-Authored-By: Greg Hoin <1416421+gregone@users.noreply.github.com> * Update ui-v2/app/templates/dc/nodes/-services.hbs Co-Authored-By: Greg Hoin <1416421+gregone@users.noreply.github.com> Co-authored-by: Greg Hoin <1416421+gregone@users.noreply.github.com>	5 years ago
Kenia	f0ce300204	ui: Delete the Promise rsvp imports from codebase (#7372)	5 years ago
John Cowen	2f28232df0	ui: Upgrade to ember 3.16 Octane Edition (#7334) ... * v3.12.0...v3.16.0 * Upgrades * Remove old wormhole fix * Fixup ember power select (camelcasing) * Fixup immedaitely closing dropdown When clicking on the syntax selector, it seemed like an extra click event was firing from the label, which then immediately closed the dropdown. By adding a for="" attribute this event isn't passed to the dropdown menu and therefore doesn't immediately close * Fix up integration tests with new style (plus standardize titles) * Temporarily disable some template linting rules * Add required methods (even though they aren't used anywhere) * Ensure event sources get closed on destruction	5 years ago
Kenia	191496e4a5	ui: Create a helper to show the last 8 characters of token Accessor ID (#7327) ... * Create substr helper * Create a test for the new substr helper * Display the last 8 characters of token Accessor ID in the Token lists page	5 years ago
John Cowen	aea3d00a9d	ui: Move to angle brackets for ember components (#7321) ... * Modify templates with codemods angle brackets * ui: Fix up problem with intention filter action attribute Co-authored-by: Kenia <19161242+kaxcode@users.noreply.github.com>	5 years ago
John Cowen	f306c753e2	ui: HTTP Body testing (#7290) ... * ui: Test Coverage Reporting (#7027) * Serve up the /coverage folder whilst developing * Upgrade ember-cli-api-double now it supports passthrough per url * ui: make env into a service and use it where we need to be injectable * Give http/client a body method so we can use it on its own for testing * Add test helper for testing with and without nspaces enabled * Add two tests, one thay needs nspaces and one that doesn't * Keep cleaning up client/http, whilst figuring out a immutable bug * Convert tests to new return format ([actual, leftovers])	5 years ago
John Cowen	f9bd3a0b93	ui: Use a service-proxy to test service removal notification (#7315)	5 years ago
John Cowen	e9ed49d9aa	ui: Test coverage developer experience (#7275) ... * ui: Add getSplitters unit test and additional getResolvers test * Make ordering of makefile target consistent	5 years ago
John Cowen	771973a713	ui: Add consul-service-list presentational component (#7279) ... This commit moves our service list into a new presentational component, and is therefore mainly just moving things around. The main thing moved here is the logic required to resizing columns correctly is now moved to a component instead of the controller	5 years ago
John Cowen	b6915793d0	ui: Remove custom css-vars 'polyfill' and use native CSS props (#7249) ... * ui: Remove custom css-vars 'polyfill' and use native CSS props Previously we used a sort of polyfill for certain places where we needed CSS property-like behavior. This meant duplicating code between JS and CSS, specifically some of our SVG icons. We moved to CSS props only in the places where they are beneficial and populated the variables with our already existing SASS variables. This means we no longer have to duplicate CSS and we can remove our custom css-var helper/polyfill.	5 years ago
Alvin Huang	48a52e07da	fix ember parallelization (#7221)	5 years ago
John Cowen	79156324bf	ui: Test Coverage Reporting (#7027) ... * Serve up the /coverage folder whilst developing * Upgrade ember-cli-api-double now it supports passthrough per url	5 years ago
John Cowen	604de8758b	ui: Fix using 'ui-like' KVs when using an empty default nspace (#7734) ... When using namespaces, the 'default' namespace is a little special in that we wanted the option for all our URLs to stay the same when using namespaces if you are using the default namespace, with the option of also being able to explicitly specify `~default` as a namespace. In other words both `ui/services/service-name` and `ui/~default/services/service-name` show the same thing. This means that if you switch between OSS and Enterprise, all of your URLs stay the same, but you can still specifically link to the default namespace itself. Our routing configuration is duplicated in order to achieve this: ``` - :dc - :service - :kv - :edit - :nspace - :dc - :service - :kv - :edit ``` Secondly, ember routing resolves/matches routes in the order that you specify them, unless, its seems, when using wildcard routes, like we do in the KV area. When not using the wildcard routes the above routing configuration resolves/matches a `/dc-1/kv/service` to the `dc.kv.edit` route correctly (dc:dc-1, kv:services), that route having been configured in a higher priority than the nspace routes. However when configured with wildcards (required in the KV area), note the asterisk below: ``` - :dc :service - :kv - *edit - :nspace - :dc - :service - :kv - *edit ``` Given something like `/dc-1/kv/services` the router instead matches the `nspace.dc.service` (nspace:dc-1, dc:kv, service:services) route first even though the `dc.kv.edit` route should still match first. Changing the `dc.kv.edit` route back to use a non-wildcard route (:edit instead of *edit), returns the router to match the routes in the correct order. In order to work around this, we catch any incorrectly matched routes (those being directed to the nspace Route but not having a `~` character in the nspace parameter), and then recalculate the correct route name and parameters. Lastly we use this recalculated route to direct the user/app to the correct route. This route recalcation requires walking up the route to gather up all of the required route parameters, and although this feels like something that could already exist in ember, it doesn't seem to. We had already done a lot of this work a while ago when implementing our `href-mut` helper. This commit therefore repurposes that work slighlty and externalizes it outside of the helper itself into a more usable util so we can import it where we need it. Tests have been added before refactoring it down to make the code easier to follow.	5 years ago
John Cowen	31b9b90bc3	ui: Ensure blocking query configuration is passed through to findInstanceBySlug (#7543) ... * ui: Ensure configuration is passed through to findInstanceBySlug Due to the addition of namespace support, this arguments passed to this method have been increased. Whilst the nspace support continues ot work here, the configuration for blocking queries is never passed through. This results in a 2 second poll rather than a blocking query. This commit fixes that * ui: Add a basic test to check the number of arguments passed through	5 years ago