consul

Commit Graph

Author	SHA1	Message	Date
John Cowen	9c0233cf59	Revert "ui: Add partition parameter when clearing child-selector forms in ACLs" This reverts commit `a670bde57d`.	3 years ago
John Cowen	a670bde57d	ui: Add partition parameter when clearing child-selector forms in ACLs	3 years ago
John Cowen	cfbd1bb84e	ui: [BUGFIX] Re-enable namespace menus whilst editing intentions (#11095 ) This PR supersedes #10706 and fixes #10686 whilst making sure that saving intentions continues to work. The original fix in #10706 ignored the change action configured for the change event on the menus, meaning that the selected source/destination namespace could not be set by the user when editing/creating intentions. This, coupled with the fact that using the later intention exact endpoint for API requests endpoint means that you could not use wildcard namespaces for saving intentions. All in all this meant that intentions could no longer be saved using the UI (whilst using ENT) This PR reverts #10706 to fix the intention saving issue, and adds a fix for the original visual issue of nspaces doubling up in the menu once clicked. This meant repeating the existing functionality for nspaces aswell as services. It did seem strange to me that the original issue was only apparent for the nspace menus and not the service menus which should all function exactly the same way. There is potentially more to come here partly related to what the exact functionality should be, but I'm working with other folks to figure out what the best way forwards is longer term. In the meantime this brings us back to the original functionality with the visual issue fixed. Squashed commits: * Revert "ui: Fix dropdown option duplications (#10706)" This reverts commit `eb5512fb74`. * ui: Ensure additional nspaces are added to the unique list of nspaces * Add some acceptance tests	3 years ago
John Cowen	1d9d3349ca	ui: Ensure we request permission wiht the correct partition (#11060 )	3 years ago
John Cowen	fc14a412fd	ui: Partitions Application Layer (#11017 ) * Add Partition to all our models * Add partitions into our serializers/fingerprinting * Make some amends to a few adapters ready for partitions * Amend blueprints to avoid linting error * Update all our repositories to include partitions, also Remove enabled/disable nspace repo and just use a nspace with conditionals * Ensure nspace and parition parameters always return '' no matter what * Ensure data-sink finds the model properly This will later be replaced by a @dataSink decorator but we are find kicking that can down the road a little more * Add all the new partition data layer * Add a way to set the title of the page from inside the route and make it accessibile via a route announcer * Make the Consul Route the default/basic one * Tweak nspace and partition abilities not to check the length * Thread partition through all the components that need it * Some ACL tweaks * Move the entire app to use partitions * Delete all the tests we no longer need * Update some Unit tests to use partition * Fix up KV title tests * Fix up a few more acceptance tests * Fixup and temporarily ignore some acceptance tests * Stop using ember-cli-page-objects fillable as it doesn't seem to work * Fix lint error * Remove old ACL related test * Add a tick after filling out forms * Fix token warning modal * Found some more places where we need a partition var * Fixup some more acceptance tests * Tokens still needs a repo service for CRUD * Remove acceptance tests we no longer need * Fixup and "FIXME ignore" a few tests * Remove an s * Disable blocking queries for KV to revert to previous release for now * Fixup adapter tests to follow async/function resolving interface * Fixup all the serializer integration tests * Fixup service/repo integration tests * Fixup deleting acceptance test * Fixup some ent tests * Make sure nspaces passes the dc through for when thats important * ...aaaand acceptance nspaces with the extra dc param	3 years ago
John Cowen	b16a6fa033	ui: Adds Partitions to the HTTP layer (#10447 ) This PR mainly adds partition to our HTTP adapter. Additionally and perhaps most importantly, we've also taken the opportunity to move our 'conditional namespaces' deeper into the app. The reason for doing this was, we like that namespaces should be thought of as required instead of conditional, 'special' things and would like the same thinking to be applied to partitions. Now, instead of using code throughout the app throughout the adapters to add/remove namespaces or partitions depending on whether they are enabled or not. As a UI engineer you just pretend that namespaces and partitions are always enabled, and we remove them for you deeper in the app, out of the way of you forgetting to treat these properties as a special case. Notes: Added a PartitionAbility while we were there (not used as yet) Started to remove the CONSTANT variables we had just for property names. I prefer that our adapters are as readable and straightforwards as possible, it just looks like HTTP. We'll probably remove our formatDatacenter method we use also at some point, it was mainly too make it look the same as our previous formatNspace, but now we don't have that, it instead now looks different! We enable parsing of partition in the UIs URL, but this is feature flagged so still does nothing just yet. All of the test changes were related to the fact that we were treating client.url as a function rather than a method, and now that we reference this in client.url (etc) it needs binding to client.	3 years ago
Kenia	eeeb91beaa	ui: Hide all metrics for ingress gateway services (#10858 )	3 years ago
Kenia	a907e1d879	ui: Add support in Topology view for Routing Configurations (#10872 )	3 years ago
John Cowen	a0b0ed2bca	ui: [BUGFIX] Add missing `@` to fix missing non-subset Failovers (#10913 ) This commit fixes a problem where parent Failovers where not showing (subset children were fine). Seems to have been introduced with a move/glimmer upgrade here #9154 so I'm adding a 1.9.x backport.	3 years ago
Kenia	a777b0a9ba	ui: Disabling policy form fields from users with 'read' permissions (#10902 )	3 years ago
John Cowen	8192dde485	ui: Unskip auth-method serializer test (#10878 ) During #9617 we added a list view only for AuthMethods, but not a detail view. We did add the Adapter/Serializer that collected/reshaped data for a detail view. The test for this serializer was skipped here, but I'm not sure why. We then added #9845 which began to use this AuthMethod Serializer, but we didn't go back to finish up the skipped test here either. This PR unskips this test and finishes off the test correctly.	3 years ago
John Cowen	05a28c3111	ui: [BUGFIX] Properly encode non-URL safe characters in OIDC responses (#10901 ) This commit fixes 2 problems with our OIDC flow in the UI, the first is straightforwards, the second is relatively more in depth: 1: A typo (1.10.1 only) During #10503 we injected our settings service into the our oidc-provider service, there are some comments in the PR as to the whys and wherefores for this change (https://github.com/hashicorp/consul/pull/10503/files#diff-aa2ffda6d0a966ba631c079fa3a5f60a2a1bdc7eed5b3a98ee7b5b682f1cb4c3R28) Fixing the typo so it was no longer looking for an unknown service (repository/settings > settings) fixed this. 2: URL encoding (1.9.x, 1.10.x) TL;DR: /oidc/authorize/provider/with/slashes/code/with/slashes/status/with/slashes should be /oidc/authorize/provider%2Fwith%2Fslashes/code%2Fwith%2Fslashes/status%2Fwith%2Fslashes When we receive our authorization response back from the OIDC 3rd party, we POST the code and status data from that response back to consul via acallback as part of the OIDC flow. From what I remember back when this feature was originally added, the method is a POST request to avoid folks putting secret-like things into API requests/URLs/query params that are more likely to be visible to the human eye, and POSTing is expected behaviour. Additionally, in the UI we identify all external resources using unique resource identifiers. Our OIDC flow uses these resources and their identifiers to perform the OIDC flow using a declarative state machine. If any information in these identifiers uses non-URL-safe characters then these characters require URL encoding and we added a helper a while back to specifically help us to do this once we started using this for things that required URL encoding. The final fix here make sure that we URL encode code and status before using them with one of our unique resource identifiers, just like we do with the majority of other places where we use these identifiers.	3 years ago
Kenia	ae9c313382	ui: Update intention permissions notice wording (#10836 )	3 years ago
Kenia	019ce785ab	ui: Create Routing Configurations route and page (#10835 )	3 years ago
Kenia	ab6a675209	ui: Split up the socket mode from the socket path (#10581 )	3 years ago
Kenia	bcd53e73a2	ui: Add Vault as a Service External Source (#10769 )	3 years ago
Kenia	8ad1ab9c08	ui: Fix Health Checks in K/V form Lock Sessions Info section (#10767 )	3 years ago
Kenia	2ee501be8d	ui: Add copy button for Secret ID in Tokens list page (#10735 )	3 years ago
Kenia	eb5512fb74	ui: Fix dropdown option duplications (#10706 )	3 years ago
Kenia	1eb7a83eec	ui: Add tests for topology metrics stats (#10600 )	3 years ago
John Cowen	0762da3a62	ui: [BUGFIX] Ensure we use the ns query param name when requesting permissions (#10608 ) Previously when namespaces were enabled, we weren't requesting permission for the actively selected namespace, and instead always checking the permissions for the default namespace. This commit ensures we request permissions for the actively selected namespace.	3 years ago
John Cowen	3e80e637ba	ui: [BUGFIX] Fix KV Code Editor syntax loading (#10605 ) This commit adds a bit of string wrangling to avoid the keys in our javascript source file also being transformed. Additionally, whilst looking at this we decided that Maps are a better dictionary than javascript objects, so we moved to use those here also (but this doesn't affect the issue)	3 years ago
John Cowen	54f0cd812a	ui: Show the correct 'ACLs Disabled' page when ACLs are disabled (#10604 ) Adds 'can access ACLs' which means one of two things 1. When ACLs are disabled I can access the 'please enable ACLs' page 2. When ACLs are enabled, its the same as canRead	3 years ago
John Cowen	b256313256	ui: [BUGFIX] Ensure in-folder KVs are created in the correct folder (#10569 ) When clicking to create a KV within folder name, would would be viewing a form that was a form for creating a KV in the root, which when the user clicked to save, saved the KV in the root. For the moment at least I've removed the code that strips double slashes, and whilst this isn't ideal, it looks like we've picked up one of those bugs that turns into a 'feature', and completely reworking KV to not rely on the double slashes is not really an option right now.	3 years ago
Kenia	a96e87aece	ui: Add socket icon for UDS (#10573 )	3 years ago
John Cowen	6fbeea5def	ui: Don't default to the default namespace, use the token default namespace instead (#10503 ) The default namespace, and the tokens default namespace (or its origin namespace) is slightly more complicated than other things we deal with in the UI, there's plenty of info/docs on this that I've added in this PR. Previously: When a namespace was not specified in the URL, we used to default to the default namespace. When you logged in using a token we automatically forward you the namespace URL that your token originates from, so you are then using the namespace for your token by default. You can of course then edit the URL to remove the namespace portion, or perhaps revisit the UI at the root path with you token already set. In these latter cases we would show you information from the default namespace. So if you had no namespace segment/portion in the URL, we would assume default, perform actions against the default namespace and highlight the default namespace in the namespace selector menu. If you wanted to perform actions in your tokens origin namespace you would have to manually select it from the namespace selector menu. This PR: Now, when you have no namespace segment/portion in the URL, we use the token's origin namespace instead (and if you don't have a token, we then use the default namespace like it was previously) Notes/thoughts: I originally thought we were showing an incorrectly selected namespace in the namespace selector, but it also matched up with what we were doing with the API, so it was in fact correct. The issue was more that we weren't selecting the origin namespace of the token for the user when a namespace segment was omitted from the URL. Seeing as we automatically forward you to the tokens origin namespace when you log in, and we were correctly showing the namespace we were acting on when you had no namespace segment in the URL (in the previous case default), I'm not entirely sure how much of an issue this actually was. This characteristic of namespace+token+namespace is a little weird and its easy to miss a subtlety or two so I tried to add some documentation in here for future me/someone else (including some in depth code comment around one of the API endpoints where this is very subtle and very hard to miss). I'm not the greatest at words, so would be great to get some edits there if it doesn't seem clear to folks. The fact that we used to save your previous datacenter and namespace into local storage for reasons also meant the interaction here was slightly more complicated than it needed to be, so whilst we were here we rejigged things slightly to satisfy said reasons still but not use local storage (we try and grab the info from higher up). A lot of the related code here is from before we had our Routlets which I think could probably make all of this a lot less complicated, but I didn't want to do a wholesale replacement in this PR, we can save that for a separate PR on its own at some point.	3 years ago
John Cowen	74070c0955	ui: Add intl debug helpers (#10513 ) This commit adds a couple of debug utilities to help us to continue slowly adding i18n support: - We've added a CONSUL_INTL_DEBUG env/cookie variable to turn off variable interpolation within the t helper so you can see which variables are being interpolated. - We've added a CONSUL_INTL_LOCALE env/cookie which currently supports two 'pseudo-locales' - la-fk (fake latin) and - (just dashes) either of which will make it easier to see what has not been localized until we can add prettier rules to prevent adding any copy into templates at all. I would guess if we ever translated the app we would use this for looking at things whilst developing also - but as yet I've not adding anything for that here seeing as we don't translate anything. Both variables are dev-time only and all code for this is removed from the production build.	3 years ago
John Cowen	b0d69efcc1	ui: Allow disabling of sourcemaps via env var (#10491 )	3 years ago
John Cowen	e541a43b37	ui: Fixup definition-table + copy-button margin (#10512 )	3 years ago
John Cowen	a6996b6ea5	ui: CopyButton amends (#10511 ) * ui: Add with-copyable modifier * Use with-copyable modifier for our own CopyButton * Move copy-button styling and remove most of `copy-btn`	3 years ago
Daniel Nephin	3a045cca8d	ca: remove unused RotationPeriod field This field was never used. Since it is persisted as part of a map[string]interface{} it is pretty easy to remove it.	3 years ago
Jared Kirschner	bd536151e1	Replace use of 'sane' where appropriate HashiCorp voice, style, and language guidelines recommend avoiding ableist language unless its reference to ability is accurate in a particular use.	3 years ago
John Cowen	ace794d214	ui: Enable specifying additional docfy config as json (#10464 )	3 years ago
John Cowen	c78f7ecb27	ui: Colocate remaining CSS components to the app/components folder (#10328 )	3 years ago
John Cowen	043f631b7f	ui: Rename icons for consistency and remove unused icons (#10311 ) * ui: Standardize logo naming According to structure it should always be logo-name not name-logo * Make sure all our logos use logo-name format * Upgrade to @hashicorp/structure-icons 1.9.0 * Add `-color` to be consistent with other logos * Add ms logo back in * Remove all the old `-color` icons from before when we got masks Add missing files * Missed glimmer extend name change	3 years ago
John Cowen	4bddd52103	ui: Increase z-index of main menus to avoid layering issues (#10428 )	3 years ago
John Cowen	9eab715149	ui: Move all our icons to use CSS custom properties instead of SASS vars (#10298 ) * ui: Move all our icons to use CSS custom properties The good thing about SASS vars is, if you don't use them they get removed from the final build. Whereas with CSS we have no tree-shaking to get rid of unused CSS custom properties. We can mostly work around this and for some things like colors its no big deal if we have some hex-codes in the build that we don't use as hex-codes are relatively small. We've been slowly but surely moving all of our colors (and other things) to use CSS custom properties instead of SASS vars now that we have them available. This commit makes use of the 'tree-shaking' abilities of @extend to ensure that we only compile in the icons that we use. This commit is mostly churn-less as we already use @extend for the majority of our icons, so generally there is zero change here for working on the UI, but I did spot one single place where we were using SASS vars instead of @extend. This now uses the new form (second commit) Interestingly this reduces our CSS payload by ~2kb to ~53kb (around 25kb of that is these icons)	3 years ago
John Cowen	ac424187fe	ui: %horizontal-kv-list CSS component (and related) (#10285 ) This commit uses docfy to isolate the individual parts and options and investigates the why you might use certain options and document how you might use certain options. Originally we used a single %icon-definition CSS component to represent this, but seeing as some of them don't have icons, it didn't seem like the best name. So this PR splits this component into various different ones and then uses the new ones to continue to provide a now deprecated %icon-definition. The component is currently a CSS only component that assumes a single (or multiple) description lists for its markup component, and provides for multiple different options (including a reversed mode which I'm still not totally sure about, but we don't use this right now anyway). - %icon-definition - %horizontal-kv-list - %csv-list - %tag-list - %badge	3 years ago
John Cowen	18190fb071	ui: Move intention description field (#10292 ) ...from under the permissions widget to over the permissions widget	4 years ago
John Cowen	ddee7afbb9	ui: Fixup prettier for scss files and run (#10296 ) * ui: Ensure prettier makes all our scss files pretty * Run prettier on all our scss files	4 years ago
John Cowen	af72b9e9ab	ui: Unix Domain Socket support (#10287 ) This commit adds UI support for Unix Domain Sockets for upstream and downstreams (see #9981 and #10252)	4 years ago
John Cowen	2e4c9f5330	ui: Support Route optional parameters/segments (#10212 ) Moves our URLs with 'optional namespace segment' into a separately abstracted 'optional URL segment' feature	4 years ago
John Cowen	e11454cf71	ui: Colocate old base components into our app/component folder (#10275 )	4 years ago
John Cowen	a73b38a368	ui: Minor CSS tweaks (#10295 )	4 years ago
Kenia	f3efde3843	ui: Create and use collapsible notices component (#10270 ) * Create and use collapsible notices * Refactor collapsible-notices * Split up the topology acceptance tests * Add acceptance tests for tproxy notices * Add component file * Adds additional TProxy notices tests * Adds conditional to only show collapsable if more than 2 notices are present * Adds changelog * Refactorting the conditonal for collapsing the notices * Renaming undefinedIntention to be notDefinedIntention * Refactor tests	4 years ago
John Cowen	600f857531	ui: Add docs for AppView (#10265 ) * ui: change coloring of secondary navigation elements * Remove top border, this was probably from older designs/iterations * ui: Move app-view styles into components also... 1. Remove dead %app-view-content-error 2. Remove TabNav border overwriting * Bring into line with our 'project standard' class/attributes pattern * Add docs for AppView	4 years ago
John Cowen	dd4a66808d	ui: change coloring of secondary navigation elements (#10259 )	4 years ago
John Cowen	4e420df7ae	ui: Adds QUnit toggle bookmarklet to our docs (#10269 )	4 years ago
John Cowen	39302041e9	ui: Miscellaneous Lock Session fixes (#10225 )	4 years ago
John Cowen	8301e79c56	ui: Bump node to v14 (#10238 )	4 years ago

1 2 3 4 5

250 Commits (d2274df53faeb6a40ae020d8f0fc0a0c866a66d2)