consul

Commit Graph

Author	SHA1	Message	Date
Daniel Nephin	dccd3f5806	Merge remote-tracking branch 'origin/main' into serve-panic-recovery	3 years ago
R.B. Boyer	e20e6348dd	areas: make the gRPC server tracker network area aware (#11748 ) Fixes a bug whereby servers present in multiple network areas would be properly segmented in the Router, but not in the gRPC mirror. This would lead servers in the current datacenter leaving from a network area (possibly during the network area's removal) from deleting their own records that still exist in the standard WAN area. The gRPC client stack uses the gRPC server tracker to execute all RPCs, even those targeting members of the current datacenter (which is unlike the net/rpc stack which has a bypass mechanism). This would manifest as a gRPC method call never opening a socket because it would block forever waiting for the current datacenter's pool of servers to be non-empty.	3 years ago
Daniel Nephin	4185045a7f	sdk/freeport: rename Port to GetOne For better consistency with GetN	3 years ago
Daniel Nephin	e8312d6b5a	testing: remove unnecessary calls to freeport Previously we believe it was necessary for all code that required ports to use freeport to prevent conflicts. https://github.com/dnephin/freeport-test shows that it is actually save to use port 0 (`127.0.0.1:0`) as long as it is passed directly to `net.Listen`, and the listener holds the port for as long as it is needed. This works because freeport explicitly avoids the ephemeral port range, and port 0 always uses that range. As you can see from the test output of https://github.com/dnephin/freeport-test, the two systems never use overlapping ports. This commit converts all uses of freeport that were being passed directly to a net.Listen to use port 0 instead. This allows us to remove a bit of wrapping we had around httptest, in a couple places.	3 years ago
Daniel Nephin	d795a73f78	testing: use the new freeport interfaces	3 years ago
Giulio Micheloni	af7b7b5693	Merge branch 'main' into serve-panic-recovery	3 years ago
Dhia Ayachi	2801785710	regenerate expired certs (#11462 ) * regenerate expired certs * add documentation to generate tests certificates	3 years ago
Giulio Micheloni	a3fb665b88	Restored comment.	3 years ago
Giulio Micheloni	fecce25658	Separete test file and no stack trace in ret error	3 years ago
Giulio Micheloni	0c78ddacde	Merge branch 'main' of https://github.com/hashicorp/consul into hashicorp-main	3 years ago
R.B. Boyer	5b6d96d27d	grpc: ensure that streaming gRPC requests work over mesh gateway based wan federation (#10838 ) Fixes #10796	3 years ago
Giulio Micheloni	7fa01105cc	Fix merge conflicts	3 years ago
Giulio Micheloni	655da1fc42	Merge branch 'main' into serve-panic-recovery	3 years ago
Giulio Micheloni	4b0eaa4bff	grpc, xds: recovery middleware to return and log error in case of panic 1) xds and grpc servers: 1.1) to use recovery middleware with callback that prints stack trace to log 1.2) callback turn the panic into a core.Internal error 2) added unit test for grpc server	3 years ago
Mike Morris	3bae53a989	deps: upgrade gogo-protobuf to v1.3.2 (#10813 ) * deps: upgrade gogo-protobuf to v1.3.2 * go mod tidy using go 1.16 * proto: regen protobufs after upgrading gogo/protobuf Co-authored-by: Daniel Nephin <dnephin@hashicorp.com>	3 years ago
Giulio Micheloni	2b14a9b59a	grpc Server: turn panic into error through middleware	3 years ago
R.B. Boyer	fc9b1a277d	sync changes to oss files made in enterprise (#10670 )	3 years ago
Daniel Nephin	dce59d9277	fix 64-bit aligment for 32-bit platforms sync/atomic must be used with 64-bit aligned fields, and that alignment is difficult to ensure unless the field is the first one in the struct. https://golang.org/pkg/sync/atomic/#pkg-note-BUG.	3 years ago
Daniel Nephin	29e93f6338	grpc: fix a data race by using a static resolver We have seen test flakes caused by 'concurrent map read and map write', and the race detector reports the problem as well (prevent us from running some tests with -race). The root of the problem is the grpc expects resolvers to be registered at init time before any requests are made, but we were using a separate resolver for each test. This commit introduces a resolver registry. The registry is registered as the single resolver for the consul scheme. Each test uses the Authority section of the target (instead of the scheme) to identify the resolver that should be used for the test. The scheme is used for lookup, which is why it can no longer be used as the unique key. This allows us to use a lock around the map of resolvers, preventing the data race.	4 years ago
Paul Banks	44718456b5	Set gRPC keepalives to mirror Yamux keepalive behaviour	4 years ago
Pierre Souchay	e2f2d4b0d7	[Streaming][bugfix] handle TLS signalisation when TLS is disabled on client side Tnis is an alternative to https://github.com/hashicorp/consul/pull/9494	4 years ago
Kit Patella	15af5ead0b	trim help strings to save a few bytes	4 years ago
Kit Patella	3966ecb02f	merge master	4 years ago
Kit Patella	5da2f1efa8	finish adding static server metrics	4 years ago
Kit Patella	06d59c03b9	add the service name in the agent rather than in the definitions themselves	4 years ago
Kit Patella	24a2471029	first pass on agent-configured prometheusDefs and adding defs for every consul metric	4 years ago
Daniel Nephin	1a137c29d6	grpc: fix grpc metrics defaultMetrics was being set at package import time, which meant that it received an instance of the original default. But lib/telemetry.InitTelemetry sets a new global when it is called. This resulted in the metrics being sent nowhere. This commit changes defaultMetrics to be a function, so it will return the global instance when called. Since it is called after InitTelemetry it will return the correct metrics instance.	4 years ago
Daniel Nephin	f0ac093fef	agent/grpc: add connection count metrics Gauge metrics are great for understanding the current state, but can somtimes hide problems if there are many disconnect/reconnects. This commit adds counter metrics for connections and streams to make it easier to see the count of newly created connections and streams.	4 years ago
Daniel Nephin	5319ba02b0	agent/grpc: rename metrics These new names should make it easier to add counter metics with similar prefixes	4 years ago
Daniel Nephin	8bcd5040c7	agent/grpc: Add an integration test for ClientPool with TLS Also deregister the resolver.Builder in tests.	4 years ago
Daniel Nephin	8a785a351c	agent/grpc: pass metrics to constructor Instead of referencing a package var. This does not fix the flaky test, but it seems more correct.	4 years ago
Daniel Nephin	d19657404f	agent/grpc: fix a flaky test by performing more retries Instead of using retry.Run, which appears to have problems in some cases where it does not emit an error message, use a for loop. Increase the number of attempts and remove any sleep, since this operation is not that expensive to do in a tight loop	4 years ago
Daniel Nephin	df405ac978	agent/grpc: remove misleading warnings from test output Handle shutdown properly in tests so that the tests don't warn about using a closed connection.	4 years ago
Daniel Nephin	e101aa8a74	agent/grpc: fix a flake in TestHandler_EmitsStats	4 years ago
Daniel Nephin	19da9c3a9b	agent/grpc: use a separate channel for closing the Accept Closing l.conns can lead to a race and a 'panic: send on closed chan' when a connection is in the middle of being handled when the server is shutting down. Found using '-race -count=800'	4 years ago
Daniel Nephin	d8299670cc	agent/grpc/resolver: namespace the server ID with the DC name So that if two datacenters end up with overlapping serverIDs we don't send requests to the wrong server	4 years ago
Daniel Nephin	af8a617797	grpc: fix data rate in stats handler test	4 years ago
Daniel Nephin	d0256a0c07	subscribe: add a stateless subscribe service for the gRPC server With a Backend that provides access to the necessary dependencies.	4 years ago
Daniel Nephin	f14145e6d9	agent/grpc: always close the conn when dialing fails.	4 years ago
Daniel Nephin	e6ffd987a3	agent/grpc: seed the rand for shuffling servers	4 years ago
Daniel Nephin	2294793357	agent/grpc: use router.Manager to handle the rebalance The router.Manager is already rebalancing servers for other connection pools, so it can call into our resolver to do the same. This change allows us to remove the serf dependency from resolverBuilder, and remove Datacenter from the config. Also revert the change to refreshServerRebalanceTimer	4 years ago
Daniel Nephin	2273673500	grpc: restore integration tests for grpc client conn pool Add a fake rpc Listener	4 years ago
Daniel Nephin	bad4d3ff7c	grpc: redeuce dependencies, unexport, and add godoc Rename GRPCClient to ClientConnPool. This type appears to be more of a conn pool than a client. The clients receive the connections from this pool. Reduce some dependencies by adjusting the interface baoundaries. Remove the need to create a second slice of Servers, just to pick one and throw the rest away. Unexport serverResolver, it is not used outside the package. Use a RWMutex for ServerResolverBuilder, some locking is read-only. Add more godoc.	4 years ago
Daniel Nephin	25f47b46e1	grpc: move client conn pool to grpc package	4 years ago
Daniel Nephin	636f76f6f1	agent/grpc: make TestHandler_EmitsStats predictable Occasionally this test would flake. The flakes were fixed by: 1. Stopping the service and retrying to check on metrics. This way we also include the active_streams going to 0 in the metric calls. 2. Using a reference to the global Metrics. This way when other tests have background goroutines that are still shutting down, they won't emit metrics to the metric instance with the fake Sink. The stats test can patch the local reference to the global, so the existing statHandlers will continue to emit to the global, but the stats test will send all metrics to the replacement.	4 years ago
Daniel Nephin	ee65ee541e	grpc: add Datacenter field to testing service response	4 years ago
Daniel Nephin	fd42804063	grpc: Add a simple test service for testing the gRPC server	4 years ago
Daniel Nephin	2257247095	server: add gRPC server for streaming events Includes a stats handler and stream interceptor for grpc metrics. Co-authored-by: Paul Banks <banks@banksco.de>	4 years ago

48 Commits (cbea3d203c44db86a37920c43015e10e66ecfd97)