3798 Commits (cbe0910dc8b56e2a7ca73b9a992abbc538839958)

 

All Branches   

Search

Author	SHA1	Message	Date
Sean Chittenden	8ac35d84f0	Rename serverCfg to sc for consistency	9 years ago
Sean Chittenden	664ab238fd	Add a quick length check ... Verify that AddServer behaved as expected	9 years ago
Sean Chittenden	4589c36308	Switch the order of ServerDetails.String() ... It's more natrual to have the network first. I think I flipped the order accidentally.	9 years ago
Sean Chittenden	e8a2e56370	Move rebalance log statement from INFO to DEBUG	9 years ago
Sean Chittenden	060dd49a95	Chase the API bump re: refreshServerRebalanceTimer ... If it works in prod, why shouldn't it work in the tests?	9 years ago
Sean Chittenden	3d00208351	Move initialization of the rebalanceTimer to New()	9 years ago
Sean Chittenden	5652c60971	Add a test for ConnPool.PingConsulServer ... Spin up 5x servers, join and ping each server	9 years ago
Sean Chittenden	efc1113406	Expose ServerManager.ResetRebalanceTimer ... Move the rebalance timer from ServerManager.Start's stack to struct ServerManager. This makes it possible to shuffle during tests without actually waiting >120s.	9 years ago
Sean Chittenden	d275cac1a3	Logging improvements ... Comment out noisly loggers for the time being. Improve the final logging statement to be useful and hint what the next active server for the client is going to be.	9 years ago
Sean Chittenden	35ff2eb71a	Standardize the log message based on the package ... This log statement used to belong in the consul package but has since moved to the server manager package.	9 years ago
Sean Chittenden	e327630523	Reduce the error level from Fatal when unit testing	9 years ago
Sean Chittenden	92c2e8e668	Start server rebalance task after init'ing Serf ... Now that there is no longer an event loop driven directly by Serf, start the ServerManager task after Serf has been setup. When testing and adjusting timers and timeouts to unreasonably low values, it's possible to tickle a race condition where Serf's NumNodes() would fail because Serf had not been initialized.	9 years ago
Sean Chittenden	ee95c55d88	Catch up to a few renames	9 years ago
Sean Chittenden	dc291e4027	Use empty string for addr in ServerDetails.String()	9 years ago
Sean Chittenden	970938c2dd	Guard against a nil ServerDetails.Addr ... It's not clear how or why this would ever be nil, but some of the unit tests produce a nil addr. Be defensive.	9 years ago
Sean Chittenden	ca5950a538	Proactively ping server before rotation ... Before shuffling the server list, proactively ping the next server in the list to establish the connection and verify the remote endpoint is healthy.	9 years ago
Sean Chittenden	18270bbd04	Factor out the shuffle server	9 years ago
Sean Chittenden	90d626b5d9	Revise comments re: cycleServer ... Improve the comments to discuss what happens presently. Add a note to consider possibly calling to TestConsulServer proactively.	9 years ago
Sean Chittenden	cf59a860e7	Comment why the interface is needed: cyclic import	9 years ago
Sean Chittenden	3ecd72f3b5	Add a struct key type for server_details	9 years ago
Sean Chittenden	ae32a3ceae	Merge pull request #1873 from hashicorp/f-rebalance-worker-0.7 ... Periodically rebalance the servers that agents talk to	9 years ago
Sean Chittenden	5893bd5a35	Add additional checks	9 years ago
Sean Chittenden	d18e4d7455	Delete the right tag ... "role" != "consul"	9 years ago
Sean Chittenden	b1194e83cb	Don't pass in sm, server manager is already in scope ... Go closures are implicitly capturing lambdas.	9 years ago
Sean Chittenden	a3a0eeeadd	Trim residual complexity from server join notifications ... Now that serf node join events are decoupled from rebalancing activities completely, remove the complixity of draining the channel and ensuring only one go routine was rebalancing the server list. Now that we're no longer initializing a notification channel, we can remove the config load/save from `Start()`	9 years ago
Sean Chittenden	a71fbe57e3	Only log in FindServers ... In FindServer this is a useful warning hinting why its call failed. RPC returns error and leaves it to the higher level caller to do whatever it wants. As an operator, I'd have the detail necessary to know why the RPC call(s) failed.	9 years ago
Sean Chittenden	58246fcc0b	Initialize the rebalancce to clientRPCMinReuseDuration ... In an earlier version there was a channel to notify when a new server was added, however this has long since been removed. Just default to the sane value of 2min before the first rebalance calc takes place. Pointed out by: slackpad	9 years ago
Sean Chittenden	4fec6a9608	Guard against very small or negative rates ... Pointed out by: slackpad	9 years ago
Sean Chittenden	d9251e30c8	Use range vs for ... Returning a new array vs mutating an array in place so we can use range now.	9 years ago
Sean Chittenden	9c18bb5f1c	Comment updates	9 years ago
Sean Chittenden	0b3f6932df	Only rotate server list with more than one server ... Fantastic observation by slackpad. This was left over from when there was a boolean for health in the server struct (vs current strategy where we use server position in the list and rely on serf to cleanup the stale members). Pointed out by: slackpad	9 years ago
Sean Chittenden	24eb274860	Relocate saveServerConfig next to getServerConfig ... Requested by: slackpad	9 years ago
Sean Chittenden	b00db393e7	Clarify that ConsulClusterInfo is an interface over serf ... An interface was used to break a cyclic import dependency.	9 years ago
Sean Chittenden	b8bbdb9e7a	Reword comment after moving code into new packages	9 years ago
Sean Chittenden	68183c4378	Change initialReblaanaceTimeout to a time.Duration ... Pointed out by: @slackpad	9 years ago
Sean Chittenden	3433feb93b	Negative check: test an invalid condition	9 years ago
Sean Chittenden	0f3ad9c120	Test to make sure bootstrap is missing	9 years ago
Sean Chittenden	7a2d30d1cf	Be more Go idiomatic w/ variable names: s/valid/ok/g ... Cargo culting is bad, m'kay? Pointy Hat: sean-	9 years ago
Sean Chittenden	9daccb8b41	Fix stale comment ... Pointed out by: @slackpad	9 years ago
Sean Chittenden	db72041063	Add a comment for Client serverMgr	9 years ago
James Phillips	3340d7ccd7	Merge pull request #1876 from hashicorp/f-tls-helper ... Adds TLS config helper to API client.	9 years ago
James Phillips	0eb6279c5e	Improves the comment for the Address field.	9 years ago
James Phillips	e3f6c6a798	Merge pull request #1877 from hashicorp/api-constants ... Added some constants in the api for check health statuses	9 years ago
Diptanu Choudhury	4811a72d80	Added some constants in the api for check health statuses	9 years ago
James Phillips	1cfed981b3	Adds TLS config helper to API client.	9 years ago
Sean Chittenden	4d4806ab02	Add CHANGELOG entry re: agent rebalancing	9 years ago
Sean Chittenden	828606232e	Correct a bogus goimport rewrite for tests	9 years ago
Sean Chittenden	da872fee63	Test ServerManager.refreshServerRebalanceTimer ... Change the signature so it returns a value so that this can be tested externally with mock data. See the sample table in TestServerManagerInternal_refreshServerRebalanceTimer() for the rate at which it will back off. This function is mostly used to not cripple large clusters in the event of a partition.	9 years ago
Sean Chittenden	a63d5ab963	Add a handful more unit tests to the public interface	9 years ago
Sean Chittenden	8e3c83a258	Rename GetNumServers to NumServers() ... Matches the style of the rest of the repo	9 years ago