66 Commits (c9fae76b7d84b06f19bbccfad690e45d15c41c4a)

Author	SHA1	Message	Date
John Cowen	65ef2969c7	ui: Async Search (#4859) ... This does several things to make improving the search experience easier moving forwards: 1. Separate searching off from filtering. 'Searching' can be thought of as specifically 'text searching' whilst filtering is more of a boolean/flag search. 2. Decouple the actual searching functionality to almost pure, isolated / unit testable units and unit test. (I still import embers get which, once I upgrade to 3.5, I shouldn't need) 3. Searching rules are now configurable from the outside, i.e. not wrapped in Controllers or Components. 4. General searching itself now can use an asynchronous approach based on events. This prepares for future possibilities of handing off the searching to a web worker or elsewhere, which should aid in large scale searching and prepares the way for other searching methods. 5. Adds the possibility of have multiple searches in one template/route/page. Additionally, this adds a WithSearching mixin to aid linking the searching to ember in an ember-like way in a single place. Plus a WithListeners mixin to aid with cleaning up of event listeners on Controller/Component destruction. Post-initial work I slightly changed the API of create listeners: Returning the handler from a `remover` means you can re-add it again if you want to, this avoids having to save a reference to the handler elsewhere to do the same. The `remove` method itself now returns an array of handlers, again you might want to use these again or something, and its also more useful then just returning an empty array. The more I look at this the more I doubt that you'll ever use `remove` to remove individual handlers, you may aswell just use the `remover` returned from add. I've added some comments to reflect this, but they'll likely be removed once I'm absolutely sure of this. I also added some comments for WithSearching to explain possible further work re: moving `searchParams` so it can be `hung` off the controller object	6 years ago
John Cowen	a35fe7c5ba	ui: Removes delete button form pages that show your current token (#5241) ... Tokens can no longer delete themselves see: https://github.com/hashicorp/consul/pull/5210 ...so we remove the button to allow you to do that from the UI	6 years ago
John Cowen	c8386ec0cc	UI: [BUGFIX] Decode/encode urls (#5206) ... In 858b05fc31 (diff-46ef88aa04507fb9b039344277531584) we removed encoding values in pathnames as we thought they were eventually being encoded by `ember`. It looks like this isn't the case. Turns out sometimes they are encoded sometimes they aren't. It's complicated. If at all possible refer to the PR https://github.com/hashicorp/consul/pull/5206. It's related to the difference between `dynamic` routes and `wildcard` routes. Partly related to this is a decision on whether we urlencode the slashes within service names or not. Whilst historically we haven't done this, we feel its a good time to change this behaviour, so we'll also be changing services to use dynamic routes instead of wildcard routes. So service links will then look like /ui/dc-1/services/application%2Fservice rather than /ui/dc-1/services/application/service Here, we define our routes in a declarative format (for the moment at least JSON) outside of Router.map, and loop through this within Router.map to set all our routes using the standard this.route method. We essentially configure our Router from the outside. As this configuration is now done declaratively outside of Router.map we can also make this data available to href-to and paramsFor, allowing us to detect wildcard routes and therefore apply urlencoding/decoding. Where I mention 'conditionally' below, this is detection is what is used for the decision. We conditionally add url encoding to the `{{href-to}}` helper/addon. The reasoning here is, if we are asking for a 'href/url' then whatever we receive back should always be urlencoded. We've done this by reusing as much code from the original `ember-href-to` addon as possible, after this change every call to the `{{href-to}}` helper will be urlencoded. As all links using `{{href-to}}` are now properly urlencoded. We also need to decode them in the correct place 'on the other end', so.. We also override the default `Route.paramsFor` method to conditionally decode all params before passing them to the `Route.model` hook. Lastly (the revert), as we almost consistently use url params to construct API calls, we make sure we re-encode any slugs that have been passed in by the user/developer. The original API for the `createURL` function was to allow you to pass values that didn't need encoding, values that **did** need encoding, followed by query params (which again require url encoding) All in all this should make the entire ember app url encode/decode safe.	6 years ago
John Cowen	66c139ceae	UI: Text change and clarity Node Health > Health Checks (#5115) ... Text change Node Health > Health Checks Also adds an info icon and tooltip to Health Checks column header	6 years ago
Jihoon Chung	d5e28bda56	ui: Fix typo in acl-migration guide link (#5135)	6 years ago
John Cowen	9c11109db4	ui: If a service has no external-source, don't show the icon (#4996)	6 years ago
John Cowen	f65f001675	UI: Catch 500 error on token endpoint and revert to legacy tokens (#4874) ... In some circumstances a consul 1.4 client could be running in an un-upgraded 1.3 or lower cluster. Currently this gives a 500 error on the new ACL token endpoint. Here we catch this specific 500 error/message and set the users AccessorID to null. Elsewhere in the frontend we use this fact (AccessorID being null) to decide whether to present the legacy or the new ACL UI to the user. Also: - Re-adds in most of the old style ACL acceptance tests, now that we are keeping the old style UI - Restricts code editors to HCL only mode for all `Rules` editing (legacy/'half legacy'/new style) - Adds a [Stop using] button to the old style ACL rows so its possible to logout. - Updates copy and documentation links for the upgrade notices	6 years ago
John Cowen	d98c1242dc	ui: Adds multi syntax linting to the code editor (#4814)	6 years ago
John Cowen	7d89e519a2	UI: New ACLs (#4789) ... UI to accompany the new ACLs APIs	6 years ago
John Cowen	5f39bfd161	ui: Improve layout of node cards on large and small screens (#4761) ... 1. The grid based unhealthy cards are now clamped to only four wide maximum. This means that on larger screen the cards are much wider meaning you can view more information. Grid gutters are also clamped at a certain ideal width screen, remaining responsive for anything below this. 2. The healthy node columns are finally responsive following the same column rules as unhealthy nodes	6 years ago
John Cowen	99c51c9f86	UI: Reduce in-development deprecations (also use toLocaleString) (#4677) ... Various ember addons produced deprecation messages, some in the browser console and some in terminal. Upgrading and replacing some of these has reduced this. Upgrades: - ember-collection - ember-computed-style Replacements: - ember-pluralize replaced with ember-inflector - ember-cli-format-number replaced with custom helper using standard `toLocaleString` Removing ember-cli-format-number also meant some further changes related to decimal places in the tomography graph, done using `toFixed` The ExternalSources background-images have also now been escaped correctly preventing in-development `console` warnings. The only deprecation warnings are now from ember-block-slots, only in terminal, making for a better development experience overall, especially now we have an empty browser console Also adds a `callIfType` 'helper util' which is a util specifically for helpers (it conforms to a helper argument signature) to be expanded upon later.	6 years ago
John Cowen	96508e556b	ui: Layout fix. Small padding additions to tables (#4701) ... 1. The 'Services' header need to be knocked ot the right slightly to line up properly with the service name when there are no external source icons. 2. Add a single space between ServiceName and ServiceID on the Node > [Services] tab table.	6 years ago
John Cowen	ece09e300d	UI: Tooltips and feedback-dialogs are the same thing - merge (#4678)	6 years ago
John Cowen	d0405ba8b9	UI: CSS Additions (mainly %frames) (#4623) ... * Move almost everything to use %frames * Fix pill styles of ACL types * Remove horizontal scrollbars from dom recycling scroller component * Make text areas look ok in Firefox * Remove ember-bulma-css * New form elements, break out %toggle * %button design tweaks * %form-element design tweaks * Better hashicorp logo * Small screen CSS improvements (#4624) 1. Reduce header size when there are no breadcrumbs 2. Make the filters toggleable, closed by default 3. Reduce the size of the footer on small screens 4. Hide all non-primary columns for forms 5. Slightly change the layout of various items, mainly buttons within forms 6. Make some confirmation dialogs work vertically on small screens. Guessing we might be better just using native confirmations on small screens	6 years ago
John Cowen	0757a08684	ui: Adds a `default` view helper for providing a default value (#4650) ... If the first value passed to the helper is an empty string or undefined then return the second value	6 years ago
John Cowen	5ea748005c	UI: External Source markers (#4640) ... 1. Addition of external source icons for services marked as such. 2. New %with-tooltip css component (wip) 3. New 'no healthcheck' icon as external sources might not have healthchecks, also minus icon on node cards in the service detail view 4. If a service doesn't have healthchecks, we use the [Services] tabs as the default instead of the [Health Checks] tab in the Service detail page. 5. `css-var` helper. The idea here is that it will eventually be replaced with pure css custom properties instead of having to use JS. It would be nice to be able to build the css variables into the JS at build time (you'd probably still want to specify in config which variables you wanted available in JS), but that's possible future work. Lastly there is probably a tiny bit more testing edits here than usual, I noticed that there was an area where the dynamic mocking wasn't happening, it was just using the mocks from consul-api-double, the mocks I was 'dynamically' setting happened to be the same as the ones in consul-api-double. I've fixed this here also but it wasn't effecting anything until actually made certain values dynamic.	6 years ago
John Cowen	981882d5ff	UI: Bugfix. Remove split view code editor (#4615) ... When adding an auto resizing (heightwise) code editor, the ivy-codemirror plugin seems to do this using more nested divs. This div had a horizontal scroller but couldn't be seen on some platforms (with hidden scrollbars). This commit makes the code editor slightly more usable and more visually correct by removing the scroll bar in this div to stop producing the 'split view look', yet keeping the horizontal scroller at the bottom of the code editor for when you enter code that is wider than the area. A max-width has also been added here to prevent the text area from growing off the side of the page. Another improvement to the code editor here is the addition of a nicer color for hightlighting text selection so its at least visible. Lastly, there was a way you could get the bottom horizontal scrollbar to overlay the code in the editor. This makes sure there is always some space at the bottom of the editor to make sure the code won't be obscured	6 years ago
John Cowen	5e987965fa	UI: Bugfix. Fix code toggle in Safari (#4608) ... I'd mistakenly changed the checkbox event to listen to oninput, which works in Chrome and Firefox. Changed this back to onchange as it should be.	6 years ago
John Cowen	40e71f1b91	UI: Simplify/refactor the actions/notification layer (#4572) + (#4573) ... * Move notification texts to a slightly different layer (#4572) * Further Simplify/refactor the actions/notification layer (#4573) 1. Move the 'with-feedback' actions to a 'with-blocking-action' mixin which better describes what it does 2. Additional set of unit tests almost over the entire layer to prove things work/add confidence for further changes The multiple 'with-action' mixins used for every 'index/edit' combo are now reduced down to only contain the functionality related to their specific routes, i.e. where to redirect. The actual functionality to block and carry out the action and then notify are 'almost' split out so that their respective classes/objects do one thing and one thing 'well'. Mixins are chosen for the moment as the decoration approach used by mixins feels better than multiple levels of inheritence, but I would like to take this fuether in the future to a 'compositional' based approach. There is still possible further work to be done here, but I'm a lot happier now this is reduced down into separate parts.	6 years ago
John Cowen	1b3d566a7a	UI: Begin unskipping some more trivial tests (#4574) ... WIP Unskip some lower level trivial tests. This is the beginning of work to unskip some of the more trivial tests that I'd skipped a while back (if the thing they are testing broke, they would have failed higher up in other acceptance tests). I'd rather keep the tests, as they do test things in a more isolated manner, and the plan was to always come back and work to unskip them time allowing. I didn't get to far into this work in progress here, but I'd rather merge what I've done all the same and come back at a later date and continue.	6 years ago
John Cowen	1d31bef0a4	Show the Service.IP address instead of the Node.IP address in detail	6 years ago
John Cowen	310a038f87	Show Service.ID's throughout the app, allow searching by Service.ID ... 1. In the Services > Services detail page for both healthy and unhealthy nodes, also add searching by Service.ID here 2. In the Nodes > Node detail > [Services] tab only if its different from the Service name, add searching by Service.ID here	6 years ago
John Cowen	f85369c375	Add some navigation testing for back buttons and create buttons	6 years ago
John Cowen	649d777714	Acceptance test for using tokens from listing and detail pages	6 years ago
John Cowen	701d6a3a72	Move deleting to a top level feature	6 years ago
John Cowen	e0f7cdb128	Start purifying page objects	6 years ago
John Cowen	e3ce2a8beb	Lock Session invalidation acceptance test	6 years ago
John Cowen	ed286585e9	Add some low hanging intention tests, basically add intentions to others ... 1. There are various things tests that can just have intentions added into them, like filters and such like, add intentions to these 2. Start thinking about being able to negate steps easily, which will lead on to a cleanup of the steps	6 years ago
John Cowen	b445df39bb	Use html5 oninput instead of onkeyup for native textual inputs ... This enables people to enter things using the mouse to paste for example, plus possible other things. As an aside it also answers my query regarding `fillIn` for testing, nothing needs to be actually _typed_ anymore! Doh	6 years ago
mkeeler	6813a99081	Merge remote-tracking branch 'connect/f-connect'	7 years ago
John Cowen	5ac19b164e	Change the appearance of `*` for intention listings ... 1. Use 'All Services (*)' as opposed to '*' 2. Set 'Destination' in teh same bold font as 'Source' 3. Ensure you can search for all services by using '*' or 'All Services (*)'	7 years ago
John Cowen	d61a09ea28	Fix linting typo, caused the selection of future services to break	7 years ago
John Cowen	f600d8fcc9	Move intentions menu item to after ACLs	7 years ago
John Cowen	f4218b4bea	Validate all the things, all the time	7 years ago
John Cowen	ea3e4a720a	Only offer to create a future service if the name doesn't already exist	7 years ago
John Cowen	5575455053	Add support for specifying future services and wildcards	7 years ago
John Cowen	24f6155efc	Switch to single selects rather than inputs	7 years ago
John Cowen	148621d98e	Have a look at power select for select elements	7 years ago
John Cowen	9d6b9b7717	Remove SourceType for the moment	7 years ago
John Cowen	b38e5df630	WIP: First draft intentions ... 1. Listing, filtering by action and searching by source name and destination name 2. Edit/Create page, edits ping the API double fine, need to work through creates and deletes 3. Currently uses a `Precedence` intention keyname that doesn't yet exist in the real API	7 years ago
John Cowen	61e3fa3244	Make sure the dc menu is as useful as possible when things go wrong ... 1. Check the dc's model for both dcs list and the requested dc. 2. If the dc model doesn't exist use and empty array for dcs and a fake dc with the Name 'Error' as we can't even trust what is in the `paramsFor`	7 years ago
John Cowen	fd60f225ec	Merge branch 'master' into feature/ui-node-ports-for-service	7 years ago
John Cowen	b41d19c3c0	Merge pull request #4251 from hashicorp/bugfix/ui-null-tokens ... Ensure a blank/empty token is sent if the localStorage kv doesn't exist	7 years ago
John Cowen	30402b51b1	Merge pull request #4253 from hashicorp/feature/ui-clearer-tags ... UI - Clearer tags	7 years ago
John Cowen	1881ec4824	Add a failing test to show that lock session TTL's are not shown	7 years ago
John Cowen	0ad1d562db	Use the pill styling elsewhere... ... TODO: Probably change the %tag to %pill now I've remembered the word I was looking for!	7 years ago
John Cowen	d2d501a4a4	Add a reusable %tag and use it for the ACL 'tags' ready to use elsewhere	7 years ago
John Cowen	484f6ccaf2	Add port the service is running on for each node in the service view	7 years ago
John Cowen	8c5416ecaf	Ensure a blank token is sent if the localStorage kv doesn't exist	7 years ago
John Cowen	894667b87a	Merge pull request #4247 from hashicorp/feature/acl-sort-by-name ... UI - Sort ACL tokens by name	7 years ago