14611 Commits (c78f7ecb27175f50bc4d04cca261cf7379f4c0a6)

 

All Branches   

Search

Author	SHA1	Message	Date
hc-github-team-consul-core	fade7e6583	auto-updated agent/uiserver/bindata_assetfs.go from commit fc7fe23b4	4 years ago
John Cowen	fc7fe23b4d	ui: Fix text search for upstream instances (#10151) ... * ui: Fix text search for upstream instances * Clean up predicates for other model types * Add some docs around DataCollection and searching * Enable UI Engineering Docs for our preview sites * Use debug CSS in dev and staging	4 years ago
John Cowen	4533a5e959	ui: Adds CRD popover 'informed action' for intentions managed by CRDs (#10100) ... * ui: Adds CRD popover 'informed action' for intentions add via CRDs	4 years ago
Freddy	ed1082510d	Fixup discovery chain handling in transparent mode (#10168) ... Co-authored-by: R.B. Boyer <4903+rboyer@users.noreply.github.com> Previously we would associate the address of a discovery chain target with the discovery chain's filter chain. This was broken for a few reasons: - If the upstream is a virtual service, the client proxy has no way of dialing it because virtual services are not targets of their discovery chains. The targets are distinct services. This is addressed by watching the endpoints of all upstream services, not just their discovery chain targets. - If multiple discovery chains resolve to the same target, that would lead to multiple filter chains attempting to match on the target's virtual IP. This is addressed by only matching on the upstream's virtual IP. NOTE: this implementation requires an intention to the redirecting virtual service and not just to the final destination. This is how we can know that the virtual service is an upstream to watch. A later PR will look into traversing discovery chains when computing upstreams so that intentions are only required to the discovery chain targets.	4 years ago
Paul Banks	3ad754ca7b	Make Raft trailing logs and snapshot timing reloadable (#10129) ... * WIP reloadable raft config * Pre-define new raft gauges * Update go-metrics to change gauge reset behaviour * Update raft to pull in new metric and reloadable config * Add snapshot persistance timing and installSnapshot to our 'protected' list as they can be infrequent but are important * Update telemetry docs * Update config and telemetry docs * Add note to oldestLogAge on when it is visible * Add changelog entry * Update website/content/docs/agent/options.mdx Co-authored-by: Matt Keeler <mkeeler@users.noreply.github.com> Co-authored-by: Matt Keeler <mkeeler@users.noreply.github.com>	4 years ago
Luke Kysow	8d6cbe7281	Give descriptive error if auth method not found (#10163) ... * Give descriptive error if auth method not found Previously during a `consul login -method=blah`, if the auth method was not found, the error returned would be "ACL not found". This is potentially confusing because there may be many different ACLs involved in a login: the ACL of the Consul client, perhaps the binding rule or the auth method. Now the error will be "auth method blah not found", which is much easier to debug.	4 years ago
Freddy	2ca3f481f8	Only consider virtual IPs for transparent proxies (#10162) ... Initially we were loading every potential upstream address into Envoy and then routing traffic to the logical upstream service. The downside of this behavior is that traffic meant to go to a specific instance would be load balanced across ALL instances. Traffic to specific instance IPs should be forwarded to the original destination and if it's a destination in the mesh then we should ensure the appropriate certificates are used. This PR makes transparent proxying a Kubernetes-only feature for now since support for other environments requires generating virtual IPs, and Consul does not do that at the moment.	4 years ago
Daniel Nephin	c8f53a1d52	ci: allow cherry-picking a manual backport to other release branches ... If an automatic backport fails to more than one release branch we need to crate a PR to backport it. So far we've had to create a backport PR for each target release branch. With this change, we may be able to create only a single PR, and then run the backport automation to cherry-pick it into other release branches. The idea is that if a change introduced in version n-1 caused a conflict, and there are no other changes, then the backport automation should be able to use the same commit for version n-2 and n-3.	4 years ago
Kendall Strautman	1cbea66717	[Assembly]: Website Branding Refresh (#9884) ... * style: update gray brand colors * style: update brand colors * chore: upgrades base platform deps * style: updates learn callouts label color * style: icons to flat consul primary color * style: errand link styles * refactor(home): use react-learn-callout * chore; adds ts config, upgrades components * chore: upgrade deps chore: upgrade to latest component styles chore: upgrades nextjs-scripts * chore: fix-router * update deps, add new downloads page * chore: upgrade to stable deps chore: use npm 7 * style: home callouts body copy to gray-2 * chore: upgrade hashi-stack-menu * style: home feature icons update * chore: upgrade deps body copy colors * chore: upgrades alert banner * feat: updates favicon * style(downloads): adds pre-release and release candidate styles * fix(home): adds right padding to quote * content(home): swap assets * content(uses-cases): updates assets * chore: removes use cases icon override * content(use-cases): swap out svgs for pngs * content: copies asset * trying again with this asset * try putting asset in public * content(use-cases): updates mercedes case study aseset * chore: upgrades product download page prerelease * chore: updates product download page to stable * chore: updates favicon path Co-authored-by: Jeff Escalante <jescalan@users.noreply.github.com>	4 years ago
hc-github-team-consul-core	a37c1e8466	auto-updated agent/uiserver/bindata_assetfs.go from commit 211bc824a	4 years ago
Hector Simpson	211bc824a9	Update brand assets (#10081) ... * Update header logo and inline icon * Update full logos + layout on loading screen * Update favicon assets and strategy - Switches to serve an ico file alongside an SVG file - Introduces an apple-touch-icon * Removes unused favicon/meta assets * Changelog item for ui * Create component for logo * Simplify logo component, set brand color * Fix docs loading state CSS issue	4 years ago
Frederic Hemberger	9a5a0ba209	docs(discovery/service): Clarify multiple service definitions ... Be more explicit that the definition of multiple services only works in config files, not using the HTTP API. Ref: https://discuss.hashicorp.com/t/register-multiple-services-via-put-request/	4 years ago
Daniel Nephin	00d3283e93	Merge pull request #10149 from hashicorp/dnephin/config-use-streaming-backend-defualt-true ... config: default UseStreamingBackend to true	4 years ago
R.B. Boyer	0f8cdfaeff	dev: adding a make target to regenerate envoy golden files (#10158)	4 years ago
tarat44	51f8db3879	create separate function with its own context to shutdown http2 client conn in h2ping check	4 years ago
Daniel Nephin	a07a58a873	config-entry: use custom MarshalJSON for mesh type ... So that the Kind field is added to the JSON object.	4 years ago
Daniel Nephin	62efaaab21	config-entry: remove Kind and Name field from Mesh config entry ... No config entry needs a Kind field. It is only used to determine the Go type to target. As we introduce new config entries (like this one) we can remove the kind field and have the GetKind method return the single supported value. In this case (similar to proxy-defaults) the Name field is also unnecessary. We always use the same value. So we can omit the name field entirely.	4 years ago
R.B. Boyer	abc1dc0fe9	connect: update supported envoy versions to 1.18.2, 1.17.2, 1.16.3, and 1.15.4 (#10101) ... The only thing that needed fixing up pertained to this section of the 1.18.x release notes: > grpc_stats: the default value for stats_for_all_methods is switched from true to false, in order to avoid possible memory exhaustion due to an untrusted downstream sending a large number of unique method names. The previous default value was deprecated in version 1.14.0. This only changes the behavior when the value is not set. The previous behavior can be used by setting the value to true. This behavior change by be overridden by setting runtime feature envoy.deprecated_features.grpc_stats_filter_enable_stats_for_all_methods_by_default. For now to maintain status-quo I'm explicitly setting `stats_for_all_methods=true` in all versions to avoid relying upon the default. Additionally the naming of the emitted metrics for these gRPC requests changed slightly so the integration test assertions for `case-grpc` needed adjusting.	4 years ago
R.B. Boyer	85a718da63	xds: ensure that all envoyproxy/go-control-plane protobuf symbols are linked into the final binary (#10131) ... This ensures that if someone does include some extension Consul does not currently make use of, that extension is actually usable. Without linking these envoy protobufs into the main binary it can't round trip the escape hatches to send them down to envoy. Whenenver the go-control-plane library is upgraded next we just have to re-run 'make envoy-library'.	4 years ago
R.B. Boyer	71d45a3460	Support Incremental xDS mode (#9855) ... This adds support for the Incremental xDS protocol when using xDS v3. This is best reviewed commit-by-commit and will not be squashed when merged. Union of all commit messages follows to give an overarching summary: xds: exclusively support incremental xDS when using xDS v3 Attempts to use SoTW via v3 will fail, much like attempts to use incremental via v2 will fail. Work around a strange older envoy behavior involving empty CDS responses over incremental xDS. xds: various cleanups and refactors that don't strictly concern the addition of incremental xDS support Dissolve the connectionInfo struct in favor of per-connection ResourceGenerators instead. Do a better job of ensuring the xds code uses a well configured logger that accurately describes the connected client. xds: pull out checkStreamACLs method in advance of a later commit xds: rewrite SoTW xDS protocol tests to use protobufs rather than hand-rolled json strings In the test we very lightly reuse some of the more boring protobuf construction helper code that is also technically under test. The important thing of the protocol tests is testing the protocol. The actual inputs and outputs are largely already handled by the xds golden output tests now so these protocol tests don't have to do double-duty. This also updates the SoTW protocol test to exclusively use xDS v2 which is the only variant of SoTW that will be supported in Consul 1.10. xds: default xds.Server.AuthCheckFrequency at use-time instead of construction-time	4 years ago
Tara Tufano	e345ef6086	make h2ping changelog entry conform with changelog template (#10111) ... LGTM!	4 years ago
Luigi Tagliamonte	5220699696	Improve doc: add note about address validation (#10123) ... * Update website/content/docs/discovery/services.mdx with address field behavior. Co-authored-by: Jono Sosulska <42216911+jsosulska@users.noreply.github.com> Co-authored-by: Jono Sosulska <42216911+jsosulska@users.noreply.github.com>	4 years ago
Iryna Shustava	8dffb89131	Implement traffic redirection exclusion based on proxy config and user-provided values (#10134) ... * Use proxy outbound port from TransparentProxyConfig if provided * If -proxy-id is provided to the redirect-traffic command, exclude any listener ports from inbound traffic redirection. This includes envoy_prometheus_bind_addr, envoy_stats_bind_addr, and the ListenerPort from the Expose configuration. * Allow users to provide additional inbound and outbound ports, outbound CIDRs and additional user IDs to be excluded from traffic redirection. This affects both the traffic-redirect command and the iptables SDK package.	4 years ago
Daniel Nephin	5a87b8aaab	Add changelog	4 years ago
hc-github-team-consul-core	cbabf82587	auto-updated agent/uiserver/bindata_assetfs.go from commit 5d89ba031	4 years ago
John Cowen	5d89ba0313	ui: Add a max height and scroll to the intention perm header lists (#10128)	4 years ago
Freddy	701b49f772	Rename cluster config files to mesh as well (#10148)	4 years ago
Daniel Nephin	bb472111fd	config: default UseStreamingBackend to true	4 years ago
Freddy	078c40425f	Rename "cluster" config entry to "mesh" (#10127) ... This config entry is being renamed primarily because in k8s the name cluster could be confusing given that the config entry applies across federated datacenters. Additionally, this config entry will only apply to Consul as a service mesh, so the more generic "cluster" name is not needed.	4 years ago
Daniel Nephin	e19aef45cb	Merge pull request #10146 from hashicorp/dnephin/connect-proxy-test-deadlock ... connect/proxy: fix a few problems with tests	4 years ago
Daniel Nephin	9b344b3300	Merge pull request #10112 from hashicorp/dnephin/remove-streaming-from-cache ... streaming: replace agent/cache with submatview.Store	4 years ago
Daniel Nephin	d18a03b07f	connect/proxy: fix a number of problems with Listener ... We noticed that TestUpstreamListener would deadlock sometimes when run with the race detector. While debugging this issue I found and fixed the following problems. 1. the net.Listener was not being closed properly when Listener.Stop was called. This caused the Listener.Serve goroutine to run forever. Fixed by storing a reference to net.Listener and closing it properly when Listener.Stop is called. 2. call connWG.Add in the correct place. WaitGroup.Add must be called before starting a goroutine, not from inside the goroutine. 3. Set metrics config EnableRuntimeMetrics to `false` so that we don't start a background goroutine in each test for no reason. There is no way to shutdown this goroutine, and it was an added distraction while debugging these timeouts. 5. two tests were calling require.NoError from a goroutine. require.NoError calls t.FailNow, which MUST be called from the main test goroutine. Instead use t.Errorf, which can be called from other goroutines and will still fail the test. 6. `assertCurrentGaugeValue` wass breaking out of a for loop, which would cause the `RWMutex.RUnlock` to be missed. Fixed by calling unlock before `break`. The core issue of a deadlock was fixed by https://github.com/armon/go-metrics/pull/124.	4 years ago
Jamie Finnigan	8fc62cb87f	remove Codecov from CI runs (#10145)	4 years ago
Kenia	f9a4b6d050	ui: Add TProxy Mode notice banner to service instance Upstreams tab (#10136)	4 years ago
Daniel Nephin	146e1d3878	connect/proxy: remove t.Parallel from tests ... These tests run in under 10ms, t.Parallel provides no value and makes debuging failures more difficult.	4 years ago
Daniel Nephin	3a27fce2ad	submatview: fix godoc and comment typos ... Co-authored-by: Paul Banks <banks@banksco.de>	4 years ago
Kenia	0c9555ec0e	ui: Update not-defined intention popover and banner (#10133)	4 years ago
Kenia	7caa47da56	ui: Update conditional for topology empty state (#10124)	4 years ago
Kenia	ce98d08d12	ui: Fix empty SVG height to prevent service mesh from breaking when there are no upstreams (#10122)	4 years ago
hc-github-team-consul-core	4ad37c326e	auto-updated agent/uiserver/bindata_assetfs.go from commit 345765f76	4 years ago
John Cowen	345765f766	ui: Adds human formatting to nanosecond based session durations (#10062) ... * ui: Adds human formatting to nanosecond based session durations	4 years ago
Daniel Nephin	31cd58084f	Add changelog	4 years ago
Daniel Nephin	11398892b3	submatview: avoid sorting results unnecessarily ... Previous getFromView would call view.Result when the result may not have been returned (because the index is updated past the minIndex. This would allocate a slice and sort it for no reason, because the values would never be returned. Fix this by re-ordering the operations in getFromView. The test changes in this commit were an attempt to cover the case where an update is received but the index does not exceed the minIndex.	4 years ago
Daniel Nephin	23e1cd6f93	submatview: only return materializer from getEntry ... Also rename it to readEntry now that it doesn't return the entire entry. Based on feedback in PR review, the full entry is not used by the caller, and accessing the fields wouldn't be safe outside the lock, so it is safer to return only the Materializer	4 years ago
Daniel Nephin	46b7d0b573	submatview: godoc	4 years ago
Daniel Nephin	d9537411b8	rpcclient/health: convert tests to the new submatview.Store interface ... Also fixes a minor data race in Materializer. Capture the error before releasing the lock.	4 years ago
Daniel Nephin	79a54f208e	agent: fix data race in tests caused by grpc log init ... grpclog.SetLoggerV2 is meant to be called only once before any gRPC requests are received, but each test that uses TestAgent will call NewBaseDeps again. Use a sync.Once to prevent the grpc logging from being re-initialized by each test. This will mean that a test can't use a fake logger to capture logs from the gRPC server.	4 years ago
Daniel Nephin	dacf50038d	submatview: fix two flaky tests ... These tests can flake when we get a notification for an earlier event. Retry the read from update channel a few times to make sure we get the event we expect.	4 years ago
Daniel Nephin	a2986ebb9c	sdk/retry: support ending the iteration early ... I've found this feature to be very useful in https://pkg.go.dev/gotest.tools/v3/poll#WaitOn I have encountered a few cases where I wanted that same support, so this commit adds it.	4 years ago
Daniel Nephin	034c5c5f8c	sdk/retry: remove the need to pass args to NextOr	4 years ago