381 Commits (c64f3600f0d6cc0856569e6c83f2e1cfeddaf296)

Author	SHA1	Message	Date
Freddy	8207b832df	Add TransparentProxy option to proxy definitions	4 years ago
Christopher Broglie	f0307c73e5	Add support for configuring TLS ServerName for health checks ... Some TLS servers require SNI, but the Golang HTTP client doesn't include it in the ClientHello when connecting to an IP address. This change adds a new TLSServerName field to health check definitions to optionally set it. This fixes #9473.	4 years ago
freddygv	6fd30d0384	Add TransparentProxy opt to proxy definition	4 years ago
Silas Rech	ab9c484137	Fix advertise_addr_wan_ipv6 configuration key	4 years ago
Daniel Nephin	3aec942b17	streaming: default rpc.enable_streaming to true ... So that all servers will start the grpc server used by streaming	4 years ago
Daniel Nephin	1f9247677b	Merge pull request #9763 from hashicorp/dnephin/cache-warn-on-error-in-notify ... cache: log a warning when Cache.Notify handles an error	4 years ago
Daniel Nephin	b91c5a8383	config: rename testCase fields ... So that their name better reflects their purpose	4 years ago
Daniel Nephin	534631659c	config: make TestLoad_IntegrationWithFlags easier to work with ... Replace the large table of tests with individual calls to run(). By using runCase, failure messages will include the line number for the test case, as well as a line number from the test functions. Example: === FAIL: agent/config TestLoad_IntegrationWithFlags/failing_case (0.01s) runtime_test.go:4721: case: failing case runtime_test.go:4864: error "data_dir cannot be empty" does not contain "I expected this error" Previous: runtime_test.go:4864: error "data_dir cannot be empty" does not contain "I expected this error" Without the line number to the testCase data, debugging these tests is difficult. It is impossible to jump directly to the test case, and difficult to find the location because of many similarly named cases.	4 years ago
Daniel Nephin	bd728df345	move test case iteration to caller ... To make the test case logic more obvious	4 years ago
Daniel Nephin	f86ceea803	config: remove test cases for impossible scenarios ... AEInterval is overridden by NonUserSource, so there is no way for a user to set this value. These two cases represented impossible real world scenarios. Instead the test is replaced with one that shows that the AEInterval can not be set by config. This change allows us to remove the hcltail and jsontail fields from testCase	4 years ago
Daniel Nephin	76787d4dd0	Fix error checking ... There were two identical if lines, remove one and use a switch/case so the compiler can catch this problem.	4 years ago
Daniel Nephin	863551beb4	config: move testing shims to LoadOpts ... This will allow us to eventually port these tests to use config.Load instead of unexported functions.	4 years ago
Daniel Nephin	4411da5ddd	Remove patchActual, does not appear to be necessary ... also small rename and fix comment	4 years ago
Daniel Nephin	d9b8d30cad	cache: log a warning when Cache.Notify handles an error ... Without these warnings, errors are silently ignored, which can make debugging problems more challenging.	4 years ago
Daniel Nephin	1dcafa51a4	config: make config.TestLoad_FullConfig use config.Load ... This commit makes a number of changes that should make TestLoad_FullConfig easier to work with, and make the test more like real world scenarios. * use separate files in testdata/ dir to store the config source. Separate files are much easier to edit because editors can syntax highlight json/hcl, and it makes strings easier to find. Previously trying to find strings would match strings used in other tests. * use the exported config.Load interface instead of internal NewBuilder and BuildAndValidate. * remove the tail config overrides, which are only necessary with nonZero works.	4 years ago
Daniel Nephin	a0dd45941b	config: Unexport Builder and NewBuilder ... This type and constructor are implementation details of config loading. All callers should use config.Load.	4 years ago
Daniel Nephin	32d36d0dd4	config: replace calls to config.NewBuilder with config.Load ... This is another incremental change to reduce config loading to a single small interface. All calls to NewBuilder can be replaced with Load.	4 years ago
Daniel Nephin	97a577502d	config: improve the interface of Load ... This commit reduces the interface to Load() a bit, in preparation for unexporting NewBuilder and having everything call Load. The three arguments are reduced to a single argument by moving the other two into the options struct. The three return values are reduced to two by moving the RuntimeConfig and Warnings into a LoadResult struct.	4 years ago
Daniel Nephin	27df0d9a78	Merge pull request #9252 from hashicorp/dnephin/config-unmethod ... config: remove Builder receiver from funcs that dont use it	4 years ago
Daniel Nephin	e66af1a559	agent/consuk: Rename RPCRate -> RPCRateLimit ... so that the field name is consistent across config structs.	4 years ago
Daniel Nephin	e35d5c93c7	config: remove Builder receiver from funcs that dont use it ... This change allows us to re-use these functions in other places without the Builder, and makes it more explicit about which functions can warn/error and which can not.	4 years ago
Daniel Nephin	c500182105	config: Use golden for TestRuntimeConfig_Sanitize ... A golden file makes the expected value easier to work with. This change also removes a number of shims for enterprise and replaces them with a single one for the golden filename.	4 years ago
Pierre Souchay	7c1b69cbeb	Display a warning when rpc.enable_streaming = true is set on a client (#9530) ... * Display a warning when rpc.enable_streaming = true is set on a client This option has no effect when running as an agent * Added warning when server starts with use_streaming_backend but without rpc.enable_streaming * Added unit test	4 years ago
Daniel Nephin	6f1f679457	Merge pull request #9250 from hashicorp/dnephin/config-tags-2 ... config: remove unnecessary json/hcl struct tags	4 years ago
Daniel Nephin	7b45d0baea	Merge pull request #9249 from hashicorp/dnephin/config-tags ... config: use fields to detect enterprise-only settings	4 years ago
Daniel Nephin	de7e1d7ca1	config: remove unnecessary json/hcl struct tags ... Using find/replace with regex json:"[^"]+" hcl:"[^"]+"	4 years ago
Daniel Nephin	724a281e1c	config: Use config fields to warn about enterprise settings ... It is no safe to assumes that the mapstructure keys will contain all the keys because some config can be specified with command line flags or literals. This change allows us to remove the json marshal/unmarshal cycle for command line flags, which will allow us to remove all of the hcl/json struct tags on config fields.	4 years ago
Daniel Nephin	a9285ad76a	Merge pull request #9251 from hashicorp/dnephin/config-cleanup-flags-and-opts ... config: move testing shims and cleanup some defaults	4 years ago
Daniel Nephin	ce1deae3c8	config: use LiteralConfig for flag values	4 years ago
Daniel Nephin	a9734b69c5	config: remove t.Parallel and some unused fields from tests ... Use go-cmp for better diffs in tests	4 years ago
Michael Montgomery	ba3fe0c875	Remove unneeded test	4 years ago
Michael Montgomery	e4f603dfae	Merge branch 'master' into 6074-allow-config-MaxHeaderBytes	4 years ago
Michael Montgomery	817903b925	Fixed failing tests ... Removed use of `NewTestAgent`, per review comment Removed CLI flag, per review comment Updated website documentation Added changelog entry	4 years ago
Daniel Nephin	b9e60c0775	testing: skip slow tests with -short ... Add a skip condition to all tests slower than 100ms. This change was made using `gotestsum tool slowest` with data from the last 3 CI runs of master. See https://github.com/gotestyourself/gotestsum#finding-and-skipping-slow-tests With this change: ``` $ time go test -count=1 -short ./agent ok github.com/hashicorp/consul/agent 0.743s real 0m4.791s $ time go test -count=1 -short ./agent/consul ok github.com/hashicorp/consul/agent/consul 4.229s real 0m8.769s ```	4 years ago
Hans Hasselberg	44674bcdf8	fix serf_wan documentation (#9289) ... WAN config is different than LAN config, source of truth is f72d2042a8/config.go (L315-L326) and now the docs are correct.	4 years ago
Daniel Nephin	a1e4b69527	config: remove unused const	4 years ago
Daniel Nephin	78f767e78c	config: move testing shims to BuilderOpts ... And remove the devMode field from builder. This change helps make the Builder state more explicit by moving inputs to the BuilderOps struct, leaving only fields that can change during Builder.Build on the Builder struct.	4 years ago
Daniel Nephin	0a44906fe3	config: Use LiteralSource for some defaults ... Using the LiteralSource makes it much easier to find default values, because an IDE reports the location of a default. With an HCL string they are harder to discover. Also removes unnecessary mapstructure.Decodes of constant values.	4 years ago
Michael Montgomery	585c84e9ff	Merge branch 'master' into 6074-allow-config-MaxHeaderBytes	4 years ago
Matt Keeler	66fd23d67f	Refactor to call non-voting servers read replicas (#9191) ... Co-authored-by: Kit Patella <kit@jepsen.io>	4 years ago
Kit Patella	8e554ee74b	Merge branch 'mkcp/telemetry/add-all-metric-definitions' of ssh://github.com/hashicorp/consul into mkcp/telemetry/add-all-metric-definitions	4 years ago
Kit Patella	ad4cebc1d8	fix some tests that were broken from the TelemetryConfig change	4 years ago
Kit Patella	fc30f07cc7	linting: sort and group import	4 years ago
Kit Patella	2fe021f03c	update runtime_test to handle PrometheusOpts expiry field change	4 years ago
Kit Patella	5e0e4098c9	push prometheus sink definiitons into prometheus.PrometheusOpts	4 years ago
R.B. Boyer	61eac21f1a	agent: return the default ACL policy to callers as a header (#9101) ... Header is: X-Consul-Default-ACL-Policy=<allow|deny> This is of particular utility when fetching matching intentions, as the fallthrough for a request that doesn't match any intentions is to enforce using the default acl policy.	4 years ago
Matt Keeler	c048e86bb2	Switch to using the external autopilot module	4 years ago
R.B. Boyer	8e616a93c1	agent: sanitize ui metrics proxy header values on agent/self endpoint (#9104)	4 years ago
R.B. Boyer	a66c4591d7	agent: introduce path allow list for requests going through the metrics proxy (#9059) ... Added a new option `ui_config.metrics_proxy.path_allowlist`. This defaults to `["/api/v1/query", "/api/v1/query_range"]` when the metrics provider is set to `prometheus`. Requests that do not use one of the allow-listed paths (via exact match) get a 403 Forbidden response instead.	4 years ago
Michael Montgomery	5b6ac035ff	Resolves #6074. Adds new option to configure HTTP Server's MaxHeaderBytes with option `-http-max-header-bytes` ... Adds tests for behavior	4 years ago