consul

Commit Graph

Author	SHA1	Message	Date
Daniel Nephin	7246d8b6cb	agent/cache: Reduce differences between notify implementations These two notify functions are very similar. There appear to be just enough differences that trying to parameterize the differences may not improve things. For now, reduce some of the cosmetic differences so that the material differences are more obvious.	5 years ago
Daniel Nephin	66fbb13976	agent/cache: Inline the refresh function to make recursion more obvious fetch is already an exceptionally long function, but hiding the recrusion in a function call likely does not help.	5 years ago
Daniel Nephin	faeaed5d0c	agent/cache: Make the return values of getEntryLocked more obvious Use named returned so that the caller has a better idea of what these bools mean. Return early to reduce the scope, and make it more obvious what values are returned in which cases. Also reduces the number of conditional expressions in each case.	5 years ago
Daniel Nephin	0e51f89414	Merge pull request #7639 from hashicorp/dnephin/fix-master Fix test failing on master	5 years ago
Daniel Nephin	25b585d0bf	Fix golden file for envoy tests The envoy version was updated after the PR which added this test was opened, and merged before the test was merged, so it ended up with the wrong version.	5 years ago
Daniel Nephin	e9e45545dd	agent/cache: Small formatting improvements to improve readability Remove Cache.entryKey which called a single function. Format multiline struct creation one field per line.	5 years ago
Daniel Nephin	329d76fd0e	Remove SnapshotRPC passthrough The caller has access to the delegate, so we do not gain anything by wrapping the call in Agent.	5 years ago
Daniel Nephin	6b860c926f	Merge pull request #7608 from hashicorp/dnephin/grpc-default-scheme command/envoy: enable TLS when CONSUL_HTTP_ADDR=https://...	5 years ago
Daniel Nephin	1f25bf88b8	Merge pull request #7596 from hashicorp/dnephin/agent-cache-type-entry agent/cache: move typeEntry lookup to the edge	5 years ago
Matt Keeler	4468002f37	Update CHANGELOG.md	5 years ago
Pierre Souchay	2199a134a0	More tolerant assert_alive_wan_member_count to fix unstable tests Example of failure (very frequent): https://circleci.com/gh/hashicorp/consul/157985	5 years ago
Pierre Souchay	1b4218a068	fix flaky TestReplication_FederationStates test due to race conditions (#7612 ) The test had two racy bugs related to memdb references. The first was when we initially populated data and retained the FederationState objects in a slice. Due to how the `inmemCodec` works these were actually the identical objects passed into memdb. The second was that the `checkSame` assertion function was reading from memdb and setting the RaftIndexes to zeros to aid in equality checks. This was mutating the contents of memdb which is a no-no. With this fix, the command: ``` i=0; while /usr/local/bin/go test -count=1 -timeout 30s github.com/hashicorp/consul/agent/consul -run '^(TestReplication_FederationStates)$'; do i=$((i + 1)); printf "$i "; done ``` That used to break on my machine in less than 20 runs is now running 150+ times without any issue. Might also fix #7575	5 years ago
Andrea Scarpino	bf601842c2	docs: document consulPrefix properly (#7603 )	5 years ago
danielehc	0fef193278	Adding API version for example call (#7626 )	5 years ago
Hans Hasselberg	66415be90e	connect: support envoy 1.14.1 (#7624 )	5 years ago
Pierre Souchay	4a6569a4e3	tests: change default http_max_conns_per_client to 250 to ease tests (#7625 ) On recent Mac OS versions, the ulimit defaults to 256 by default, but many systems (eg: some Linux distributions) often limit this value to 1024. On validation of configuration, Consul now validates that the number of allowed files descriptors is bigger than http_max_conns_per_client. This make some unit tests failing on Mac OS. Use a less important value in unit test, so tests runs well by default on Mac OS without need for tuning the OS.	5 years ago
Blake Covarrubias	7f03949424	docs: Fix broken link to Nomad Consul Connect guide	5 years ago
Freddy	9eb1867fbb	Terminating gateway discovery (#7571 ) * Enable discovering terminating gateways * Add TerminatingGatewayServices to state store * Use GatewayServices RPC endpoint for ingress/terminating	5 years ago
Freddy	aae14b3951	Add decode rules for Expose cfg in service-defaults (#7611 )	5 years ago
Daniel Nephin	8b6861518f	Fix CONSUL_HTTP_ADDR=https not enabling TLS Use the config instead of attempting to reparse the env var.	5 years ago
Daniel Nephin	0888c6575b	Step 3: fix a bug in api.NewClient and fix the tests The api client should never rever to HTTP if the user explicitly requested TLS. This change broke some tests because the tests always use an non-TLS http server, but some tests explicitly enable TLS.	5 years ago
Iryna Shustava	74bd138bae	docs: Add Helm docs for auto-encrypt and external servers (#7595 ) * docs: Add Helm docs for auto-encrypt and external servers	5 years ago
Luke Kysow	c03e314c16	Merge pull request #7586 from hashicorp/helm-docs Document bootstrapACLs deprecation	5 years ago
Daniel Nephin	1a8ffec6a7	Step 2: extract the grpc address logic and a new type The new grpcAddress function contains all of the logic to translate the command line options into the values used in the template. The new type has two advantages. 1. It introduces a logical grouping of values in the BootstrapTplArgs struct which is exceptionally large. This grouping makes the struct easier to understand because each set of nested values can be seen as a single entity. 2. It gives us a reasonable return value for this new function.	5 years ago
Daniel Nephin	830b4a15f6	Step 1: move all the grpcAddr logic into the same spot There is no reason a reader should have to jump around to find this value. It is only used in 1 place	5 years ago
Alvin Huang	1bb4e1ccd2	filter out non go branches from the 'go-tests' workflow (#7606 )	5 years ago
Matt Keeler	32daa2b27c	Update CHANGELOG.md	5 years ago
Matt Keeler	0e7d3d93b3	Enable filtering language support for the v1/connect/intentions… (#7593 ) * Enable filtering language support for the v1/connect/intentions listing API * Update website for filtering of Intentions * Update website/source/api/connect/intentions.html.md	5 years ago
Daniel Nephin	8549cc2d99	Merge pull request #7598 from pierresouchay/preallocation_of_dns_meta Pre-allocations of DNS meta to avoid several allocations	5 years ago
Luke Kysow	df9d88831d	Update website/source/docs/platform/k8s/helm.html.md Co-Authored-By: Iryna Shustava <ishustava@users.noreply.github.com>	5 years ago
Pierre Souchay	d1d016d61d	[LINT] Close resp.Body to avoid linter complaining (#7600 )	5 years ago
Pierre Souchay	c9e01ed0a3	Pre-allocations of DNS meta to avoid several allocations	5 years ago
Jono Sosulska	93509690be	Change style to match "join" singular (#7569 ) * Change style to match "join" singular - Replaced "(Consul) cluster" with "Consul Datacenter" - Removed "ing" so the feature fits "Consul Auto-join", and that the tense is correct. Co-authored-by: danielehc <40759828+danielehc@users.noreply.github.com>	5 years ago
Daniel Nephin	c9a87be6ee	agent/cache: move typeEntry lookup to the edge This change moves all the typeEntry lookups to the first step in the exported methods, and makes unexporter internals accept the typeEntry struct. This change is primarily intended to make it easier to extract the container of caches from the Cache type. It may incidentally reduce locking in fetch, but that was not a goal.	5 years ago
David Yu	b51ad875c3	[docs] Built-in Proxies not meant for production (#7579 ) * [docs] Built-in Proxies not meant for production * Adding link to Envoy for Connect * Update website/source/docs/connect/proxies/built-in.md Co-Authored-By: Blake Covarrubias <blake@covarrubi.as> * Revising note * Update website/source/docs/connect/proxies/built-in.md period Co-Authored-By: Hans Hasselberg <me@hans.io> Co-authored-by: Blake Covarrubias <blake@covarrubi.as> Co-authored-by: Hans Hasselberg <me@hans.io>	5 years ago
Daniel Nephin	b9cb1e93c3	Merge pull request #7589 from pierresouchay/fix_unstable_test_TestForwardSignals Fixed unstable test TestForwardSignals()	5 years ago
Pierre Souchay	73056fecf8	Fixed unstable test TestForwardSignals() Sometimes, in the CI, it could receive a SIGURG, producing this line: FAIL: TestForwardSignals/signal-interrupt (0.06s) util_test.go:286: expected to read line "signal: interrupt" but got "signal: urgent I/O condition" Only forward the signals we test to avoid this kind of false positive Example of such unstable errors in CI: https://circleci.com/gh/hashicorp/consul/153571	5 years ago
Pierre Souchay	09e638a9c6	tests: more tolerance to latency for unstable test `TestCacheNotifyPolling()`. (#7574 )	5 years ago
Luke Kysow	08df582e20	Document bootstrapACLs deprecation	5 years ago
Freddy	b61214ef24	Fix regression with gateway registration and update docs (#7582 )	5 years ago
Matt Keeler	8aec09aa8f	Ensure that token clone copies the roles (#7577 )	5 years ago
Chris Piraino	bcb7a89fda	Update CHANGELOG.md	5 years ago
Chris Piraino	584f90bbeb	Fix flapping of mesh gateway connect-service watches (#7575 )	5 years ago
Pierre Souchay	2a8bf45e38	agent: show warning when enable_script_checks is enabled without safty net (#7437 ) In order to enforce a bit security on Consul agents, add a new method in agent to highlight possible security issues. This does not return an error for now, but might in the future. For now, it detects issues such as: https://www.hashicorp.com/blog/protecting-consul-from-rce-risk-in-specific-configurations/ This would display this kind of messages: ``` 2020-03-11T18:27:49.873+0100 [ERROR] agent: [SECURITY] issue: error="using enable-script-checks without ACLs and without allow_write_http_from is DANGEROUS, use enable-local-script-checks instead see https://www.hashicorp.com/blog/protecting-consul-from-rce-risk-in-specific-configurations/" ```	5 years ago
Andy Lindeman	fb0a990e4d	agent: rewrite checks with proxy address, not local service address (#7518 ) Exposing checks is supposed to allow a Consul agent bound to a different IP address (e.g., in a different Kubernetes pod) to access healthchecks through the proxy while the underlying service binds to localhost. This is an important security feature that makes sure no external traffic reaches the service except through the proxy. However, as far as I can tell, this is subtly broken in the case where the Consul agent cannot reach the proxy over localhost. If a proxy is configured with: `{ LocalServiceAddress: "127.0.0.1", Checks: true }`, as is typical with a sidecar proxy, the Consul checks are currently rewritten to `127.0.0.1:<random port>`. A Consul agent that does not share the loopback address cannot reach this address. Just to make sure I was not misunderstanding, I tried configuring the proxy with `{ LocalServiceAddress: "<pod ip>", Checks: true }`. In this case, while the checks are rewritten as expected and the agent can reach the dynamic port, the proxy can no longer reach its backend because the traffic is no longer on the loopback interface. I think rewriting the checks to use `proxy.Address`, the proxy's own address, is more correct in this case. That is the IP where the proxy can be reached, both by other proxies and by a Consul agent running on a different IP. The local service address should continue to use `127.0.0.1` in most cases.	5 years ago
Andy Lindeman	c1cb18c648	proxycfg: support path exposed with non-HTTP2 protocol (#7510 ) If a proxied service is a gRPC or HTTP2 service, but a path is exposed using the HTTP1 or TCP protocol, Envoy should not be configured with `http2ProtocolOptions` for the cluster backing the path. A situation where this comes up is a gRPC service whose healthcheck or metrics route (e.g. for Prometheus) is an HTTP1 service running on a different port. Previously, if these were exposed either using `Expose: { Checks: true }` or `Expose: { Paths: ... }`, Envoy would still be configured to communicate with the path over HTTP2, which would not work properly.	5 years ago
Pierre Souchay	be1c5c4b48	config: validate system limits against limits.http_max_conns_per_client (#7434 ) I spent some time today on my local Mac to figure out why Consul 1.6.3+ was not accepting limits.http_max_conns_per_client. This adds an explicit check on number of file descriptors to be sure it might work (this is no guarantee as if many clients are reaching the agent, it might consume even more file descriptors) Anyway, many users are fighting with RLIMIT_NOFILE, having a clear message would allow them to figure out what to fix. Example of message (reload or start): ``` 2020-03-11T16:38:37.062+0100 [ERROR] agent: Error starting agent: error="system allows a max of 512 file descriptors, but limits.http_max_conns_per_client: 8192 needs at least 8212" ```	5 years ago
Daniel Nephin	a6cede401a	Merge pull request #7572 from hashicorp/dnephin/ci-fix-go-mod-download ci: Fix working_directory for go mod download	5 years ago
Daniel Nephin	625ce9baf2	ci: Fix working_directory for go mod download The previous PR which added these was accidentally performing the download in the root directory. For the api, and sdk directories it should be in done in the same directory that will be used to run tests. Otherwise the wrong dependencies will be downloaded which may add unnecessary time to the CI run.	5 years ago
Shaker Islam	ac309d55f4	docs: document exported functions in agent.go (closes #7101 ) (#7366 ) and fix one linter error	5 years ago

1 2 3 4 5 ...

11302 Commits (c11e9d38d03b7f7f88a2909c89a1ab6fff606234) All Branches Search

11302 Commits (c11e9d38d03b7f7f88a2909c89a1ab6fff606234)

All Branches