237 Commits (be9ba707ba65983927ab12e54e06e4b0b544b907)

Author	SHA1	Message	Date
John Cowen	5a88d4ebe1	ui: Explicitly remove properties that shouldn't be sent when saving (#6917)	5 years ago
John Cowen	f691a29240	Ensure AbortErrors have a zero status (#6839)	5 years ago
John Cowen	b3b32dc0f6	ui: UI Release Merge (ui-staging merge) (#6527) ... ## HTTPAdapter (#5637) ## Ember upgrade 2.18 > 3.12 (#6448) ### Proxies can no longer get away with not calling _super This means that we can't use create anymore to define dynamic methods. Therefore we dynamically make 2 extended Proxies on demand, and then create from those. Therefore we can call _super in the init method of the extended Proxies. ### We aren't allowed to reset a service anymore We never actually need to now anyway, this is a remnant of the refactor from browser based confirmations. We fix it as simply as possible here but will revisit and remove the old browser confirm functionality at a later date ### Revert classes to use ES5 style to workaround babel transp. probs Using a mixture of ES6 classes (and hence super) and arrow functions means that when babel transpiles the arrow functions down to ES5, a reference to this is moved before the call to super, hence causing a js error. Furthermore, we the testing environment no longer lets use use apply/call on the constructor. These errors only manifests during testing (only in the testing environment), the application itself runs fine with no problems without this change. Using ES5 style class definitions give us freedom to do all of the above without causing any errors, so we reverted these classes back to ES5 class definitions ### Skip test that seems to have changed due to a change in RSVP timing This test tests a usecase/area of the API that will probably never ever be used, it was more testing out the API. We've skipped the test for now as this doesn't affect the application itself, but left a note to come back here later to investigate further ### Remove enumerableContentDidChange Initial testing looks like we don't need to call this function anymore, the function no longer exists ### Rework Changeset.isSaving to take into account new ember APIs Setting/hanging a computedProperty of an instantiated object no longer works. Move to setting it on the prototype/class definition instead ### Change how we detect whether something requires listening New ember API's have changed how you can detect whether something is a computedProperty or not. It's not immediately clear if its even possible now. Therefore we change how we detect whether something should be listened to or not by just looking for presence of `addEventListener` ### Potentially temporary change of ci test scripts to ensure deps exist All our tooling scripts run through a Makefile (for people familiar with only using those), which then call yarn scripts which can be called independently (for people familar with only using yarn). The Makefile targets always check to make sure all the dependencies are installed before running anything that requires them (building, testing etc). The CI scripts/targets didn't follow this same route and called the yarn scripts directly (usually CI builds a cache of the dependencies first). For some reason this cache isn't doing what it usually does, and it looks as though, in CI, ember isn't installed. This commit makes the CI scripts consistently use the same method as all of the other tooling scripts (Makefile target > Install Deps if required > call yarn script). This should install the dependencies if for some reason the CI cache building doesn't complete/isn't successful. Potentially this commit may be reverted if, the root of the problem is elsewhere, although consistency is always good, so it might be a good idea to leave this commit as is even if we need to debug and fix things elsewhere. ### Make test-parallel consistent with the rest of the tooling scripts As we are here making changes for CI purposes (making test-ci consistent), we spotted that test-parallel is also inconsistent and also the README manual instructions won't work without `ember` installed globally. This commit makes everything consistent and changes the manual instructions to use the local ember instance that gets installed via yarn ### Re-wrangle catchable to fit with new ember 3.12 APIs In the upgrade from ember 3.8 > 3.12 the public interfaces for ComputedProperties have changed slightly. `meta` is no longer a public property of ComputedProperty but of a ComputedDecoratorImpl mixin instead. 7e4ba1096e/packages/%40ember/-internals/metal/lib/computed.ts (L725) There seems to be no way, by just using publically available methods, to replicate this behaviour so that we can create our own 'ComputedProperty` factory via injecting the ComputedProperty class as we did previously. 3f333bada1/ui-v2/app/utils/computed/factory.js (L1-L18) Instead we dynamically hang our `Catchable` `catch` method off the instantiated ComputedProperty. In doing it like this `ComputedProperty` has already has its `meta` method mixed in so we don't have to manually mix it in ourselves (which doesn't seem possible) This functionality is only used during our work in trying to ensure our EventSource/BlockingQuery work was as 'ember-like' as possible (i.e. using the traditional Route.model hooks and ember-like Controller properties). Our ongoing/upcoming work on a componentized approach to data a.k.a `<DataSource />` means we will be able to remove the majority of the code involved here now that it seems to be under an amount of flux in ember. ### Build bindata_assetfs.go with new UI changes	5 years ago
Dmitry Shemin	90d945590a	ui: [bugfix] Tag wrapping on detail pages (#6478) ... Makes sure that tags wrap on the detail pages for service and nodes whilst making sure they don't wrap on the listing pages.	5 years ago
John Cowen	20984e2a73	ui: re-remove the `Type` header on the service listing page (#6439) ... The `Type` column used for giving details on what type of a service each item is was removed in https://github.com/hashicorp/consul/pull/6075. As a result of keeping long running branches in sync, this change was partly reverted in an earlier PR (the type header was re-added) https://github.com/hashicorp/consul/pull/5913 following a rebase. This commit re-removes the `Type` table header (the `<th>`)	5 years ago
John Cowen	2369c47033	ui: Adds a `sort-control` component for asc/desc sorting of columns etc (#6034) ... This adds the component but doesn't yet use it anywhere. No tests are added here as there isn't an awful lot to test.	5 years ago
John Cowen	24847b169e	ui: Leader icon for node listing view (#6265) ... - yarn upgrade consul-api-double which includes `status/leader` - add all the ember-data things required to call a new endpoint - Pass the new leader variable through to the template - use the new leader variable in the template to set a leader - add acceptance testing to verify leaders are highlighted - Change testing navigation/api requests to status/leader (on the node listing page, status/leader is now the last get request to be called). - Template whitespace commit (less indenting) - adds a test to to assert no errors happen with an unelected leader	5 years ago
John Cowen	ceebd53b81	ui: fix/replace magnifier icon (#6308)	5 years ago
John Cowen	44c2da3518	ui: add some additional env level URLs for easier linking (#6145) ... Right now we only use CONSUL_DOCS_URL, the others are for future usage	5 years ago
John Cowen	5debc74fa2	ui: Enable blocking queries by default (#6194) ... -Enable blocking queries by default -Change assertion to check for the last PUT request, not just any request for session destruction from a node page. Since we've now turned on blocking queries by default this means that a second GET request is made after the PUT request that we are asserting for but before the assertion itself, this meant the assertion failed. We double checked this by turning off blocking queries for this test using ``` And settings from yaml --- consul:client: blocking: 0 --- ``` which made the test pass again. As moving forwards blocking queries will be on by default, we didn't want to disable blocking queries for this test, so we now assert the last PUT request specifically. This means we continue to assert that the session has been destroyed but means we don't get into problems of ordering of requests here	5 years ago
John Cowen	e636a72ffd	ui: [Bugfix] - Sticky KV Sessions (#6166) ... Initialize session value to `null` to prevent stickiness from a session the previous KV	5 years ago
John Cowen	a263bff6b9	ui: Change layout styling for healthcheckoutput, add CheckID (#6195)	5 years ago
John Cowen	dd91ce33d6	ui: Show the correct message when a session has been removed from a KV (#6167)	5 years ago
John Cowen	d01ef7225a	ui: Add `stats-card` component, integrate more `@hashicorp/structure-icons` (#6021) ... 1. Rebuild the heathchecked-resource component now we can copy and paste 2. As the above rebuild came with new icons, we also swapped out 'most' of the other areas where we were using these new icons, plus any icons that were effected by the new icon placeholders 3. Begin to remove more and more of the project specific icons (now replaced by the shared ones)	5 years ago
John Cowen	86208b4a70	ui: Add an additional 'more than 1 char' check for selection (#6022) ... We'd rather 'play it safe' for our selection detection (which avoids following links if you have some text selected). This commit adds an additional check of 'more than 1 character' to the 'isSelected' check. This is based on the fact that it's far quicker to type the character so why would a user select on character? This therefore caters for any fairly large (in the scheme of things) incidential mouse moves whilst clicking a link. Overall this is probably overkill	5 years ago
John Cowen	5c6fa1c458	ui: Be more exact with intent for table truncation (#6023) ... Truncation should only happen currently on table content if the tag within the td is the only child	5 years ago
John Cowen	876dd3b97d	ui: Ensure event sources are closed to the correct state when connecting (#6036) ... This fails the tests, but wouldn't produce an actual bug as the source is still set to closing, just 1 tick later.	5 years ago
John Cowen	9efe2b2ced	ui: removes `npm:` imports now we have standard importing (#6035)	5 years ago
John Cowen	62fa803d9f	ui: {{phrase-editor}} amends (#5991) ... 1. Re-focus the input element on phrase removal 2. Move all actions to `actions:` 3. Move to a form looking `value` rather than `items` 4. Move placeholder functionalit yinto the component 5. Force DDAU instead of two way binding with `slice` and `onchange` 6. Begin to deprecate the `searchable` interface	5 years ago
John Cowen	6d8a706b4d	ui: Adds the ability to frontend search instances by address (ip:port) (#5993)	5 years ago
John Cowen	01d1b3c139	ui: Small EventSource additions (#5978) ... 1. EventSources now pass themselves thorugh to the run function as a second argument. This enables the use of arrow functions along with the EventSources API `(configuration, source) => source.close()`. Order of arguments could potentially be switched at a later date. 2. BlockingEventSources now let you pass an 'event' through at instantation time. If you do this, the event will immediately be dispatched once the EventSource is opened. The usecase for this is for 'unfreezing' cached BlockingEvents. This makes it easier to provide a cache for BlockingEventSources by caching its data rather than the entire BlockingEventSource itself. ``` new BlockingEventSource( (config, source) => { /* something */ }, { cursor: 1024, // this would also come from a cache currentEvent: getFromSomeSortOfCache(eventSourceId) //this is the new bit } ); // more realistically new BlockingEventSource( (config, source) => { return data.findSomething(slug, config) }, getFromSomeSortOfCache(eventSourceId) ); ```	5 years ago
John Cowen	32387fdbcf	ui: Enable creating listeners using an object/hash (#5975) ... Makes listening to multiple events on one target slightly easier. Adding events can be rolled up into passing through an object, and the returned remove function removes all of the handlers in the object For example: ``` //this.listen... const remove = listeners.add( { 'message': handler, 'error': handler } ); remove(); // removes all listeners in the object ``` The entire API for listeners is now becoming slightly overloaded, so potentially we'd use this API always and remove the ability to use a string/function pair.	5 years ago
John Cowen	63a0582fa3	ui: Reduce mutation of html.classList (#5974) ... Throughout the app we mutate the value of the root node classList on navigation between separate pages (basically on URL change). Every template has a unique classList for example `template-service template-show` and `template-service template-list` etc etc. When navigating between 2 pages, both pages using the same template yet with different data, previoulsy we would entirely clear out the `html.classList` and then refill it again with eaxctly the same classes. This commit moves this to perform a diff previous to mutating the classList, and then potentially no classList mutating is needed when moving between 2 pages of the same template.	5 years ago
John Cowen	62e3c5605c	ui: Change vocab of ReopenableEventSource from 'reopen' to 'open' (#5973) ... You can potentially close an EventSource before its first tick by immediately setting the readyState to a non-open state. Therefore it never opens. Calling `open` will then open it. 'Open' fits better than 'reopen' when taking the above into account	5 years ago
John Cowen	06b6aff8d0	ui: CSS Components Migration (#5913) ... Migrate roughly half of the base components into base Adds a target for easily formatting CSS Further CSS amends/migration (#5921) 1. tooltips within tables where a slightly bit troublesome due to a mix of `inline-flex`, `overflow` and the need for truncation. This refineds tooltips a slight bit more to work 'everywhere'. 2. We also move tooltip to use the correct color and min-width from structure, but we overwrite the min-width here until we get confirmation on widths/alignment of text within a tooltip. 3. Tiny fixes for breadcrumbs and toggle-buttons in tabular listings 4. Now we inline-flex our table cells, it means it is impossible to truncate text without wrapping it in another element. This wraps all Description like text in `<p>` tags. Generally the first column of text is already wrapped in an `<a>` tag. Other items such as consul tags and policy names etc get 'cutoff' rather than truncated. 5. We are now using all the icons from `@hashicorp/structure-icons`	5 years ago
John Cowen	2b30667fc7	ui: Adds ember-auto-import and replaces the 3 places where we used npm: (#5952) ... Also removes ember-browserify	5 years ago
John Cowen	df0cf11a0f	ui: Put some options in for event source runners (behind flags) (#5738)	5 years ago
John Cowen	82a2f206dc	ui: Ensure an EventSource isn't opened if closed before first tick (#5703) ... EventSources will wait for 1 tick before 'opening'. There is always the chance that the EventSource is '.close()'ed before that tick. We therefore check the 'readyState' before opening the EventSource	5 years ago
John Cowen	e609defd70	ui: Allow text selection of clickable elements and their contents (#5770) ... * ui: Allow text selection of clickable elements and their contents This commit disables a click on mousedown be removing the `href` attribute and moving it to a `data-href` attribute. On mouseup it will only move it back if there is no selection. This means that an anchor will only be followed on click _if_ there is no selection. This fixes the fact that whenever you select some copy within a clickable element it immediately throws you into the linked page when you release your mouse. Further notes: We use the `isCollapsed` property here which 'seems' to be classed as 'experimental' in one place where I researched it: https://developer.mozilla.org/en-US/docs/Web/API/Selection/isCollapsed Although in others it makes no mention of this 'experimental' e.g: - https://webplatform.github.io/docs/dom/Selection/isCollapsed/ - https://w3c.github.io/selection-api/#dom-selection-iscollapsed I may have gone a little overboard in feature detection for this, but I conscious of that fact that if `isCollapsed` doesn't exist at some point in the future (something that seems unlikely). The code here will have no effect on the UI. But I'd specifically like a second pair of eyes on that. * ui: Don't break right click, detects a secondary click on mousedown * ui: Put anchor selection capability behind an ENV var	5 years ago
John Cowen	42adafbd02	ui: Reconcile ember-data store when records are deleted via blocking (#5745) ... * ui: Reconciliate ember-data store when records are deleted via blocking Currently we are barely using the ember-data store/cache, but it will still cache records in the store even though technically we aren't using it. This adds a SyncTime to every record that uses blocking queries so we can delete older records from the ember-data cache to prevent them building up * ui: Add basic timestamp method we can access from tests, fixup tests Adds a timestamp method that we can access from within tests so we can test that the SyncTime is being set. There is probably a better way to do this, but this is also probably the simplest approach - we are also likely to revisit this at a later date	5 years ago
John Cowen	eccff12a9b	ui: Expands create-listeners API to allow recursive and functions (#5616) ... 1. Adds a Listeners class, which lets us... 2. Add Listeners recursively. So you can createListeners().add(createListeners()) 3. Also add the ability to `.add` as a plain function This moves the entire idea more towards a generic teardown utility	5 years ago
John Cowen	266c288fc0	ui: Adds readonly meta data to the serviceInstance and node detail pages (#6196)	5 years ago
John Cowen	dcb9800442	ui: Gateway Addresses (#6075) ... - Removes 'type' icons (basically the proxy icon, not the text itself) - Add support for Mesh Gateways plus their addresses This adds a 'Mesh Gateway' type label to service and service instance pages, plus a new 'Addresses' tab if the service is a Mesh Gateway showing a table of addresses for the service - plus tests	5 years ago
Joel Kuzmarski	0598b66a80	Fix text and add feature test for copy button (#5958) ... `Copied IP Address!` > `Copied output!` Adds feature test for copy button	5 years ago
Sarah Christoff	d3d92d76f3	ui: modify content path (#5950) ... * Add ui-content-path flag * tests complete, regex validator on string, index.html updated * cleaning up debugging stuff * ui: Enable ember environment configuration to be set via the go binary at runtime (#5934) * ui: Only inject {{.ContentPath}} if we are makeing a prod build... ...otherwise we just use the current rootURL This gets injected into a <base /> node which solves the assets path problem but not the ember problem * ui: Pull out the <base href=""> value and inject it into ember env See previous commit: The <base href=""> value is 'sometimes' injected from go at index serve time. We pass this value down to ember by overwriting the ember config that is injected via a <meta> tag. This has to be done before ember bootup. Sometimes (during testing and development, basically not production) this is injected with the already existing value, in which case this essentially changes nothing. The code here is slightly abstracted away from our specific usage to make it easier for anyone else to use, and also make sure we can cope with using this same method to pass variables down from the CLI through to ember in the future. * ui: We can't use <base /> move everything to javascript (#5941) Unfortuantely we can't seem to be able to use <base> and rootURL together as URL paths will get doubled up (`ui/ui/`). This moves all the things that we need to interpolate with .ContentPath to the `startup` javascript so we can conditionally print out `{{.ContentPath}}` in lots of places (now we can't use base) * fixed when we serve index.html * ui: For writing a ContentPath, we also need to cope with testing... (#5945) ...and potentially more environments Testing has more additional things in a separate index.html in `tests/` This make the entire thing a little saner and uses just javascriopt template literals instead of a pseudo handbrake synatx for our templating of these files. Intead of just templating the entire file this way, we still only template `{{content-for 'head'}}` and `{{content-for 'body'}}` in this way to ensure we support other plugins/addons * build: Loosen up the regex for retrieving the CONSUL_VERSION (#5946) * build: Loosen up the regex for retrieving the CONSUL_VERSION 1. Previously the `sed` replacement was searching for the CONSUL_VERSION comment at the start of a line, it no longer does this to allow for indentation. 2. Both `grep` and `sed` where looking for the omment at the end of the line. We've removed this restriction here. We don't need to remove it right now, but if we ever put the comment followed by something here the searching would break. 3. Added `xargs` for trimming the resulting version string. We aren't using this already in the rest of the scripts, but we are pretty sure this is available on most systems. * ui: Fix erroneous variable, and also force an ember cache clean on build 1. We referenced a variable incorrectly here, this fixes that. 2. We also made sure that every `make` target clears ember's `tmp` cache to ensure that its not using any caches that have since been edited everytime we call a `make` target. * added docs, fixed encoding * fixed go fmt * Update agent/config/config.go Co-Authored-By: R.B. Boyer <public@richardboyer.net> * Completed Suggestions * run gofmt on http.go * fix testsanitize * fix fullconfig/hcl by setting correct 'want' * ran gofmt on agent/config/runtime_test.go * Update website/source/docs/agent/options.html.md Co-Authored-By: Hans Hasselberg <me@hans.io> * Update website/source/docs/agent/options.html.md Co-Authored-By: kaitlincarter-hc <43049322+kaitlincarter-hc@users.noreply.github.com> * remove contentpath from redirectFS struct	5 years ago
John Cowen	a44541a91f	ui: Implements a testable clipboard {{copy-button}} (#5967) ... 1. Remove ember-cli-clipboard dependency 2. Provide a new copy-button component implementing the same interface as ^ but make the clipboard functionality injectable 3. Provide 2 implementations of a Clipboard. One using clipboard.js (as previously) and an additional local storage 'clipboard'. 4. add a BDD step to assert whats in the clipboard (the fake one) Main reason here is that `document.exec` must be called by a user interaction	6 years ago
John Cowen	e8722e6a35	ui: Normal proxies link to services, sidecars to instances (#5944) ... * ui: Normal proxies line to services, sidecars to instances Following on from https://github.com/hashicorp/consul/pull/5933 we noticed that 'normal' proxies should link to the service, rather than the service instance. Additionally proxy 'searching' within the repository should take into account the name of the node that the originating service is on (sidecar proxies are generally co-located) Added an additional test here to prove that a sidecar-proxy with the same service id but on a different node does not show the sidecar proxy link.	6 years ago
John Cowen	a41c13ae83	ui: Ensure Service Instance pages account for nodes (#5933) ... Include node name in the URL for service instances Integrate the node name slug into tests for service instance pages	6 years ago
John Cowen	685b89bdec	ui: Adds ability to search by policy, role or service ident names (#5811)	6 years ago
John Cowen	9013e53ebc	ui: Ensures nested policy forms are reset properly (#5838) ... 1. All {{ivy-codemirror}} components need 'refreshing' when they become visible via our own `didAppear` method on the `{{code-editor}}` component (also see:) - https://github.com/hashicorp/consul/pull/4190#discussion_r193270223 - 73db111db8 (r225264296) 2. On initial investigation, it looks like the component we are using for the code editor doesn't distinguish between setting its `value` programatically and a `keyup` event, i.e. an interaction from the user. We currently pretend that whenever its `value` changes, it is a `keyup` event. This means that when we reset the `value` to `""` programmatically for form resetting purposes, a 'pretend keyup' event would also be fired, which would in turn kick off the validation, which would fail and show an error message for empty values in other fields of the form - something that is perfectly valid if you haven't typed anything yet. We solved this by checking for `isPristine` on fields that are allowed to be empty before you have typed anything.	6 years ago
John Cowen	8306b2f251	ui: Replaces destroyRecord with unloadRecord for KV 404's (#5837) ... Just because Consul gives us a 404 this doesn't guarantee the KV doesn't exist, it doesn't even mean we don't have access to it. Furthermore we should never destroyRecord's without user interaction (therefore only via the repo.delete method). This switches destroyRecord to unloadRecord which performs the additional legwork to keep ember-data in sync with the actual truth. unloadRecord unloads the record from ember-data rather than sending an API delete request, which would have been the intent here.	6 years ago
John Cowen	75e221d256	ui: ACL Policies. Catch all server errors (#5836) ... Always show any server errors under Rules, not just invalid HCL	6 years ago
John Cowen	ee393e34fb	ui: Adds tick whilst editing the link template in the Settings area (#5820) ... 1. Amends our `base` animation placeholder to always reset transition-duration. This has no effect on other components that are already using this animation. 2. Adds a confirming class whenever a key is pressed, to show the green tick. Uses CSS via `transition-delay` for debouncing.	6 years ago
John Cowen	077d70ff44	ui: Previously we were passing through 'fake' events, revert to real.. (#5810) ... Previously we were creating a fake event and amending the name of the fake event, this meant that other `event.target` properties weren't being passed through (in this instance `checked`) this changes the approach to not use fake events, and allows you to overwrite the name that the form uses for `handleEvent`	6 years ago
John Cowen	793f0747c6	ui: Gives the minimal in-form token list use a maximum row size (#5807) ... This means its more straightforwards to calculate the height of the listing itself. This component is currently only used on the form pages for tokens and roles, should therefore be a restricted size.	6 years ago
John Cowen	7e2c66ad12	ui: fix production build only empty role modal (#5806) ... Adds the ability for multiple components to use the same dom buffer	6 years ago
John Cowen	727fddcae3	ui: Remove old 'default' template keyword, we now use '' for default (#5805)	6 years ago
John Cowen	249dcaf6cd	ui: Ensure room for non-hidden scrollbars (#5802)	6 years ago
John Cowen	614ac96fa6	ui: Make the proxy icon full size in service listings (#5799)	6 years ago
John Cowen	119bd02368	ui: Uses the default cursor instead of a pointer for upstream rows (#5785)	6 years ago