233 Commits (b21851c90394584cf3ce61e30d98cd1fae753823)

Author	SHA1	Message	Date
R.B. Boyer	b21851c903	test: add test helper to detect if the current build is enterprise (#19201) ... This can help conditionally change test behavior if the test is executing in enterprise without the need to split the test with build tags.	1 year ago
Kumar Kavish	68e7f27fd2	[NET-6438] Add tenancy to xDS Tests (#19551) ... * [NET-6438] Add tenancy to xDS Tests * [NET-6438] Add tenancy to xDS Tests - Fixing imports * [NET-6438] Add tenancy to xDS Tests - Added cleanup post test run * [NET-6356] Add tenancy to xDS Tests - Added cleanup post test run * [NET-6438] Add tenancy to xDS Tests - using t.Cleanup instead of defer delete * [NET-6438] Add tenancy to xDS Tests - rebased * [NET-6438] Add tenancy to xDS Tests - rebased	1 year ago
aahel	005e1b9926	added exported svc controller (#19589) ... * added exported svc controller * added license headers	1 year ago
Nathan Coleman	40c57f10a0	NET-6391 Initialize controller for MeshGateway resource (#19552) ... * Generate resource_types for MeshGateway by specifying spec option * Register MeshGateway type w/ TODOs for hooks * Initialize controller for MeshGateway resources * Add meshgateway to list of v2 resource dependencies for golden test * Scope MeshGateway resource to partition	1 year ago
Kumar Kavish	3df8b58479	[NET-6444] Add tenancy to Reaper Tests (#19550)	1 year ago
Kumar Kavish	f09dbb99e9	[NET-6356] Add tenancy to Failover Tests (#19547) ... * [NET-6356] Add tenancy to Failover Tests * [NET-6438] Add tenancy to xDS Tests - Added cleanup post test run * [NET-6356] Add tenancy to failover Tests - using t.Cleanup instead of defer delete	1 year ago
Ashesh Vidyut	515eed8c7c	Net 6439 (#19517) ... * node health controller tenancy * some prog * some fixes * revert * pr comment resolved * removed name * Add namespace and tenancy in sidecar proxy controller test * revert node health controller * clean up data * fix local * copy from ENT * removed dup code * removed tenancy * add test tenancies	1 year ago
Matt Keeler	a7774a9538	Introduce randomized timings and reproducible randomization into controller integration tests. (#19393) ... As the V2 architecture hinges on eventual consistency and controllers reconciling the existing state in response to writes, there are potential issues we could run into regarding ordering and timing of operations. We want to be able to guarantee that given a set of resources the system will always eventually get to the desired correct state. The order of resource writes and delays in performing those writes should not alter the final outcome of reaching the desired state. To that end, this commit introduces arbitrary randomized delays before performing resources writes into the `resourcetest.Client`. Its `PublishResources` method was already randomizing the order of resource writes. By default, no delay is added to normal writes and deletes but tests can opt-in via either passing hard coded options when creating the `resourcetest.Client` or using the `resourcetest.ConfigureTestCLIFlags` function to allow processing of CLI parameters. In addition to allowing configurability of the request delay min and max, the client also has a configurable random number generator seed. When Using the CLI parameter helpers, a test log will be written noting the currently used settings. If the test fails then you can reproduce the same delays and order randomizations by providing the seed during the previous test failure.	1 year ago
Ashesh Vidyut	985aa76da3	NET 6354 - Add tenancy in Node Health Controller (#19457) ... * node health controller tenancy * some prog * some fixes * revert * pr comment resolved * removed name * cleanup nodes * some fixes * merge main	1 year ago
John Murret	caaff73337	add DeliverLatest as common function for use by Manager and ProxyTracker Open (#19564) ... Open add DeliverLatest as common function for use by Manager and ProxyTracker	1 year ago
Semir Patel	2da7dd077a	v2tenancy: register tenancy controller deps (#19531)	1 year ago
Ganesh S	5352ff945c	Added tenancy tests for WorkloadHealth controller (#19530)	1 year ago
Poonam Jadhav	c3c836edae	Net-6291/fix/watch resources (#19467) ... * fix: update watch endpoint to default based on scope * test: additional test * refactor: rename list validate function * refactor: rename validate<Op>Request() -> ensure<Op>RequestValid() for consistency	1 year ago
John Murret	d94d316204	NET-6319 - L7 routes have statePrefix of upstream. and should have a full path (#19473)	1 year ago
Semir Patel	aaac20f4a8	resource: misc finalizer apis (#19474)	1 year ago
John Murret	77e9a50f8b	Source / local_app golden tests to include all protocols. (#19436) ... * cover all protocols in local_app golden tests * fix xds tests * updating latest * fix broken test * add sorting of routers to TestBuildLocalApp to get rid of the flaking	1 year ago
skpratt	896d8f5ec5	temporarily disallow L7 traffic permissions (#19322)	1 year ago
Semir Patel	0abd96c0d9	resource: resource service now checks for `v2tenancy` feature flag (#19400)	1 year ago
Matt Keeler	5698353652	Resource Hook Pre-Decode Utilities (#18548) ... Add some generic type hook wrappers to first decode the data There seems to be a pattern for Validation, Mutation and Write Authorization hooks where they first need to decode the Any data before doing the domain specific work. This PR introduces 3 new functions to generate wrappers around the other hooks to pre-decode the data into a DecodedResource and pass that in instead of the original pbresource.Resource. This PR also updates the various catalog data types to use the new hook generators.	1 year ago
Ashesh Vidyut	0295b959c9	Net 5875 - Create the Exported Services Resources (#19117) ... * init * computed exported service * make proto * exported services resource * exported services test * added some tests and namespace exported service * partition exported services * computed service * computed services tests * register types * fix comment * make proto lint * fix proto format make proto * make codegen * Update proto-public/pbmulticluster/v1alpha1/computed_exported_services.proto Co-authored-by: Eric Haberkorn <erichaberkorn@gmail.com> * Update internal/multicluster/internal/types/computed_exported_services.go Co-authored-by: Eric Haberkorn <erichaberkorn@gmail.com> * using different way of resource creation in tests * make proto * fix computed exported services test * fix tests * differnet validation for computed services for ent and ce * Acls for exported services * added validations for enterprise features in ce * fix error * fix acls test * Update internal/multicluster/internal/types/validation_exported_services_ee.go Co-authored-by: Eric Haberkorn <erichaberkorn@gmail.com> * removed the create method * update proto * removed namespace * created seperate function for ce and ent * test files updated and validations fixed * added nil checks * fix tests * added comments * removed tenancy check * added mutation function * fix mutation method * fix list permissions in test * fix pr comments * fix tests * lisence * busl license * Update internal/multicluster/internal/types/helpers_ce.go Co-authored-by: Eric Haberkorn <erichaberkorn@gmail.com> * Update internal/multicluster/internal/types/helpers_ce.go Co-authored-by: Eric Haberkorn <erichaberkorn@gmail.com> * Update internal/multicluster/internal/types/helpers_ce.go Co-authored-by: Eric Haberkorn <erichaberkorn@gmail.com> * make proto * some pr comments addressed * some pr comments addressed * acls helper * some comment changes * removed unused files * fixes * fix function in file * caps * some positioing * added test for validation error * fix names * made valid a function * remvoed patch * removed mutations * v2 beta1 * v2beta1 * rmeoved v1alpha1 * validate error * merge ent * some nits * removed dup func * removed nil check --------- Co-authored-by: Eric Haberkorn <erichaberkorn@gmail.com>	1 year ago
Poonam Jadhav	b5023b69c3	feat: read resource namespace (#19320) ... * test: add missing tests for read resource namespace * refactor: remove redundant test * refactor: rename import aliases * fix: typo var name * refctor: remove another redundant test	1 year ago
Michael Zalimeni	a7803bd829	[NET-6305] xds: Ensure v2 route match and protocol are populated for gRPC (#19343) ... * xds: Ensure v2 route match is populated for gRPC Similar to HTTP, ensure that route match config (which is required by Envoy) is populated when default values are used. Because the default matches generated for gRPC contain a single empty `GRPCRouteMatch`, and that proto does not directly support prefix-based config, an interpretation of the empty struct is needed to generate the same output that the `HTTPRouteMatch` is explicitly configured to provide in internal/mesh/internal/controllers/routes/generate.go. * xds: Ensure protocol set for gRPC resources Add explicit protocol in `ProxyStateTemplate` builders and validate it is always set on clusters. This ensures that HTTP filters and `http2_protocol_options` are populated in all the necessary places for gRPC traffic and prevents future unintended omissions of non-TCP protocols. Co-authored-by: John Murret <john.murret@hashicorp.com> --------- Co-authored-by: John Murret <john.murret@hashicorp.com>	1 year ago
John Murret	59d4962564	NET-6079 - wire up sidecarproxy golden file inputs into xds controller - sources (#19241) ... * NET-5397 - wire up golden tests from sidecar-proxy controller for xds controller and xdsv2 * WIP * WIP * everything matching except leafCerts. need to mock those * single port destinations working except mixed destinations * golden test input to xds controller tests for destinations * proposed fix for failover group naming errors * clean up test to use helper. * clean up test to use helper. * fix test file * add docstring for test function. * add docstring for test function. * fix linting error * fixing test after route fix merged into main * first source test works * WIP * modify all source files * source tests pass * fixing tests after bug fix in main	1 year ago
John Murret	9775758d0c	NET-5397 - wire up destination golden tests from sidecar-proxy controller for xds controller and xdsv2 (#19167) ... * NET-5397 - wire up golden tests from sidecar-proxy controller for xds controller and xdsv2 * WIP * WIP * everything matching except leafCerts. need to mock those * single port destinations working except mixed destinations * golden test input to xds controller tests for destinations * proposed fix for failover group naming errors * clean up test to use helper. * clean up test to use helper. * fix test file * add docstring for test function. * add docstring for test function. * fix linting error * fixing test after route fix merged into main	1 year ago
Iryna Shustava	809bf1deb8	mesh: ensure route configs are named uniquely per port (#19323)	1 year ago
Dhia Ayachi	d5c9f11b59	Tenancy Bridge v2 (#19220) ... * tenancy bridge v2 for v2 resources * add missing copywrite headers	1 year ago
Nitya Dhanushkodi	def66ddf0e	mesh: provide missing domain to route configurations in ProxyStateTemplate (#19298) ... * add empty domains * update unit tests	1 year ago
Iryna Shustava	dfea3a0efe	acls,catalog,mesh: properly authorize workload selectors on writes (#19260) ... To properly enforce writes on resources that have workload selectors with prefixes, we need another service authorization rule that allows us to check whether read is allowed within a given prefix. Specifically we need to only allow writes if the policy prefix allows for a wider set of names than the prefix selector on the resource. We should also not allow policies with exact names for prefix matches. Part of [NET-3993]	1 year ago
Eric Haberkorn	f45be222bb	Prevent circular dependencies between v2 resources and generate a mermaid diagram with their dependencies (#19230)	1 year ago
Nitya Dhanushkodi	51b58cd910	fix expose paths (#19257) ... When testing adding http probes to apps, I ran into some issues which I fixed here: - The listener should be listening on the exposed listener port, updated that. - The listener and route names were pointing to the path of the exposed path. In my test, the path was "/" resulting in an empty string path. Also, the path may not be unique across exposed path listeners, so I decided to use the path+exposed port as the unique identifier.	1 year ago
John Murret	9f4f99c626	NET-6097 - sidecar proxy controller - give name to first failover policy target (#19239)	1 year ago
Semir Patel	4c5a46e5e1	v2tenancy: rename v1alpha1 -> v2beta1 (#19227)	1 year ago
R.B. Boyer	6741392a4f	catalog: add FailoverPolicy ACL hook tenancy test (#19179)	1 year ago
R.B. Boyer	df8ea430c6	mesh: add DestinationPolicy ACL hook tenancy tests (#19178) ... Enhance the DestinationPolicy ACL hook tests to cover tenanted situations. These tests will only execute in enterprise.	1 year ago
Semir Patel	ad177698f7	resource: enforce lowercase v2 resource names (#19218)	1 year ago
R.B. Boyer	6c7d0759e4	mesh: add xRoute ACL hook tenancy tests (#19177) ... Enhance the xRoute ACL hook tests to cover tenanted situations. These tests will only execute in enterprise.	1 year ago
John Murret	a7fbd00865	NET-5073 - ProxyConfiguration: implement various connection options (#19187) ... * NET-5073 - ProxyConfiguration: implement various connection options * PR feedback - LocalConnection and InboundConnection do not affect exposed routes. configure L7 route destinations. fix connection proto sequence numbers. * add timeout to L7 Route Destinations	1 year ago
Iryna Shustava	105ebfdd00	catalog, mesh: implement missing ACL hooks (#19143) ... This change adds ACL hooks to the remaining catalog and mesh resources, excluding any computed ones. Those will for now continue using the default operator:x permissions. It refactors a lot of the common testing functions so that they can be re-used between resources. There are also some types that we don't yet support (e.g. virtual IPs) that this change adds ACL hooks to for future-proofing.	1 year ago
Iryna Shustava	2ea33e9b86	mesh: add more validations to Destinations resource (#19202)	1 year ago
Iryna Shustava	e94d6ceca6	mesh: add validation hook to proxy configuration (#19186)	1 year ago
Ashwin Venkatesh	3d1a606c3b	Clone proto into deepcopy correctly (#19204)	1 year ago
R.B. Boyer	99f7a1219e	catalog: add metadata filtering to refine workload selectors (#19198) ... This implements the Filter field on pbcatalog.WorkloadSelector to be a post-fetch in-memory filter using the https://github.com/hashicorp/go-bexpr expression language to filter resources based on their envelope metadata fields. All existing usages of WorkloadSelector should be able to make use of the filter.	1 year ago
R.B. Boyer	f0e4897736	mesh: ensure that xRoutes have ParentRefs that have matching Tenancy to the enclosing resource (#19176) ... We don't want an xRoute controlling traffic for a Service in another tenancy.	1 year ago
Dhia Ayachi	5fbf0c00d3	Add namespace read write tests (#19173)	1 year ago
Ashwin Venkatesh	c2a0d4f9ca	Create DeepCopy() and Json Marshal/Unmarshal for proto-public (#19015) ... * Override Marshal/UnmarshalJSON for proto-public types * Generate Deepcopy() for proto-public types for Kubernetes CRDs.	1 year ago
Nitya Dhanushkodi	95d9b2c7e4	[NET-4931] xdsv2, sidecarproxycontroller, l4 trafficpermissions: support L7 (#19185) ... * xdsv2: support l7 by adding xfcc policy/headers, tweaking routes, and make a bunch of listeners l7 tests pass * sidecarproxycontroller: add l7 local app support * trafficpermissions: make l4 traffic permissions work on l7 workloads * rename route name field for consistency with l4 cluster name field * resolve conflicts and rebase * fix: ensure route name is used in l7 destination route name as well. previously it was only in the route names themselves, now the route name and l7 destination route name line up	1 year ago
Iryna Shustava	e3cb4ec35e	mesh: properly handle missing workload protocols (#19172) ... Sometimes workloads could come with unspecified protocols such as when running on Kubernetes. Currently, if this is the case, we will just default to tcp protocol. However, to make sidecar-proxy controller work with l7 protocols we should instead inherit the protocol from service. This change adds tracking for services that a workload is part of and attempts to inherit the protocol whenever services a workload is part of doesn't have conflicting protocols.	1 year ago
Iryna Shustava	a39eec0ef4	mesh: fix race in the sidecar-proxy controller test (#19183)	1 year ago
John Murret	dbca544d25	NET-5951 - Unique route names for implicit routes (#19174) ... * NET-5951 - Unique route names for implicit routes * remove use of datacenter * PR feedback	1 year ago
Iryna Shustava	54a12ab3c9	mesh: sidecar proxy controller improvements (#19083) ... This change builds on #19043 and #19067 and updates the sidecar controller to use those computed resources. This achieves several benefits: * The cache is now simplified which helps us solve for previous bugs (such as multiple Upstreams/Destinations targeting the same service would overwrite each other) * We no longer need proxy config cache * We no longer need to do merging of proxy configs as part of the controller logic * Controller watches are simplified because we no longer need to have complex mapping using cache and can instead use the simple ReplaceType mapper. It also makes several other improvements/refactors: * Unifies all caches into one. This is because originally the caches were more independent, however, now that they need to interact with each other it made sense to unify them where sidecar proxy controller uses one cache with 3 bimappers * Unifies cache and mappers. Mapper already needed all caches anyway and so it made sense to make the cache do the mapping also now that the cache is unified. * Gets rid of service endpoints watches. This was needed to get updates in a case when service's identities have changed and we need to update proxy state template's spiffe IDs for those destinations. This will however generate a lot of reconcile requests for this controller as service endpoints objects can change a lot because they contain workload's health status. This is solved by adding a status to the service object tracking "bound identities" and have service endpoints controller update it. Having service's status updated allows us to get updates in the sidecar proxy controller because it's already watching service objects * Add a watch for workloads. We need it so that we get updates if workload's ports change. This also ensures that we update cached identities in case workload's identity changes.	1 year ago