1907 Commits (a95974cf791c9ced09c322f4bbc2c0ac943a652c)

Author	SHA1	Message	Date
Mitchell Hashimoto	5d969e3cbb	command/connect/proxy: set ACL token based on proxy token flag	7 years ago
Mitchell Hashimoto	867db89303	command/connect/proxy: set proxy ID from env var if set	7 years ago
Paul Banks	1b197d934a	Don't allow connect watches in agent/cli yet	7 years ago
Paul Banks	e8c510332c	Support legacy watch.HandlerFunc type for backward compat reduces impact of change	7 years ago
Paul Banks	cd88b2a351	Basic `watch` support for connect proxy config and certificate endpoints. ... - Includes some bug fixes for previous `api` work and `agent` that weren't tested - Needed somewhat pervasive changes to support hash based blocking - some TODOs left in our watch toolchain that will explicitly fail on hash-based watches. - Integration into `connect` is partially done here but still WIP	7 years ago
Paul Banks	10db79c8ae	Rework connect/proxy and command/connect/proxy. End to end demo working again	7 years ago
Paul Banks	69d5efdbbd	Original proxy and connect.Client implementation. Working end to end.	7 years ago
Paul Banks	5f3d20c5cf	Merge pull request #4194 from hashicorp/fix-kv-del-validation ... Fix KV del command validation error	7 years ago
Matt Keeler	88a8c5e968	Merge pull request #4156 from hashicorp/enterprise-coexistence ... Enterprise/Licensing Cleanup	7 years ago
Paul Banks	378c37fadd	Fix KV del command validation error ... This has an explcit unit test already which somehow passes at least some of the time. I suspect it passes because under some conditions the actual KV delete fails and returns non-zero as well as printing the warning which is what is being checked for in the test. For some reason despite working for quite some time like this, I now have a branch in which this test fails consistently. It may be a timing/env issue where another process running an agent causes the delete to be successful so the command returns a 0 by chance. Either way this is clearly wrong and fixing it stops the test being flaky in my branch.	7 years ago
Kyle Havlovitz	03652a8519	command/agent: don't re-parse the flags on reload	7 years ago
Matt Keeler	2e7a37890c	Move data source loading into a command helpers function	7 years ago
Paul Banks	4de68fcb4b	Merge pull request #4016 from pierresouchay/support_for_prometheus ... Support for prometheus for metrics endpoint	7 years ago
Matt Keeler	63250c5d43	Merge pull request #4024 from jen20/signal-notify-once ... Only call signal.Notify once during agent startup	7 years ago
Kyle Havlovitz	af4be34a2a	Update make static-assets goal and run format	7 years ago
James Nugent	96f871862e	Only call signal.Notify once during agent startup ... Calling twice appears to have no adverse effects, however serves to confuse as to what the semantics of such code may be! This seems like it was probably introduced while resolving conflicts during the merge of the fix for #2404.	7 years ago
Pierre Souchay	93a01b0949	Now use prometheus_retention_time > 0 to enable prometheus support	7 years ago
Pierre Souchay	fd98fb1449	Added support exposing metrics in Prometheus format	7 years ago
Matt Keeler	48bd84073a	Address PR feedback	7 years ago
Matt Keeler	9f64d4856a	Update unit-tests to use requirements instead of manual checks.	7 years ago
Matt Keeler	92ceaaad81	Update case of member in comment	7 years ago
Matt Keeler	4e6f0f9a79	Formatting update	7 years ago
Matt Keeler	ada1252480	GH-3996: Add config-format flag to validate subcommand	7 years ago
Guido Iaquinti	8cd11d5888	Add package name to log output	7 years ago
Josh Soref	94835a2715	Spelling (#3958) ... * spelling: another * spelling: autopilot * spelling: beginning * spelling: circonus * spelling: default * spelling: definition * spelling: distance * spelling: encountered * spelling: enterprise * spelling: expands * spelling: exits * spelling: formatting * spelling: health * spelling: hierarchy * spelling: imposed * spelling: independence * spelling: inspect * spelling: last * spelling: latest * spelling: client * spelling: message * spelling: minimum * spelling: notify * spelling: nonexistent * spelling: operator * spelling: payload * spelling: preceded * spelling: prepared * spelling: programmatically * spelling: required * spelling: reconcile * spelling: responses * spelling: request * spelling: response * spelling: results * spelling: retrieve * spelling: service * spelling: significantly * spelling: specifies * spelling: supported * spelling: synchronization * spelling: synchronous * spelling: themselves * spelling: unexpected * spelling: validations * spelling: value	7 years ago
Paul Banks	de58eb1820	Fixes #3891: agent monitor no longer unresponsive before logs stream. ... The root cause is actually that the agent's streaming HTTP API didn't flush until the first log line was found which commonly was pretty soon since the default level is INFO. In cases where there were no logs immediately due to level for instance, the client gets stuck in the HTTP code waiting on a response packet from the server before we enter the loop that checks the shutdown channel from the signal handler. This fix flushes the initial status immediately on the streaming endpoint which lets the client code get into it's expected state where it's listening for shutdown or log lines.	7 years ago
Kyle Havlovitz	d16f103b48	Pull http config flag merge into public method	7 years ago
Veselkov Konstantin	7de57ba4de	remove golint warnings	7 years ago
Chad Whitacre	9ff59df34b	Fix typo	7 years ago
Kyle Havlovitz	a86d11ec0a	Merge pull request #3737 from hashicorp/autopilot-refactor ... Move autopilot to a standalone package	7 years ago
James Phillips	c676e6b8c8	Adds -base64 support to kv get command. ... Fixes #3736	7 years ago
Kyle Havlovitz	de28555671	Move autopilot to a standalone package	7 years ago
James Phillips	521e46ce91	Adds a registry mechanism for CLI commands.	7 years ago
Kyle Havlovitz	921d2e1469	Fix a panic in snapshot inspect command	7 years ago
Frank Schroeder	8f145559d8	Decouple the code that executes checks from the agent	7 years ago
Frank Schroeder	9872475167	agent: fix TestRetryJoin	7 years ago
Frank Schroeder	7d3467176b	agent: fix TestRetryJoinFail	7 years ago
Frank Schroeder	96a584dee2	agent: fix TestRetryJoinWanFail	7 years ago
Frank Schroeder	b97ab367f4	config: return error on extra command line arguments (#3397) ... The `consul agent` command was ignoring extra command line arguments which can lead to confusion when the user has for example forgotten to add a dash in front of an argument or is not using an `=` when setting boolean flags to `true`. `-bootstrap true` is not the same as `-bootstrap=true`, for example. Since all command line flags are known and we don't expect unparsed arguments we can return an error. However, this may make it slightly more difficult in the future if we ever wanted to have these kinds of arguments. Fixes #3397	7 years ago
James Phillips	ecee15b466	Updates documentation for consul validate. ... This makes it clear that you need to pass the full configuration, and that the command won't work with config fragments. Closes #3591	7 years ago
Frank Schroeder	9dec64dd17	commands: add shorter helper vars to keep fmt sane	7 years ago
Frank Schroeder	983e4aa0eb	commands: cleanup init	7 years ago
Frank Schroeder	b3292d13fb	commands: get HTTP API flags for usage automatically	7 years ago
Frank Schroeder	0cadee99ff	commands: drop http server flags from reload command	7 years ago
Frank Schroeder	cb96d1f126	commands: drop http server flags from leave command	7 years ago
Frank Schroeder	cb95cf2a34	commands: drop http server flags from keyring command	7 years ago
Frank Schroeder	1715cbd5de	commands: drop http server flags from force-leave command	7 years ago
Frank Schroeder	1b026de1db	commands: run all tests in parallel (again)	7 years ago
Frank Schroeder	56b24d3d4f	commands: cleanup help and synopsis. ... * move Help and Synopsis to bottom * make help and synopsis constants * make sure help output is formatted	7 years ago
Frank Schroeder	d54a5ef8d8	commands: do not run cmd tests in parallel ... Package level parallelization is sufficient.	7 years ago
Frank Schroeder	e5d08cf47d	commands: add missing noTabs test	7 years ago
Frank Schroeder	84a82cff3d	commands: cleanup test names	7 years ago
Frank Schroeder	5979723446	commands: cleanup catalog list services tests	7 years ago
Frank Schroeder	a03738c117	commands: cleanup catalog list nodes tests	7 years ago
Frank Schroeder	2530b9dd83	commands: simplify import names	7 years ago
Frank Schroeder	2bd8b070fb	commands: move operator subcommands to subdirs	7 years ago
Frank Schroeder	ce1ec000ca	commands: move kv subcommands to subdirs	7 years ago
Frank Schroeder	e16ef316d4	commands: move catalog subcommands to subdirs	7 years ago
Frank Schroeder	51799e5d23	commands: move snapshot subcommands to subdirs	7 years ago
Frank Schroeder	6bc5716336	commands: simplify commands.go	7 years ago
Frank Schroeder	2850f0f6d0	commands: drop base command and utils	7 years ago
Frank Schroeder	31d5fb7f47	commands: move agent command to separate pkg	7 years ago
Frank Schroeder	10e0be65a9	commands: move watch command to separate pkg	7 years ago
Frank Schroeder	8a0195ee99	add token and addr to http flags	7 years ago
Frank Schroeder	e2b686b982	commands: move snapshot save command to separate pkg	7 years ago
Frank Schroeder	fb1f09d447	commands: move snapshot restore command to separate pkg	7 years ago
Frank Schroeder	3acbc278f0	commands: move version command to separate pkg	7 years ago
Frank Schroeder	3a02ce9ebc	commands: move snapshot inspect command to separate pkg	7 years ago
Frank Schroeder	c8992cbe28	commands: move snapshot command to separate pkg	7 years ago
Frank Schroeder	4d6a0b94dd	commands: move rtt command to separate pkg	7 years ago
Frank Schroeder	566359234a	commands: move reload command to separate pkg	7 years ago
Frank Schroeder	4947ba7f3d	commands: move operator autopilot set command to separate pkg	7 years ago
Frank Schroeder	f719d78441	commands: move operator autopilot get command to separate pkg	7 years ago
Frank Schroeder	bd1b189990	commands: move operator autopilot command to separate pkg	7 years ago
Frank Schroeder	c50e43a4ea	commands: move operator list remove-peer command to separate pkg	7 years ago
Frank Schroeder	2a824f0575	commands: move operator raft list-peers command to separate pkg	7 years ago
Frank Schroeder	f10f07b448	commands: move operator raft command to separate pkg	7 years ago
Frank Schroeder	cc103391b2	commands: move operator command to separate pkg	7 years ago
Preetha Appan	1eec0e757c	Move monitor command to its own package	7 years ago
Preetha Appan	f389fe7757	Fix import order	7 years ago
Preetha Appan	5b6f0504ae	Move members command to its own package	7 years ago
Preetha Appan	ba546b0c1d	Move maint command to its own package	7 years ago
Preetha Appan	ff4d070bdf	Move lock command to its own package	7 years ago
Preetha Appan	85bc32f8a0	Fix leave and validate commands to build help string in constructor	7 years ago
Preetha Appan	71887d1709	Fix KV CLI subcommands to build help string in constructor	7 years ago
Preetha Appan	b1d5f99a58	Fix Keyring and keygen commands to build help string in constructor	7 years ago
Preetha Appan	85a834d008	Fix join command to build help string in constructor	7 years ago
Preetha Appan	a049dccd20	Fix up info and forceleave to build help string in constructor	7 years ago
Preetha Appan	55a1724b9e	s/initFlags/init/g	7 years ago
Preetha Appan	7689e1e5cd	Fix exec and event commands to build help string in constructor	7 years ago
Preetha Appan	a2519fb76f	Fix up catalog list services to build help string in constructor	7 years ago
Preetha Appan	2ed2c63a26	Fix up list datacenters to build help string in constructor	7 years ago
Preetha Appan	9d52f6ea92	Fix tests by calling initFlags for each test case to reset state.	7 years ago
Preetha Appan	4e31514df8	Better name for usage string and moving constant definition down	7 years ago
Preetha Appan	a3863c73d6	Construct the help string in constructor using helper function.	7 years ago
Frank Schroeder	0ec520582d	commands: move catalog list services to separate pkg	7 years ago
Frank Schroeder	117305eb4f	commands: move catalog list nodes command to separate pkg	7 years ago
Frank Schroeder	bd73c4cecf	commands: move catalog list datacenters command to separate pkg	7 years ago
Frank Schroeder	675e727224	commands: move catalog command to separate pkg	7 years ago
Frank Schroeder	9a9e5ef82d	commands: move leave command to separate pkg	7 years ago
Frank Schroeder	076361a37d	commands: move force-leave command to separate pkg	7 years ago
Frank Schroeder	631502009d	commands: move keyring command to separate pkg	7 years ago
Frank Schroeder	9e19207918	commands: move kv put command to separate pkg	7 years ago
Frank Schroeder	3377f46085	commands: move kv get command to separate pkg	7 years ago
Frank Schroeder	e1785a0e8f	commands: move kv import command to separate pkg	7 years ago
Frank Schroeder	cce364445e	commands: move export entry struct to separate pkg	7 years ago
Frank Schroeder	585b5b8d4e	commands: move kv export command to separate pkg	7 years ago
Frank Schroeder	5e3371eee1	commands: move kv delete command to separate pkg	7 years ago
Frank Schroeder	200199a875	commands: move kv command to separate pkg	7 years ago
Frank Schroeder	aca803ca8d	commands: move keygen command to separate pkg	7 years ago
Frank Schroeder	b1c5ee39a5	commands: move info command to separate pkg	7 years ago
Frank Schroeder	8a5836368e	commands: move rExec helper to bottom	7 years ago
Frank Schroeder	0ada23f92f	commands: move exec command to separate pkg	7 years ago
Frank Schroeder	85bfd8f339	commands: move event command to separate pkg	7 years ago
Frank Schroeder	d870c6289b	commands: move join command to separate pkg	7 years ago
Frank Schroeder	e0551b80a6	commands: move validate command to separate pkg	7 years ago
Frank Schroeder	cef6a80ae6	commands: move flag handling into flags pkg	7 years ago
Frank Schroeder	a49711b8bf	config: refactor commands to print help for flags (#3536) ... This patch refactors the commands that use the mitchellh/cli library to populate the command line flag set in both the Run() and the Help() method. Earlier versions of the mitchellh/cli library relied on the Run() method to populuate the flagset for generating the usage screen. This has changed in later versions and was previously solved with a small monkey patch to the library to restore the old behavior. However, this makes upgrading the library difficult since the patch has to be restored every time. This patch addresses this by moving the command line flags into an initFlags() method where appropriate and also moving all variables for the flags from the Run() method into the command itself. Fixes #3536	7 years ago
Ryan Slade	85e4aea9d1	Replace time.Now().Sub(x) with time.Since(x)	7 years ago
James Phillips	575d70aaa7	Cleans up some drift between the OSS and Enterprise trees.	7 years ago
Frank Schroeder	7bee8e644d	command: show full help text on usage	7 years ago
Frank Schroeder	bb13277ca1	command: do not merge flags in-place	7 years ago
Frank Schroeder	e769cd22f6	command: simplify duplicate code	7 years ago
Frank Schroeder	a364555121	command: drop hidden flags from base command	7 years ago
Frank Schroeder	bc78fa576a	command: drop unused hidden flags for 'validate'	7 years ago
Frank Schroeder	497d2702bf	command: drop legacy 'operator raft' tests	7 years ago
Frank Schroeder	4d604c5138	command: simplify 'operator raft' ... The cli library can handle subcommands. Therefore, most of the code is no longer necessary.	7 years ago
Frank Schroeder	3a7fb35fb0	command: don't show confusing error on usage output	7 years ago
Frank Schroeder	ce0d03c46a	command: drop deprecated 'configtest' command ... 'configtest' has been replaced with 'validate'	7 years ago
Kyle Havlovitz	adf29675f3	Merge pull request #3535 from hashicorp/metric-docs ... Update metric names and add a legacy config flag	7 years ago
Kyle Havlovitz	198ed6076d	Clean up subprocess handling and make shell use optional (#3509) ... * Clean up handling of subprocesses and make using a shell optional * Update docs for subprocess changes * Fix tests for new subprocess behavior * More cleanup of subprocesses * Minor adjustments and cleanup for subprocess logic * Makes the watch handler reload test use the new path. * Adds check tests for new args path, and updates existing tests to use new path. * Adds support for script args in Docker checks. * Fixes the sanitize unit test. * Adds panic for unknown watch type, and reverts back to Run(). * Adds shell option back to consul lock command. * Adds shell option back to consul exec command. * Adds shell back into consul watch command. * Refactors signal forwarding and makes Windows-friendly. * Adds a clarifying comment. * Changes error wording to a warning. * Scopes signals to interrupt and kill. This avoids us trying to send SIGCHILD to the dead process. * Adds an error for shell=false for consul exec. * Adds notes about the deprecated script and handler fields. * De-nests an if statement.	7 years ago
Kyle Havlovitz	c728564994	Update metric names and add a legacy config flag	7 years ago
Kyle Havlovitz	787787f904	Split BaseCommand http config into a separate function	7 years ago
Kyle Havlovitz	8b31eef467	Add base command option for hiding generated help for normal args	7 years ago
James Phillips	be92c6862d	Returns errors properly from the consul operator raft list-peers command.	7 years ago
Frank Schröder	e84c2b2edd	Metrics service prefix (#3498) ... * metrics: replace statsite_prefix with service_prefix The metrics prefix isn't statsite specific and is in fact used for all metrics providers. Since we are deprecating fields anyway we should fix this one as well. Fixes #3293 * Updates docs and sorts telemetry section. * Renames to "metrics_prefix" to disambiguate with Consul services. * Updates the change log.	7 years ago
Preetha Appan	3c4a108769	Move Raft protocol version for list peers end point to server side, fix unit tests. This fixes #3449	7 years ago
preetapan	73951d8319	Merge pull request #3494 from hashicorp/enforce_json_extension ... Enforce json or hcl extension to Consul config files, updated unit tests	7 years ago
James Phillips	45646ac3f4	Bumps default Raft protocol to version 3. (#3477) ... * Changes default Raft protocol to 3. * Changes numPeers() to report only voters. This should have been there before, but it's more obvious that this is incorrect now that we default the Raft protocol to 3, which puts new servers in a read-only state while Autopilot waits for them to become healthy. * Fixes TestLeader_RollRaftServer. * Fixes TestOperator_RaftRemovePeerByAddress. * Fixes TestServer_*. Relaxed the check for a given number of voter peers and instead do a thorough check that all servers see each other in their Raft configurations. * Fixes TestACL_*. These now just check for Raft replication to be set up, and don't care about the number of voter peers. * Fixes TestOperator_Raft_ListPeers. * Fixes TestAutopilot_CleanupDeadServerPeriodic. * Fixes TestCatalog_ListNodes_ConsistentRead_Fail. * Fixes TestLeader_ChangeServerID and adjusts the conn pool to throw away sockets when it sees io.EOF. * Changes version to 1.0.0 in the options doc. * Makes metrics test more deterministic with autopilot metrics possible.	7 years ago
Preetha Appan	a286ad7533	Enforce json or hcl extension to Consul config files, updated unit tests	7 years ago
Frank Schröder	12216583a1	New config parser, HCL support, multiple bind addrs (#3480) ... * new config parser for agent This patch implements a new config parser for the consul agent which makes the following changes to the previous implementation: * add HCL support * all configuration fragments in tests and for default config are expressed as HCL fragments * HCL fragments can be provided on the command line so that they can eventually replace the command line flags. * HCL/JSON fragments are parsed into a temporary Config structure which can be merged using reflection (all values are pointers). The existing merge logic of overwrite for values and append for slices has been preserved. * A single builder process generates a typed runtime configuration for the agent. The new implementation is more strict and fails in the builder process if no valid runtime configuration can be generated. Therefore, additional validations in other parts of the code should be removed. The builder also pre-computes all required network addresses so that no address/port magic should be required where the configuration is used and should therefore be removed. * Upgrade github.com/hashicorp/hcl to support int64 * improve error messages * fix directory permission test * Fix rtt test * Fix ForceLeave test * Skip performance test for now until we know what to do * Update github.com/hashicorp/memberlist to update log prefix * Make memberlist use the default logger * improve config error handling * do not fail on non-existing data-dir * experiment with non-uniform timeouts to get a handle on stalled leader elections * Run tests for packages separately to eliminate the spurious port conflicts * refactor private address detection and unify approach for ipv4 and ipv6. Fixes #2825 * do not allow unix sockets for DNS * improve bind and advertise addr error handling * go through builder using test coverage * minimal update to the docs * more coverage tests fixed * more tests * fix makefile * cleanup * fix port conflicts with external port server 'porter' * stop test server on error * do not run api test that change global ENV concurrently with the other tests * Run remaining api tests concurrently * no need for retry with the port number service * monkey patch race condition in go-sockaddr until we understand why that fails * monkey patch hcl decoder race condidtion until we understand why that fails * monkey patch spurious errors in strings.EqualFold from here * add test for hcl decoder race condition. Run with go test -parallel 128 * Increase timeout again * cleanup * don't log port allocations by default * use base command arg parsing to format help output properly * handle -dc deprecation case in Build * switch autopilot.max_trailing_logs to int * remove duplicate test case * remove unused methods * remove comments about flag/config value inconsistencies * switch got and want around since the error message was misleading. * Removes a stray debug log. * Removes a stray newline in imports. * Fixes TestACL_Version8. * Runs go fmt. * Adds a default case for unknown address types. * Reoders and reformats some imports. * Adds some comments and fixes typos. * Reorders imports. * add unix socket support for dns later * drop all deprecated flags and arguments * fix wrong field name * remove stray node-id file * drop unnecessary patch section in test * drop duplicate test * add test for LeaveOnTerm and SkipLeaveOnInt in client mode * drop "bla" and add clarifying comment for the test * split up tests to support enterprise/non-enterprise tests * drop raft multiplier and derive values during build phase * sanitize runtime config reflectively and add test * detect invalid config fields * fix tests with invalid config fields * use different values for wan sanitiziation test * drop recursor in favor of recursors * allow dns_config.udp_answer_limit to be zero * make sure tests run on machines with multiple ips * Fix failing tests in a few more places by providing a bind address in the test * Gets rid of skipped TestAgent_CheckPerformanceSettings and adds case for builder. * Add porter to server_test.go to make tests there less flaky * go fmt	7 years ago
James Phillips	00605c0214	Shows the segment name in the keyring API and command output.	7 years ago
James Phillips	d12b172a5d	Remaps servers to "<all>" only when listing multiple segments.	7 years ago
James Phillips	1a117ba0a8	Makes the all segments query explict, and the default for `consul members`.	7 years ago
James Phillips	74d635e9c6	Simplifies members command to not fetch segments.	7 years ago
Kyle Havlovitz	f8261330f0	Remove duplicate error message	7 years ago
Kyle Havlovitz	62102a537e	Organize segments for a cleaner split between enterprise and OSS	7 years ago
Kyle Havlovitz	7e565d7338	Fix some inconsistencies with segment logic and comments	7 years ago
Kyle Havlovitz	21513b0393	Update coord display in ui to account for segments	7 years ago
Kyle Havlovitz	d129767657	Add agent.segment interpolation to prepared queries	7 years ago
Kyle Havlovitz	2ada0439d4	Add rpc_listener option to segment config	7 years ago
James Phillips	b1a15e0c3d	Adds open source side of network segments (feature is Enterprise-only).	7 years ago
Frank Schroeder	831d84c940	build: make tests independent of build tags ... When the metadata server is scanning the agents for potential servers it is parsing the version number which the agent provided when it joined. This version number has to conform to a certain format, i.e. 'n.n.n'. Without this version number properly set some tests fail with error messages that disguise the root cause. The default version number is currently set to 'unknown' in version/version.go which does not parse and triggers the tests to fail. The work around is to use a build tag 'consul' which will use the version number set in version_base.go instead which has the correct format and is set to the current release version. In addition, some parts of the code also require the version number to be of a certain value. Setting it to '0.0.0' for example makes some tests pass and others fail since they don't pass the semantic check. When using go build/install/test one has to remember to use '-tags consul' or tests will fail with non-obvious error messages. Using build tags makes the build process more complex and error prone since it prevents the use of the plain go toolchain and - at least in its current form - introduces subtle build and test issues. We should try to eliminate build tags for anything else but platform specific code. This patch removes all references to specific version numbers in the code and tests and sets the default version to '9.9.9' which is syntactically correct and passes the semantic check. This solves the issue of running go build/install/test without tags for the OSS build.	7 years ago
wuxin	d6729243eb	fix command/kv_import.go help text (#3387)	7 years ago
Frank Schröder	4b642fed2f	agent: honor deprecated flags for retry-join-{ec2,azure,gce} (#3384)	7 years ago
Frank Schroeder	1acff3533e	agent: move agent/consul/structs to agent/structs	7 years ago
Kyle Havlovitz	d5634fe2a8	Add support for labels/filters from go-metrics	7 years ago
Frank Schroeder	2fac427cd4	agent: use github.com/hashicorp/go-discover ... Replace the provider specific node discovery code with go-discover to support AWS, Azure and GCE. Fixes #3282	7 years ago
Preetha Appan	840749db7e	Fix comments, and remove redundant TestConfig init from a couple of unit tests	7 years ago
Preetha Appan	aa98aeb4b1	Moved handling advertise address to readConfig and out of the agent's constructor, plus unit test fixes	7 years ago
Preetha Appan	25acd1534a	Move go-socketaddr template parsing into config package to make it happen before creating a new agent. Also removed redundant parsetemplate calls from agent.go.	7 years ago
James Phillips	08a8d9f2a7	command/lock: Add -child-exitcode, return 2 on child error (#3329) ... * Exit 2 if -child-exit-code and the child returned with an error. * There is no platform independent way to check the exact return code of * the child, so on error always return 2. * Closes #947 * Closes #1503	7 years ago
Kyle Havlovitz	9268849d11	Add UpgradeVersionTag to autopilot get/set commands	7 years ago
James Phillips	1791d99a10	Adds new config to make script checks opt-in, updates documentation. (#3284)	7 years ago
James Phillips	86918be323	Sort tags so output is deterministic.	7 years ago
Seth Vargo	afd83a9705	Add catalog CLI functions (#3204)	7 years ago
Frank Schroeder	406dc2ead8	command: make TestExecCommandRun_CrossDC more resilient ... Wait after WAN join that both members see each other.	8 years ago
James Phillips	f1bded7c5e	Removes unneeded shutdown channel in config reading tests.	8 years ago
James Phillips	6977e40077	Fixes watch tracking during reloads and fixes address issue. (#3189) ... This patch fixes watch registration through the config file and a broken log line when the watch registration fails. It also plumbs all the watch loading through a common function and tweaks the unit test to create the watch before the reload.	8 years ago
James Phillips	380c8b957d	Changes host-based node IDs from opt-out to opt-in. (#3187)	8 years ago
Jared Wasinger	3cdde3c7ca	Warn when attempting to bootstrap an even number of nodes (#3158) ... * Warn when attempting to bootstrap an even number of nodes. Addresses #1282 * add more detailed warning for two server case	8 years ago
Frank Schroeder	ea5b0f2c7c	agent: fix 'consul leave' shutdown race (#2880) ... When the agent is triggered to shutdown via an external 'consul leave' command delivered via the HTTP API then the client expects to receive a response when the agent is down. This creates a race on when to shutdown the agent itself like the RPC server, the checks and the state and the external endpoints like DNS and HTTP. This patch splits the shutdown process into two parts: * shutdown the agent * shutdown the endpoints (http and dns) They can be executed multiple times, concurrently and in any order but should be executed first agent, then endpoints to provide consistent behavior across all use cases. Both calls have to be executed for a proper shutdown. This could be partially hidden in a single function but would introduce some magic that happens behind the scenes which one has to know of but isn't obvious. Fixes #2880	8 years ago
James Phillips	6b2ad20131	Moves flag slice helper into configutil.	8 years ago
James Phillips	902f1ce16f	Moves config util helpers into their own package. (#3165)	8 years ago
Kyle Havlovitz	5d99ee80ca	Add an option to disable keyring file (#3145) ... Also disables keyring file in dev mode.	8 years ago
Frank Schroeder	1c75cf1af5	pkg refactor ... command/agent/* -> agent/* command/consul/* -> agent/consul/* command/agent/command{,_test}.go -> command/agent{,_test}.go command/base/command.go -> command/base.go command/base/* -> command/* commands.go -> command/commands.go The script which did the refactor is: ( cd $GOPATH/src/github.com/hashicorp/consul git mv command/agent/command.go command/agent.go git mv command/agent/command_test.go command/agent_test.go git mv command/agent/flag_slice_value{,_test}.go command/ git mv command/agent . git mv command/base/command.go command/base.go git mv command/base/config_util{,_test}.go command/ git mv commands.go command/ git mv consul agent rmdir command/base/ gsed -i -e 's|package agent|package command|' command/agent{,_test}.go gsed -i -e 's|package agent|package command|' command/flag_slice_value{,_test}.go gsed -i -e 's|package base|package command|' command/base.go command/config_util{,_test}.go gsed -i -e 's|package main|package command|' command/commands.go gsed -i -e 's|base.Command|BaseCommand|' command/commands.go gsed -i -e 's|agent.Command|AgentCommand|' command/commands.go gsed -i -e 's|\tCommand:|\tBaseCommand:|' command/commands.go gsed -i -e 's|base\.||' command/commands.go gsed -i -e 's|command\.||' command/commands.go gsed -i -e 's|command|c|' main.go gsed -i -e 's|range Commands|range command.Commands|' main.go gsed -i -e 's|Commands: Commands|Commands: command.Commands|' main.go gsed -i -e 's|base\.BoolValue|BoolValue|' command/operator_autopilot_set.go gsed -i -e 's|base\.DurationValue|DurationValue|' command/operator_autopilot_set.go gsed -i -e 's|base\.StringValue|StringValue|' command/operator_autopilot_set.go gsed -i -e 's|base\.UintValue|UintValue|' command/operator_autopilot_set.go gsed -i -e 's|\bCommand\b|BaseCommand|' command/base.go gsed -i -e 's|BaseCommand Options|Command Options|' command/base.go gsed -i -e 's|base.Command|BaseCommand|' command/*.go gsed -i -e 's|c\.Command|c.BaseCommand|g' command/*.go gsed -i -e 's|\tCommand:|\tBaseCommand:|' command/*_test.go gsed -i -e 's|base\.||' command/*_test.go gsed -i -e 's|\bCommand\b|AgentCommand|' command/agent{,_test}.go gsed -i -e 's|cmd.AgentCommand|cmd.BaseCommand|' command/agent.go gsed -i -e 's|cli.AgentCommand = new(Command)|cli.Command = new(AgentCommand)|' command/agent_test.go gsed -i -e 's|exec.AgentCommand|exec.Command|' command/agent_test.go gsed -i -e 's|exec.BaseCommand|exec.Command|' command/agent_test.go gsed -i -e 's|NewTestAgent|agent.NewTestAgent|' command/agent_test.go gsed -i -e 's|= TestConfig|= agent.TestConfig|' command/agent_test.go gsed -i -e 's|: RetryJoin|: agent.RetryJoin|' command/agent_test.go gsed -i -e 's|\.\./\.\./|../|' command/config_util_test.go gsed -i -e 's|\bverifyUniqueListeners|VerifyUniqueListeners|' agent/config{,_test}.go command/agent.go gsed -i -e 's|\bserfLANKeyring\b|SerfLANKeyring|g' agent/{agent,keyring,testagent}.go command/agent.go gsed -i -e 's|\bserfWANKeyring\b|SerfWANKeyring|g' agent/{agent,keyring,testagent}.go command/agent.go gsed -i -e 's|\bNewAgent\b|agent.New|g' command/agent{,_test}.go gsed -i -e 's|\bNewAgent|New|' agent/{acl_test,agent,testagent}.go gsed -i -e 's|\bAgent\b|agent.&|g' command/agent{,_test}.go gsed -i -e 's|\bBool\b|agent.&|g' command/agent{,_test}.go gsed -i -e 's|\bConfig\b|agent.&|g' command/agent{,_test}.go gsed -i -e 's|\bDefaultConfig\b|agent.&|g' command/agent{,_test}.go gsed -i -e 's|\bDevConfig\b|agent.&|g' command/agent{,_test}.go gsed -i -e 's|\bMergeConfig\b|agent.&|g' command/agent{,_test}.go gsed -i -e 's|\bReadConfigPaths\b|agent.&|g' command/agent{,_test}.go gsed -i -e 's|\bParseMetaPair\b|agent.&|g' command/agent{,_test}.go gsed -i -e 's|\bSerfLANKeyring\b|agent.&|g' command/agent{,_test}.go gsed -i -e 's|\bSerfWANKeyring\b|agent.&|g' command/agent{,_test}.go gsed -i -e 's|circonus\.agent|circonus|g' command/agent{,_test}.go gsed -i -e 's|logger\.agent|logger|g' command/agent{,_test}.go gsed -i -e 's|metrics\.agent|metrics|g' command/agent{,_test}.go gsed -i -e 's|// agent.Agent|// agent|' command/agent{,_test}.go gsed -i -e 's|a\.agent\.Config|a.Config|' command/agent{,_test}.go gsed -i -e 's|agent\.AppendSliceValue|AppendSliceValue|' command/{configtest,validate}.go gsed -i -e 's|consul/consul|agent/consul|' GNUmakefile gsed -i -e 's|\.\./test|../../test|' agent/consul/server_test.go # fix imports f=$(grep -rl 'github.com/hashicorp/consul/command/agent' * | grep '\.go') gsed -i -e 's|github.com/hashicorp/consul/command/agent|github.com/hashicorp/consul/agent|' $f goimports -w $f f=$(grep -rl 'github.com/hashicorp/consul/consul' * | grep '\.go') gsed -i -e 's|github.com/hashicorp/consul/consul|github.com/hashicorp/consul/agent/consul|' $f goimports -w $f goimports -w command/*.go main.go )	8 years ago
Frank Schroeder	9ceef2b32e	test: move discover tests	8 years ago
Frank Schroeder	d2ee591fbf	use 'c' as command receiver for simple commands	8 years ago
Frank Schroeder	902f4caff2	agent: move watch plans into agent	8 years ago
preetapan	2de032125b	Fixed regression with dns server start condition (#3137)	8 years ago
Seth Vargo	89f16984f9	Simplify	8 years ago
Seth Vargo	ee1b5d5024	Update comment	8 years ago
Seth Vargo	532f8d1435	Parse values given to ?passing in the API ... This PR fixes GH-2212 in the most backwards-compatible way I can think of. If the user does not pass a value for `?passing`, it's assumed to be true, which mirrors the current behavior. However, if the user passes any value for passing, that value is parsed as a bool using strconv. It's important to note that this is technically a breaking change. Previously using `?passing=false` would return only passing nodes. While this behavior is obviously incorrect, it was the previous behavior. We should call this out very clearly in the CHANGELOG.	8 years ago
James Phillips	86713c1b8a	Opens up timing bound on flaky test.	8 years ago
James Phillips	66ec9c7a7d	Fixes HTTP header compare by including standard headers.	8 years ago
Frank Schroeder	b5f8d6f9fd	agent: fix time.Duration parsing ... The duration can be passed as a string, a float64 or a time.Duration and this patch handles this properly.	8 years ago
Frank Schroeder	39d33c2fdc	agent: log events and exit code to the log file ... This patch logs the signals, events, errors and the exit code to the log file instead of printing it on the console. This should provide a more complete picture for debugging.	8 years ago
Frank Schroeder	4a223111d2	log: use prefix [ERR] instead of [ERROR]	8 years ago
James Phillips	fa8a26ad54	Updates static assets to latest.	8 years ago
James Phillips	a09eed585e	Merge pull request #3121 from hashicorp/increase-graceful-timeout ... agent: increase graceful shutdown timeout	8 years ago
Frank Schroeder	fe69de3bba	agent: increase graceful shutdown timeout ... When triggering a leave through an INT/TERM signal the hard-coded timeout of 5 seconds is too short to complete the leave successfully. Therefore, the agent always times out. This value should probably configurable.	8 years ago
Frank Schroeder	46c055d57b	agent: log differnt shutdown stages ... Log the different code paths during shutdown.	8 years ago
Frank Schröder	825f72f5ef	agent: support custom header and method for http checks (#3106) ... This patch adds support for custom headers and method for HTTP checks. Fixes #2474 Fixes #2657 Fixes #3106	8 years ago
Frank Schroeder	94b39557e8	test: refactor TestDecodeConfig test ... This patch refactors the multiple tests for DecodeConfig into a single table-driven test that tests most fields individually.	8 years ago
Frank Schroeder	325f82972a	test: Fix TestAgent_Reload ... This test was still referring to cmd.agent which has been removed.	8 years ago
James Phillips	240413f5d6	Merge pull request #3105 from hashicorp/test-stability ... Tweaks things for better test stability.	8 years ago
Frank Schroeder	51e0e158f1	agent: fix graceful http server shutdown	8 years ago
Frank Schroeder	ae711c3b04	agent: cleanup run method	8 years ago
Frank Schroeder	b203ffab29	agent: move registerWatches out of the run method	8 years ago
Frank Schroeder	11245e53a7	agent: move telemetry out of the run method	8 years ago
Frank Schroeder	84f5e8c3ab	agent: move update check out of the run method	8 years ago
Frank Schroeder	96d8035adc	agent: simplify signal handling	8 years ago
Frank Schroeder	34fd31b7b1	agent: move config reloading into the agent	8 years ago
Frank Schroeder	aa1519c9f7	agent: move parseMetaPair to config and export	8 years ago
Frank Schroeder	cb98754cd6	agent: remove agent from command ... Decouple command and agent a bit more.	8 years ago
Frank Schroeder	d977aa1fe7	agent: move retry join into agent	8 years ago
Frank Schroeder	55a513da2e	agent: add GossipEncrypted function ... Remove dead code and expose a GossipEncrypted() method on the agent instead of accessing the internal delegate.	8 years ago
James Phillips	b0b5df579f	Cleans up an unrelated vet error.	8 years ago
James Phillips	b4b5036dfb	Adds back the port shuffle on agent start retries.	8 years ago
Frank Schroeder	375825f34c	Do not recurse when the service address is a local cname ... Fixes #2795	8 years ago
Frank Schroeder	9956bc9b47	agent: LastContact cannot be negative (#3067) ... The X-Consul-LastContact header cannot be negative. Fixes #3067	8 years ago
Frank Schroeder	db15cd847a	test: replace one more BoolFalse with agent.Bool()	8 years ago
Frank Schroeder	dcc68f0f85	test: we will not use dev mode for testing for now	8 years ago
Frank Schroeder	f89ae9f7e7	test: stagger retry attempts of TestAgent.Start	8 years ago
Frank Schroeder	bdfed817ee	test: make TestAgent setup reusable ... Pick the random ports only once and try starting with them a number of times so that the configuration can be re-used. This is because the ports are written into the data files and a subsequent agent reading the files needs to have the same ports. For the same reason we do not remove the data directory on every attempt since this makes it impossible to re-read the data files.	8 years ago
Frank Schroeder	4034d0ac0b	agent: use agent logger for consul client and deps	8 years ago
Frank Schroeder	c1e6a77c75	test: start secondary agents also via TestAgent	8 years ago
Frank Schroeder	a9451d596f	agent: set tcpKeepAliveListener when there is no error	8 years ago
Frank Schroeder	345666bdb6	test: use test name as log prefix	8 years ago
Frank Schroeder	d6c7404b34	agent: simplify shutdown timeout logging ... Note that we are currently timing out every time. This still needs to be investigated.	8 years ago
Frank Schroeder	30ba712857	agent: set proto to http since we are logging it now	8 years ago
Frank Schroeder	ceda18366f	test: Use Bool() instead of &BoolTrue/False since	8 years ago
Frank Schroeder	ec729693d7	Address review comments	8 years ago
Frank Schroeder	26200929c1	agent: start HTTPS only if there is a cert and key	8 years ago
Frank Schroeder	b6c69ebf5d	agent: refactor DNS and HTTP server ... * refactor DNS server to be ready for multiple bind addresses * drop tcpKeepAliveListener since it is default for the HTTP servers * add startup timeout watcher for HTTP servers identical to DNS server	8 years ago
Frank Schroeder	aa92adcdd5	test: increase sleep time for test	8 years ago
Frank Schroeder	f498f24032	test: allow tests to control anti-entropy syncs	8 years ago
Frank Schroeder	eea16e1640	test: run mock dns recursors on random ports	8 years ago
Frank Schroeder	6148910399	test: skip tests that use cmd.Run until signal handling is fixed	8 years ago
Frank Schroeder	56cf015117	test: add test for starting/stopping lots of agents	8 years ago
Frank Schroeder	7c5892a196	test: use UniqueID prefix for check tests to unify log output	8 years ago
Frank Schroeder	0a31094e06	test: improve TestAgent ... * don't use retry to try restarting the agent this caused some issues when the startup would fail in a separate go routine * clear out the data directory on every retry since the ports are stored in the raft data files * set a unique id for every agent to allow for tracking of concurrent output	8 years ago
Frank Schroeder	10540f8d5f	agent: fix logging ... * use agent logger for consul/serf/raft/dns/agent/... * support optional id for concurrent tests	8 years ago
Frank Schroeder	fe777852cd	test: call t.Fatal() from main go routine	8 years ago
Frank Schroeder	3e39f04527	dns: do not log socket close during shutdown	8 years ago
Frank Schroeder	1df74e36bd	agent: print more useful shutdown message	8 years ago
Frank Schroeder	2e14c09447	test: start sync after agent start	8 years ago
Frank Schroeder	5b5566d916	test: add test name to output	8 years ago
Frank Schroeder	28ed8f1847	test: perform blocking query on agent	8 years ago
Frank Schroeder	ebc0c80f08	test: parallelize dns test	8 years ago
Frank Schroeder	72c214b908	test: fix failing test	8 years ago
Frank Schroeder	c5f565ee1a	test: remove output to stdout	8 years ago
Frank Schroeder	8f943542b0	test: use cli.NewMockUi instead of new(cli.MockUi) ... Use the constructor function to prevent a nil panic if there was no write to the output buffers.	8 years ago
Frank Schroeder	0325a42089	test: fix data race with endpoints	8 years ago
Frank Schroeder	e16589c079	agent: shutdown delegate if created ... When the TestAgent shuts down a half-started agent the delegate may not have been created at this point.	8 years ago
Frank Schroeder	632f837c98	agent: shutdown dns servers on error	8 years ago
Frank Schroeder	8c1a668481	test: Shutdown half-started agent before retrying	8 years ago
Frank Schroeder	584693482d	test: fix data race in MockNotify ... 42 -> 32 data races	8 years ago
Frank Schroeder	9509ab463c	test: run command tests in parallel	8 years ago
Frank Schroeder	3658d4d428	test: address pull request comments	8 years ago