consul

Commit Graph

Author	SHA1	Message	Date
James Phillips	483898abe5	Renames "prepared_query" ACL policy to "query".	9 years ago
James Phillips	67de77482e	Creates new "prepared-query" ACL type and new token capture behavior. Prior to this change, prepared queries had the following behavior for ACLs, which will need to change to support templates: 1. A management token, or a token with read access to the service being queried needed to be provided in order to create a prepared query. 2. The token used to create the prepared query was stored with the query in the state store and used to execute the query. 3. A management token, or the token used to create the query needed to be supplied to perform and CRUD operations on an existing prepared query. This was pretty subtle and complicated behavior, and won't work for templates since the service name is computed at execution time. To solve this, we introduce a new "prepared-query" ACL type, where the prefix applies to the query name for static prepared query types and to the prefix for template prepared query types. With this change, the new behavior is: 1. A management token, or a token with "prepared-query" write access to the query name or (soon) the given template prefix is required to do any CRUD operations on a prepared query, or to list prepared queries (the list is filtered by this ACL). 2. You will no longer need a management token to list prepared queries, but you will only be able to see prepared queries that you have access to (you get an empty list instead of permission denied). 3. When listing or getting a query, because it was easy to capture management tokens given the past behavior, this will always blank out the "Token" field (replacing the contents as <hidden>) for all tokens unless a management token is supplied. Going forward, we should discourage people from binding tokens for execution unless strictly necessary. 4. No token will be captured by default when a prepared query is created. If the user wishes to supply an execution token then can pass it in via the "Token" field in the prepared query definition. Otherwise, this field will default to empty. 5. At execution time, we will use the captured token if it exists with the prepared query definition, otherwise we will use the token that's passed in with the request, just like we do for other RPCs (or you can use the agent's configured token for DNS). 6. Prepared queries with no name (accessible only by ID) will not require ACLs to create or modify (execution time will depend on the service ACL configuration). Our argument here is that these are designed to be ephemeral and the IDs are as good as an ACL. Management tokens will be able to list all of these. These changes enable templates, but also enable delegation of authority to manage the prepared query namespace.	9 years ago
Ryan Uber	58c26497a9	acl: adding negative tests for bad policy	10 years ago
Ryan Uber	7e50a457d9	acl: allow omitting keyring policy, add tests	10 years ago
Ryan Uber	0c624350eb	acl: support for user events	10 years ago
Armon Dadgar	3695f65292	acl: Support for service policies	10 years ago
Armon Dadgar	05900f35c2	acl: Test parsing JSON	10 years ago
Armon Dadgar	50ba1f6067	acl: Change types	10 years ago
Armon Dadgar	1abfd6c050	acl: Adding cached policy fetch via ACL	10 years ago
Armon Dadgar	7a1d778474	acl: First pass	10 years ago

10 Commits (a7cfcc3634eb0b5e55f5389a68596310a2e1b09d)