9816 Commits (a7c479e0739ba7a4599e5ccda81ef53cec3ee3ad)

 

All Branches   

Search

Author	SHA1	Message	Date
John Cowen	a7c479e073	ui: Increases the pause between blocking queries to 2000ms (#5582) ... ...also: Temporarily overwrites native setTimeout and setInterval for e2e/acceptance testing similar to how XHR is overwritten for e2e/acceptance testing. This makes the blocking query acceptance tests run faster until we add a better burstable rate limiter for blocking queries.	6 years ago
John Cowen	4a9d259304	ui: Remove index.html from the docs URL so we just point to `/docs` (#5547)	6 years ago
John Cowen	a14a37a078	UI: Add support for blocking queries on the service instance detail page (#5487) ... This commit includes several pieces of functionality to enable services to be removed and the page to present information that this has happened but also keep the deleted information on the page. Along with the more usual blocking query based listing. To enable this: 1. Implements `meta` on the model (only available on collections in ember) 2. Adds new `catchable` ComputedProperty alongside a `listen` helper for working with specific errors that can be thrown from EventSources in an ember-like way. Briefly, normal computed properties update when a property changes, EventSources can additionally throw errors so we can catch them and show different visuals based on that. Also: Add support for blocking queries on the service instance detail page 1. Previous we could return undefined when a service instance has no proxy, but this means we have nothing to attach `meta` to. We've changed this to return an almost empty object, so with only a meta property. At first glance there doesn't seem to be any way to provide a proxy object to templates and be able to detect whether it is actually null or not so we instead change some conditional logic in the templates to detect the property we are using to generate the anchor. 2. Made a `pauseUntil` test helper function for steps where we wait for things. This helps for DRYness but also means if we can move away from setInterval to something else later, we can do it in one place 3. Whilst running into point 1 here, we managed to make the blocking queries eternally loop. Whilst this is due to an error in the code and shouldn't ever happen whilst in actual use, we've added an extra check so that we only recur/loop the blocking query if the previous response has a `meta.cursor` Adds support for blocking queries on the node detail page (#5489) 1. Moves data re-shaping for the templates variables into a repository so they are easily covered by blocking queries (into coordinatesRepo) 2. The node API returns a 404 as signal for deregistration, we also close the sessions and coordinates blocking queries when this happens	6 years ago
John Cowen	9daf8f53d9	ui: Adds blocking query support to the service detail page (#5479) ... This commit includes several pieces of functionality to enable services to be removed and the page to present information that this has happened but also keep the deleted information on the page. Along with the more usual blocking query based listing. To enable this: 1. Implements `meta` on the model (only available on collections in ember) 2. Adds new `catchable` ComputedProperty alongside a `listen` helper for working with specific errors that can be thrown from EventSources in an ember-like way. Briefly, normal computed properties update when a property changes, EventSources can additionally throw errors so we can catch them and show different visuals based on that.	6 years ago
John Cowen	e2df5de795	UI: Add blocking cursor validation and more straightforward throttle (#5470) ... More recommendations for blocking queries clients was added here: https://github.com/hashicorp/consul/pull/5358 This commit mainly adds cursor/index validation/correction based on these recommendations (plus tests) The recommendations also suggest that clients should include rate limiting. Because of this, we've moved the throttling out of Consul UI specific code and into Blocking Query specific code. Currently the 'rate limiting' in this commit only adds a sleep to every iteration of the loop, which is not the recommended approach, but the code here organizes the throttling functionality into something we can work with later to provide something more apt.	6 years ago
John Cowen	83cd4684c6	UI: Amends blocking queries text and toggle component in settings (#5467)	6 years ago
John Cowen	10c1f29ffa	ui: Add proxy icons to proxy services and instances where appropriate (#5463)	6 years ago
John Cowen	3d76540297	ui: Fix erroneous HTML that was being fixed by either browser/ember (#5530) ... The resulting DOM from this template was actually correct, we'd assume it was being fixed by the browser	6 years ago
John Cowen	5dd9cd2d2e	UI: Add forking based on service instance id existence (#5392) ... * ui: Add forking based on service instance id existence Proxies come in 2 flavours, 'normal' and sidecar. We know when a proxy is a sidecar proxy based on whether a DestinationServiceID is set. LocalServiceAddress and LocalServicePort are only relevant for sidecar proxies. This adds template logic to show different text depending on this information. Additionally adds test around connect proxies (#5418) 1. Adds page object for the instance detail page 2. Adds further scenario steps used in the tests 3. Adds acceptance testing around the instance detail page. Services with proxies and the sidecar proxies and proxies themselves 4. Adds datacenter column for upstreams 5. Fixes bug routing bug for decision as to whether to request proxy information or not	6 years ago
John Cowen	20e1a39aef	ui: remove call to super in setupController (#5383)	6 years ago
John Cowen	11ccea88e1	ui: Amend breakpoints for new numberless filter buttons (#5381)	6 years ago
John Cowen	18b0de2785	UI: Use custom block-slots for changeableset	6 years ago
John Cowen	8f35715e47	UI: Service Numbers (#5348) ... Add totals to some listing views, remove healthcheck totals 1. Adds markup to render totals for Services, Nodes, Intentions and v1 ACLs 2. Removes counts from healthcheck filters, and therefore simplify text, moving the copy to the templates 3. Alter test to reflect the fact that the text of the buttons are no static in the component template rather than a dynamic attribute	6 years ago
John Cowen	355f034822	UI: Service Instances (#5326) ... This gives more prominence to 'Service Instances' as opposed to 'Services'. It also begins to surface Connect related 'nouns' such as 'Proxies' and 'Upstreams' and begins to interconnect them giving more visibility to operators. Various smaller changes: 1. Move healthcheck-status component to healthcheck-output 2. Create a new healthcheck-status component for showing the number of checks plus its icon 3. Create a new healthcheck-info component to group multiple statuses plus a different view if there are no checks 4. Componentize tag-list	6 years ago
John Cowen	cfa4bc264e	UI: Add ember steps:list command for listing available steps (#5255) ... * ui: Add ember steps:list command for listing available steps 1. Adds `command` addon to house the new command 2. Start to organize out the steps themselves, bring a bit more order to things ready to dedupe and cleanup	6 years ago
John Cowen	cb0c5309c9	UI: Add EventSource ready for implementing blocking queries (#5070) ... - Maintain http headers as JSON-API meta for all API requests (#4946) - Add EventSource ready for implementing blocking queries - EventSource project implementation to enable blocking queries for service and node listings (#5267) - Add setting to enable/disable blocking queries (#5352)	6 years ago
John Cowen	f225da36f1	ui: Correctly rebase own token/no delete change	6 years ago
John Cowen	516610eb0b	ui: Adds XHR connection management to HTTP/1.1 installs (#5083) ... Adds xhr connection managment to http/1.1 installs This includes various things: 1. An object pool to 'acquire', 'release' and 'dispose' of objects, also a 'purge' to completely empty it 2. A `Request` data object, mainly for reasoning about the object better 3. A pseudo http 'client' which doens't actually control the request itself but does help to manage the connections An initializer is used to detect the script element of the consul-ui sourcecode which we use later to sniff the protocol that we are most likely using for API access	6 years ago
John Cowen	4d183ef743	ui: Adds 2 computed utilities, a factory and a purify (#5079) ... 1. The factory is taken from the ember source, but makes it more reusable 2. Purify converts conventional ember `computed` into a pure version This commit only adds new files that could be used further down the line	6 years ago
John Cowen	c71f718bc7	ui: Adds controller lifecycle `reset` hook (#5056)	6 years ago
John Cowen	2920f73ddd	ui: Adds `document` and `viewport` methods to the dom service (#5052) ... `window` and `document` are easily injected anyhow, but this primarily this keeps everything dom related in the same place. Included here are changes to make all ember related objects use the dom service `document` and `viewport` instead of just `document` and `window`. Quote from a previous PR (#4924) which explains the thinking around this: > Now I have all these things in the dom service, it would make sense to get window from there also. I was thinking of making a viewport method, which would be a nice word whether window was a browser window, an iframe (not really a window) like when ember testing, or anything else. To me the viewport is what we are actually talking about here.	6 years ago
John Cowen	ebfddaaace	ui: ember-data AbortError should have a `0` status (#5048)	6 years ago
John Cowen	bf50beff42	ui: Prefer `cursor` over `index`, add `configuration` option to repos (#5042)	6 years ago
John Cowen	338527cc2e	ui: Adds better error passthrough, disable/unauthorize properly on error (#5041) ... 1. Ensure any unexpected developer errors are passed through/shown 2. Previously when errors where returns/resolved the special isEnabled/isAuthorized would never get resolved. This was fine as they were set to false to start with anyway, but this resolves them again to false for completeness 3. Improved unit testing coverage	6 years ago
John Cowen	23a236ae95	ui: Adds warning flash messages (yellow with warning icon) (#5033)	6 years ago
John Cowen	acd121f988	ui: Rename extended Component variables, tweak some comments (#5021)	6 years ago
John Cowen	845081e871	ui: Resolve bad rebase and add in KV test for change of GET for KVs (#5000)	6 years ago
John Cowen	7fc59af7e2	ui: Pass GET data and clean certain values for KV's ensuring consistency (#4991)	6 years ago
John Cowen	7dc7d325dc	ui: Fixup tests to expect the new `meta` property on listings (#4990)	6 years ago
John Cowen	f7d2651ac3	ui: Maintain http headers as JSON-API meta for all API requests (#4946)	6 years ago
John Cowen	9ec7f3851b	UI: Use buttons instead of anchors where appropriate (#4939) ... Use buttons instead of anchors where appropriate	6 years ago
John Cowen	3780622df0	ui: Move intention source/destination menus use text from the template (#4938)	6 years ago
John Cowen	4368040a4a	UI: Move legacy ACLs, KVs and Intentions to use `form` functionality (#4936) ... Change legacy acls, kvs and intentions to use `form`s	6 years ago
John Cowen	104e6bac71	UI: Move legacy ACLs to use the new searchables/changeable-sets (#4933)	6 years ago
John Cowen	c532e53d9a	UI: dom usage refactoring (#4924) ... Move all the dom-things to use the dom service in tabular-collection, feedback-dialog, list-collection and node show. Move get-component-factory into utils/dom and use dom.root() in a few more places This includes an additional `dom.components` method which gives you a list of components matching the selector instead of just one.	6 years ago
John Cowen	d46b059673	UI: CSS Refactor (#4919) ... - Adds full set of svg icons as CSS/Sass variables to the source - Starts picking out some frame-grays, whilst commenting in possibles - Remove color prefixing The prefixes `ui-` and `brand-` for colors hav been removed. This makes colors slightly easier to type. In order to differentiate between brand colors and 'normal' colors, normal colors are named as 'true colors' i.e. blue, red, green etc etc whereas the brand colors used a more premium sounding name such as 'steel' for vault gray, 'magenta' for consul, 'cobalt' for vagrant etc etc.	6 years ago
John Cowen	3879487ab8	ui: Prefer using `notOk(actual)` instead of `ok(!actual)` in tests (#4925) ... And make sure its consistent throughout the app	6 years ago
John Cowen	d6c1b9ed3f	ui: Move ACL policy and token repos to use the RepositoryService (#4867)	6 years ago
John Cowen	c9fae76b7d	ui: Refactors the code-mirror linting/restrict legacy tokens to HCL (#4866)	6 years ago
John Cowen	65ef2969c7	ui: Async Search (#4859) ... This does several things to make improving the search experience easier moving forwards: 1. Separate searching off from filtering. 'Searching' can be thought of as specifically 'text searching' whilst filtering is more of a boolean/flag search. 2. Decouple the actual searching functionality to almost pure, isolated / unit testable units and unit test. (I still import embers get which, once I upgrade to 3.5, I shouldn't need) 3. Searching rules are now configurable from the outside, i.e. not wrapped in Controllers or Components. 4. General searching itself now can use an asynchronous approach based on events. This prepares for future possibilities of handing off the searching to a web worker or elsewhere, which should aid in large scale searching and prepares the way for other searching methods. 5. Adds the possibility of have multiple searches in one template/route/page. Additionally, this adds a WithSearching mixin to aid linking the searching to ember in an ember-like way in a single place. Plus a WithListeners mixin to aid with cleaning up of event listeners on Controller/Component destruction. Post-initial work I slightly changed the API of create listeners: Returning the handler from a `remover` means you can re-add it again if you want to, this avoids having to save a reference to the handler elsewhere to do the same. The `remove` method itself now returns an array of handlers, again you might want to use these again or something, and its also more useful then just returning an empty array. The more I look at this the more I doubt that you'll ever use `remove` to remove individual handlers, you may aswell just use the `remover` returned from add. I've added some comments to reflect this, but they'll likely be removed once I'm absolutely sure of this. I also added some comments for WithSearching to explain possible further work re: moving `searchParams` so it can be `hung` off the controller object	6 years ago
Matt Keeler	69f902608c	Update to use a consulent build tag instead of just ent (#5759)	6 years ago
Matt Keeler	3145bf5230	Centralized Config CLI (#5731) ... * Add HTTP endpoints for config entry management * Finish implementing decoding in the HTTP Config entry apply endpoint * Add CAS operation to the config entry apply endpoint Also use this for the bootstrapping and move the config entry decoding function into the structs package. * First pass at the API client for the config entries * Fixup some of the ConfigEntry APIs Return a singular response object instead of a list for the ConfigEntry.Get RPC. This gets plumbed through the HTTP API as well. Dont return QueryMeta in the JSON response for the config entry listing HTTP API. Instead just return a list of config entries. * Minor API client fixes * Attempt at some ConfigEntry api client tests These don’t currently work due to weak typing in JSON * Get some of the api client tests passing * Implement reflectwalk magic to correct JSON encoding a ProxyConfigEntry Also added a test for the HTTP endpoint that exposes the problem. However, since the test doesn’t actually do the JSON encode/decode its still failing. * Move MapWalk magic into a binary marshaller instead of JSON. * Add a MapWalk test * Get rid of unused func * Get rid of unused imports * Fixup some tests now that the decoding from msgpack coerces things into json compat types * Stub out most of the central config cli Fully implement the config read command. * Basic config delete command implementation * Implement config write command * Implement config list subcommand Not entirely sure about the output here. Its basically the read output indented with a line specifying the kind/name of each type which is also duplicated in the indented output. * Update command usage * Update some help usage formatting * Add the connect enable helper cli command * Update list command output * Rename the config entry API client methods. * Use renamed apis * Implement config write tests Stub the others with the noTabs tests. * Change list output format Now just simply output 1 line per named config * Add config read tests * Add invalid args write test. * Add config delete tests * Add config list tests * Add connect enable tests * Update some CLI commands to use CAS ops This also modifies the HTTP API for a write op to return a boolean indicating whether the value was written or not. * Fix up the HTTP API CAS tests as I realized they weren’t testing what they should. * Update config entry rpc tests to properly test CAS * Fix up a few more tests * Fix some tests that using ConfigEntries.Apply * Update config_write_test.go * Get rid of unused import	6 years ago
Matt Keeler	fe38042e33	Update CHANGELOG.md	6 years ago
Matt Keeler	f665695b6b	Ensure ServiceName is populated correctly for agent service checks ... Also update some snapshot agent docs * Enforce correct permissions when registering a check Previously we had attempted to enforce service:write for a check associated with a service instead of node:write on the agent but due to how we decoded the health check from the request it would never do it properly. This commit fixes that. * Update website/source/docs/commands/snapshot/agent.html.markdown.erb Co-Authored-By: mkeeler <mkeeler@users.noreply.github.com>	6 years ago
Matt Keeler	d0f410cd84	Make a few config entry endpoints return 404s and allow for snake_case and lowercase key names. (#5748)	6 years ago
Freddy	44e3dd79ff	go fmt runtime_test.go	6 years ago
Paul Banks	90c83e64ec	fix agent in connect docs	6 years ago
Freddy	d19eb36085	Restrict config file extensions read	6 years ago
Alvin Huang	b5d2de1727	fix redirects for acl-migrate-tokens (#5749)	6 years ago
Matt Keeler	4901166e65	Update CHANGELOG.md	6 years ago