consul

Tree: 9ef2156195

Author	SHA1	Message	Date
Frank Schroeder	1acff3533e	agent: move agent/consul/structs to agent/structs	7 years ago
Preetha Appan	aa98aeb4b1	Moved handling advertise address to readConfig and out of the agent's constructor, plus unit test fixes	7 years ago
Frank Schroeder	727b6444ad	dns: fix data races in DNS compression tests Make the DisableCompression value configurable at runtime to allow tests to change it without restarting/recreating the server.	7 years ago
Frank Schroeder	ea5b0f2c7c	agent: fix 'consul leave' shutdown race (#2880 ) When the agent is triggered to shutdown via an external 'consul leave' command delivered via the HTTP API then the client expects to receive a response when the agent is down. This creates a race on when to shutdown the agent itself like the RPC server, the checks and the state and the external endpoints like DNS and HTTP. This patch splits the shutdown process into two parts: * shutdown the agent * shutdown the endpoints (http and dns) They can be executed multiple times, concurrently and in any order but should be executed first agent, then endpoints to provide consistent behavior across all use cases. Both calls have to be executed for a proper shutdown. This could be partially hidden in a single function but would introduce some magic that happens behind the scenes which one has to know of but isn't obvious. Fixes #2880	8 years ago
Frank Schroeder	1c75cf1af5	pkg refactor command/agent/* -> agent/* command/consul/* -> agent/consul/* command/agent/command{,_test}.go -> command/agent{,_test}.go command/base/command.go -> command/base.go command/base/* -> command/* commands.go -> command/commands.go The script which did the refactor is: ( cd $GOPATH/src/github.com/hashicorp/consul git mv command/agent/command.go command/agent.go git mv command/agent/command_test.go command/agent_test.go git mv command/agent/flag_slice_value{,_test}.go command/ git mv command/agent . git mv command/base/command.go command/base.go git mv command/base/config_util{,_test}.go command/ git mv commands.go command/ git mv consul agent rmdir command/base/ gsed -i -e 's\|package agent\|package command\|' command/agent{,_test}.go gsed -i -e 's\|package agent\|package command\|' command/flag_slice_value{,_test}.go gsed -i -e 's\|package base\|package command\|' command/base.go command/config_util{,_test}.go gsed -i -e 's\|package main\|package command\|' command/commands.go gsed -i -e 's\|base.Command\|BaseCommand\|' command/commands.go gsed -i -e 's\|agent.Command\|AgentCommand\|' command/commands.go gsed -i -e 's\|\tCommand:\|\tBaseCommand:\|' command/commands.go gsed -i -e 's\|base\.\|\|' command/commands.go gsed -i -e 's\|command\.\|\|' command/commands.go gsed -i -e 's\|command\|c\|' main.go gsed -i -e 's\|range Commands\|range command.Commands\|' main.go gsed -i -e 's\|Commands: Commands\|Commands: command.Commands\|' main.go gsed -i -e 's\|base\.BoolValue\|BoolValue\|' command/operator_autopilot_set.go gsed -i -e 's\|base\.DurationValue\|DurationValue\|' command/operator_autopilot_set.go gsed -i -e 's\|base\.StringValue\|StringValue\|' command/operator_autopilot_set.go gsed -i -e 's\|base\.UintValue\|UintValue\|' command/operator_autopilot_set.go gsed -i -e 's\|\bCommand\b\|BaseCommand\|' command/base.go gsed -i -e 's\|BaseCommand Options\|Command Options\|' command/base.go gsed -i -e 's\|base.Command\|BaseCommand\|' command/.go gsed -i -e 's\|c\.Command\|c.BaseCommand\|g' command/.go gsed -i -e 's\|\tCommand:\|\tBaseCommand:\|' command/_test.go gsed -i -e 's\|base\.\|\|' command/_test.go gsed -i -e 's\|\bCommand\b\|AgentCommand\|' command/agent{,_test}.go gsed -i -e 's\|cmd.AgentCommand\|cmd.BaseCommand\|' command/agent.go gsed -i -e 's\|cli.AgentCommand = new(Command)\|cli.Command = new(AgentCommand)\|' command/agent_test.go gsed -i -e 's\|exec.AgentCommand\|exec.Command\|' command/agent_test.go gsed -i -e 's\|exec.BaseCommand\|exec.Command\|' command/agent_test.go gsed -i -e 's\|NewTestAgent\|agent.NewTestAgent\|' command/agent_test.go gsed -i -e 's\|= TestConfig\|= agent.TestConfig\|' command/agent_test.go gsed -i -e 's\|: RetryJoin\|: agent.RetryJoin\|' command/agent_test.go gsed -i -e 's\|\.\./\.\./\|../\|' command/config_util_test.go gsed -i -e 's\|\bverifyUniqueListeners\|VerifyUniqueListeners\|' agent/config{,_test}.go command/agent.go gsed -i -e 's\|\bserfLANKeyring\b\|SerfLANKeyring\|g' agent/{agent,keyring,testagent}.go command/agent.go gsed -i -e 's\|\bserfWANKeyring\b\|SerfWANKeyring\|g' agent/{agent,keyring,testagent}.go command/agent.go gsed -i -e 's\|\bNewAgent\b\|agent.New\|g' command/agent{,_test}.go gsed -i -e 's\|\bNewAgent\|New\|' agent/{acl_test,agent,testagent}.go gsed -i -e 's\|\bAgent\b\|agent.&\|g' command/agent{,_test}.go gsed -i -e 's\|\bBool\b\|agent.&\|g' command/agent{,_test}.go gsed -i -e 's\|\bConfig\b\|agent.&\|g' command/agent{,_test}.go gsed -i -e 's\|\bDefaultConfig\b\|agent.&\|g' command/agent{,_test}.go gsed -i -e 's\|\bDevConfig\b\|agent.&\|g' command/agent{,_test}.go gsed -i -e 's\|\bMergeConfig\b\|agent.&\|g' command/agent{,_test}.go gsed -i -e 's\|\bReadConfigPaths\b\|agent.&\|g' command/agent{,_test}.go gsed -i -e 's\|\bParseMetaPair\b\|agent.&\|g' command/agent{,_test}.go gsed -i -e 's\|\bSerfLANKeyring\b\|agent.&\|g' command/agent{,_test}.go gsed -i -e 's\|\bSerfWANKeyring\b\|agent.&\|g' command/agent{,_test}.go gsed -i -e 's\|circonus\.agent\|circonus\|g' command/agent{,_test}.go gsed -i -e 's\|logger\.agent\|logger\|g' command/agent{,_test}.go gsed -i -e 's\|metrics\.agent\|metrics\|g' command/agent{,_test}.go gsed -i -e 's\|// agent.Agent\|// agent\|' command/agent{,_test}.go gsed -i -e 's\|a\.agent\.Config\|a.Config\|' command/agent{,_test}.go gsed -i -e 's\|agent\.AppendSliceValue\|AppendSliceValue\|' command/{configtest,validate}.go gsed -i -e 's\|consul/consul\|agent/consul\|' GNUmakefile gsed -i -e 's\|\.\./test\|../../test\|' agent/consul/server_test.go # fix imports f=$(grep -rl 'github.com/hashicorp/consul/command/agent' * \| grep '\.go') gsed -i -e 's\|github.com/hashicorp/consul/command/agent\|github.com/hashicorp/consul/agent\|' $f goimports -w $f f=$(grep -rl 'github.com/hashicorp/consul/consul' * \| grep '\.go') gsed -i -e 's\|github.com/hashicorp/consul/consul\|github.com/hashicorp/consul/agent/consul\|' $f goimports -w $f goimports -w command/*.go main.go )	8 years ago
James Phillips	b4b5036dfb	Adds back the port shuffle on agent start retries.	8 years ago
Frank Schroeder	dcc68f0f85	test: we will not use dev mode for testing for now	8 years ago
Frank Schroeder	f89ae9f7e7	test: stagger retry attempts of TestAgent.Start	8 years ago
Frank Schroeder	bdfed817ee	test: make TestAgent setup reusable Pick the random ports only once and try starting with them a number of times so that the configuration can be re-used. This is because the ports are written into the data files and a subsequent agent reading the files needs to have the same ports. For the same reason we do not remove the data directory on every attempt since this makes it impossible to re-read the data files.	8 years ago
Frank Schroeder	345666bdb6	test: use test name as log prefix	8 years ago
Frank Schroeder	ceda18366f	test: Use Bool() instead of &BoolTrue/False since	8 years ago
Frank Schroeder	ec729693d7	Address review comments	8 years ago
Frank Schroeder	f498f24032	test: allow tests to control anti-entropy syncs	8 years ago
Frank Schroeder	eea16e1640	test: run mock dns recursors on random ports	8 years ago
Frank Schroeder	0a31094e06	test: improve TestAgent * don't use retry to try restarting the agent this caused some issues when the startup would fail in a separate go routine * clear out the data directory on every retry since the ports are stored in the raft data files * set a unique id for every agent to allow for tracking of concurrent output	8 years ago
Frank Schroeder	2e14c09447	test: start sync after agent start	8 years ago
Frank Schroeder	5b5566d916	test: add test name to output	8 years ago
Frank Schroeder	28ed8f1847	test: perform blocking query on agent	8 years ago
Frank Schroeder	8c1a668481	test: Shutdown half-started agent before retrying	8 years ago
Frank Schroeder	0f912c8aad	test: remove ACL options from default test config	8 years ago
Frank Schroeder	bc47972696	test: allocate ports in blocks of 10	8 years ago
Frank Schroeder	53c1c86ab3	test: refactor command tests to use TestAgent	8 years ago
Frank Schroeder	24eec373de	test: retry a bit more often	8 years ago
Frank Schroeder	141efd9588	test: rename *Config vars to 'cfg' 'c' is ambigous since Command also uses this and we want to use 'config' as a package name.	8 years ago
Frank Schroeder	06677708cf	test: use less aggressive retry for agent startup	8 years ago
Frank Schroeder	47501309ae	test: use system temp dir for TestAgent	8 years ago
Frank Schroeder	308f9929b3	test: run agent tests in parallel This brings down the test run from 108 sec to 15 sec. There is an occasional port conflict because of the nature the next port is chosen. So far it seems rare enough to live with it.	8 years ago
Frank Schroeder	b5b3aa1376	agent: add TestAgent to replace other mechanisms TestAgent will replace the following mechanisms to start test agents in subsequent requests: * makeAgentXXX * makeDNSServerXXX * makeHTTPServerXXX * testServer * httpTest	8 years ago

5 Commits (9ef2156195512ce58f8f809a0714df718f136362)