114 Commits (9a5a0ba20965dab1595de2b8e240bed2d9596e5f)

Author	SHA1	Message	Date
Daniel Nephin	55a677b7d1	rpcclient/health: integrate submatview.Store into rpcclient/health	4 years ago
Daniel Nephin	6f29fa0de8	rpcclient: move streaming cache tests	4 years ago
Daniel Nephin	832f1a2847	submatview: reduce the getFromView implementation ... Remove View.Result error return value, it was always nil, and seems like it will likely always remain nill since it is simply reading a stored value. Also replace some cache types with local types.	4 years ago
Daniel Nephin	c574108354	submatview: setup testing structure	4 years ago
Paul Banks	5529cb7347	Tune streaming backoff on errors to retry a bit faster when TCP connections drop	4 years ago
freddygv	f4f45af6d0	Merge master and fix upstream config protocol defaulting	4 years ago
freddygv	7892964a0c	Add cache-type for Internal.IntentionUpstreams	4 years ago
freddygv	acec711a6a	Update server-side config resolution and client-side merging	4 years ago
Daniel Nephin	71b0f0a7a6	structs: remove EnterpriseMeta.GetNamespace ... I added this recently without realizing that the method already existed and was named NamespaceOrEmpty. Replace all calls to GetNamespace with NamespaceOrEmpty or NamespaceOrDefault as appropriate.	4 years ago
Daniel Nephin	5c8a6311b6	Merge pull request #9703 from pierresouchay/streaming_tags_and_case_insensitive ... Streaming filter tags + case insensitive lookups for Service Names	4 years ago
Daniel Nephin	d1772ae305	structs: rename EnterpriseMeta constructor ... To match the Go convention.	4 years ago
Daniel Nephin	d5cc206e39	streaming: move ServiceTag and NodeMetaFiltering to the cache-entry ... So that all the client side filtering is in the same place. Previously only the bexpr filter was in the cache-entry. Also makes a small change to the filtering so that instead of rebuilding slices of items, the filtering can return a bool to determine if the event payload is saved or not.	4 years ago
Daniel Nephin	6b36ab744c	streaming: double the cache TTL ... 10 minutes is the default blocking query timeout. Using the same value results in us hitting the expired cache entry bug frequently. By extending this TTL we at least mitigate the problem. The underlying bug still needs to be fixed.	4 years ago
Daniel Nephin	b9e60c0775	testing: skip slow tests with -short ... Add a skip condition to all tests slower than 100ms. This change was made using `gotestsum tool slowest` with data from the last 3 CI runs of master. See https://github.com/gotestyourself/gotestsum#finding-and-skipping-slow-tests With this change: ``` $ time go test -count=1 -short ./agent ok github.com/hashicorp/consul/agent 0.743s real 0m4.791s $ time go test -count=1 -short ./agent/consul ok github.com/hashicorp/consul/agent/consul 4.229s real 0m8.769s ```	4 years ago
Pierre Souchay	76d95fd388	Applied suggestions from @dnephin ... * Renamed `cachedHealResultSorter` into `sortCheckServiceNodes` * Use `<` instead of `strings.Compare` * Single line comparison in unit test	4 years ago
Pierre Souchay	45151090c1	[Streaming] Predictable order for results of /health/service/:serviceName to mimic memdb ... This ensures the result is consitent with/witout streaming Will partially fix #9239	4 years ago
Daniel Nephin	9b2fae9bac	cache-type: use namespace in tests ... to verify that the namespace is passed through correctly to the server.	4 years ago
Daniel Nephin	c42fe5ae43	subscribe: set the request namespace	4 years ago
Daniel Nephin	68342a0cb5	proto: remove Event.Key field ... The field is never used, and the value is available from the payload.	4 years ago
Daniel Nephin	9a1e845be8	proto: remove Event.Namespace field ... All events are part of a single Topic, so we don't need this field.	4 years ago
Daniel Nephin	3c8929c7e1	streaming: apply filter to a single item ... Instead of the whole map. This should save a lot of time performing reflecting on a large map. The filter does not change, so there is no reason to re-apply it to older entries.	4 years ago
Daniel Nephin	ea77eccb14	Merge pull request #8825 from hashicorp/streaming/add-config ... streaming: add config and docs	4 years ago
Daniel Nephin	3ff6c5b3d3	cache-types: skip tests with races	4 years ago
Daniel Nephin	b5b790d4c0	streaming: Use a shorter LastGetTTL for the cache	4 years ago
Daniel Nephin	8b887af0d3	streaming: store services with a unique ID that includes namespace	4 years ago
Daniel Nephin	5972bdc87c	streaming: improve godoc for cache-type ... And fix a bug where any error that implemented the temporary interface was considered a temporary error, even when the method would return false.	4 years ago
Daniel Nephin	3fa08beecf	submatview: add a test for handling of NewSnapshotToFollow ... Also add some godoc Rename some vars and functions Fix a data race in the new cache test for entry closing.	4 years ago
Daniel Nephin	534d8b45bb	submatview: refactor Materializer ... Refactor of Materializer.Run Use handlers to manage state in Materializer Rename Materializer receiver rename m.l to m.lock, and flip some conditionals to remove the negative. Improve godoc, rename Deps, move resetErr, and pass err into notifyUpdate Update for NewSnapshotToFollow events Refactor to move context cancel out of Materializer	4 years ago
Daniel Nephin	e849f6d7ac	submatview: Move the 'use materialize from result.State' logic ... No need to do all this other work if we have one already. This logic moved closer to this call site 3 times during the process of refactoring.	4 years ago
Daniel Nephin	edf30b2714	submatview: Move Materializer to submatview package	4 years ago
Daniel Nephin	ed45957ffb	submatview: Refactor MaterializeView ... Replace InitFilter with Reset. Removes the need to store a fatalErr and the cache-type, and removes the need to recreate the filter each time. Pass dependencies into MaterializedView. Remove context from MaterializedView. Rename state to view. Rename MaterialziedView to Materialzier. Rename to NewMaterializer Pass in retry.Waiter	4 years ago
Daniel Nephin	b576a2d3c7	cache-types: Update Streaming health cache-type ... To use latest protobuf types	4 years ago
Daniel Nephin	132b76acef	agent/cache: Add cache-type and materialized view for streaming health ... Extracted from d97412ce4c Co-authored-by: Paul Banks <banks@banksco.de>	4 years ago
freddygv	7fd518ff1d	Merge master	4 years ago
freddygv	c8f5215e9d	Fix test build	4 years ago
Daniel Nephin	ba3ace1219	Return nil value on error. ... The main bug was fixed in cb050b280c, but the return value of 'result' is still misleading. Change the return value to nil to make the code more clear.	4 years ago
freddygv	aa6c59dbfc	end to end changes to pass gatewayservices to /ui/services/	4 years ago
Matt Keeler	be01c4241d	Default Cache rate limiting options in New ... Also get rid of the TestCache helper which was where these defaults were happening previously.	4 years ago
Matt Keeler	83d09de230	Fix some broken code in master ... There were several PRs that while all passed CI independently, when they all got merged into the same branch caused compilation errors in test code. The main changes that caused issues where changing agent/cache.Cache.New to require a concrete options struct instead of a pointer. This broke the cert monitor tests and the catalog_list_services_test.go. Another change was made to unembed the http.Server from the agent.HTTPServer struct. That coupled with another change to add a test to ensure cache rate limiting coming from HTTP requests was working as expected caused compilation failures.	4 years ago
Matt Keeler	12acdd7481	Disable background cache refresh for Connect Leaf Certs ... The rationale behind removing them is that all of our own code (xDS, builtin connect proxy) use the cache notification mechanism. This ensures that the blocking fetch behind the scenes is always executing. Therefore the only way you might go to get a certificate and have to wait is when 1) the request has never been made for that cert before or 2) you are using the v1/agent/connect/ca/leaf API for retrieving the cert yourself. In the first case, the refresh change doesn’t alter the behavior. In the second case, it can be mitigated by using blocking queries with that API which just like normal cache notification mechanism will cause the blocking fetch to be initiated and to get leaf certs as soon as needed. If you are not using blocking queries, or Envoy/xDS, or the builtin connect proxy but are retrieving the certs yourself then the HTTP endpoint might take a little longer to respond. This also renames the RefreshTimeout field on the register options to QueryTimeout to more accurately reflect that it is used for any type that supports blocking queries.	4 years ago
Daniel Nephin	2ec3760b70	agent/cache: Use AllowNotModifiedResponse in CatalogListServices ... Co-authored-by: Pierre Souchay <pierresouchay@users.noreply.github.com>	4 years ago
Matt Keeler	a5a9560bbd	Initialize the agent leaf cert cache result with a state to prevent unnecessary second certificate signing	4 years ago
Matt Keeler	39b567a55a	Fix auto_encrypt IP/DNS SANs ... The initial auto encrypt CSR wasn’t containing the user supplied IP and DNS SANs. This fixes that. Also We were configuring a default :: IP SAN. This should be ::1 instead and was fixed.	4 years ago
Daniel Nephin	5afcf5c1bc	Merge pull request #8034 from hashicorp/dnephin/add-linter-staticcheck-4 ... ci: enable SA4006 staticcheck check and add ineffassign	5 years ago
Daniel Nephin	068b43df90	Enable gofmt simplify ... Code changes done automatically with 'gofmt -s -w'	5 years ago
Daniel Nephin	cb050b280c	ci: enable SA4006 staticcheck check ... And fix the 'value not used' issues. Many of these are not bugs, but a few are tests not checking errors, and one appears to be a missed error in non-test code.	5 years ago
Matt Keeler	8837907de4	Make the Agent Cache more Context aware (#8092) ... Blocking queries issues will still be uncancellable (that cannot be helped until we get rid of net/rpc). However this makes it so that if calling getWithIndex (like during a cache Notify go routine) we can cancell the outer routine. Previously it would keep issuing more blocking queries until the result state actually changed.	5 years ago
freddygv	19e3954603	Move compound service names to use ServiceName type	5 years ago
freddygv	15c74d6943	Move GatewayServices out of Internal	5 years ago
Daniel Nephin	caa692deea	ci: Enabled SA2002 staticcheck check ... And handle errors in the main test goroutine	5 years ago