92 Commits (999426794f24a603327c432b5fb83ceff34ac2f4)

Author	SHA1	Message	Date
Aestek	f669bb7b0f	Add support for DNS config hot-reload (#4875) ... The DNS config parameters `recursors` and `dns_config.*` are now hot reloaded on SIGHUP or `consul reload` and do not need an agent restart to be modified. Config is stored in an atomic.Value and loaded at the beginning of each request. Reloading only affects requests that start _after_ the reload. Ongoing requests are not affected. To match the current behavior the recursor handler is loaded and unloaded as needed on config reload.	6 years ago
R.B. Boyer	f4a3b9d518	fix typos reported by golangci-lint:misspell (#5434)	6 years ago
Aestek	02f991843f	Fix race condition in DNS when using cache (#5398) ... * Fix race condition in DNS when using cache The healty node filtering was modifying the result from the cache, which caused a crash when multiple queries were made to the same service simultaneously. We now copy the node slice before filtering to ensure we do not modify the data stored in the cache. * Fix wording in dns cache config doc s/dns_max_age/cache_max_age/	6 years ago
Aestek	f1cdfbe40e	Allow DNS interface to use agent cache (#5300) ... Adds two new configuration parameters "dns_config.use_cache" and "dns_config.cache_max_age" controlling how DNS requests use the agent cache when querying servers.	6 years ago
Matt Keeler	1736e24fb3	Don't generate TXT records just to discard them (#5272) ... * Don't generate TXT records just to discard them * Add unit test for formatNodeRecord to ensure it prevents returning TXT records	6 years ago
Pierre Souchay	ae7f88f995	Avoid to have infinite recursion in DNS lookups when resolving CNAMEs (#4918) ... * Avoid to have infinite recursion in DNS lookups when resolving CNAMEs This will avoid killing Consul when a Service.Address is using CNAME to a Consul CNAME that creates an infinite recursion. This will fix https://github.com/hashicorp/consul/issues/4907 * Use maxRecursionLevel = 3 to allow several recursions	6 years ago
Paul Banks	b29bc906ee	bugfix: use ServiceTags to generate cache key hash (#4987) ... * bugfix: use ServiceTags to generate cahce key hash * update unit test * update * remote print log * Update .gitignore * Completely deprecate ServiceTag field internally for clarity * Add explicit test for CacheInfo cases	6 years ago
Pierre Souchay	fab55bee2b	dns: implements prefix lookups for DNS TTL (#4605) ... This will fix https://github.com/hashicorp/consul/issues/4509 and allow forinstance lb-* to match services lb-001 or lb-service-007.	6 years ago
Pierre Souchay	251156eb68	Added SOA configuration for DNS settings. (#4714) ... This will allow to fine TUNE SOA settings sent by Consul in DNS responses, for instance to be able to control negative ttl. Will fix: https://github.com/hashicorp/consul/issues/4713 # Example Override all settings: * min_ttl: 0 => 60s * retry: 600 (10m) => 300s (5 minutes), * expire: 86400 (24h) => 43200 (12h) * refresh: 3600 (1h) => 1800 (30 minutes) ``` consul agent -dev -hcl 'dns_config={soa={min_ttl=60,retry=300,expire=43200,refresh=1800}}' ``` Result: ``` dig +multiline @localhost -p 8600 service.consul ; <<>> DiG 9.12.1 <<>> +multiline @localhost -p 8600 service.consul ; (2 servers found) ;; global options: +cmd ;; Got answer: ;; ->>HEADER<<- opcode: QUERY, status: NXDOMAIN, id: 36557 ;; flags: qr aa rd; QUERY: 1, ANSWER: 0, AUTHORITY: 1, ADDITIONAL: 1 ;; WARNING: recursion requested but not available ;; OPT PSEUDOSECTION: ; EDNS: version: 0, flags:; udp: 4096 ;; QUESTION SECTION: ;service.consul. IN A ;; AUTHORITY SECTION: consul. 0 IN SOA ns.consul. hostmaster.consul. ( 1537959133 ; serial 1800 ; refresh (30 minutes) 300 ; retry (5 minutes) 43200 ; expire (12 hours) 60 ; minimum (1 minute) ) ;; Query time: 4 msec ;; SERVER: 127.0.0.1#8600(127.0.0.1) ;; WHEN: Wed Sep 26 12:52:13 CEST 2018 ;; MSG SIZE rcvd: 93 ```	6 years ago
Matt Keeler	d3ee66eed4	Add ECS option to EDNS responses where appropriate (#4647) ... This implements parts of RFC 7871 where Consul is acting as an authoritative name server (or forwarding resolver when recursors are configured) If ECS opt is present in the request we will mirror it back and return a response with a scope of 0 (global) or with the same prefix length as the request (indicating its valid specifically for that subnet). We only mirror the prefix-length (non-global) for prepared queries as those could potentially use nearness checks that could be affected by the subnet. In the future we could get more sophisticated with determining the scope bits and allow for better caching of prepared queries that don’t rely on nearness checks. The other thing this does not do is implement the part of the ECS RFC related to originating ECS headers when acting as a intermediate DNS server (forwarding resolver). That would take a quite a bit more effort and in general provide very little value. Consul will currently forward the ECS headers between recursors and the clients transparently, we just don't originate them for non-ECS clients to get potentially more accurate "location aware" results.	6 years ago
Pierre Souchay	eddcf228ea	Implementation of Weights Data structures (#4468) ... * Implementation of Weights Data structures Adding this datastructure will allow us to resolve the issues #1088 and #4198 This new structure defaults to values: ``` { Passing: 1, Warning: 0 } ``` Which means, use weight of 0 for a Service in Warning State while use Weight 1 for a Healthy Service. Thus it remains compatible with previous Consul versions. * Implemented weights for DNS SRV Records * DNS properly support agents with weight support while server does not (backwards compatibility) * Use Warning value of Weights of 1 by default When using DNS interface with only_passing = false, all nodes with non-Critical healthcheck used to have a weight value of 1. While having weight.Warning = 0 as default value, this is probably a bad idea as it breaks ascending compatibility. Thus, we put a default value of 1 to be consistent with existing behaviour. * Added documentation for new weight field in service description * Better documentation about weights as suggested by @banks * Return weight = 1 for unknown Check states as suggested by @banks * Fixed typo (of -> or) in error message as requested by @mkeeler * Fixed unstable unit test TestRetryJoin * Fixed unstable tests * Fixed wrong Fatalf format in `testrpc/wait.go` * Added notes regarding DNS SRV lookup limitations regarding number of instances * Documentation fixes and clarification regarding SRV records with weights as requested by @banks * Rephrase docs	6 years ago
Siva Prasad	865068a358	DNS : Fixes recursors answering the DNS query to properly return the correct response. (#4461) ... * Fixes the DNS recursor properly resolving the requests * Added a test case for the recursor bug * Refactored code && added a test case for all failing recursors * Inner indentation moved into else if check	6 years ago
Matt Keeler	0fd7e97c2d	Merge remote-tracking branch 'origin/master' into bugfix/prevent-multi-cname	6 years ago
Matt Keeler	cbf8f14451	Ensure TXT RRs always end up in the Additional section except for ANY or TXT queries ... This also changes where the enforcement of the enable_additional_node_meta_txt configuration gets applied. formatNodeRecord returns the main RRs and the meta/TXT RRs in separate slices. Its then up to the caller to add to the appropriate sections or not.	6 years ago
Matt Keeler	e3783a75e7	Refactor to make this much less confusing	6 years ago
Matt Keeler	554035974e	Add a bunch of comments about preventing multi-cname ... Hopefully this a bit clearer as to the reasoning	6 years ago
Matt Keeler	22c2be5bf1	Fix some edge cases and add some tests.	6 years ago
Matt Keeler	9a8500412b	Only allow 1 CNAME when querying for a service. ... This just makes sure that if multiple services are registered with unique service addresses that we don’t blast back multiple CNAMEs for the same service DNS name and keeps us within the DNS specs.	6 years ago
mkeeler	6813a99081	Merge remote-tracking branch 'connect/f-connect'	7 years ago
Kyle Havlovitz	050da22473	connect/ca: undo the interface changes and use sign-self-issued in Vault	7 years ago
Matt Keeler	8216816e3f	Make filtering out TXT RRs only apply when they would end up in Additional section ... ANY queries are no longer affected.	7 years ago
Mitchell Hashimoto	406366c45b	agent: working DNS for Connect queries, I think, but have to ... implement Health endpoints to be sure	7 years ago
Matt Keeler	6cc0422408	Add configuration entry to control including TXT records for node meta in DNS responses ... If set to false, the only way to retrieve TXT records for node meta is to specifically query for TXT records.	7 years ago
Matt Keeler	27fe219918	Merge pull request #4131 from pierresouchay/enable_full_dns_compression ... Enable full dns compression	7 years ago
Pierre Souchay	fa37f262eb	Fixed comments for max DNS records returned as requested by @mkeeler	7 years ago
Wim	d10e6d0292	Do reverse service lookup only if address doesn't match node	7 years ago
Wim	5c04864b28	Add support for reverse lookup of services	7 years ago
Pierre Souchay	486417a0fc	Ensure to never send messages more than 64k	7 years ago
Pierre Souchay	cfa5986df7	Fixed unit tests and updated limits	7 years ago
Pierre Souchay	6e80b6b127	Re-Enable compression while computing Len(), so we can send more answers ... This will fix https://github.com/hashicorp/consul/issues/4071	7 years ago
Kyle Havlovitz	ba3971d2c1	Remove deprecated metric names	7 years ago
Pierre Souchay	076ecf9712	Removed unecessary copy of Extra and index	7 years ago
Pierre Souchay	728c5308df	Fixed sync of Extra in binarySearch	7 years ago
Pierre Souchay	fadfb95e07	Added Unit tests + fixed boudary limit	7 years ago
Pierre Souchay	c838376dfa	Added comment for function dnsBinaryTruncate	7 years ago
Pierre Souchay	94c0bf978a	Perform a binary search to find optimal size of DNS responses ... Will fix https://github.com/hashicorp/consul/issues/4036 Instead of removing one by one the entries, find the optimal size using binary search. For SRV records, with 5k nodes, duration of DNS lookups is divided by 4 or more.	7 years ago
Kyle Havlovitz	af4be34a2a	Update make static-assets goal and run format	7 years ago
Matt Keeler	0619efc254	GH-3798: More PR Updates ... Update docs a little Update/add tests. Make sure all the various ways of determining the source IP work Update X-Forwarded-For header parsing. This can be a comma separated list with the first element being the original IP so we now handle csv data there. Got rid of error return from sourceAddrFromRequest	7 years ago
Matt Keeler	cec8d5145b	GH-3798: A few more PR updates	7 years ago
Matt Keeler	d065d3a6db	GH-3798: Updates for PR ... Allow DNS peer IP as the source IP. Break early when the right node was found for executing the preapred query. Update docs	7 years ago
Matt Keeler	45a537def9	GH-3798: Add near=_ip support for prepared queries	7 years ago
Matt Keeler	27899f9f46	Merge pull request #3948 from pierresouchay/fix_tcp_dns_limit ... [BUGFIX] do not break when TCP DNS answer exceeds 64k	7 years ago
Matt Keeler	ebc6f414ac	Formatting update	7 years ago
Matt Keeler	3facce6bfa	GH-3854: Warn when node name isnt a valid DNS label	7 years ago
Pierre Souchay	93fa1f6f49	Optimize size for SRV records, should improve performance a bit ... Stricter Unit tests that checks if truncation was OK.	7 years ago
Pierre Souchay	ce3f47a75d	Performance optimization for services having more than 2k records	7 years ago
Pierre Souchay	7d59249d96	Avoid issue with compression of DNS messages causing overflow	7 years ago
Pierre Souchay	b77fd5ce9d	64000 max limit to DNS messages since there is overhead ... Added debug log to give information about truncation.	7 years ago
Pierre Souchay	be39fb20cc	[BUGFIX] do not break when TCP DNS answer exceeds 64k ... It will avoid having discovery broken when having large number of instances of a service (works with SRV and A* records). Fixes https://github.com/hashicorp/consul/issues/3850	7 years ago
Pierre Souchay	0b7f620dc6	Allow to control the number of A/AAAA Record returned by DNS ... This allows to have randomized resource records (i.e. each answer contains only one IP, but the IP changes every request) for A, AAAA records. It will fix https://github.com/hashicorp/consul/issues/3355 and https://github.com/hashicorp/consul/issues/3937 See https://github.com/hashicorp/consul/issues/3937#issuecomment-370610509 for details. It basically add a new option called `a_record_limit` and will not return more than a_record_limit when performing A, AAAA or ANY DNS requests. The existing `udp_answer_limit` option is still working but should be considered as deprecated since it works only with DNS clients not supporting EDNS.	7 years ago