3217 Commits (8b1217417a7248995049bf7b5ad855752f3b2fb8)

Author	SHA1	Message	Date
Mark Anderson	8b1217417a	First changes for unix domain sockets upstreams ... Start making structure changes to support unix domain socket address for upstreams upstreams = [ { destination_name = "echo-service" local_bind_socket_path = "/tmp/upstream.sock" config { passive_health_check { interval = "10s" max_failures = 42 } } } Signed-off-by: Mark Anderson <manderson@hashicorp.com>	4 years ago
Daniel Nephin	6713afdff3	lint: fix warning by removing reference to deprecated interface	4 years ago
hc-github-team-consul-core	8f9d5c8eef	auto-updated agent/uiserver/bindata_assetfs.go from commit 07e11f32e	4 years ago
hc-github-team-consul-core	fade7e6583	auto-updated agent/uiserver/bindata_assetfs.go from commit fc7fe23b4	4 years ago
Freddy	ed1082510d	Fixup discovery chain handling in transparent mode (#10168) ... Co-authored-by: R.B. Boyer <4903+rboyer@users.noreply.github.com> Previously we would associate the address of a discovery chain target with the discovery chain's filter chain. This was broken for a few reasons: - If the upstream is a virtual service, the client proxy has no way of dialing it because virtual services are not targets of their discovery chains. The targets are distinct services. This is addressed by watching the endpoints of all upstream services, not just their discovery chain targets. - If multiple discovery chains resolve to the same target, that would lead to multiple filter chains attempting to match on the target's virtual IP. This is addressed by only matching on the upstream's virtual IP. NOTE: this implementation requires an intention to the redirecting virtual service and not just to the final destination. This is how we can know that the virtual service is an upstream to watch. A later PR will look into traversing discovery chains when computing upstreams so that intentions are only required to the discovery chain targets.	4 years ago
Paul Banks	3ad754ca7b	Make Raft trailing logs and snapshot timing reloadable (#10129) ... * WIP reloadable raft config * Pre-define new raft gauges * Update go-metrics to change gauge reset behaviour * Update raft to pull in new metric and reloadable config * Add snapshot persistance timing and installSnapshot to our 'protected' list as they can be infrequent but are important * Update telemetry docs * Update config and telemetry docs * Add note to oldestLogAge on when it is visible * Add changelog entry * Update website/content/docs/agent/options.mdx Co-authored-by: Matt Keeler <mkeeler@users.noreply.github.com> Co-authored-by: Matt Keeler <mkeeler@users.noreply.github.com>	4 years ago
Luke Kysow	8d6cbe7281	Give descriptive error if auth method not found (#10163) ... * Give descriptive error if auth method not found Previously during a `consul login -method=blah`, if the auth method was not found, the error returned would be "ACL not found". This is potentially confusing because there may be many different ACLs involved in a login: the ACL of the Consul client, perhaps the binding rule or the auth method. Now the error will be "auth method blah not found", which is much easier to debug.	4 years ago
Freddy	2ca3f481f8	Only consider virtual IPs for transparent proxies (#10162) ... Initially we were loading every potential upstream address into Envoy and then routing traffic to the logical upstream service. The downside of this behavior is that traffic meant to go to a specific instance would be load balanced across ALL instances. Traffic to specific instance IPs should be forwarded to the original destination and if it's a destination in the mesh then we should ensure the appropriate certificates are used. This PR makes transparent proxying a Kubernetes-only feature for now since support for other environments requires generating virtual IPs, and Consul does not do that at the moment.	4 years ago
hc-github-team-consul-core	a37c1e8466	auto-updated agent/uiserver/bindata_assetfs.go from commit 211bc824a	4 years ago
Daniel Nephin	00d3283e93	Merge pull request #10149 from hashicorp/dnephin/config-use-streaming-backend-defualt-true ... config: default UseStreamingBackend to true	4 years ago
R.B. Boyer	abc1dc0fe9	connect: update supported envoy versions to 1.18.2, 1.17.2, 1.16.3, and 1.15.4 (#10101) ... The only thing that needed fixing up pertained to this section of the 1.18.x release notes: > grpc_stats: the default value for stats_for_all_methods is switched from true to false, in order to avoid possible memory exhaustion due to an untrusted downstream sending a large number of unique method names. The previous default value was deprecated in version 1.14.0. This only changes the behavior when the value is not set. The previous behavior can be used by setting the value to true. This behavior change by be overridden by setting runtime feature envoy.deprecated_features.grpc_stats_filter_enable_stats_for_all_methods_by_default. For now to maintain status-quo I'm explicitly setting `stats_for_all_methods=true` in all versions to avoid relying upon the default. Additionally the naming of the emitted metrics for these gRPC requests changed slightly so the integration test assertions for `case-grpc` needed adjusting.	4 years ago
R.B. Boyer	85a718da63	xds: ensure that all envoyproxy/go-control-plane protobuf symbols are linked into the final binary (#10131) ... This ensures that if someone does include some extension Consul does not currently make use of, that extension is actually usable. Without linking these envoy protobufs into the main binary it can't round trip the escape hatches to send them down to envoy. Whenenver the go-control-plane library is upgraded next we just have to re-run 'make envoy-library'.	4 years ago
R.B. Boyer	71d45a3460	Support Incremental xDS mode (#9855) ... This adds support for the Incremental xDS protocol when using xDS v3. This is best reviewed commit-by-commit and will not be squashed when merged. Union of all commit messages follows to give an overarching summary: xds: exclusively support incremental xDS when using xDS v3 Attempts to use SoTW via v3 will fail, much like attempts to use incremental via v2 will fail. Work around a strange older envoy behavior involving empty CDS responses over incremental xDS. xds: various cleanups and refactors that don't strictly concern the addition of incremental xDS support Dissolve the connectionInfo struct in favor of per-connection ResourceGenerators instead. Do a better job of ensuring the xds code uses a well configured logger that accurately describes the connected client. xds: pull out checkStreamACLs method in advance of a later commit xds: rewrite SoTW xDS protocol tests to use protobufs rather than hand-rolled json strings In the test we very lightly reuse some of the more boring protobuf construction helper code that is also technically under test. The important thing of the protocol tests is testing the protocol. The actual inputs and outputs are largely already handled by the xds golden output tests now so these protocol tests don't have to do double-duty. This also updates the SoTW protocol test to exclusively use xDS v2 which is the only variant of SoTW that will be supported in Consul 1.10. xds: default xds.Server.AuthCheckFrequency at use-time instead of construction-time	4 years ago
hc-github-team-consul-core	cbabf82587	auto-updated agent/uiserver/bindata_assetfs.go from commit 5d89ba031	4 years ago
Freddy	701b49f772	Rename cluster config files to mesh as well (#10148)	4 years ago
Daniel Nephin	bb472111fd	config: default UseStreamingBackend to true	4 years ago
Freddy	078c40425f	Rename "cluster" config entry to "mesh" (#10127) ... This config entry is being renamed primarily because in k8s the name cluster could be confusing given that the config entry applies across federated datacenters. Additionally, this config entry will only apply to Consul as a service mesh, so the more generic "cluster" name is not needed.	4 years ago
Daniel Nephin	9b344b3300	Merge pull request #10112 from hashicorp/dnephin/remove-streaming-from-cache ... streaming: replace agent/cache with submatview.Store	4 years ago
Daniel Nephin	3a27fce2ad	submatview: fix godoc and comment typos ... Co-authored-by: Paul Banks <banks@banksco.de>	4 years ago
hc-github-team-consul-core	4ad37c326e	auto-updated agent/uiserver/bindata_assetfs.go from commit 345765f76	4 years ago
Daniel Nephin	11398892b3	submatview: avoid sorting results unnecessarily ... Previous getFromView would call view.Result when the result may not have been returned (because the index is updated past the minIndex. This would allocate a slice and sort it for no reason, because the values would never be returned. Fix this by re-ordering the operations in getFromView. The test changes in this commit were an attempt to cover the case where an update is received but the index does not exceed the minIndex.	4 years ago
Daniel Nephin	23e1cd6f93	submatview: only return materializer from getEntry ... Also rename it to readEntry now that it doesn't return the entire entry. Based on feedback in PR review, the full entry is not used by the caller, and accessing the fields wouldn't be safe outside the lock, so it is safer to return only the Materializer	4 years ago
Daniel Nephin	46b7d0b573	submatview: godoc	4 years ago
Daniel Nephin	d9537411b8	rpcclient/health: convert tests to the new submatview.Store interface ... Also fixes a minor data race in Materializer. Capture the error before releasing the lock.	4 years ago
Daniel Nephin	79a54f208e	agent: fix data race in tests caused by grpc log init ... grpclog.SetLoggerV2 is meant to be called only once before any gRPC requests are received, but each test that uses TestAgent will call NewBaseDeps again. Use a sync.Once to prevent the grpc logging from being re-initialized by each test. This will mean that a test can't use a fake logger to capture logs from the gRPC server.	4 years ago
Daniel Nephin	dacf50038d	submatview: fix two flaky tests ... These tests can flake when we get a notification for an earlier event. Retry the read from update channel a few times to make sure we get the event we expect.	4 years ago
Daniel Nephin	c932833acb	rpcclient:health: fix a data race and flake in tests ... Split the TestStreamingClient into the two logical components the real client uses. This allows us to test multiple clients properly. Previously writing of ctx from multiple Subscribe calls was showing a data race. Once this was fixed a test started to fail because the request had to be made with a greater index, so that the store.Get call did not return immediately.	4 years ago
Daniel Nephin	5fa0dea63a	rpcclient/health: fix data race in a test ... The idleTTL was being written and read concurrently. Instead move the idleTTL to a struct field so that when one test patches the TTL it does not impact others. The background goroutines for the store can outlive a test because context cancellation is async.	4 years ago
Daniel Nephin	10ec9c2be3	rpcclient: close the grpc.ClientConn on shutdown	4 years ago
Daniel Nephin	e229b877d8	health: create health.Client in Agent.New	4 years ago
Daniel Nephin	a16c377ca7	rpcclient/health: move all backend routing logic to client	4 years ago
Daniel Nephin	0558586dbd	health: use blocking queries for near query parameter	4 years ago
Daniel Nephin	2a26085b2c	connect: do not set QuerySource.Node ... Setting this field to a value is equivalent to using the 'near' query paramter. The intent is to sort the results by proximity to the node requesting them. However with connect we send the results to envoy, which doesn't care about the order, so setting this field is increasing the work performed for no gain. It is necessary to unset this field now because we would like connect to use streaming, but streaming does not support sorting by proximity.	4 years ago
Daniel Nephin	4fb2ba9de7	submatview: move error return to NewMaterializer ... So that we don't have to create views ahead of time, when we will never use that view.	4 years ago
Daniel Nephin	55a677b7d1	rpcclient/health: integrate submatview.Store into rpcclient/health	4 years ago
Daniel Nephin	6f29fa0de8	rpcclient: move streaming cache tests	4 years ago
Daniel Nephin	6ebb0f8b74	submatview: test Store.Run	4 years ago
Daniel Nephin	9854c424eb	submatview: test store with Get and Notify calls together	4 years ago
Daniel Nephin	c1063999fc	submatview: more test cases for Store.Get ... And simplify the return value by using a Result type.	4 years ago
Daniel Nephin	832f1a2847	submatview: reduce the getFromView implementation ... Remove View.Result error return value, it was always nil, and seems like it will likely always remain nill since it is simply reading a stored value. Also replace some cache types with local types.	4 years ago
Daniel Nephin	1d9d7d0aa5	submatview: track requests instead of notifiers ... And only start expiration time when the last request ends. This makes tracking expiry simpler, and ensures that no entry can be expired while there are active requests.	4 years ago
Daniel Nephin	7d13465c7b	submatview: set up expiry of materializers	4 years ago
Daniel Nephin	c574108354	submatview: setup testing structure	4 years ago
Daniel Nephin	ddddbdb990	submatview: rough outline of the Get and Notify methods.	4 years ago
Daniel Nephin	3d52abb5e2	submatview: setup the interface for the store	4 years ago
Matt Keeler	65d73771a5	Add prometheus guage definitions for replication metrics. (#10109)	4 years ago
Matt Keeler	ecbccdc261	Add replication metrics (#10073)	4 years ago
hashicorp-ci	8f3223a984	auto-updated agent/uiserver/bindata_assetfs.go from commit 7a095e7d2	4 years ago
hashicorp-ci	78886e8f4f	auto-updated agent/uiserver/bindata_assetfs.go from commit f6f282ac7	4 years ago
Daniel Nephin	2e4dc7b705	Merge pull request #10045 from hashicorp/dnephin/state-proxy-defaults ... state: remove config-entries kind index	4 years ago