consul

Commit Graph

Author	SHA1	Message	Date
John Cowen	ece09e300d	UI: Tooltips and feedback-dialogs are the same thing - merge (#4678 )	6 years ago
John Cowen	d0405ba8b9	UI: CSS Additions (mainly %frames) (#4623 ) * Move almost everything to use %frames * Fix pill styles of ACL types * Remove horizontal scrollbars from dom recycling scroller component * Make text areas look ok in Firefox * Remove ember-bulma-css * New form elements, break out %toggle * %button design tweaks * %form-element design tweaks * Better hashicorp logo * Small screen CSS improvements (#4624) 1. Reduce header size when there are no breadcrumbs 2. Make the filters toggleable, closed by default 3. Reduce the size of the footer on small screens 4. Hide all non-primary columns for forms 5. Slightly change the layout of various items, mainly buttons within forms 6. Make some confirmation dialogs work vertically on small screens. Guessing we might be better just using native confirmations on small screens	6 years ago
John Cowen	89620b93c2	ui: Turn off the code editor whilst making an edit during testing (#4668 ) Having the code editor on removes the text area from the DOM, making it more difficult to enter text in the text editor during testing. This turns the code editor off whilst making edits during testing. No changes to UI code	6 years ago
John Cowen	eb218ab93f	ui: Test bugfix. Specifically set deny for intention creation (#4663 ) Make sure we speficially set and test for deny on testing intention creation	6 years ago
John Cowen	5bb38f6ab5	ui: Tests Bugfix. Reflect extra json property `ExternalSources` in mocks (#4662 ) The mocks where using randomly generated `ExternalSources` this change makes sure they are fixed so we can reliably test the values. No change to actual UI code	6 years ago
John Cowen	028875a732	UI: Set the CODE view as the default view for editing KV's (#4651 ) Sets the code toggle on the KV edit/create page to be on by default, we figured most people probably prefer this view. Also, previously we forced the KV toggle back to a default setting for every time you visited a KV form page. We've now changed this so that the KV code toggle button acts as a 'global' toggle. So whatever you set it as will be the same for every KV for the lifetime of your 'ember session' If we are to keep this, then consider saving this into localStorage settings or similar, added some thoughts in comments re: this as it's very likely to happen.	6 years ago
John Cowen	f54fd21946	ui: [BUGFIX] Intentions were showing the wrong notification on creation (#4658 ) The error notification was being shown on creation of an intention. This was as a result of #4572 and/or #4572 and has not been included in a release. This includes a fix, plus tests to try to prevent any further regression.	6 years ago
John Cowen	0757a08684	ui: Adds a `default` view helper for providing a default value (#4650 ) If the first value passed to the helper is an empty string or undefined then return the second value	6 years ago
John Cowen	5ea748005c	UI: External Source markers (#4640 ) 1. Addition of external source icons for services marked as such. 2. New %with-tooltip css component (wip) 3. New 'no healthcheck' icon as external sources might not have healthchecks, also minus icon on node cards in the service detail view 4. If a service doesn't have healthchecks, we use the [Services] tabs as the default instead of the [Health Checks] tab in the Service detail page. 5. `css-var` helper. The idea here is that it will eventually be replaced with pure css custom properties instead of having to use JS. It would be nice to be able to build the css variables into the JS at build time (you'd probably still want to specify in config which variables you wanted available in JS), but that's possible future work. Lastly there is probably a tiny bit more testing edits here than usual, I noticed that there was an area where the dynamic mocking wasn't happening, it was just using the mocks from consul-api-double, the mocks I was 'dynamically' setting happened to be the same as the ones in consul-api-double. I've fixed this here also but it wasn't effecting anything until actually made certain values dynamic.	6 years ago
John Cowen	981882d5ff	UI: Bugfix. Remove split view code editor (#4615 ) When adding an auto resizing (heightwise) code editor, the ivy-codemirror plugin seems to do this using more nested divs. This div had a horizontal scroller but couldn't be seen on some platforms (with hidden scrollbars). This commit makes the code editor slightly more usable and more visually correct by removing the scroll bar in this div to stop producing the 'split view look', yet keeping the horizontal scroller at the bottom of the code editor for when you enter code that is wider than the area. A max-width has also been added here to prevent the text area from growing off the side of the page. Another improvement to the code editor here is the addition of a nicer color for hightlighting text selection so its at least visible. Lastly, there was a way you could get the bottom horizontal scrollbar to overlay the code in the editor. This makes sure there is always some space at the bottom of the editor to make sure the code won't be obscured	6 years ago
John Cowen	e5f300dd21	UI: Bugfix. Move to a different TextEncoder/Decoder (#4613 ) 1. The previously used TextEncoder/Decoder (used as a polyfill for browsers that don't have a native version) didn't expose an encoder via CommonJS. Use a different polyfill that exposes both a decoder and an encoder. 2. The feature detection itself was flawed. This does a less error prone detection that ensures native encoding/decoding where available and polyfilled encoding/decoding where not available.	6 years ago
John Cowen	5e987965fa	UI: Bugfix. Fix code toggle in Safari (#4608 ) I'd mistakenly changed the checkbox event to listen to oninput, which works in Chrome and Firefox. Changed this back to onchange as it should be.	6 years ago
John Cowen	40e71f1b91	UI: Simplify/refactor the actions/notification layer (#4572 ) + (#4573 ) * Move notification texts to a slightly different layer (#4572) * Further Simplify/refactor the actions/notification layer (#4573) 1. Move the 'with-feedback' actions to a 'with-blocking-action' mixin which better describes what it does 2. Additional set of unit tests almost over the entire layer to prove things work/add confidence for further changes The multiple 'with-action' mixins used for every 'index/edit' combo are now reduced down to only contain the functionality related to their specific routes, i.e. where to redirect. The actual functionality to block and carry out the action and then notify are 'almost' split out so that their respective classes/objects do one thing and one thing 'well'. Mixins are chosen for the moment as the decoration approach used by mixins feels better than multiple levels of inheritence, but I would like to take this fuether in the future to a 'compositional' based approach. There is still possible further work to be done here, but I'm a lot happier now this is reduced down into separate parts.	6 years ago
John Cowen	b41cad6fdf	UI: CSS refactor (#4430 ) + Fullscreen Layout (#4435 ) * Begin refactoring CSS into component folders. Moved most components into layout/skin folders, left out a couple of ones I want to think about more. * Adjust grays based on recent Structure changes * Switch to fullscreen layout for lists and detail, left aligned forms (#4435) * Specifically use the 'actions_close' label, not just the :last-child (actions-group) * Replace some non-var-ed colours in vaults code skin, plus prefixing (black and white)	6 years ago
John Cowen	7bb35c4c78	UI: Repo layer integration tests (#4454 ) (#4563 ) ui: Repo layer integration tests for methods that touch the API Includes a `repo` test helper to make repetitive tasks easier, plus a injectable reporter for sending performance metrics to a centralized metrics system Also noticed somewhere in the ember models that I'd like to improve, but left for the moment to make sure I concentrate on one task at a time, more or less: The tests currently asserts against the existing JSON tree, which doesn't seem to be a very nice tree. The work at hand here is to refactor what is there, so test for the not nice tree to ensure we don't get any regression, and add a skipped test so I can come back here later	6 years ago
John Cowen	1b3d566a7a	UI: Begin unskipping some more trivial tests (#4574 ) WIP Unskip some lower level trivial tests. This is the beginning of work to unskip some of the more trivial tests that I'd skipped a while back (if the thing they are testing broke, they would have failed higher up in other acceptance tests). I'd rather keep the tests, as they do test things in a more isolated manner, and the plan was to always come back and work to unskip them time allowing. I didn't get to far into this work in progress here, but I'd rather merge what I've done all the same and come back at a later date and continue.	6 years ago
John Cowen	4ebd70e6cd	UI: Fixes healthy node listing resize on large portrait screens (#4564 ) 1. Split the resizing functionality of into a separate mixin to be shared across components 2. Add basic integration tests to prove that everything is getting called through out the lifetime of the app. I decided against unit testing as there isn't really any isolated logic to be tested, more checking that things are being called in the correct order etc i.e. the integration is correct. Adds assertion to with-resizing so its obvious to override `resize`	6 years ago
John Cowen	80a307cb9f	UI: Add conditional enterprise logo (#4432 ) Adds additional 'enterprise' text underneath the 'startup' logo if the ui is built with a CONSUL_BINARY_TYPE environment variable that doesn't equal `oss`.	6 years ago
John Cowen	fde41467cf	ui: Adds bottom breathing space on the bottom of forms (#4433 )	6 years ago
John Cowen	12811c0844	UI - Refactor Adapter.handleResponse (#4398 ) * Add some tests to check the correct GET API endpoints are called * Refactor adapters 1. Add integration tests for `urlFor...` and majority `handleResponse` methods 2. Refactor out `handleResponse` a little more into single/batch/boolean methods 3. Move setting of the `Datacenter` property into the `handleResponse` method, basically the same place that the uid is being set using the dc parsed form the URL 4. Add some Errors for if you don't pass ids to certain `urlFor` methods	6 years ago
John Cowen	45d85542a9	UI - Non-prod CSS sourcemaps (#4418 )	6 years ago
John Cowen	e7a3235afc	Use `some` for the tags search instead of munging and searching	6 years ago
John Cowen	09a885dadd	ADd some extra tests to pick up on searching by two joined tags	6 years ago
John Cowen	d510e1e6d3	Add basic searching by tags using the freetext search near-term	6 years ago
John Cowen	3c40abcbae	Acceptance test for searching service by tag	6 years ago
John Cowen	1d31bef0a4	Show the Service.IP address instead of the Node.IP address in detail	6 years ago
John Cowen	24c9037cae	Make the tests break by switching to a Service.IP	6 years ago
John Cowen	ab914001c1	Bump consul-api-double	6 years ago
John Cowen	310a038f87	Show Service.ID's throughout the app, allow searching by Service.ID 1. In the Services > Services detail page for both healthy and unhealthy nodes, also add searching by Service.ID here 2. In the Nodes > Node detail > [Services] tab only if its different from the Service name, add searching by Service.ID here	6 years ago
John Cowen	40a270a492	Acceptance tests to search/look for service id's	6 years ago
John Cowen	4179afae06	Instead of rewriting the API call, use ember to rewrite the URL We now essentially do 2 redirects if you hit a `folder/` 1. If you visit `/ui/dc1/kv/folder/`, `consul` will redirect you to `/ui/dc1/kv/folder` 2. Once redirected to `/ui/dc1/kv/folder` via a 301, use ember/history API to redirect you back to `/ui/dc1/kv/folder/`. Bit long winded, but achieves what we want without having to get stuck into `consul` itself to remove the 301 for the UI	6 years ago
John Cowen	887d4e9dde	If we are indexing or foldering then its going to be folder-like ...therefore add a trailing slash to the API call	6 years ago
John Cowen	faf813fee2	Add tests that break when you request a folder without a trailing slash	6 years ago
John Cowen	f6cd162f75	Stop trying to remove consul-api-double we don't need to anymore	6 years ago
John Cowen	fb91d05eb4	Don't assume the last item in the healthcheck listing is passing	6 years ago
John Cowen	c01fb37c46	Don't clone prev, there's no need	6 years ago
John Cowen	a5fa27d718	Fix a couple of typos in the comments	6 years ago
John Cowen	67402b3d26	Tests and comments regarding the previous 2 commits	6 years ago
John Cowen	b29546e578	Looking into atob functionality, consequence of Value: null The Consul API can pass through `Value: null` which does not get cast to a string by ember-data. This snowballs into problems with `atob` which then tried to decode `null`. There are 2 problems here. 1. `Value` should never be `null` - I've added a removeNull function to shallowly loop though props and remove properties that are `null`, for the moment this is only on single KV JSON responses - therefore `Value` will never be `null` which is the root of the problem 2. `atob` doesn't quite follow the `window.atob` API in that the `window.atob` API casts everything down to a string first, therefore it will try to decode `null` > `'null'` > `crazy unicode thing`. - I've commented in a fix for this, but whilst this shouldn't be causing anymore problems in our UI (now that `Value` is never `null`), I'll uncomment it in another future release. Tests are already written for it which more closely follow `window.atob` but skipped for now (next commit)	6 years ago
John Cowen	6a407a044e	Remove validation for presence of KV values	6 years ago
John Cowen	83caa6a296	Add some more detail to the README pre-adding a CONTRIBUTING	6 years ago
John Cowen	7b8b3a012c	Upgrade consul-api-double for session destroy	6 years ago
John Cowen	15b627a517	Basic acceptance testing for navigating via cancel buttons	6 years ago
John Cowen	f85369c375	Add some navigation testing for back buttons and create buttons	6 years ago
John Cowen	649d777714	Acceptance test for using tokens from listing and detail pages	6 years ago
John Cowen	701d6a3a72	Move deleting to a top level feature	6 years ago
John Cowen	e0f7cdb128	Start purifying page objects	6 years ago
John Cowen	e3ce2a8beb	Lock Session invalidation acceptance test	6 years ago
John Cowen	ed286585e9	Add some low hanging intention tests, basically add intentions to others 1. There are various things tests that can just have intentions added into them, like filters and such like, add intentions to these 2. Start thinking about being able to negate steps easily, which will lead on to a cleanup of the steps	6 years ago
John Cowen	b445df39bb	Use html5 oninput instead of onkeyup for native textual inputs This enables people to enter things using the mouse to paste for example, plus possible other things. As an aside it also answers my query regarding `fillIn` for testing, nothing needs to be actually _typed_ anymore! Doh	6 years ago

... 2 3 4 5 6 ...

306 Commits (7ac6a085c595096e7d534a311252a259f9755a87)