741 Commits (673d02d30fe911b593b91ba83b9408c9a69d1f4c)

Author	SHA1	Message	Date
John Cowen	64767b53e7	ui: Configure routes in route config rather than classes (#11900)	3 years ago
James Tran	d1ac40e967	ui: Add XML syntax highlighting to key/value editor (#11785) ... * ui: Add XML syntax highlighting to key/value editor * ui: Make explicit options that are specific to XML for clarity	3 years ago
John Cowen	f8b336b9a0	ui: Fix URL params decoding (#11931) ... * ui: Move wildcard param decoding to routlet service	3 years ago
John Cowen	72e5d7e1d4	ui: Ensure disconnect error doesn't appear w/auth change on some pages (#11905)	3 years ago
John Cowen	3949acbc1d	ui: Remove any route level auth checks (#11891)	3 years ago
John Cowen	2f6ae96ccd	ui: Fixup names of Meta for instance search, also add Node (#11774)	3 years ago
John Cowen	2c1eb052e3	ui: Various empty state improvements/fixups (#11892) ... * ui: Add login button to per service intentions for zero results * Add login button and consistent header for when you have zero nodes * `services` doesn't exists use `items` consequently: Previous to this fix we would not show a more tailored message for when you empty result set was due to a user search rather than an empty result set straight from the backend * Fix `error` > `@error` in ErrorState plus code formatting and more docs * Changelog	3 years ago
John Cowen	72cddf4f49	ui: Check for `intention` ACL resources, not `intentions` ACL resources (#11880) ... * ui: Check for `intention` ACL resources, not `intentions` ACL resources * ui: Flip the test assertion to see the create button temporarily	3 years ago
John Cowen	ba70fe5e55	ui: Fix up missing policy delete warning modal (#11868) ... Fixes an issue where the policy detail page delete button would disappear when clicking rather than showing a modal confirmation	3 years ago
John Cowen	20cc028ac0	ui: Fixes an issue with the version footer when scrolling (#11850)	3 years ago
John Cowen	11ab84f840	ui: Add version information back into the footer (#11803)	3 years ago
John Cowen	2ba0e86d6d	ui: Disable setting wildcard partitions for intentions (#11804)	3 years ago
John Cowen	79b25901d7	ui: Change the URL prefix of partitions from `-` to `_` (#11801)	3 years ago
John Cowen	79679da840	ui: Fix a problem showing the default part in a non-primary (#11800) ... When switching to a non-primary datacenter we should only show the word 'default' in place of the partition menu, this fixes up a bug preventing that from happening due to erroneous if/let nesting	3 years ago
John Cowen	b5c0b35ef7	ui: Prefer shorter partition word in certain places vs Admin Partition (#11772)	3 years ago
John Cowen	be23aab001	ui: Ensure we show a special readonly page for intentions (#11767)	3 years ago
John Cowen	e4d33187b9	ui: reuse BucketList for intention view pages (#11765)	3 years ago
John Cowen	4400d7c071	ui: Change partitions to expect `[]` from the API (#11791)	3 years ago
John Cowen	c410d295be	ui: Amends to Routing visualization for partitions (#11747) ... * Update disco fixtures now we have partitions * Add virtual-admin-6 fixture with partition 'redirects' and failovers * Properly cope with extra partition segment for splitters and resolvers * Make 'redirects' and failovers look/act consistently * Fixup some unit tests	3 years ago
John Cowen	c434fefda2	ui: Fixup notifications for tokens using and topology intention saving (#11763)	3 years ago
John Cowen	340a0e03f5	ui: Make 'dangerous' buttons have white text even in dark theme (#11756)	3 years ago
John Cowen	05fabbe898	ui: Improve error messaging for when we can't make a slug (#11697) ... Ember Data requires the usage of unique ID to identify its records in the frontend, and we use a centralized function to do that for all records. There are occasions where it can't make an ID, usually this is a bug our side, but there are occasions where Consul might not be giving us the data needed to make an ID, for example if a Service comes down to us with a blank Name. Whilst this isn't a problem to be fixed in the UI, I thought we could make an improvement here by giving a little more info as to why the UI cannot make a unique ID. This is currently semi-hidden away in the javascript console, but we could potentially surface this in the UI itself as a larger task. I figured this smaller task could help folks in the meantime if they hit upon this as they might open up the javascript console themselves to see whats up and they'd at least get this extra clue.	3 years ago
John Cowen	c04701b387	ui: remove old head.hbs file we don't need (#11678)	3 years ago
John Cowen	77412fd2e0	ui: Stop tables overlapping with their headers when scrolling (#11670)	3 years ago
John Cowen	85c39092c0	ui: Adds basic support for partition exports to Service listings (#11702) ... Also: * ui: Add cross partition linking and rollout BucketList (#11712) * ui: Add exported service partition to the source filter menu (#11727)	3 years ago
John Cowen	171cb0a247	ui: Adds partition support to Service and Node Identity templates (#11696)	3 years ago
John Cowen	f27685cc40	ui: Adds basic support for the Routing tab viz with partitions (#11679)	3 years ago
John Cowen	b07ff88874	ui: Add documentation link for partitions (#11668)	3 years ago
John Cowen	4e0507aed3	ui: Don't cache event sources following a 401 (#11681)	3 years ago
John Cowen	f3d9565277	ui: Refactor KV and Lock Sessions following partitions update (#11666) ... This commit uses all our new ways of doing things to Lock Sessions and their interactions with KV and Nodes. This is mostly around are new under-the-hood things, but also I took the opportunity to upgrade some of the CSS to reuse some of our CSS utils that have been made over the past few months (%csv-list and %horizontal-kv-list). Also added (and worked on existing) documentation for Lock Session related components.	3 years ago
John Cowen	5ad82693d8	ui: Don't check global session permissions for a single session (#11657)	3 years ago
John Cowen	b5c8af4580	ui: Add `Service.Partition` as available variable for dashboard urls (#11654)	3 years ago
John Cowen	bda64f98b3	ui: Don't show policy datacenter selector for non-default partitions (#11656)	3 years ago
John Cowen	26341f0b05	ui: Move nspace CRUD to use the same approach as partitions (#11633) ... This sounds a bit 'backwards' as the end goal here is to add an improved UX to partitions, not namespaces. The reason for doing it this way is that Namespaces already has a type of 'improved UX' CRUD in that it has one to many relationship in the form when saving your namespaces (the end goal for partitions). In moving Namespaces to use the same approach as partitions we: - Ensure the new approach works with one-to-many forms. - Test the new approach without writing a single test (we already have a bunch of tests for namespaces which are now testing the approach used by both namespaces and partitions) Additionally: - Fixes issue with missing default nspace in the nspace selector - In doing when checking to see that things where consistent between the two, I found a few little minor problems with the Admin Partition CRUD so fixed those up here also. - Removed the old style Nspace notifications	3 years ago
John Cowen	f7b8df281b	ui: Add `Service.Namespace` variable to dashboard URL templates (#11640) ... We currently allow only Datacenter, Service.Name, this PR adds Service.Namespace.	3 years ago
John Cowen	3f131dcf34	ui: Notifications re-organization/re-style (#11577) ... - Moves where they appear up to the <App /> component. - Instead of a <Notification /> wrapping component to move whatever you use for a notification up to where they need to appear (via ember-cli-flash), we now use a {{notification}} modifier now we have modifiers. - Global notifications/flashes are no longer special styles of their own. You just use the {{notification}} modifier to hoist whatever component/element you want up to the top of the page. This means we can re-use our existing <Notice /> component for all our global UI notifications (this is the user visible change here)	3 years ago
John Cowen	2b8273bc6e	ui: Support for SSO with Admin Partitions (#11604) ... * Upgrade AuthForm and document current state a little better * Hoist SSO out of the AuthForm * Bare minimum admin partitioned SSO also: ui: Tabbed Login with Token or SSO interface (#11619) - I upgraded our super old, almost the first ember component I wrote, to use glimmer/almost template only. This should use slots/contextual components somehow, but thats a bigger upgrade so I didn't go that far. - I've been wanting to upgrade the shape of our StateChart component for a very long while now, here its very apparent that it would be much better to do this sooner rather than later. I left it as is for now, but there will be a PR coming soon with a slight reshaping of this component. - Added a did-upsert modifier which is a mix of did-insert/did-update - Documentation added/amended for all the new things.	3 years ago
John Cowen	b84ee47ff0	ui: Fix brand coloring for inline-code plus docs (#11578) ... * ui: Fix brand coloring for inline-code plus docs Also use --tones instead of --black/--white (#11601) Co-authored-by: Evan Rowe <ev.rowe@gmail.com>	3 years ago
John Cowen	392dedc3e2	ui: Upgrades token sourcing related components to Glimmer+docs (#11592)	3 years ago
John Cowen	b4a7278e72	ui: Add eng docs for our render-template helper (#11359) ... Adds Engineer documentation for our recently improved render-template helper, plus some ideas for further work/improvement here should anyone ever want to pick that up.	3 years ago
John Cowen	b7bd938411	ui: Store the default partition when logging in (#11591) ... Make sure we store the default Partition for a users token.	3 years ago
John Cowen	35ccc2bc29	ui: Adding partitions + icons to upstreams/upstream instances (#11556) ... Adds a partition badge/label/visual to upstreams and upstream instances.	3 years ago
John Cowen	2ef9ea00b1	ui: When certain menus are selected reset either nspace/partition (#11479) ... For our dc, nspace and partition 'bucket' menus, sometimes when selecting one 'bucket' we need to reset a different 'bucket' back to the one that your token has by default (or the default if not). For example when switching to a different partition whilst you are in a non-default namespace of another partition, we need to switch you to the token default namespace of the partition you are switching to.	3 years ago
John Cowen	28b1e642cb	ui: Upstream CSS Tweaks (#11554) ... Various CSS tweaks/HTML cleanup around upstreams (but impacts other 'rows') - Prefer {{tooltip}} to <Tooltip> - Removed some now unnecessary spans - Stop using an empty class="" for styling purposes. - Renamed any classes used to identify response properties to follow the exact property name but kebab-cased. - Fixed up the alignment of things in the rows when used with a 'tiny copy button' (see screengrab) which was minus positioning and knocking things out (pending a proper refactor of our copy button CSS which is from the very very start of things)	3 years ago
John Cowen	c847c9a8cb	ui: Fixup partiton > partition typo (#11572)	3 years ago
Alessandro De Blasis	53a61349e1	ui: Fix code editor resizing and restyle (#11474) ... Fixes an issue where the code editor would not resizing to the full extent of the browser window plus CodeEditor restyling/refactoring - :label named block - :tools named block - :content named block - code and CSS cleanup - CodeEditor.mdx Signed-off-by: Alessandro De Blasis <alex@deblasis.net> Co-authored-by: John Cowen <johncowen@users.noreply.github.com>	3 years ago
John Cowen	6557f52962	ui: Bump our browser support (#11505) ... Bumps our browser support to a "rough ~2 years back" approach.	3 years ago
John Cowen	66f1dd9425	ui: [Port] Ensure the tokens default nspace (and partition) is passed thru to the auth endpoint (#11490) ... Most HTTP API calls will use the default namespace of the calling token to additionally filter/select the data used for the response if one is not specified by the frontend. The internal permissions/authorize endpoint does not do this (you can ask for permissions from different namespaces in on request). Therefore this PR adds the tokens default namespace in the frontend only to our calls to the authorize endpoint. I tried to do it in a place that made it feel like it's getting added in the backend, i.e. in a place which was least likely to ever require changing or thinking about. Note: We are probably going to change this internal endpoint to also inspect the tokens default namespace on the backend. At which point we can revert this commit/PR. * Add the same support for the tokens default partition	3 years ago
Kenia	37de276350	ui: Add Consul API Gateway as an external source (#11371)	3 years ago
John Cowen	537c4f32f7	Revert "Merge pull request #11328 from radiantly/ui/feature/allow-${}-style-interpolation" ... This reverts commit cd55c0cda3, reversing changes made to 14af8cb7a9.	3 years ago
John Cowen	aeaa0a6c96	ui: Temporarily force all UI capabilities (#11520) ... Temporarily revert to pre-1.10 UI functionality by overwriting frontend permissions. These are used to hide certain UI elements, but they are still enforced on the backend. This temporary measure should be removed again once https://github.com/hashicorp/consul/issues/11098 has been resolved	3 years ago
John Cowen	1515c3e667	ui: Filter global intentions list by selected partition (#11475) ... * ui: Filter global intentions list by namespace and partition Filters global intention listing by the current partition rather than trying to use a wildcard.	3 years ago
Kenia	4c2fa322a1	ui: Topology view with no dependencies (#11280)	3 years ago
John Cowen	25961355c1	ui: Only show partition / partition selector if enabled (#11484) ... I missed that partitions should never display if you can't use them, not just if you can't choose them.	3 years ago
John Cowen	72be2dd204	ui: Ensure we check intention service prefix permissions for per service (#11409) ... Port of: Ensure we check intention service prefix permissions for per service (#11270) Previously, when showing some action buttons for 'per service intentions' we used a global 'can I do something with any intention' permission to decide whether to show a certain button or not. If a user has a token that does not have 'global' intention permissions, but does have intention permissions on one or more specific services (for example via service / service_prefix), this meant that we did not show them certain buttons required to create/edit the intentions for this specific service. This PR adds that extra permissions check so we now check the intentions permissions per service instead of using the 'global' "can I edit intentions" question/request. **Notes:** - If a HTML button is `disabled` this means tippy.js doesn't adopt the popover properly and subsequently hide it from the user, so aswell as just disabling the button so you can't active the popover, we also don't even put the popover on the page - If `ability.item` or `ability.item.Resources` are empty then assume no access **We don't try to disable service > right hand side intention actions here** Whether you can create intentions for a service depends on the _destination_ of the intention you would like to create. For the topology view going from the LHS to the center, this is straightforwards as we only need to know the permissions for the central service, as when you are going from the LHS to the center, the center is the _destination_. When going from the center to the RHS the _destination[s]_ are on the RHS. This means we need to know the permissions for potentially 1000s of services all in one go in order to know when to show a button or not. We can't realistically discover the permissions for service > RHS services as we'd have either make a HTTP request per right hand service, or potentially make an incredibly large POST request for all the potentially 1000s of services on the right hand side (more preferable to 1000s of HTTP requests). Therefore for the moment at least we keep the old functionality (thin client) for the middle to RHS here. If you do go to click on the button and you don't have permissions to update the intention you will still not be able to update it, only you won't know this until you click the button (at which point you'll get a UI visible 403 error) Note: We reversed the conditional here between 1.10 and 1.11 So this make 100% sense that the port is different here to 1.11	3 years ago
Luke Kysow	c61208146d	Use "Open dashboard" everywhere (#11406) ... Previously we had "Open metrics Dashboard" and "Configure metrics dashboard" in the topology cards and then we had "Open Dashboard" in the top nav when the dashboard was configured. Now we use "Open dashboard" and "Configure dashboard". This change was made for consistency in wording and casing. In addition, the dashboard could be used for metrics but also other dashboards so there's no need to scope it only to metrics. Also the config is: ```hcl ui_config { dashboard_url_templates } ``` Which does not mention metrics	3 years ago
John Cowen	76f5de1455	ui: Ensure dc selector correctly shows the currently selected dc (#11380) ... * ui: Ensure dc selector correctly shows the currently selected dc * ui: Restrict access to non-default partitions in non-primaries (#11420) This PR restricts access via the UI to only the default partition when in a non-primary datacenter i.e. you can only have multiple (non-default) partitions in the primary datacenter.	3 years ago
John Cowen	b96794401f	ui: Add initial "How 2 Test UI" docs (#11296) ... Attempt to document out what a beginner to the project needs to know here in order to get started quickly Co-authored-by: Jared Kirschner <85913323+jkirschner-hashicorp@users.noreply.github.com>	3 years ago
John Cowen	86c88cc43a	ui: Ensure we provide an id for filtering policy-tokens (#11311)	3 years ago
Chris S. Kim	76bbeb3baf	ui: Pass primary dc through to uiserver (#11317) ... Co-authored-by: John Cowen <johncowen@users.noreply.github.com>	3 years ago
Jared Kirschner	cd55c0cda3	Merge pull request #11328 from radiantly/ui/feature/allow-${}-style-interpolation ... ui: Allow ${ } interpolation for UI Dashboard template URLs	3 years ago
John Cowen	e938e0afe0	ui: Remove remaining partition FIXME comments (#11312)	3 years ago
cooleditphoto	f801662f5c	ui: Topology metrics view outbound bytes color blue (#11343)	3 years ago
radiantly	fd51b3e76e	ui: Allow ${} interpolation for template URLs	3 years ago
John Cowen	a1a0ce1dad	ci: Only install UI dependencies for CI frontend-cache (#11313)	3 years ago
John Cowen	79b53ab23a	ui: Move the Role remove dialog to use InformedAction (#11298)	3 years ago
John Cowen	585f78f35a	ui: Fixup route blueprint to reflect project conventions (#11153)	3 years ago
Kenia	daec73e76c	ui: Topology - Fix up Default Allow and Permissive Intentions notices (#11216) ... * ui: Default allow notices test (#11240)	3 years ago
DillonStreator	03bc755162	ui: consistent empty state for intentions (#11261)	3 years ago
John Cowen	ed6918c6c2	ui: Improve dev-time SSO/OIDC visibility (#11248) ... This commit tries to make the development experience of working on our OIDC support a little more realistic, essentially by creating our own OIDC provider in our application (only during development builds). You can still provide a real OIDC provider to work with via our dev time environment/cookie variables as before, just now we default to the behaviour in this commit. Overall this makes it much easier to verify our OIDC support in the UI, and also opens up avenues for us to be able to test more scenarios that we couldn't before (for example not only successful logins, but also erroneous, potentially with multiple error reasons).	3 years ago
John Cowen	26c9d5c135	ui: Ignore erroneous ember/jQuery eslint warnings (#11238)	3 years ago
John Cowen	e5a15fdaac	ci: Don't focus install JS deps (#11267)	3 years ago
John Cowen	ebc8cbf957	ui: Fix up socket icon (#11234)	3 years ago
John Cowen	1cf008296d	docs: Fixes a typo in the UI readme docs (#11268)	3 years ago
Kenia	fca0e117e5	ui: Instructions for branch naming pattern (#11256) ... * Instructions for branch naming pattern * fix	3 years ago
John Cowen	baa377ddca	ui: Adds initial CRUD for partitions (#11188) ... * Add `is` and `test` helpers in a similar vein to `can` Adds 2 new helpers in a similar vein to ember-cans can: - `is` allows you to use vocab/phrases such as (is "something model") which calls isSomething() on the models ability. - `test` allows you to use vocab/phrases such as (test "is something model") or (test "can something model")which calls isSomething() / canSomething() on the models ability. Mostly using the is helper and the can helper. It's basically the is/can helper combined. * Adds TextInput component + related modifiers/helpers/machines/services (#11189) Adds a few new components/modifiers/helpers to aid building forms. - state-chart helper, used in lieu of a more generic approach for requiring our statecharts. - A few modifications to our existing disabled modifier. - A new 'validation' modifier, a super small form validation approach built to make use of state charts (optionally). Eventually we should be able to replace our current validation approach (ember-changeset-validations + extra deps) with this. - A new TextInput component, which is the first of our new components specifically to make it easy to build forms with validations. This is still a WIP, I left some comments in pointing out where this one would be progressed, but as we don't need the planned functionality yet, I left it where it was. All of this will be fleshed out more at a later date. Documentation is included for all of ^ * ui: Adds initial CRUD for partitions (#11190) Adds basic CRUD support for partitions. Engineering-wise probably the biggest takeaway here is that we needed to write very little javascript code to add this entire feature, and the little javascript we did need to write was very straightforwards. Everything is pretty much just HTML. Another note to make is that both ember-changeset and ember-data (model layer things) are now completely abstracted away from the view layer of the application. New components: - Consul::Partition::Form - Consul::Partition::List - Consul::Partition::Notifications - Consul::Partition::SearchBar - Consul::Partition::Selector See additional documentation here for more details New Route templates: - index.hbs partition listing/searching/filtering - edit.hbs partition editing and creation Additionally: There is some additional debug work here for better observability and to prevent any errors regarding our href-to usage when a dc is not available in our documentation site. Our softDelete functionality has been DRYed out a little to be used across two repos. isLinkable was removed from our ListCollection component for lists like upstream and service listing, and instead use our new is helper from within the ListCollection, meaning we've added a few more lighterweight templateOnly components. * ui: Exclude all debug-like files from the build (#11211) This PR adds **/*-debug.* to our test/prod excluded files (realised I needed to add test-support.js also so added that here as its more or less the same thing). Conditionally juggling ES6 static imports (specifically debug ones) for this was also getting a little hairy, so I moved it all to use the same approach as our conditional routes. All in all it brings the vendor build back down to ~430kb gzipped.	3 years ago
John Cowen	b8166de30d	ui: Replaces almost all remaining instances of SASS variables with CSS (#11200) ... From an engineers perspective, whenever specifying colors from now on we should use the form: ``` color: rgb(var(--tone-red-500)); ``` Please note: - Use rgb. This lets us do this like rgb(var(--tone-red-500) / 10%) so we can use a 10% opacity red-500 if we ever need to whilst still making use of our color tokens. - Use --tone-colorName-000 (so the prefix tone). Previously we could use a mix of --gray-500: $gray-500 (note the left hand CSS prop and right hand SASS var) for the things we need to theme currently. As we no longer use SASS we can't do --gray-500: --gray-500, so we now do --tone-gray-500: --gray-500. Just for clarity after that, whenever specifying a color anywhere, use rgb and --tone. There is only one reason where you might not use tone, and that is if you never want a color to be affected by a theme (for example a background shadow probably always should use --black) There are a 2 or 3 left for the code editor, plus our custom-query values	3 years ago
John Cowen	a9fe39e035	ui: Fix up blocking reconciliation for multiple models (#11237) ... > In the future, this should all be moved to each individual repository now, which will mean we can finally get rid of this service. This PR moves reconciliation to 'each individual repository'. I stopped short of getting rid of the service, but its so small now we pretty much don't need it. I'd rather wait until I look at the equivalent DataSink service and see if we can get rid of both equivalent services together (this also currently dependant on work soon to be merged) Reconciliation of models (basically doing the extra work to clean up the ember-data store and bring our frontend 'truth' into line with the actual backend truth) when blocking/long-polling on different views/filters of data is slightly more complicated due to figuring out what should be cleaned up and what should be left in the store. This is especially apparent for KVs. I built in a such a way to hopefully make sure it will all make sense for the future. I also checked that this all worked nicely with all our models, even KV which has never supported blocking queries. I left all that work in so that if we want to enable blocking queries/live updates for KV it now just involves deleting a couple of lines of code. There is a tonne of old stuff that we can clean up here now (our 'fake headers' that we pass around) and I've added that to my list of thing for a 'Big Cleanup PR' that will remove lots of code that we no longer require.	3 years ago
John Cowen	8b002d086a	ui: Address some Admin Partition FIXMEs (#11057) ... This commit addresses some left over admin partition FIXMEs 1. Adds Partition correctly to Service Instances 2. Converts non-important 'we can do this later' FIXMEs to TODOs 3. Removes some FIXMEs that I've double checked and addressed. Most of the remaining FIXMEs I'm waiting on responses to questions from the consul core folks for. I'll address those in a separate PR.	3 years ago
Kenia	5e7ef183ea	ui: Use of header default ACL policy (#11192) ... * Use of header default ACL policy * Update test for dc serializer	3 years ago
John Cowen	35a92e856b	ui: Make it hard to not URLEncode DataSource srcs/URIs (#11117) ... Our DataSource came in very iteratively, when we first started using it we specifically tried not to use it for things that would require portions of the @src="" attribute to be URL encoded (so things like service names couldn't be used, but dc etc would be fine). We then gradually added an easy way to url encode the @src="" attributes with a uri helper and began to use the DataSource component more and more. This meant that some DataSource usage continued to be used without our uri helper. Recently we hit #10901 which was a direct result of us not encoding @src values/URIs (I didn't realise this was one of the places that required URL encoding) and not going back over things to finish things off once we had implemented our uri helper, resulting in ~half of the codebase using it and ~half of it not. Now that almost all of the UI uses our DataSource component, this PR makes it even harder to not use the uri helper, by wrapping the string that it requires in a private URI class/object, that is then expected/asserted within the DataSource component/service. This means that as a result of this PR you cannot pass a plain string to the DataSource component without seeing an error in your JS console, which in turn means you have to use the uri helper, and it's very very hard to not URL encode any dynamic/user provided values, which otherwise could lead to bugs/errors similar to the one mentioned above. The error that you see when you don't use the uri helper is currently a 'soft' dev time only error, but like our other functionality that produces a soft error when you mistakenly pass an undefined value to a uri, at some point soon we will make these hard failing "do not do this" errors. Both of these 'soft error' DX features have been used this to great effect to implement our Admin Partition feature and these kind of things will minimize the amount of these types of bugs moving forwards in a preventative rather than curative manner. Hopefully these are the some of the kinds of things that get added to our codebase that prevent a multitude of problems and therefore are often never noticed/appreciated. Additionally here we moved the remaining non-uri using DataSources to use uri (that were now super easy to find), and also fixed up a place where I noticed (due to the soft errors) where we were sometimes passing undefined values to a uri call. The work here also led me to find another couple of non-important 'bugs' that I've PRed already separately, one of which is yet to be merged (#11105), hence the currently failing tests here. I'll rebase that once that PR is in and the tests here should then pass 🤞 Lastly, I didn't go the whole hog here to make DataSink also be this strict with its uri usage, there is a tiny bit more work on DataSink as a result of recently work, so I may (or may not) make DataSink equally as strict as part of that work in a separate PR.	3 years ago
John Cowen	7a5f335b7c	ui: Adds Flight icons to our icon set (#11097) ... * ui: Adds Flight icons to our icon set This commit doesn't actually add anything to the UI, rather just makes the flight icons available for use.	3 years ago
John Cowen	5e34d89f7f	ui: Hide create buttons for policies/roles/namespaces with readonly access (#10914) ... This PR adds a check to policy, role and namespace list pages to make sure the user has can write those things before offering to create them via a button. (The create page/form would then be a read-only form)	3 years ago
John Cowen	bce724baf1	ui: Don't show the CRD menu for read-only intentions (#11149) ... * ui: Don't show the CRD menu for read-only intentions The UI bug here manifests itself only when a user/token is configured to have read-only access to intentions. Instead of only letting folks click to see a read only page of the intention, we would show an additional message saying that the intention was read-only due to it being 'Managed by [a kubernetes] CRD'. Whilst the intention was still read only, this extra message was still confusing for users. This PR fixes up the conditional logic and further moves the logic to use ember-can - looking at the history of the files in question, this bug snuck itself in partly due to it being 'permission-y type stuff' previous to using ember-can and when something being editable or not was nothing to do with ACLs. Then we moved to start using ember-can without completely realising what IsEditable previously meant. So overall the code here is a tiny bit clearer/cleaner by adding a proper can view CRD intention instead of overloading the idea of 'editability'.	3 years ago
John Cowen	ce21c5109b	ui: Adds a set of basic unit tests for abilities (#11132)	3 years ago
John Cowen	581357c32a	ui: Remove info panel from the nspace menu when editing nspaces (#11130) ... * ui: Remove info panel form the nspace menu when editing nspaces	3 years ago
John Cowen	01c9dc5728	ui: Add initial partition support to intentions (#11129) ... * ui: Add initial partition support to intentions	3 years ago
John Cowen	eb00b45ef4	ui: Use last-child for selecting the desired nspace instead of nth-child (#11127)	3 years ago
John Cowen	e59b8ffc17	ui: Remove refresh-route action for session invalidation (#11105) ... * ui: Move action to the correct button for session invalidation * Remove refresh-route completely, its not needed	3 years ago
John Cowen	6bc8af364f	ui: Add initial i18n docs page (#10888)	3 years ago
John Cowen	61e69a9fe5	ui: Add partition parameter when clearing child-selector forms in ACLs (#11106)	3 years ago
John Cowen	ececa7da45	ui: Add an isDestroyed check for the MenuPanel component (#11104) ... This solves an occasionally flakey tests I see every so often	3 years ago
John Cowen	e088d8674c	ui: Remove legacy ACLs (#11096)	3 years ago
John Cowen	6e396e4456	ui: Gracefully recover from non-existent DC errors (#11077) ... * ui: Gracefully recover from non-existent DC errors This PR fixes what happens in the UI if you try to navigate to a non-existing DC. When we received a 500 error from an API response due to a non-existent DC, previously we would show a 404 error, which is what we were trying to convey. But in the spirit of the UI being a 'thin client', its probably best to just show the 500 error from the API response, which may help folks to debug any issues better. * Automatically set the CONSUL_DATACENTER_LOCAL env var for testing	3 years ago
John Cowen	cf638ee551	ui: Always show main navigation Key/Value link (#10916) ... * ui: Ignore response from API for KV permissions Currently there is no way for us to use our HTTP authorization API endpoint to tell us whether a user has access to any KVs (including the case where a user may not have access to the root KV store, but do have access to a sub item) This is a little weird still as in the above case the user would click on this link and still get a 403 for the root, and then have to manually type in the URL for the KV they do have access to. Despite this we think this change makes sense as at least something about KV is visible in the main navigation. Once we have the ability to know if any KVs are accessible, we can add this guard back in. We'd initially just removed the logic around the button, but then noticed there may be further related KV issues due to the nested nature of KVs so we finally decided on simply ignoring the responses from the HTTP API, essentially reverting the KV area back to being a thin client. This means when things are revisited in the backend we can undo this easily change in one place. * Move acceptance tests to use ACLs perms instead of KV ones	3 years ago
John Cowen	9c0233cf59	Revert "ui: Add partition parameter when clearing child-selector forms in ACLs" ... This reverts commit a670bde57d.	3 years ago
John Cowen	a670bde57d	ui: Add partition parameter when clearing child-selector forms in ACLs	3 years ago
John Cowen	cfbd1bb84e	ui: [BUGFIX] Re-enable namespace menus whilst editing intentions (#11095) ... This PR supersedes #10706 and fixes #10686 whilst making sure that saving intentions continues to work. The original fix in #10706 ignored the change action configured for the change event on the menus, meaning that the selected source/destination namespace could not be set by the user when editing/creating intentions. This, coupled with the fact that using the later intention exact endpoint for API requests endpoint means that you could not use wildcard namespaces for saving intentions. All in all this meant that intentions could no longer be saved using the UI (whilst using ENT) This PR reverts #10706 to fix the intention saving issue, and adds a fix for the original visual issue of nspaces doubling up in the menu once clicked. This meant repeating the existing functionality for nspaces aswell as services. It did seem strange to me that the original issue was only apparent for the nspace menus and not the service menus which should all function exactly the same way. There is potentially more to come here partly related to what the exact functionality should be, but I'm working with other folks to figure out what the best way forwards is longer term. In the meantime this brings us back to the original functionality with the visual issue fixed. Squashed commits: * Revert "ui: Fix dropdown option duplications (#10706)" This reverts commit eb5512fb74. * ui: Ensure additional nspaces are added to the unique list of nspaces * Add some acceptance tests	3 years ago
John Cowen	1d9d3349ca	ui: Ensure we request permission wiht the correct partition (#11060)	3 years ago
John Cowen	fc14a412fd	ui: Partitions Application Layer (#11017) ... * Add Partition to all our models * Add partitions into our serializers/fingerprinting * Make some amends to a few adapters ready for partitions * Amend blueprints to avoid linting error * Update all our repositories to include partitions, also Remove enabled/disable nspace repo and just use a nspace with conditionals * Ensure nspace and parition parameters always return '' no matter what * Ensure data-sink finds the model properly This will later be replaced by a @dataSink decorator but we are find kicking that can down the road a little more * Add all the new partition data layer * Add a way to set the title of the page from inside the route and make it accessibile via a route announcer * Make the Consul Route the default/basic one * Tweak nspace and partition abilities not to check the length * Thread partition through all the components that need it * Some ACL tweaks * Move the entire app to use partitions * Delete all the tests we no longer need * Update some Unit tests to use partition * Fix up KV title tests * Fix up a few more acceptance tests * Fixup and temporarily ignore some acceptance tests * Stop using ember-cli-page-objects fillable as it doesn't seem to work * Fix lint error * Remove old ACL related test * Add a tick after filling out forms * Fix token warning modal * Found some more places where we need a partition var * Fixup some more acceptance tests * Tokens still needs a repo service for CRUD * Remove acceptance tests we no longer need * Fixup and "FIXME ignore" a few tests * Remove an s * Disable blocking queries for KV to revert to previous release for now * Fixup adapter tests to follow async/function resolving interface * Fixup all the serializer integration tests * Fixup service/repo integration tests * Fixup deleting acceptance test * Fixup some ent tests * Make sure nspaces passes the dc through for when thats important * ...aaaand acceptance nspaces with the extra dc param	3 years ago
John Cowen	b16a6fa033	ui: Adds Partitions to the HTTP layer (#10447) ... This PR mainly adds partition to our HTTP adapter. Additionally and perhaps most importantly, we've also taken the opportunity to move our 'conditional namespaces' deeper into the app. The reason for doing this was, we like that namespaces should be thought of as required instead of conditional, 'special' things and would like the same thinking to be applied to partitions. Now, instead of using code throughout the app throughout the adapters to add/remove namespaces or partitions depending on whether they are enabled or not. As a UI engineer you just pretend that namespaces and partitions are always enabled, and we remove them for you deeper in the app, out of the way of you forgetting to treat these properties as a special case. Notes: Added a PartitionAbility while we were there (not used as yet) Started to remove the CONSTANT variables we had just for property names. I prefer that our adapters are as readable and straightforwards as possible, it just looks like HTTP. We'll probably remove our formatDatacenter method we use also at some point, it was mainly too make it look the same as our previous formatNspace, but now we don't have that, it instead now looks different! We enable parsing of partition in the UIs URL, but this is feature flagged so still does nothing just yet. All of the test changes were related to the fact that we were treating client.url as a function rather than a method, and now that we reference this in client.url (etc) it needs binding to client.	3 years ago
Kenia	eeeb91beaa	ui: Hide all metrics for ingress gateway services (#10858)	3 years ago
Kenia	a907e1d879	ui: Add support in Topology view for Routing Configurations (#10872)	3 years ago
John Cowen	a0b0ed2bca	ui: [BUGFIX] Add missing `@` to fix missing non-subset Failovers (#10913) ... This commit fixes a problem where parent Failovers where not showing (subset children were fine). Seems to have been introduced with a move/glimmer upgrade here #9154 so I'm adding a 1.9.x backport.	3 years ago
Kenia	a777b0a9ba	ui: Disabling policy form fields from users with 'read' permissions (#10902)	3 years ago
John Cowen	8192dde485	ui: Unskip auth-method serializer test (#10878) ... During #9617 we added a list view only for AuthMethods, but not a detail view. We did add the Adapter/Serializer that collected/reshaped data for a detail view. The test for this serializer was skipped here, but I'm not sure why. We then added #9845 which began to use this AuthMethod Serializer, but we didn't go back to finish up the skipped test here either. This PR unskips this test and finishes off the test correctly.	3 years ago
John Cowen	05a28c3111	ui: [BUGFIX] Properly encode non-URL safe characters in OIDC responses (#10901) ... This commit fixes 2 problems with our OIDC flow in the UI, the first is straightforwards, the second is relatively more in depth: 1: A typo (1.10.1 only) During #10503 we injected our settings service into the our oidc-provider service, there are some comments in the PR as to the whys and wherefores for this change (https://github.com/hashicorp/consul/pull/10503/files#diff-aa2ffda6d0a966ba631c079fa3a5f60a2a1bdc7eed5b3a98ee7b5b682f1cb4c3R28) Fixing the typo so it was no longer looking for an unknown service (repository/settings > settings) fixed this. 2: URL encoding (1.9.x, 1.10.x) TL;DR: /oidc/authorize/provider/with/slashes/code/with/slashes/status/with/slashes should be /oidc/authorize/provider%2Fwith%2Fslashes/code%2Fwith%2Fslashes/status%2Fwith%2Fslashes When we receive our authorization response back from the OIDC 3rd party, we POST the code and status data from that response back to consul via acallback as part of the OIDC flow. From what I remember back when this feature was originally added, the method is a POST request to avoid folks putting secret-like things into API requests/URLs/query params that are more likely to be visible to the human eye, and POSTing is expected behaviour. Additionally, in the UI we identify all external resources using unique resource identifiers. Our OIDC flow uses these resources and their identifiers to perform the OIDC flow using a declarative state machine. If any information in these identifiers uses non-URL-safe characters then these characters require URL encoding and we added a helper a while back to specifically help us to do this once we started using this for things that required URL encoding. The final fix here make sure that we URL encode code and status before using them with one of our unique resource identifiers, just like we do with the majority of other places where we use these identifiers.	3 years ago
Kenia	ae9c313382	ui: Update intention permissions notice wording (#10836)	3 years ago
Kenia	019ce785ab	ui: Create Routing Configurations route and page (#10835)	3 years ago
Kenia	ab6a675209	ui: Split up the socket mode from the socket path (#10581)	3 years ago
Kenia	bcd53e73a2	ui: Add Vault as a Service External Source (#10769)	3 years ago
Kenia	8ad1ab9c08	ui: Fix Health Checks in K/V form Lock Sessions Info section (#10767)	3 years ago
Kenia	2ee501be8d	ui: Add copy button for Secret ID in Tokens list page (#10735)	3 years ago
Kenia	eb5512fb74	ui: Fix dropdown option duplications (#10706)	3 years ago
Kenia	1eb7a83eec	ui: Add tests for topology metrics stats (#10600)	3 years ago
John Cowen	0762da3a62	ui: [BUGFIX] Ensure we use the ns query param name when requesting permissions (#10608) ... Previously when namespaces were enabled, we weren't requesting permission for the actively selected namespace, and instead always checking the permissions for the default namespace. This commit ensures we request permissions for the actively selected namespace.	3 years ago
John Cowen	3e80e637ba	ui: [BUGFIX] Fix KV Code Editor syntax loading (#10605) ... This commit adds a bit of string wrangling to avoid the keys in our javascript source file also being transformed. Additionally, whilst looking at this we decided that Maps are a better dictionary than javascript objects, so we moved to use those here also (but this doesn't affect the issue)	3 years ago
John Cowen	54f0cd812a	ui: Show the correct 'ACLs Disabled' page when ACLs are disabled (#10604) ... Adds 'can access ACLs' which means one of two things 1. When ACLs are disabled I can access the 'please enable ACLs' page 2. When ACLs are enabled, its the same as canRead	3 years ago
John Cowen	b256313256	ui: [BUGFIX] Ensure in-folder KVs are created in the correct folder (#10569) ... When clicking to create a KV within folder name, would would be viewing a form that was a form for creating a KV in the root, which when the user clicked to save, saved the KV in the root. For the moment at least I've removed the code that strips double slashes, and whilst this isn't ideal, it looks like we've picked up one of those bugs that turns into a 'feature', and completely reworking KV to not rely on the double slashes is not really an option right now.	3 years ago
Kenia	a96e87aece	ui: Add socket icon for UDS (#10573)	3 years ago
John Cowen	6fbeea5def	ui: Don't default to the default namespace, use the token default namespace instead (#10503) ... The default namespace, and the tokens default namespace (or its origin namespace) is slightly more complicated than other things we deal with in the UI, there's plenty of info/docs on this that I've added in this PR. Previously: When a namespace was not specified in the URL, we used to default to the default namespace. When you logged in using a token we automatically forward you the namespace URL that your token originates from, so you are then using the namespace for your token by default. You can of course then edit the URL to remove the namespace portion, or perhaps revisit the UI at the root path with you token already set. In these latter cases we would show you information from the default namespace. So if you had no namespace segment/portion in the URL, we would assume default, perform actions against the default namespace and highlight the default namespace in the namespace selector menu. If you wanted to perform actions in your tokens origin namespace you would have to manually select it from the namespace selector menu. This PR: Now, when you have no namespace segment/portion in the URL, we use the token's origin namespace instead (and if you don't have a token, we then use the default namespace like it was previously) Notes/thoughts: I originally thought we were showing an incorrectly selected namespace in the namespace selector, but it also matched up with what we were doing with the API, so it was in fact correct. The issue was more that we weren't selecting the origin namespace of the token for the user when a namespace segment was omitted from the URL. Seeing as we automatically forward you to the tokens origin namespace when you log in, and we were correctly showing the namespace we were acting on when you had no namespace segment in the URL (in the previous case default), I'm not entirely sure how much of an issue this actually was. This characteristic of namespace+token+namespace is a little weird and its easy to miss a subtlety or two so I tried to add some documentation in here for future me/someone else (including some in depth code comment around one of the API endpoints where this is very subtle and very hard to miss). I'm not the greatest at words, so would be great to get some edits there if it doesn't seem clear to folks. The fact that we used to save your previous datacenter and namespace into local storage for reasons also meant the interaction here was slightly more complicated than it needed to be, so whilst we were here we rejigged things slightly to satisfy said reasons still but not use local storage (we try and grab the info from higher up). A lot of the related code here is from before we had our Routlets which I think could probably make all of this a lot less complicated, but I didn't want to do a wholesale replacement in this PR, we can save that for a separate PR on its own at some point.	3 years ago
Daniel Nephin	2c4f22a9f0	Merge pull request #10552 from hashicorp/dnephin/ca-remove-rotation-period ... ca: remove unused RotationPeriod field	3 years ago
John Cowen	74070c0955	ui: Add intl debug helpers (#10513) ... This commit adds a couple of debug utilities to help us to continue slowly adding i18n support: - We've added a CONSUL_INTL_DEBUG env/cookie variable to turn off variable interpolation within the t helper so you can see which variables are being interpolated. - We've added a CONSUL_INTL_LOCALE env/cookie which currently supports two 'pseudo-locales' - la-fk (fake latin) and - (just dashes) either of which will make it easier to see what has not been localized until we can add prettier rules to prevent adding any copy into templates at all. I would guess if we ever translated the app we would use this for looking at things whilst developing also - but as yet I've not adding anything for that here seeing as we don't translate anything. Both variables are dev-time only and all code for this is removed from the production build.	3 years ago
John Cowen	b0d69efcc1	ui: Allow disabling of sourcemaps via env var (#10491)	3 years ago
John Cowen	e541a43b37	ui: Fixup definition-table + copy-button margin (#10512)	3 years ago
John Cowen	a6996b6ea5	ui: CopyButton amends (#10511) ... * ui: Add with-copyable modifier * Use with-copyable modifier for our own CopyButton * Move copy-button styling and remove most of `copy-btn`	3 years ago
jkirschner-hashicorp	5f73de6fbc	Merge pull request #10560 from jkirschner-hashicorp/change-sane-to-reasonable ... Replace use of 'sane' where appropriate	3 years ago
Daniel Nephin	3a045cca8d	ca: remove unused RotationPeriod field ... This field was never used. Since it is persisted as part of a map[string]interface{} it is pretty easy to remove it.	3 years ago
Jared Kirschner	bd536151e1	Replace use of 'sane' where appropriate ... HashiCorp voice, style, and language guidelines recommend avoiding ableist language unless its reference to ability is accurate in a particular use.	3 years ago
John Cowen	ace794d214	ui: Enable specifying additional docfy config as json (#10464)	3 years ago
John Cowen	c78f7ecb27	ui: Colocate remaining CSS components to the app/components folder (#10328)	3 years ago
John Cowen	043f631b7f	ui: Rename icons for consistency and remove unused icons (#10311) ... * ui: Standardize logo naming According to structure it should always be logo-name not name-logo * Make sure all our logos use logo-name format * Upgrade to @hashicorp/structure-icons 1.9.0 * Add `-color` to be consistent with other logos * Add ms logo back in * Remove all the old `*-color` icons from before when we got masks * Add missing files * Missed glimmer extend name change	3 years ago
John Cowen	4bddd52103	ui: Increase z-index of main menus to avoid layering issues (#10428)	3 years ago
John Cowen	5f17062b0a	ui: Add resolution for xmlhttprequest-ssl at least 1.6.3 (#10370)	3 years ago
John Cowen	9eab715149	ui: Move all our icons to use CSS custom properties instead of SASS vars (#10298) ... * ui: Move all our icons to use CSS custom properties The good thing about SASS vars is, if you don't use them they get removed from the final build. Whereas with CSS we have no tree-shaking to get rid of unused CSS custom properties. We can mostly work around this and for some things like colors its no big deal if we have some hex-codes in the build that we don't use as hex-codes are relatively small. We've been slowly but surely moving all of our colors (and other things) to use CSS custom properties instead of SASS vars now that we have them available. This commit makes use of the 'tree-shaking' abilities of @extend to ensure that we only compile in the icons that we use. This commit is mostly churn-less as we already use @extend for the majority of our icons, so generally there is zero change here for working on the UI, but I did spot one single place where we were using SASS vars instead of @extend. This now uses the new form (second commit) Interestingly this reduces our CSS payload by ~2kb to ~53kb (around 25kb of that is these icons)	3 years ago
John Cowen	ac424187fe	ui: %horizontal-kv-list CSS component (and related) (#10285) ... This commit uses docfy to isolate the individual parts and options and investigates the why you might use certain options and document how you might use certain options. Originally we used a single %icon-definition CSS component to represent this, but seeing as some of them don't have icons, it didn't seem like the best name. So this PR splits this component into various different ones and then uses the new ones to continue to provide a now deprecated %icon-definition. The component is currently a CSS only component that assumes a single (or multiple) description lists for its markup component, and provides for multiple different options (including a reversed mode which I'm still not totally sure about, but we don't use this right now anyway). - %icon-definition - %horizontal-kv-list - %csv-list - %tag-list - %badge	3 years ago
John Cowen	18190fb071	ui: Move intention description field (#10292) ... ...from under the permissions widget to over the permissions widget	4 years ago
John Cowen	ddee7afbb9	ui: Fixup prettier for scss files and run (#10296) ... * ui: Ensure prettier makes all our scss files pretty * Run prettier on all our scss files	4 years ago
John Cowen	af72b9e9ab	ui: Unix Domain Socket support (#10287) ... This commit adds UI support for Unix Domain Sockets for upstream and downstreams (see #9981 and #10252)	4 years ago
John Cowen	2e4c9f5330	ui: Support Route optional parameters/segments (#10212) ... Moves our URLs with 'optional namespace segment' into a separately abstracted 'optional URL segment' feature	4 years ago
John Cowen	e11454cf71	ui: Colocate old base components into our app/component folder (#10275)	4 years ago
John Cowen	a73b38a368	ui: Minor CSS tweaks (#10295)	4 years ago
Kenia	f3efde3843	ui: Create and use collapsible notices component (#10270) ... * Create and use collapsible notices * Refactor collapsible-notices * Split up the topology acceptance tests * Add acceptance tests for tproxy notices * Add component file * Adds additional TProxy notices tests * Adds conditional to only show collapsable if more than 2 notices are present * Adds changelog * Refactorting the conditonal for collapsing the notices * Renaming undefinedIntention to be notDefinedIntention * Refactor tests	4 years ago
John Cowen	600f857531	ui: Add docs for AppView (#10265) ... * ui: change coloring of secondary navigation elements * Remove top border, this was probably from older designs/iterations * ui: Move app-view styles into components also... 1. Remove dead %app-view-content-error 2. Remove TabNav border overwriting * Bring into line with our 'project standard' class/attributes pattern * Add docs for AppView	4 years ago
John Cowen	dd4a66808d	ui: change coloring of secondary navigation elements (#10259)	4 years ago
John Cowen	4e420df7ae	ui: Adds QUnit toggle bookmarklet to our docs (#10269)	4 years ago
John Cowen	39302041e9	ui: Miscellaneous Lock Session fixes (#10225)	4 years ago
John Cowen	8301e79c56	ui: Bump node to v14 (#10238)	4 years ago
John Cowen	d1bbe0895f	ui: Use babel plugin to strip calls to runInDebug (#10237)	4 years ago
John Cowen	04bd576179	ui: Serf Health Check warning notice (#10194) ... When the Consul serf health check is failing, this means that the health checks registered with the agent may no longer be correct. Therefore we show a notice to the user when we detect that the serf health check is failing both for the health check listing for nodes and for service instances. There were a few little things we fixed up whilst we were here: - We use our @replace decorator to replace an empty Type with serf in the model. - We noticed that ServiceTags can be null, so we replace that with an empty array. - We added docs for both our Notice component and the Consul::HealthCheck::List component. Notice now defaults to @type=info.	4 years ago