365 Commits (66a51c9701e476c18060ad35de9669441ea1d110)

Author	SHA1	Message	Date
John Cowen	6ffe0e6fe4	ui: Use the `each key=""` parameter to force ember to reuse DOM (#7550) ... Ember tries to reuse DOM elements when it can but as ember looks for changes to objects rather than the DOM itself sometimes. This and the fact that an objects identity may change even though its value hasn't, results in ember occasionally re-mutating DOM when it doesn't need to. The `each` helper includes a `key` attribute to hint to ember what it should look for when deciding whether something has changed, rather than the objects identity. https://api.emberjs.com/ember/release/classes/Ember.Templates.helpers/methods/each#specifying-keys We use this here to fix an issue where DOM was being redrawn after the user had scrolled the page and was therefore resetting the scroll back to 0 (the top of the page)	5 years ago
John Cowen	31b9b90bc3	ui: Ensure blocking query configuration is passed through to findInstanceBySlug (#7543) ... * ui: Ensure configuration is passed through to findInstanceBySlug Due to the addition of namespace support, this arguments passed to this method have been increased. Whilst the nspace support continues ot work here, the configuration for blocking queries is never passed through. This results in a 2 second poll rather than a blocking query. This commit fixes that * ui: Add a basic test to check the number of arguments passed through	5 years ago
John Cowen	5f625666b4	ui: Enable recovery from an unreachable datacenter (500 error) (#7404) ... For URL maintenance reasons we store the last visited DC in localStorage incase you come back to a page (for example settings) that doesn't have a dc in the URL. A problem arises here if the last DC you tried to visit is unreachable. The first fix here clears out the last visited DC from localStorage if the API has errored out. Secondly, our `href-mut` helper which mutates the current current and replaces 'parts' in the URL rather than the whole thing functioned by detecting the current route/URL you are on an 'mutating' that. A problem arose here as even though you might be on the `/ui/dc-1/services` URL the actual route is the 'error' route which does not have a URL that can be changed properly. The second fix here uses route.currentRoute.name over route.currentRouteName. The latter is equal to error when an error occurs whereas the former gives you the name of the route before the error happened, which is actually what we want/the intent here. ie. when `router.currentRouteName === 'error'` then `router.currentRoute.name === Name Of Route Before It Errored` it seems	5 years ago
John Cowen	6074a1b4c8	ui: Coordinates don't require a nspace, so don't expect one in the repo (#7378) ... * ui: Coordinates don't require a nspace, so don't expect one in the repo * Add a test to prove the correct number of arguments are being passed	5 years ago
John Cowen	468e82dcf9	ui: Alter position of logic for showing the Round Trip Time tab to prevent DOM refresh (#7377) ... * ui: Move tomography length check inside of the partial Previously we checked the length of tomography.distances to decide whether to show the RTT tab or not. Previous to our ember upgrade this would not cause a DOM reload of so many elements (i.e. all of the tab content). Since our ember upgrade, any change to tomography (so not necessarily the length of distances) seems to fire a change to the length (even if the length remains the same). The knock on effect of this is that the array of tab panels seems to be recalculated (but remain the same) and all of the tab panels are completely re-rendered, causing the scroll of the page to be reset. This commit moves the check for tomography.distance.length to the lower down with the loop, which means the array of tab panels always remains the same, which consequently means that the entire array of tab panels is never re-rendered entirely, and therefore fixes the issue.	5 years ago
John Cowen	74ade640e3	ui: Use WithEventSource mixin on intentions to ensure cleanup (#7333) ... The WithEventSource mixin has a reset method when the Controller is exited which will close any open EventSources/Blocking queries. This adds it in for intentions	5 years ago
John Cowen	e85fd18f89	ui: Be more specific with the display toggling checkboxes (#7309)	5 years ago
John Cowen	b83c190f0c	ui: Use options.method for keying not options.type (#7308)	5 years ago
John Cowen	65dd14daf3	ui: Gracefully cope with 500 errors from the disco-chain API endpoint (#7291) ... When connect is disabled the discovery-chain endpoint returns a 500 error status, which we previoulsy did not gracefully cope with. This commit gracefully copes with any errors from the disco-chain endpoint by supressing the error and hiding the Routing tab from the Service detail page. Acceptance test included	5 years ago
John Cowen	ebc574c509	ui: oss don't ever POST/PUT Namespaces when writing data (#7238) ... * ui: Ensure we use nonEmptySet everywhere where we add Namespace We missed a coupld of places where we use the noEmptySet function, which will only perform the set if the specified property is non-empty. Currently we aren't certain there is a place in OSS where a Namespace can make its way down via the API and endup being PUT/POSTed back out again when saved. If this did ever happen we would assume it would be the default namespace, but we add an extra check here to ensure we never PUT/POST the Namespace property if Namespaces are disabled. * ui: Add step/assertion for assert if a property is NOT set in the body * ui: Improve updated/create acc testing for policy/token/roles: Including making sure a Namespace property is never sent through if you are running without namespace support	5 years ago
John Cowen	eb35d89893	ui: Run 2 separate test runs oss and ent (#7214) ... * ui: Make API integration tests aware of CONSUL_NSPACES_ENABLED * ui: Allow passing CONSUL_NSPACES_ENABLED in via the cli in ember * ui: Add more makefile targets/package scripts to switch NSPACEs on/off * ui: Ensure all acceptance tests continue to pass with NSPACEs on/off This required a little tweaking of the dictionary, at some point page-navigation and some of these little tweaks will no longer be required * ui: Try running CI frontend tests in two parellel runs oss/ent * ui: Use correct make target, use different names for the reports	5 years ago
John Cowen	9e186c7af8	ui: Fix for differences between uncompiled and compiled CSS (#7233) ... We noticed that this relative positioning is not even applied when the CSS is compiled/compressed. When looking via Web Inspector this style/selector doesn't even appear even though it is in the CSS source. This !important reduces the amount of selectors for this style rule, which fixes the error, so potentially this isn't a specificity thing.	5 years ago
John Cowen	ad3b5327d2	ui: Discovery chain improvements (#7222) ... * ui: remove the default word when describing routes * ui: Avoid mutating the chain and look for the default edges more safely * ui: Use not null check instead of a truthy check for showing disco-chain * ui: Upgrade consul-api-double for better disco-chain mocks/fixtures	5 years ago
John Cowen	279cd874cc	ui: Ensure KV flags are passed through to Consul on update (#7216) ... * ui: always pass KV flags through on update * ui: Integration test to prove the flags queryParams gets passed through * ui: Add Flags to the KV updating acceptance tests	5 years ago
Kenia	773b092a64	ui: Add ability to search nodes listing page with IP Address (#7204) ... * Update search field placeholder to display `Search` * Add an acceptance test to search node listings with node name and IP Address * Update and add unit tests for filter/search node listing with IP Address	5 years ago
Kenia	c706089c9f	ui: Hides the Routing tab for a service proxy (#7195) ... * Adds conditional in route to not make discovery-chain request if service kind is equal to `connect-proxy` or `mesh-gateway` * Adds conditional in template to not show Routing tab if `chain` returns as null * Creates a new acceptance test to test the Routing tab not being displayed for a service proxy * Adds `tabs` to the services/show page object	5 years ago
Kenia	b9e023dfe1	ui: Adds an acceptance test for hiding Blocking Queries (#7162) ... * Adds an acceptance test for hiding Blocking Queries * Creates a new scenario - If a user adds CONSUL_UI_DISABLE_REALTIME to localStorage, the Blocking Queries section is hidden. * Updates page assertion to accept functions and booleans as properties * ui: Fix "don't see" step to watch for the different pageObject error ember-cli-page object seems to throw a an error with a different message depending on how you call a function: currentPage()[property]() // message = 'Element not found' const prop = currentPage()[property]; prop() // message = 'Something about destructuring' This changes the step/test/assertion to ensure we check for both types of errors Co-authored-by: John Cowen <johncowen@users.noreply.github.com>	5 years ago
John Cowen	d5b6f3095e	ui: Move CI to use the Makefile for testing (+ tmporary removal of exam) (#7188) ... * ui: Move CI to use the Makefile for testing (+ tmporary removal of exam) * ui: make a specific test-ci target as we are using --path dist --path dist looks for a previous build to test against, in CI this exists as we run a build first, but locally potentially this dist folder doesn't	5 years ago
John Cowen	f45880bffe	ui: Fix sticky nspace menu (#7164) ... * ui: Fix typo expanded > ariaExpanded * ui: Add the things we need to test this * ui: Add tests for testing the menu closes when clicked * ui: Ensure the aria-menu closes on route change	5 years ago
John Cowen	a8504802db	ui: Split splitter names in the discovery-chain (#7180) ... Previous to 1.7 splitter names didn't include the namespace name i.e. 'service-name' as of 1.7 they now include the namespace i.e. 'service-name.namespace' This commit take account of that	5 years ago
John Cowen	3eec5edadf	ui: Discovery-Chain: Cope with some edge case configs (#7174) ... * ui: Discovery-Chain: Cope with redirects that have failovers We found a few stranger configurations for discovery-chain, one of which was redirects that can then failover. We altered the parsing here to include 2 passes, one to organize the nodes into resolvers and children/subsets based on the nodes themselves, which includes adding the failovers to resolvers and subsets. We then do a second pass which can more reliably figure out whether a target is a redirect or a failover (target failovers don't have a corresponding node), this then adds the redirect children to the already exising resolver (from the first pass) and then checks if the redirect also has failovers and adds those if so. * ui: Check to see if we have a user configured default route or not ...if we don't add one so the visualization looks complete	5 years ago
John Cowen	ac60338269	ui: Add live updates/blocking queries to the Intention listing page (#7161) ... * ui: Enable blocking queries/live updates for intentions * ui: Add acceptance tests for intention blocking queries * ui: Add copy to explain that intentions are also now 'real time'	5 years ago
John Cowen	e568cded17	ui: Add node based configuration / environment testing (#7140) ... In an ember environment `config/environment.js` exports a JSON object whereas the file itself exports a function that receives a string of the environment name that would like returning. This is so ember can automatically provide you with an already configured object containing configuration values dependent on which environment you passed to `ember-cli` using `serve`, `build` or `test`. In order to bypass this so we can easily test what is returned for different environments, we've installed a lightweight functional test harness that is simple to use `substack/tape`, that can be run easily outside of ember. We've then written as simple test case using this to enable us to test/assert that different environments return the correct configuration values. Additionally we've added some yarn scripts/make targets (yarn run test-node / make test-node) to make this easy to run. We're yet to integrate this into CI.	5 years ago
John Cowen	d47f1ca2a9	ui: Fix wrapping service ids in the Node Detail > Services tab (#7149)	5 years ago
John Cowen	c6e72c3e46	ui: Fix positioning of active icon in the selected menu item (#7148)	5 years ago
Kenia	ff315c95fd	ui: Implements the ember-page-title addon to the UI (#7118) ... * Installs ember-page-title 5.x * Adds a page title to all template files that need one * Adds an assertion step to test the page titles	5 years ago
John Cowen	1ff8678df7	ui: Remove the Policy/Service Identity selector from nspaces (#7124) ... When editing Nspaces, although you can assign policies to a nspace using PolicyDefaults you cannot assign a Service Identity to a policy like you can when adding a policy to a token. This commit adds an extra attribute to our policy-form/policy-selector component so you can disable this setting. At a later date we may change this to have a conficgurable `<Slot />` instead. Simple acceptance tests is included here	5 years ago
John Cowen	db96603a19	ui: Change environment switch statement to correct env vars	5 years ago
John Cowen	327aac9fe9	ui: Acceptance test improvements to prepare for more NS tests (#6980) ... * ui: Acceptance test improvements to prepare for more NS tests * ui: Namespace acceptance testing (#7005) * Update api-double and consul-api-double for http.body * Adds places where we missed passing the nspace through * Hardcode nspace CRUD to use the default nspace for policies and roles * Alter test helpers to allow us to control nspaces from the outside * Amends to allow tests to account for namespace, move ns from queryParam 1. We decided to move how we pass the namespace value through to the backend when performing write actions (create, update). Previoulsy we were using the queryParam although using the post body is the preferred method to send the Namespace details through to the backend. 2. Other various amends to take into account testing across multiple namespaced scenarios * Enable nspace testing by default * Remove last few occurances of old style http assertions We had informally 'deprecated' our old style of http assertions that relied on the order of http calls (even though that order was not important for the assertion). Following on from our namespace work we removed the majority of the old occrances of these old style assertions. This commit removes the remaining few, and also then cleans up the assertions/http.js file to only include the ones we are using. This reduces our available step count further and prevents any confusion over the usage of the old types and the new types. * ui: Namespace CRUD acceptance tests (#7016) * Upgrade consul-api-double * Add all the things required for testing: 1. edit and index page objects 2. enable CONSUL_NSPACE_COUNT cookie setting 3. enable mutating HTTP response bodies based on URL * Add acceptance test for nspace edit/delete/list and searching	5 years ago
Kenia	b836a772fc	ui: Checks env CONSUL_UI_DISABLE_REALTIME to show/hide blocking queries toggle (#7099) ... Adds a conditional that checks env CONSUL_UI_DISABLE_REALTIME to show/hide the Blocking Queries toggle in the Settings page.	5 years ago
John Cowen	afafe677a3	ui: New Confirmation Dialogs (#7007) ... * ui: Change action-group to use new popup-menu component in intentions * ui: Slight amends to aria-menu to prevent scrolling * ui: Begin to use aria-menu/popover-menu for other elements * Use a simpler, hackier method to fix up zIndexing * ui: Implement new confirmation dialogs in other list views (#7080) This includes another amend to the popover-menu in order to allow mutiple confirmations/subpanels in the same popover menu. The functionality added here to allow this is likely to change in the future.	5 years ago
John Cowen	a65d941e76	ui: Improve configuration/env/feature flag usage (also add build time year detection) (#7072) ... * Add new getEnvironment util/function * Use new-ish `env` function in all the places * Clean up ember env file, add year detection from commit date	5 years ago
John Cowen	ac613993bb	ui: Keyboard navigation improvements (#7090) ... * ui: Improve keyboard access for some custom components * ui: Add some accessibility related metadata	5 years ago
John Cowen	e15d1466aa	ui: Discovery Chain Improvements (#7036) ... * Reorganize resolvers so its clearer what's happening * Use entire route definition for id * Clean up a tiny bit more, use guid for ids instead of JSON * ui: Externalize disco-chain utils and add initial unit testing * Add some click outside-ness for de-highlighting things	5 years ago
John Cowen	13eb536e24	ui: Use structure-icons as much as possible (#6851) ... * ui: Delete a bunch of CSS that we recently moved elsewhere * ui: Add some masking placeholders * Switch out hashicorp logo for one from structure-icons * Change copy-button to use new copy-action icon * Change secret-button to use new visibility-hide/show icons * New folder icon for KVs * Cleanup some of the icons we no longer use * Switch from %with-exit to standard-like %with-exit-icon * Move all chevrons to use structure-icons properly * Use star-fill as much as possible * Remove the remaining icons from icons/index plus the file itself	5 years ago
John Cowen	06d09d11f1	ui: Move slots to use attributes over positional params (#7032) ... * Change all instances of yield/block-slots to use attributes over positional arguments * Remove the ability to use yield/block-slots with positional params	5 years ago
John Cowen	99fae9d65a	ui: Make sure that the namespace is passed when changing a token via [Use] (#6973) ... * Pass the namespace parameter through to the repo when using a token * Refresh the namespace menu when somebody [Use]s a token	5 years ago
John Cowen	18bafaec35	ui: Cope with the possibility of receiving no namespaces (#6975)	5 years ago
John Cowen	b2c0c08e08	Ensure ember-data ids are created correct taking into account the nspace (#6974)	5 years ago
John Cowen	36728b961f	ui: Various amends for 1.7beta (#6965) ... * Remove empty init * Actually make the disco chain endpoint send the nspace, note: The backend doesn't support this as yet. * Tweak the font size of flash-messages ever so slightly * Make sure the nspace menu is kept up to date when creating a new one * Move comment to the correct place * Only refresh the namespace menu if you specifically created a nspace * Change FIXMEs to TODOs as we are happy for these to wait until later	5 years ago
John Cowen	aa680d5f0c	ui: Discovery Chain (#6746) ... * Add data layer for discovery chain (model/adapter/serializer/repo) * Add routing plus template for routing tab * Add extra deps - consul-api-double upgrade plus ngraph for graphing * Add discovery-chain and related components and helpers: 1. discovery-chain to orchestrate/view controller 2. route-card, splitter-card, resolver card to represent the 3 different node types. 3. route-match helper for easy formatting of route rules 4. dom-position to figure out where things are in order to draw lines 5. svg-curve, simple wrapper around svg's <path d=""> attribute format. 6. data-structs service. This isn't super required but we are using other data-structures provided by other third party npm modules in other yet to be merged PRs. All of these types of things will live here for easy access/injection/changability 7. Some additions to our css-var 'polyfill' for a couple of extra needed rules * Related CSS for discovery chain 1. We add a %card base component here, eventually this will go into our base folder and %stats-card will also use it for a base component. 2. New icon for failovers * ui: Discovery Chain Continued (#6939) 1. Add in the things we use for the animations 2 Use IntersectionObserver so we know when the tab is visible, otherwise the dom-position helper won't work as the dom elements don't have any display. 3. Add some base work for animations and use them a little 4. Try to detect if a resolver is a redirect. Right now this works for datacenters and namespaces, but it can't work for services and subsets - we are awaiting backend support for doing this properly. 5. Add a fake 'this service has no routes' route that says 'Default' 6. redirect icon 7. Add CSS.escape polyfill for Edge	5 years ago
John Cowen	7044aa52c8	ui: Namespace Support (#6639) ... Adds namespace support to the UI: 1. Namespace CRUD/management 2. Show Namespace in relevant areas (intentions, upstreams) 3. Main navigation bar improvements 4. Logic/integration to interact with a new `internal/acl/authorize` endpoint	5 years ago
John Cowen	f06c3adca5	ui: %form-element-textarea > %form-area-textinput typo (#6952)	5 years ago
John Cowen	74e2b95535	ui: Fixes styling of 'duplicate intention' error message (#6936)	5 years ago
John Cowen	ab461f6603	ui: Remove `writable` usage from policy and use the request instead (#6934)	5 years ago
John Cowen	520eb41393	ui: Use base fonts throughout the app (#6881) ... We've had a set of %placeholders in our base styles for quite a while but not butten the bullet to use them. This begins to use them. We had to make a small amount of tweaks to base whilst doing this, but its as we'd prefer there to be as few font placeholders as possible. We might/should be able to reduce these further at somepoint, or potentially rename them. We currently have six header fonts (or 4 header fonts/2 strong body fonts) and 3 body fonts. We also noticed an empty CSS file and deleted that while we were here. We also noticed that the bottom border of structure tabs was a pixel larger than ours so we tweaked that here also.	5 years ago
John Cowen	7f2a1e8a54	ui: Remove some javascript files we no longer use (#6853)	5 years ago
John Cowen	8017b5ab6e	ui: Ensure %app-content > %app-view-content rename is complete (#6843) ... In https://github.com/hashicorp/consul/pull/6575 we changed the name of %app-content to %app-view-content, but missed a few places that needed renaming, this corrects that.	5 years ago
John Cowen	e6ecb47765	ui: Expose checks (#6575) ... Adds visibility for `Expose.Checks` config setting for proxies. 1. Adds an 'Exposed Path' tab to the proxy detail page to show the user information on exposed paths. 2. If the users has exposed their healthchecks we also add this information to the Service detail page for this proxy (only for http2 and gRPC checks)	5 years ago
John Cowen	5a2fc5bffb	ui: CSS Upgrade (action-group,form-elements,sliding-toggle,breadcrumbs) (#6495) ... This includes an update of our CSS npm module. The majority of this is just moving files from one folder to another. 1. %breadrumbs: As well as moving we've added 'milestone' breadcrumbs 2. %checkbox-group: Moved 3. %radio-group: Moved 4. %sliding-toggle: Moved (used to be called just %toggle) 5. %form-elements: Moved and added a new %inline-alert for form field messaging (see Structure design system) 6. %action-group is now a composition of %menu-panel, %toggle-button, plus edits to existing style to bring the %action-groups inline with the dropdowns from Structure). %action-group also includes a composed %confirmation-alert that is yet to be include. This will be compiled out until we integrate it. We've also removed some of our old icon placeholders as the above work seased to use some of them. Now we done this I'd say all in all over half of our CSS components now use the CSS npm module. The CSS specific to Consul UI also uses much of this CSS module by way of helper placeholders such as our %frames.	5 years ago