consul

Commit Graph

Author	SHA1	Message	Date
John Cowen	a65d941e76	ui: Improve configuration/env/feature flag usage (also add build time year detection) (#7072 ) * Add new getEnvironment util/function * Use new-ish `env` function in all the places * Clean up ember env file, add year detection from commit date	5 years ago
John Cowen	86208b4a70	ui: Add an additional 'more than 1 char' check for selection (#6022 ) We'd rather 'play it safe' for our selection detection (which avoids following links if you have some text selected). This commit adds an additional check of 'more than 1 character' to the 'isSelected' check. This is based on the fact that it's far quicker to type the character so why would a user select on character? This therefore caters for any fairly large (in the scheme of things) incidential mouse moves whilst clicking a link. Overall this is probably overkill	5 years ago
John Cowen	e609defd70	ui: Allow text selection of clickable elements and their contents (#5770 ) * ui: Allow text selection of clickable elements and their contents This commit disables a click on mousedown be removing the `href` attribute and moving it to a `data-href` attribute. On mouseup it will only move it back if there is no selection. This means that an anchor will only be followed on click _if_ there is no selection. This fixes the fact that whenever you select some copy within a clickable element it immediately throws you into the linked page when you release your mouse. Further notes: We use the `isCollapsed` property here which 'seems' to be classed as 'experimental' in one place where I researched it: https://developer.mozilla.org/en-US/docs/Web/API/Selection/isCollapsed Although in others it makes no mention of this 'experimental' e.g: - https://webplatform.github.io/docs/dom/Selection/isCollapsed/ - https://w3c.github.io/selection-api/#dom-selection-iscollapsed I may have gone a little overboard in feature detection for this, but I conscious of that fact that if `isCollapsed` doesn't exist at some point in the future (something that seems unlikely). The code here will have no effect on the UI. But I'd specifically like a second pair of eyes on that. * ui: Don't break right click, detects a secondary click on mousedown * ui: Put anchor selection capability behind an ENV var	5 years ago

Author

SHA1

Message

Date

John Cowen

a65d941e76

ui: Improve configuration/env/feature flag usage (also add build time year detection) (#7072 )

* Add new getEnvironment util/function

* Use new-ish `env` function in all the places

* Clean up ember env file, add year detection from commit date

John Cowen

86208b4a70

ui: Add an additional 'more than 1 char' check for selection (#6022 )

We'd rather 'play it safe' for our selection detection (which avoids
following links if you have some text selected). This commit adds an
additional check of 'more than 1 character' to the 'isSelected' check.
This is based on the fact that it's far quicker to type the character so
why would a user select on character? This therefore caters for any
fairly large (in the scheme of things) incidential mouse moves whilst
clicking a link.

Overall this is probably overkill

John Cowen

e609defd70

ui: Allow text selection of clickable elements and their contents (#5770 )

* ui: Allow text selection of clickable elements and their contents

This commit disables a click on mousedown be removing the `href`
attribute and moving it to a `data-href` attribute. On mouseup it will
only move it back if there is no selection. This means that an anchor
will only be followed on click _if_ there is no selection.

This fixes the fact that whenever you select some copy within a
clickable element it immediately throws you into the linked page when
you release your mouse.

Further notes:

We use the `isCollapsed` property here which 'seems' to be classed as
'experimental' in one place where I researched it:

https://developer.mozilla.org/en-US/docs/Web/API/Selection/isCollapsed

Although in others it makes no mention of this 'experimental' e.g:

- https://webplatform.github.io/docs/dom/Selection/isCollapsed/
- https://w3c.github.io/selection-api/#dom-selection-iscollapsed

I may have gone a little overboard in feature detection for this, but I
conscious of that fact that if `isCollapsed` doesn't exist at some point
in the future (something that seems unlikely). The code here will have
no effect on the UI. But I'd specifically like a second pair of eyes on
that.

* ui: Don't break right click, detects a secondary click on mousedown

* ui: Put anchor selection capability behind an ENV var

3 Commits (5e5dbedd47a5f875b60e241c5555a9caab595246)