Pierre Souchay
8e7b8bb524
Fixed unit test TestCatalogListServicesCommand ( #4592 )
2018-08-27 13:53:46 -04:00
Pierre Souchay
af90c88f6a
Fixed unstable test TestRTTCommand_LAN in command/rtt ( #4585 )
2018-08-27 11:37:13 -04:00
Pierre Souchay
3f9d1370b7
Fix unstable test TestRegisterMonitor_heartbeat ( #4568 )
2018-08-24 13:33:58 -04:00
Shubheksha
fc3997f266
replace old fork of text package ( #4501 )
2018-08-14 12:23:18 -07:00
Freddy
6d43d24edb
Improve reliability of tests with TestAgent ( #4525 )
...
- Add WaitForTestAgent to tests flaky due to missing serfHealth registration
- Fix bug in retries calling Fatalf with *testing.T
- Convert TestLockCommand_ChildExitCode to table driven test
2018-08-14 12:08:33 -04:00
Freddy
e305443db4
Address flakiness in command/exec tests ( #4517 )
...
* Add fn to wait for TestAgent node and check registration
* Add waits for TestAgent and retries before timeouts in exec_test
2018-08-10 15:04:07 -04:00
Pierre Souchay
cec5d72396
BUGFIX: Unit test relying on WaitForLeader() did not work due to wrong test ( #4472 )
...
- Improve resilience of testrpc.WaitForLeader()
- Add additionall retry to CI
- Increase "go test" timeout to 8m
- Add wait for cluster leader to several tests in the agent package
- Add retry to some tests in the api and command packages
2018-08-06 19:46:09 -04:00
Mitchell Hashimoto
effb17098a
Merge pull request #4314 from hashicorp/b-ignore-check
...
command/connect/proxy: ignore check doesn't exist on -register
2018-07-25 11:26:40 -05:00
Mitchell Hashimoto
e39dfc919a
command/connect/proxy: ignore check doesn't exist on -register
2018-06-29 10:58:06 -07:00
Siva
5e04d7f1f1
Merge branch 'master' of github.com:hashicorp/consul into WinService
2018-06-26 16:49:50 -04:00
Paul Banks
c6ef6a61c9
Refactor to use embedded struct.
2018-06-25 12:25:39 -07:00
Paul Banks
32f362bad9
StartupTelemetry => InitTelemetry
2018-06-25 12:25:39 -07:00
Paul Banks
a7038454fd
WIP
2018-06-25 12:25:38 -07:00
Paul Banks
ecfda7cda5
Fix unreachable code warning from go vet
2018-06-25 12:24:15 -07:00
Paul Banks
d1c67d90bc
Fixs a few issues that stopped this working in real life but not caught by tests:
...
- Dev mode assumed no persistence of services although proxy state is persisted which caused proxies to be killed on startup as their services were no longer registered. Fixed.
- Didn't snapshot the ProxyID which meant that proxies were adopted OK from snapshot but failed to restart if they died since there was no proxyID in the ENV on restart
- Dev mode with no persistence just kills all proxies on shutdown since it can't recover them later
- Naming things
2018-06-25 12:24:14 -07:00
Mitchell Hashimoto
caae034f3b
command/connect/proxy: can specify prepared query upstream types
2018-06-25 12:24:13 -07:00
Paul Banks
cdc7cfaa36
Abandon daemonize for simpler solution (preserving history):
...
Reverts:
- bdb274852ae469c89092d6050697c0ff97178465
- 2c689179c4f61c11f0016214c0fc127a0b813bfe
- d62e25c4a7ab753914b6baccd66f88ffd10949a3
- c727ffbcc98e3e0bf41e1a7bdd40169bd2d22191
- 31b4d18933fd0acbe157e28d03ad59c2abf9a1fb
- 85c3f8df3eabc00f490cd392213c3b928a85aa44
2018-06-25 12:24:10 -07:00
Paul Banks
ba0fb58a72
Make daemoinze an option on test binary without hacks. Misc fixes for racey or broken tests. Still failing on several though.
2018-06-25 12:24:09 -07:00
Paul Banks
2b377dc624
Run daemon processes as a detached child.
...
This turns out to have a lot more subtelty than we accounted for. The test suite is especially prone to races now we can only poll the child and many extra levels of indirectoin are needed to correctly run daemon process without it becoming a Zombie.
I ran this test suite in a loop with parallel enabled to verify for races (-race doesn't find any as they are logical inter-process ones not actual data races). I made it through ~50 runs before hitting an error due to timing which is much better than before. I want to go back and see if we can do better though. Just getting this up.
2018-06-25 12:24:08 -07:00
Siva
319a0ae2bf
Graceful exits added
2018-06-20 14:42:08 -04:00
Kyle Havlovitz
61d7e38148
Clarify CA commands' help text
2018-06-14 09:42:23 -07:00
Kyle Havlovitz
6ca7543ea6
Add CA CLI commands for getting/setting config
2018-06-14 09:42:22 -07:00
Mitchell Hashimoto
7d24ecd700
command/connect/proxy: register monitor tests
2018-06-14 09:42:22 -07:00
Mitchell Hashimoto
eb2a6952ba
address comment feedback
2018-06-14 09:42:22 -07:00
Mitchell Hashimoto
db10240bea
command/connect/proxy: register monitor and -register flag
2018-06-14 09:42:22 -07:00
Mitchell Hashimoto
1db42050bd
command/connect/proxy: output information when starting similar to agent
2018-06-14 09:42:21 -07:00
Mitchell Hashimoto
55c6d34ea0
command/connect/proxy: detailed help
2018-06-14 09:42:21 -07:00
Mitchell Hashimoto
b1d709fc9f
command/connect/proxy: -service-addr required for -listen
2018-06-14 09:42:21 -07:00
Mitchell Hashimoto
83f2509c6f
command/connect/proxy: can set public listener from flags
2018-06-14 09:42:21 -07:00
Mitchell Hashimoto
c93ba83310
command/connect/proxy: tests for configuration
2018-06-14 09:42:21 -07:00
Mitchell Hashimoto
42ee214c8a
command/connect/proxy: accept -service and -upstream
2018-06-14 09:42:21 -07:00
Mitchell Hashimoto
8c713e6104
connect/proxy: don't require proxy ID
2018-06-14 09:42:20 -07:00
Mitchell Hashimoto
a69e3087b2
command/intention: address comment feedback
2018-06-14 09:42:20 -07:00
Mitchell Hashimoto
be82b94f81
command/intention/create: -replace does an atomic change
2018-06-14 09:42:20 -07:00
Mitchell Hashimoto
6a82e78cb4
command/intention/match
2018-06-14 09:42:19 -07:00
Mitchell Hashimoto
8ffca97596
command/intention/delete: tests
2018-06-14 09:42:19 -07:00
Mitchell Hashimoto
88639b802c
command/intention/check: check tests
2018-06-14 09:42:19 -07:00
Mitchell Hashimoto
971b3c06a1
command/intention/get: tests
2018-06-14 09:42:19 -07:00
Mitchell Hashimoto
66deffafbb
command/intention/match
2018-06-14 09:42:19 -07:00
Mitchell Hashimoto
a083870872
command/intentions/check
2018-06-14 09:42:19 -07:00
Mitchell Hashimoto
dba937847f
command/intention/create: -replace flag, jank, we should change to PUT
2018-06-14 09:42:19 -07:00
Mitchell Hashimoto
888dc78180
command/intentions/delete
2018-06-14 09:42:19 -07:00
Mitchell Hashimoto
272211e171
command/intention/get: the get command without tests
2018-06-14 09:42:18 -07:00
Mitchell Hashimoto
988d7d984a
command/intention/finder: package for finding based on src/dst
2018-06-14 09:42:18 -07:00
Mitchell Hashimoto
961e9c1eaf
command/intention/create
2018-06-14 09:42:18 -07:00
Mitchell Hashimoto
5d969e3cbb
command/connect/proxy: set ACL token based on proxy token flag
2018-06-14 09:42:14 -07:00
Mitchell Hashimoto
867db89303
command/connect/proxy: set proxy ID from env var if set
2018-06-14 09:42:14 -07:00
Paul Banks
1b197d934a
Don't allow connect watches in agent/cli yet
2018-06-14 09:42:06 -07:00
Paul Banks
e8c510332c
Support legacy watch.HandlerFunc type for backward compat reduces impact of change
2018-06-14 09:42:05 -07:00
Paul Banks
cd88b2a351
Basic `watch` support for connect proxy config and certificate endpoints.
...
- Includes some bug fixes for previous `api` work and `agent` that weren't tested
- Needed somewhat pervasive changes to support hash based blocking - some TODOs left in our watch toolchain that will explicitly fail on hash-based watches.
- Integration into `connect` is partially done here but still WIP
2018-06-14 09:42:05 -07:00
Paul Banks
10db79c8ae
Rework connect/proxy and command/connect/proxy. End to end demo working again
2018-06-14 09:41:57 -07:00
Paul Banks
69d5efdbbd
Original proxy and connect.Client implementation. Working end to end.
2018-06-14 09:41:56 -07:00
Paul Banks
5f3d20c5cf
Merge pull request #4194 from hashicorp/fix-kv-del-validation
...
Fix KV del command validation error
2018-06-05 16:58:14 +01:00
Matt Keeler
88a8c5e968
Merge pull request #4156 from hashicorp/enterprise-coexistence
...
Enterprise/Licensing Cleanup
2018-06-05 10:50:32 -04:00
Paul Banks
378c37fadd
Fix KV del command validation error
...
This has an explcit unit test already which somehow passes at least some of the time. I suspect it passes because under some conditions the actual KV delete fails and returns non-zero as well as printing the warning which is what is being checked for in the test.
For some reason despite working for quite some time like this, I now have a branch in which this test fails consistently. It may be a timing/env issue where another process running an agent causes the delete to be successful so the command returns a 0 by chance. Either way this is clearly wrong and fixing it stops the test being flaky in my branch.
2018-06-05 13:18:16 +01:00
Kyle Havlovitz
03652a8519
command/agent: don't re-parse the flags on reload
2018-05-31 16:59:51 -07:00
Matt Keeler
2e7a37890c
Move data source loading into a command helpers function
2018-05-24 10:34:08 -04:00
Paul Banks
4de68fcb4b
Merge pull request #4016 from pierresouchay/support_for_prometheus
...
Support for prometheus for metrics endpoint
2018-04-24 16:14:43 +01:00
Matt Keeler
63250c5d43
Merge pull request #4024 from jen20/signal-notify-once
...
Only call signal.Notify once during agent startup
2018-04-20 12:37:01 -04:00
Kyle Havlovitz
af4be34a2a
Update make static-assets goal and run format
2018-04-13 09:57:25 -07:00
James Nugent
96f871862e
Only call signal.Notify once during agent startup
...
Calling twice appears to have no adverse effects, however serves to
confuse as to what the semantics of such code may be! This seems like it
was probably introduced while resolving conflicts during the merge of
the fix for #2404 .
2018-04-10 20:44:50 -05:00
Pierre Souchay
93a01b0949
Now use prometheus_retention_time > 0 to enable prometheus support
2018-04-06 14:21:05 +02:00
Pierre Souchay
fd98fb1449
Added support exposing metrics in Prometheus format
2018-04-06 09:18:06 +02:00
Matt Keeler
48bd84073a
Address PR feedback
2018-04-02 09:23:01 -04:00
Matt Keeler
9f64d4856a
Update unit-tests to use requirements instead of manual checks.
2018-03-30 10:55:21 -04:00
Matt Keeler
92ceaaad81
Update case of member in comment
2018-03-29 15:06:48 -04:00
Matt Keeler
4e6f0f9a79
Formatting update
2018-03-29 14:35:49 -04:00
Matt Keeler
ada1252480
GH-3996: Add config-format flag to validate subcommand
2018-03-29 14:30:05 -04:00
Guido Iaquinti
8cd11d5888
Add package name to log output
2018-03-21 15:56:14 +00:00
Josh Soref
94835a2715
Spelling ( #3958 )
...
* spelling: another
* spelling: autopilot
* spelling: beginning
* spelling: circonus
* spelling: default
* spelling: definition
* spelling: distance
* spelling: encountered
* spelling: enterprise
* spelling: expands
* spelling: exits
* spelling: formatting
* spelling: health
* spelling: hierarchy
* spelling: imposed
* spelling: independence
* spelling: inspect
* spelling: last
* spelling: latest
* spelling: client
* spelling: message
* spelling: minimum
* spelling: notify
* spelling: nonexistent
* spelling: operator
* spelling: payload
* spelling: preceded
* spelling: prepared
* spelling: programmatically
* spelling: required
* spelling: reconcile
* spelling: responses
* spelling: request
* spelling: response
* spelling: results
* spelling: retrieve
* spelling: service
* spelling: significantly
* spelling: specifies
* spelling: supported
* spelling: synchronization
* spelling: synchronous
* spelling: themselves
* spelling: unexpected
* spelling: validations
* spelling: value
2018-03-19 16:56:00 +00:00
Paul Banks
de58eb1820
Fixes #3891 : agent monitor no longer unresponsive before logs stream.
...
The root cause is actually that the agent's streaming HTTP API didn't flush until the first log line was found which commonly was pretty soon since the default level is INFO. In cases where there were no logs immediately due to level for instance, the client gets stuck in the HTTP code waiting on a response packet from the server before we enter the loop that checks the shutdown channel from the signal handler.
This fix flushes the initial status immediately on the streaming endpoint which lets the client code get into it's expected state where it's listening for shutdown or log lines.
2018-02-19 21:53:10 +00:00
Kyle Havlovitz
d16f103b48
Pull http config flag merge into public method
2018-02-05 15:00:04 -08:00
Veselkov Konstantin
7de57ba4de
remove golint warnings
2018-01-28 22:40:13 +04:00
Chad Whitacre
9ff59df34b
Fix typo
2018-01-05 15:24:44 -05:00
Kyle Havlovitz
a86d11ec0a
Merge pull request #3737 from hashicorp/autopilot-refactor
...
Move autopilot to a standalone package
2017-12-15 14:09:40 -08:00
James Phillips
c676e6b8c8
Adds -base64 support to kv get command.
...
Fixes #3736
2017-12-14 17:28:04 -08:00
Kyle Havlovitz
de28555671
Move autopilot to a standalone package
2017-12-11 16:45:33 -08:00
James Phillips
521e46ce91
Adds a registry mechanism for CLI commands.
2017-11-29 18:36:52 -08:00
Kyle Havlovitz
921d2e1469
Fix a panic in snapshot inspect command
2017-10-30 14:51:08 -07:00
Frank Schroeder
8f145559d8
Decouple the code that executes checks from the agent
2017-10-25 11:18:07 +02:00
Frank Schroeder
9872475167
agent: fix TestRetryJoin
2017-10-24 20:35:37 +02:00
Frank Schroeder
7d3467176b
agent: fix TestRetryJoinFail
2017-10-24 20:35:37 +02:00
Frank Schroeder
96a584dee2
agent: fix TestRetryJoinWanFail
2017-10-24 20:35:36 +02:00
Frank Schroeder
b97ab367f4
config: return error on extra command line arguments ( #3397 )
...
The `consul agent` command was ignoring extra command line arguments
which can lead to confusion when the user has for example forgotten to
add a dash in front of an argument or is not using an `=` when setting
boolean flags to `true`. `-bootstrap true` is not the same as
`-bootstrap=true`, for example.
Since all command line flags are known and we don't expect unparsed
arguments we can return an error. However, this may make it slightly
more difficult in the future if we ever wanted to have these kinds of
arguments.
Fixes #3397
2017-10-23 08:07:48 +02:00
James Phillips
ecee15b466
Updates documentation for consul validate.
...
This makes it clear that you need to pass the full configuration,
and that the command won't work with config fragments.
Closes #3591
2017-10-19 18:59:05 -07:00
Frank Schroeder
9dec64dd17
commands: add shorter helper vars to keep fmt sane
2017-10-18 02:39:10 +02:00
Frank Schroeder
983e4aa0eb
commands: cleanup init
2017-10-18 02:39:10 +02:00
Frank Schroeder
b3292d13fb
commands: get HTTP API flags for usage automatically
2017-10-18 00:08:45 +02:00
Frank Schroeder
0cadee99ff
commands: drop http server flags from reload command
2017-10-18 00:08:45 +02:00
Frank Schroeder
cb96d1f126
commands: drop http server flags from leave command
2017-10-18 00:08:45 +02:00
Frank Schroeder
cb95cf2a34
commands: drop http server flags from keyring command
2017-10-18 00:08:45 +02:00
Frank Schroeder
1715cbd5de
commands: drop http server flags from force-leave command
2017-10-18 00:08:45 +02:00
Frank Schroeder
1b026de1db
commands: run all tests in parallel (again)
2017-10-18 00:08:45 +02:00
Frank Schroeder
56b24d3d4f
commands: cleanup help and synopsis.
...
* move Help and Synopsis to bottom
* make help and synopsis constants
* make sure help output is formatted
2017-10-18 00:08:45 +02:00
Frank Schroeder
d54a5ef8d8
commands: do not run cmd tests in parallel
...
Package level parallelization is sufficient.
2017-10-18 00:08:45 +02:00
Frank Schroeder
e5d08cf47d
commands: add missing noTabs test
2017-10-18 00:08:45 +02:00
Frank Schroeder
84a82cff3d
commands: cleanup test names
2017-10-18 00:08:45 +02:00
Frank Schroeder
5979723446
commands: cleanup catalog list services tests
2017-10-18 00:08:45 +02:00
Frank Schroeder
a03738c117
commands: cleanup catalog list nodes tests
2017-10-18 00:08:45 +02:00
Frank Schroeder
2530b9dd83
commands: simplify import names
2017-10-18 00:08:45 +02:00
Frank Schroeder
2bd8b070fb
commands: move operator subcommands to subdirs
2017-10-18 00:08:45 +02:00
Frank Schroeder
ce1ec000ca
commands: move kv subcommands to subdirs
2017-10-18 00:08:45 +02:00
Frank Schroeder
e16ef316d4
commands: move catalog subcommands to subdirs
2017-10-18 00:08:45 +02:00
Frank Schroeder
51799e5d23
commands: move snapshot subcommands to subdirs
2017-10-18 00:08:45 +02:00
Frank Schroeder
6bc5716336
commands: simplify commands.go
2017-10-18 00:08:45 +02:00
Frank Schroeder
2850f0f6d0
commands: drop base command and utils
2017-10-18 00:08:45 +02:00
Frank Schroeder
31d5fb7f47
commands: move agent command to separate pkg
2017-10-18 00:08:45 +02:00
Frank Schroeder
10e0be65a9
commands: move watch command to separate pkg
2017-10-18 00:08:45 +02:00
Frank Schroeder
8a0195ee99
add token and addr to http flags
2017-10-18 00:08:45 +02:00
Frank Schroeder
e2b686b982
commands: move snapshot save command to separate pkg
2017-10-18 00:08:45 +02:00
Frank Schroeder
fb1f09d447
commands: move snapshot restore command to separate pkg
2017-10-18 00:08:45 +02:00
Frank Schroeder
3acbc278f0
commands: move version command to separate pkg
2017-10-18 00:08:45 +02:00
Frank Schroeder
3a02ce9ebc
commands: move snapshot inspect command to separate pkg
2017-10-18 00:08:45 +02:00
Frank Schroeder
c8992cbe28
commands: move snapshot command to separate pkg
2017-10-18 00:08:45 +02:00
Frank Schroeder
4d6a0b94dd
commands: move rtt command to separate pkg
2017-10-18 00:08:45 +02:00
Frank Schroeder
566359234a
commands: move reload command to separate pkg
2017-10-18 00:08:45 +02:00
Frank Schroeder
4947ba7f3d
commands: move operator autopilot set command to separate pkg
2017-10-18 00:08:45 +02:00
Frank Schroeder
f719d78441
commands: move operator autopilot get command to separate pkg
2017-10-18 00:08:45 +02:00
Frank Schroeder
bd1b189990
commands: move operator autopilot command to separate pkg
2017-10-18 00:08:45 +02:00
Frank Schroeder
c50e43a4ea
commands: move operator list remove-peer command to separate pkg
2017-10-18 00:08:45 +02:00
Frank Schroeder
2a824f0575
commands: move operator raft list-peers command to separate pkg
2017-10-18 00:08:45 +02:00
Frank Schroeder
f10f07b448
commands: move operator raft command to separate pkg
2017-10-18 00:08:45 +02:00
Frank Schroeder
cc103391b2
commands: move operator command to separate pkg
2017-10-18 00:08:45 +02:00
Preetha Appan
1eec0e757c
Move monitor command to its own package
2017-10-18 00:08:45 +02:00
Preetha Appan
f389fe7757
Fix import order
2017-10-18 00:08:45 +02:00
Preetha Appan
5b6f0504ae
Move members command to its own package
2017-10-18 00:08:45 +02:00
Preetha Appan
ba546b0c1d
Move maint command to its own package
2017-10-18 00:08:45 +02:00
Preetha Appan
ff4d070bdf
Move lock command to its own package
2017-10-18 00:08:45 +02:00
Preetha Appan
85bc32f8a0
Fix leave and validate commands to build help string in constructor
2017-10-18 00:08:45 +02:00
Preetha Appan
71887d1709
Fix KV CLI subcommands to build help string in constructor
2017-10-18 00:08:45 +02:00
Preetha Appan
b1d5f99a58
Fix Keyring and keygen commands to build help string in constructor
2017-10-18 00:08:45 +02:00
Preetha Appan
85a834d008
Fix join command to build help string in constructor
2017-10-18 00:08:45 +02:00
Preetha Appan
a049dccd20
Fix up info and forceleave to build help string in constructor
2017-10-18 00:08:45 +02:00
Preetha Appan
55a1724b9e
s/initFlags/init/g
2017-10-18 00:08:45 +02:00
Preetha Appan
7689e1e5cd
Fix exec and event commands to build help string in constructor
2017-10-18 00:08:45 +02:00
Preetha Appan
a2519fb76f
Fix up catalog list services to build help string in constructor
2017-10-18 00:08:45 +02:00
Preetha Appan
2ed2c63a26
Fix up list datacenters to build help string in constructor
2017-10-18 00:08:45 +02:00
Preetha Appan
9d52f6ea92
Fix tests by calling initFlags for each test case to reset state.
2017-10-18 00:08:45 +02:00
Preetha Appan
4e31514df8
Better name for usage string and moving constant definition down
2017-10-18 00:08:45 +02:00
Preetha Appan
a3863c73d6
Construct the help string in constructor using helper function.
2017-10-18 00:08:45 +02:00
Frank Schroeder
0ec520582d
commands: move catalog list services to separate pkg
2017-10-18 00:08:45 +02:00
Frank Schroeder
117305eb4f
commands: move catalog list nodes command to separate pkg
2017-10-18 00:08:45 +02:00
Frank Schroeder
bd73c4cecf
commands: move catalog list datacenters command to separate pkg
2017-10-18 00:08:45 +02:00
Frank Schroeder
675e727224
commands: move catalog command to separate pkg
2017-10-18 00:08:45 +02:00
Frank Schroeder
9a9e5ef82d
commands: move leave command to separate pkg
2017-10-18 00:08:45 +02:00
Frank Schroeder
076361a37d
commands: move force-leave command to separate pkg
2017-10-18 00:08:45 +02:00
Frank Schroeder
631502009d
commands: move keyring command to separate pkg
2017-10-18 00:08:45 +02:00
Frank Schroeder
9e19207918
commands: move kv put command to separate pkg
2017-10-18 00:08:45 +02:00
Frank Schroeder
3377f46085
commands: move kv get command to separate pkg
2017-10-18 00:08:45 +02:00
Frank Schroeder
e1785a0e8f
commands: move kv import command to separate pkg
2017-10-18 00:08:45 +02:00