consul

Commit Graph

Author	SHA1	Message	Date
Jeff Mitchell	28c84845bf	Update vendoring from go mod. (#5566 )	2019-03-26 17:50:42 -04:00
Pierre Souchay	9dc7194321	Bump version of miekg/dns to 1.0.4 See https://github.com/hashicorp/consul/issues/3977 While trying to improve furthermore #3948 (This pull request is still valid since we are not using Compression to compute the result anyway). I saw a strange behaviour of dns library. Basically, msg.Len() and len(msg.Pack()) disagree on Message len. Thus, calculation of DNS response is false consul relies on msg.Len() instead of the result of Pack() This is linked to miekg/dns#453 and a fix has been provided with miekg/dns#454 Would it be possible to upgrade miekg/dns to a more recent function ? Consul might for instance upgrade to a post 1.0 release such as https://github.com/miekg/dns/releases/tag/v1.0.4	2018-03-28 10:23:57 -05:00
Sean Chittenden	25b09713b9	Manage dependencies via Godep Embrace the future and use Go 1.6's vendor support via Godep. Go 1.5 users should `export GO15VENDOREXPERIMENT=1`	2016-02-12 16:50:37 -08:00

Author

SHA1

Message

Date

Jeff Mitchell

28c84845bf

Update vendoring from go mod. (#5566 )

2019-03-26 17:50:42 -04:00

Pierre Souchay

9dc7194321

Bump version of miekg/dns to 1.0.4

See https://github.com/hashicorp/consul/issues/3977

While trying to improve furthermore #3948 (This pull request is still valid since we are not using Compression to compute the result anyway).

I saw a strange behaviour of dns library.
Basically, msg.Len() and len(msg.Pack()) disagree on Message len.

Thus, calculation of DNS response is false consul relies on msg.Len() instead of the result of Pack()

This is linked to miekg/dns#453 and a fix has been provided with miekg/dns#454

Would it be possible to upgrade miekg/dns to a more recent function ?

Consul might for instance upgrade to a post 1.0 release such as https://github.com/miekg/dns/releases/tag/v1.0.4

2018-03-28 10:23:57 -05:00

Sean Chittenden

25b09713b9

Manage dependencies via Godep

Embrace the future and use Go 1.6's vendor support via Godep.

Go 1.5 users should `export GO15VENDOREXPERIMENT=1`

2016-02-12 16:50:37 -08:00

3 Commits (58f04815d5a138dbc3c68f7c5729136d44860888)