388 Commits (397757ae626b49a70f58effcfa999d7cb83484d4)

Author	SHA1	Message	Date
Kenia	397757ae62	ui: Create CSS variables for box-shadowing consistency (#7337) ... * Table - Lowest (on-hover of table items) * Buttons - Middle * Form-elements - Removed, no box-shadowing in input forms mocks. * Menu-panel -High * Modal-dialog - Highest * Stats-card -Middle/High(Active) * Tooltip - Middle * Card - Middle * Expanded-single-select - Middle * Tabular-details - High * Discovery chain - High	5 years ago
John Cowen	64ff304585	ui: Make a specific CI coverage make target ensuring use of CI cache (#7335)	5 years ago
Kenia	191496e4a5	ui: Create a helper to show the last 8 characters of token Accessor ID (#7327) ... * Create substr helper * Create a test for the new substr helper * Display the last 8 characters of token Accessor ID in the Token lists page	5 years ago
Kenia	95031f9f90	ui: Add box-shadow to table items on hover	5 years ago
John Cowen	aea3d00a9d	ui: Move to angle brackets for ember components (#7321) ... * Modify templates with codemods angle brackets * ui: Fix up problem with intention filter action attribute Co-authored-by: Kenia <19161242+kaxcode@users.noreply.github.com>	5 years ago
John Cowen	4be566e545	ui: Upgrade ember-cli-api-double (#7322) ... * ui: Upgrade ember-cli-api-double	5 years ago
John Cowen	8e5cb78c1c	ui: Add new Help menu with links to docs, learn and GH (#7310)	5 years ago
John Cowen	f306c753e2	ui: HTTP Body testing (#7290) ... * ui: Test Coverage Reporting (#7027) * Serve up the /coverage folder whilst developing * Upgrade ember-cli-api-double now it supports passthrough per url * ui: make env into a service and use it where we need to be injectable * Give http/client a body method so we can use it on its own for testing * Add test helper for testing with and without nspaces enabled * Add two tests, one thay needs nspaces and one that doesn't * Keep cleaning up client/http, whilst figuring out a immutable bug * Convert tests to new return format ([actual, leftovers])	5 years ago
John Cowen	f9bd3a0b93	ui: Use a service-proxy to test service removal notification (#7315)	5 years ago
John Cowen	59e8261936	ui: Upgrade ember-cli-api-double and ember-data to fix up stage/preview site (#7316)	5 years ago
John Cowen	1a7a1fb4f1	Upgrade to use structure-icons 1.8 (plus additional mask placeholders) (#7287)	5 years ago
John Cowen	e9ed49d9aa	ui: Test coverage developer experience (#7275) ... * ui: Add getSplitters unit test and additional getResolvers test * Make ordering of makefile target consistent	5 years ago
John Cowen	771973a713	ui: Add consul-service-list presentational component (#7279) ... This commit moves our service list into a new presentational component, and is therefore mainly just moving things around. The main thing moved here is the logic required to resizing columns correctly is now moved to a component instead of the controller	5 years ago
John Cowen	7dc5201676	ui: Remove `next` from usage from discovery-chain component (#7273) ... In a previous iteration of discovery-chain wrapping some event listeners in a call to `next` (i.e. do this on next tick) was necessary. We added a comment in here to see if we could get rid of it at a later date. We've taken another look at this and it looks like this `next` is no longer required in this later iteration. Further more there is the tiniest chance that possibly, as we are adding listeners on next tick, that the listeners could be added after component destruction, which means when you click on the page we try to set a property of a destroyed object and boom. Removing this `next` removes this tiny possibility.	5 years ago
John Cowen	b6915793d0	ui: Remove custom css-vars 'polyfill' and use native CSS props (#7249) ... * ui: Remove custom css-vars 'polyfill' and use native CSS props Previously we used a sort of polyfill for certain places where we needed CSS property-like behavior. This meant duplicating code between JS and CSS, specifically some of our SVG icons. We moved to CSS props only in the places where they are beneficial and populated the variables with our already existing SASS variables. This means we no longer have to duplicate CSS and we can remove our custom css-var helper/polyfill.	5 years ago
John Cowen	662c28307c	ui: Upgrade to node 12 LTS (#7248) ... Upgrading our build tooling to use the latest node LTS and the lastest/current Alpine version in our container	5 years ago
Alvin Huang	48a52e07da	fix ember parallelization (#7221)	5 years ago
John Cowen	ab8d318181	ui: Use the dart-sass implementation of sass (#7175)	5 years ago
John Cowen	79156324bf	ui: Test Coverage Reporting (#7027) ... * Serve up the /coverage folder whilst developing * Upgrade ember-cli-api-double now it supports passthrough per url	5 years ago
John Cowen	7bca634087	ui: Slight refactor 'name deciding' for `request` > `rpc` (#6850) ... During the refactor of the data layer we had a method that you can use to do a request/response call i.e. adapter.request > serializer.respond We weren't sure what to name this but eventually wanted it to live on the HTTPAdapter itself (see removed comments in the changeset) We've decided `rpc` is a good name and we've moved this to where we want it. We've deprecated the old `request` method name but not removed it as yet. There's also opportunity now to reduce the 'read/write' functions further as they essentially do the same thing. Again we've left this for the moment, but we are hoping to get the code for our custom Adapter down to less than 100 LoC.	5 years ago
John Cowen	604de8758b	ui: Fix using 'ui-like' KVs when using an empty default nspace (#7734) ... When using namespaces, the 'default' namespace is a little special in that we wanted the option for all our URLs to stay the same when using namespaces if you are using the default namespace, with the option of also being able to explicitly specify `~default` as a namespace. In other words both `ui/services/service-name` and `ui/~default/services/service-name` show the same thing. This means that if you switch between OSS and Enterprise, all of your URLs stay the same, but you can still specifically link to the default namespace itself. Our routing configuration is duplicated in order to achieve this: ``` - :dc - :service - :kv - :edit - :nspace - :dc - :service - :kv - :edit ``` Secondly, ember routing resolves/matches routes in the order that you specify them, unless, its seems, when using wildcard routes, like we do in the KV area. When not using the wildcard routes the above routing configuration resolves/matches a `/dc-1/kv/service` to the `dc.kv.edit` route correctly (dc:dc-1, kv:services), that route having been configured in a higher priority than the nspace routes. However when configured with wildcards (required in the KV area), note the asterisk below: ``` - :dc :service - :kv - *edit - :nspace - :dc - :service - :kv - *edit ``` Given something like `/dc-1/kv/services` the router instead matches the `nspace.dc.service` (nspace:dc-1, dc:kv, service:services) route first even though the `dc.kv.edit` route should still match first. Changing the `dc.kv.edit` route back to use a non-wildcard route (:edit instead of *edit), returns the router to match the routes in the correct order. In order to work around this, we catch any incorrectly matched routes (those being directed to the nspace Route but not having a `~` character in the nspace parameter), and then recalculate the correct route name and parameters. Lastly we use this recalculated route to direct the user/app to the correct route. This route recalcation requires walking up the route to gather up all of the required route parameters, and although this feels like something that could already exist in ember, it doesn't seem to. We had already done a lot of this work a while ago when implementing our `href-mut` helper. This commit therefore repurposes that work slighlty and externalizes it outside of the helper itself into a more usable util so we can import it where we need it. Tests have been added before refactoring it down to make the code easier to follow.	5 years ago
John Cowen	04a8a77365	ui: Lazily detect HTTP protocol (#7644) ... This commit includes 2 things: 1. Sometimes (seemingly due to client caching), performance entries aren't available, even for the currently executing script. This waits until the first retrieval of 'CONSUL_HTTP_PROTOCOL' before using the performance entries to decide this. This means that the entries aren't inspected until ember has initialized, which means that the entries are always available. 2. getCurrentResource/getResourceFor could potentially return undefined if the correct entry could not be found. This adds a default {} return value if the resource cannot be found. This means that if for whatever reason the correct resource cannot be found at least we don't fail with an error and just drop back to HTTP/1 functionality.	5 years ago
John Cowen	8d4631526c	ui: Fix token duplication bug (#7552) ... We need to detect whether an object is an ember-data snapshot or just a plain object, and we where restricted from using `instanceof` due to ember-data's `Snapshot` class being private. We'd chosen to go with `constructor.name` instead, which seemed to work, but when the javascript gets minifed the name of the contructor is also minified and therefore is not what you are expecting. This commit reverts to our original idea of checking for the existence and type of the `.attributes` function, which is the function we require within the conditional, and therefore is more reliable (if the function doesn't exist it will error out during development aswell as production)	5 years ago
John Cowen	6ffe0e6fe4	ui: Use the `each key=""` parameter to force ember to reuse DOM (#7550) ... Ember tries to reuse DOM elements when it can but as ember looks for changes to objects rather than the DOM itself sometimes. This and the fact that an objects identity may change even though its value hasn't, results in ember occasionally re-mutating DOM when it doesn't need to. The `each` helper includes a `key` attribute to hint to ember what it should look for when deciding whether something has changed, rather than the objects identity. https://api.emberjs.com/ember/release/classes/Ember.Templates.helpers/methods/each#specifying-keys We use this here to fix an issue where DOM was being redrawn after the user had scrolled the page and was therefore resetting the scroll back to 0 (the top of the page)	5 years ago
John Cowen	31b9b90bc3	ui: Ensure blocking query configuration is passed through to findInstanceBySlug (#7543) ... * ui: Ensure configuration is passed through to findInstanceBySlug Due to the addition of namespace support, this arguments passed to this method have been increased. Whilst the nspace support continues ot work here, the configuration for blocking queries is never passed through. This results in a 2 second poll rather than a blocking query. This commit fixes that * ui: Add a basic test to check the number of arguments passed through	5 years ago
John Cowen	5f625666b4	ui: Enable recovery from an unreachable datacenter (500 error) (#7404) ... For URL maintenance reasons we store the last visited DC in localStorage incase you come back to a page (for example settings) that doesn't have a dc in the URL. A problem arises here if the last DC you tried to visit is unreachable. The first fix here clears out the last visited DC from localStorage if the API has errored out. Secondly, our `href-mut` helper which mutates the current current and replaces 'parts' in the URL rather than the whole thing functioned by detecting the current route/URL you are on an 'mutating' that. A problem arose here as even though you might be on the `/ui/dc-1/services` URL the actual route is the 'error' route which does not have a URL that can be changed properly. The second fix here uses route.currentRoute.name over route.currentRouteName. The latter is equal to error when an error occurs whereas the former gives you the name of the route before the error happened, which is actually what we want/the intent here. ie. when `router.currentRouteName === 'error'` then `router.currentRoute.name === Name Of Route Before It Errored` it seems	5 years ago
John Cowen	6074a1b4c8	ui: Coordinates don't require a nspace, so don't expect one in the repo (#7378) ... * ui: Coordinates don't require a nspace, so don't expect one in the repo * Add a test to prove the correct number of arguments are being passed	5 years ago
John Cowen	468e82dcf9	ui: Alter position of logic for showing the Round Trip Time tab to prevent DOM refresh (#7377) ... * ui: Move tomography length check inside of the partial Previously we checked the length of tomography.distances to decide whether to show the RTT tab or not. Previous to our ember upgrade this would not cause a DOM reload of so many elements (i.e. all of the tab content). Since our ember upgrade, any change to tomography (so not necessarily the length of distances) seems to fire a change to the length (even if the length remains the same). The knock on effect of this is that the array of tab panels seems to be recalculated (but remain the same) and all of the tab panels are completely re-rendered, causing the scroll of the page to be reset. This commit moves the check for tomography.distance.length to the lower down with the loop, which means the array of tab panels always remains the same, which consequently means that the entire array of tab panels is never re-rendered entirely, and therefore fixes the issue.	5 years ago
John Cowen	74ade640e3	ui: Use WithEventSource mixin on intentions to ensure cleanup (#7333) ... The WithEventSource mixin has a reset method when the Controller is exited which will close any open EventSources/Blocking queries. This adds it in for intentions	5 years ago
John Cowen	e85fd18f89	ui: Be more specific with the display toggling checkboxes (#7309)	5 years ago
John Cowen	b83c190f0c	ui: Use options.method for keying not options.type (#7308)	5 years ago
John Cowen	65dd14daf3	ui: Gracefully cope with 500 errors from the disco-chain API endpoint (#7291) ... When connect is disabled the discovery-chain endpoint returns a 500 error status, which we previoulsy did not gracefully cope with. This commit gracefully copes with any errors from the disco-chain endpoint by supressing the error and hiding the Routing tab from the Service detail page. Acceptance test included	5 years ago
John Cowen	ebc574c509	ui: oss don't ever POST/PUT Namespaces when writing data (#7238) ... * ui: Ensure we use nonEmptySet everywhere where we add Namespace We missed a coupld of places where we use the noEmptySet function, which will only perform the set if the specified property is non-empty. Currently we aren't certain there is a place in OSS where a Namespace can make its way down via the API and endup being PUT/POSTed back out again when saved. If this did ever happen we would assume it would be the default namespace, but we add an extra check here to ensure we never PUT/POST the Namespace property if Namespaces are disabled. * ui: Add step/assertion for assert if a property is NOT set in the body * ui: Improve updated/create acc testing for policy/token/roles: Including making sure a Namespace property is never sent through if you are running without namespace support	5 years ago
John Cowen	eb35d89893	ui: Run 2 separate test runs oss and ent (#7214) ... * ui: Make API integration tests aware of CONSUL_NSPACES_ENABLED * ui: Allow passing CONSUL_NSPACES_ENABLED in via the cli in ember * ui: Add more makefile targets/package scripts to switch NSPACEs on/off * ui: Ensure all acceptance tests continue to pass with NSPACEs on/off This required a little tweaking of the dictionary, at some point page-navigation and some of these little tweaks will no longer be required * ui: Try running CI frontend tests in two parellel runs oss/ent * ui: Use correct make target, use different names for the reports	5 years ago
John Cowen	9e186c7af8	ui: Fix for differences between uncompiled and compiled CSS (#7233) ... We noticed that this relative positioning is not even applied when the CSS is compiled/compressed. When looking via Web Inspector this style/selector doesn't even appear even though it is in the CSS source. This !important reduces the amount of selectors for this style rule, which fixes the error, so potentially this isn't a specificity thing.	5 years ago
John Cowen	ad3b5327d2	ui: Discovery chain improvements (#7222) ... * ui: remove the default word when describing routes * ui: Avoid mutating the chain and look for the default edges more safely * ui: Use not null check instead of a truthy check for showing disco-chain * ui: Upgrade consul-api-double for better disco-chain mocks/fixtures	5 years ago
John Cowen	279cd874cc	ui: Ensure KV flags are passed through to Consul on update (#7216) ... * ui: always pass KV flags through on update * ui: Integration test to prove the flags queryParams gets passed through * ui: Add Flags to the KV updating acceptance tests	5 years ago
Kenia	773b092a64	ui: Add ability to search nodes listing page with IP Address (#7204) ... * Update search field placeholder to display `Search` * Add an acceptance test to search node listings with node name and IP Address * Update and add unit tests for filter/search node listing with IP Address	5 years ago
Kenia	c706089c9f	ui: Hides the Routing tab for a service proxy (#7195) ... * Adds conditional in route to not make discovery-chain request if service kind is equal to `connect-proxy` or `mesh-gateway` * Adds conditional in template to not show Routing tab if `chain` returns as null * Creates a new acceptance test to test the Routing tab not being displayed for a service proxy * Adds `tabs` to the services/show page object	5 years ago
Kenia	b9e023dfe1	ui: Adds an acceptance test for hiding Blocking Queries (#7162) ... * Adds an acceptance test for hiding Blocking Queries * Creates a new scenario - If a user adds CONSUL_UI_DISABLE_REALTIME to localStorage, the Blocking Queries section is hidden. * Updates page assertion to accept functions and booleans as properties * ui: Fix "don't see" step to watch for the different pageObject error ember-cli-page object seems to throw a an error with a different message depending on how you call a function: currentPage()[property]() // message = 'Element not found' const prop = currentPage()[property]; prop() // message = 'Something about destructuring' This changes the step/test/assertion to ensure we check for both types of errors Co-authored-by: John Cowen <johncowen@users.noreply.github.com>	5 years ago
John Cowen	d5b6f3095e	ui: Move CI to use the Makefile for testing (+ tmporary removal of exam) (#7188) ... * ui: Move CI to use the Makefile for testing (+ tmporary removal of exam) * ui: make a specific test-ci target as we are using --path dist --path dist looks for a previous build to test against, in CI this exists as we run a build first, but locally potentially this dist folder doesn't	5 years ago
John Cowen	f45880bffe	ui: Fix sticky nspace menu (#7164) ... * ui: Fix typo expanded > ariaExpanded * ui: Add the things we need to test this * ui: Add tests for testing the menu closes when clicked * ui: Ensure the aria-menu closes on route change	5 years ago
John Cowen	a8504802db	ui: Split splitter names in the discovery-chain (#7180) ... Previous to 1.7 splitter names didn't include the namespace name i.e. 'service-name' as of 1.7 they now include the namespace i.e. 'service-name.namespace' This commit take account of that	5 years ago
John Cowen	3eec5edadf	ui: Discovery-Chain: Cope with some edge case configs (#7174) ... * ui: Discovery-Chain: Cope with redirects that have failovers We found a few stranger configurations for discovery-chain, one of which was redirects that can then failover. We altered the parsing here to include 2 passes, one to organize the nodes into resolvers and children/subsets based on the nodes themselves, which includes adding the failovers to resolvers and subsets. We then do a second pass which can more reliably figure out whether a target is a redirect or a failover (target failovers don't have a corresponding node), this then adds the redirect children to the already exising resolver (from the first pass) and then checks if the redirect also has failovers and adds those if so. * ui: Check to see if we have a user configured default route or not ...if we don't add one so the visualization looks complete	5 years ago
John Cowen	ac60338269	ui: Add live updates/blocking queries to the Intention listing page (#7161) ... * ui: Enable blocking queries/live updates for intentions * ui: Add acceptance tests for intention blocking queries * ui: Add copy to explain that intentions are also now 'real time'	5 years ago
John Cowen	e568cded17	ui: Add node based configuration / environment testing (#7140) ... In an ember environment `config/environment.js` exports a JSON object whereas the file itself exports a function that receives a string of the environment name that would like returning. This is so ember can automatically provide you with an already configured object containing configuration values dependent on which environment you passed to `ember-cli` using `serve`, `build` or `test`. In order to bypass this so we can easily test what is returned for different environments, we've installed a lightweight functional test harness that is simple to use `substack/tape`, that can be run easily outside of ember. We've then written as simple test case using this to enable us to test/assert that different environments return the correct configuration values. Additionally we've added some yarn scripts/make targets (yarn run test-node / make test-node) to make this easy to run. We're yet to integrate this into CI.	5 years ago
John Cowen	d47f1ca2a9	ui: Fix wrapping service ids in the Node Detail > Services tab (#7149)	5 years ago
John Cowen	c6e72c3e46	ui: Fix positioning of active icon in the selected menu item (#7148)	5 years ago
Kenia	ff315c95fd	ui: Implements the ember-page-title addon to the UI (#7118) ... * Installs ember-page-title 5.x * Adds a page title to all template files that need one * Adds an assertion step to test the page titles	5 years ago
John Cowen	1ff8678df7	ui: Remove the Policy/Service Identity selector from nspaces (#7124) ... When editing Nspaces, although you can assign policies to a nspace using PolicyDefaults you cannot assign a Service Identity to a policy like you can when adding a policy to a token. This commit adds an extra attribute to our policy-form/policy-selector component so you can disable this setting. At a later date we may change this to have a conficgurable `<Slot />` instead. Simple acceptance tests is included here	5 years ago