330 Commits (38f0907c7a9f4851080bdec3bb182f1b9e5bed1e)

Author	SHA1	Message	Date
Siva Prasad	ca35d04472	Adds a new command line flag -log-file for file based logging. (#4581) ... * Added log-file flag to capture Consul logs in a user specified file * Refactored code. * Refactored code. Added flags to rotate logs based on bytes and duration * Added the flags for log file and log rotation on the webpage * Fixed TestSantize from failing due to the addition of 3 flags * Introduced changes : mutex, data-dir log writes, rotation logic * Added test for logfile and updated the default log destination for docs * Log name now uses UnixNano * TestLogFile is now uses t.Parallel() * Removed unnecessary int64Val function * Updated docs to reflect default log name for log-file * No longer writes to data-dir and adds .log if the filename has no extension	6 years ago
Siva	5e04d7f1f1	Merge branch 'master' of github.com:hashicorp/consul into WinService	7 years ago
Paul Banks	c6ef6a61c9	Refactor to use embedded struct.	7 years ago
Paul Banks	32f362bad9	StartupTelemetry => InitTelemetry	7 years ago
Paul Banks	a7038454fd	WIP	7 years ago
Siva	319a0ae2bf	Graceful exits added	7 years ago
Kyle Havlovitz	03652a8519	command/agent: don't re-parse the flags on reload	7 years ago
Paul Banks	4de68fcb4b	Merge pull request #4016 from pierresouchay/support_for_prometheus ... Support for prometheus for metrics endpoint	7 years ago
James Nugent	96f871862e	Only call signal.Notify once during agent startup ... Calling twice appears to have no adverse effects, however serves to confuse as to what the semantics of such code may be! This seems like it was probably introduced while resolving conflicts during the merge of the fix for #2404.	7 years ago
Pierre Souchay	93a01b0949	Now use prometheus_retention_time > 0 to enable prometheus support	7 years ago
Pierre Souchay	fd98fb1449	Added support exposing metrics in Prometheus format	7 years ago
Guido Iaquinti	8cd11d5888	Add package name to log output	7 years ago
Frank Schroeder	b97ab367f4	config: return error on extra command line arguments (#3397) ... The `consul agent` command was ignoring extra command line arguments which can lead to confusion when the user has for example forgotten to add a dash in front of an argument or is not using an `=` when setting boolean flags to `true`. `-bootstrap true` is not the same as `-bootstrap=true`, for example. Since all command line flags are known and we don't expect unparsed arguments we can return an error. However, this may make it slightly more difficult in the future if we ever wanted to have these kinds of arguments. Fixes #3397	7 years ago
Frank Schroeder	b3292d13fb	commands: get HTTP API flags for usage automatically	7 years ago
Frank Schroeder	56b24d3d4f	commands: cleanup help and synopsis. ... * move Help and Synopsis to bottom * make help and synopsis constants * make sure help output is formatted	7 years ago
Frank Schroeder	31d5fb7f47	commands: move agent command to separate pkg	7 years ago
Frank Schroeder	1c75cf1af5	pkg refactor ... command/agent/* -> agent/* command/consul/* -> agent/consul/* command/agent/command{,_test}.go -> command/agent{,_test}.go command/base/command.go -> command/base.go command/base/* -> command/* commands.go -> command/commands.go The script which did the refactor is: ( cd $GOPATH/src/github.com/hashicorp/consul git mv command/agent/command.go command/agent.go git mv command/agent/command_test.go command/agent_test.go git mv command/agent/flag_slice_value{,_test}.go command/ git mv command/agent . git mv command/base/command.go command/base.go git mv command/base/config_util{,_test}.go command/ git mv commands.go command/ git mv consul agent rmdir command/base/ gsed -i -e 's|package agent|package command|' command/agent{,_test}.go gsed -i -e 's|package agent|package command|' command/flag_slice_value{,_test}.go gsed -i -e 's|package base|package command|' command/base.go command/config_util{,_test}.go gsed -i -e 's|package main|package command|' command/commands.go gsed -i -e 's|base.Command|BaseCommand|' command/commands.go gsed -i -e 's|agent.Command|AgentCommand|' command/commands.go gsed -i -e 's|\tCommand:|\tBaseCommand:|' command/commands.go gsed -i -e 's|base\.||' command/commands.go gsed -i -e 's|command\.||' command/commands.go gsed -i -e 's|command|c|' main.go gsed -i -e 's|range Commands|range command.Commands|' main.go gsed -i -e 's|Commands: Commands|Commands: command.Commands|' main.go gsed -i -e 's|base\.BoolValue|BoolValue|' command/operator_autopilot_set.go gsed -i -e 's|base\.DurationValue|DurationValue|' command/operator_autopilot_set.go gsed -i -e 's|base\.StringValue|StringValue|' command/operator_autopilot_set.go gsed -i -e 's|base\.UintValue|UintValue|' command/operator_autopilot_set.go gsed -i -e 's|\bCommand\b|BaseCommand|' command/base.go gsed -i -e 's|BaseCommand Options|Command Options|' command/base.go gsed -i -e 's|base.Command|BaseCommand|' command/*.go gsed -i -e 's|c\.Command|c.BaseCommand|g' command/*.go gsed -i -e 's|\tCommand:|\tBaseCommand:|' command/*_test.go gsed -i -e 's|base\.||' command/*_test.go gsed -i -e 's|\bCommand\b|AgentCommand|' command/agent{,_test}.go gsed -i -e 's|cmd.AgentCommand|cmd.BaseCommand|' command/agent.go gsed -i -e 's|cli.AgentCommand = new(Command)|cli.Command = new(AgentCommand)|' command/agent_test.go gsed -i -e 's|exec.AgentCommand|exec.Command|' command/agent_test.go gsed -i -e 's|exec.BaseCommand|exec.Command|' command/agent_test.go gsed -i -e 's|NewTestAgent|agent.NewTestAgent|' command/agent_test.go gsed -i -e 's|= TestConfig|= agent.TestConfig|' command/agent_test.go gsed -i -e 's|: RetryJoin|: agent.RetryJoin|' command/agent_test.go gsed -i -e 's|\.\./\.\./|../|' command/config_util_test.go gsed -i -e 's|\bverifyUniqueListeners|VerifyUniqueListeners|' agent/config{,_test}.go command/agent.go gsed -i -e 's|\bserfLANKeyring\b|SerfLANKeyring|g' agent/{agent,keyring,testagent}.go command/agent.go gsed -i -e 's|\bserfWANKeyring\b|SerfWANKeyring|g' agent/{agent,keyring,testagent}.go command/agent.go gsed -i -e 's|\bNewAgent\b|agent.New|g' command/agent{,_test}.go gsed -i -e 's|\bNewAgent|New|' agent/{acl_test,agent,testagent}.go gsed -i -e 's|\bAgent\b|agent.&|g' command/agent{,_test}.go gsed -i -e 's|\bBool\b|agent.&|g' command/agent{,_test}.go gsed -i -e 's|\bConfig\b|agent.&|g' command/agent{,_test}.go gsed -i -e 's|\bDefaultConfig\b|agent.&|g' command/agent{,_test}.go gsed -i -e 's|\bDevConfig\b|agent.&|g' command/agent{,_test}.go gsed -i -e 's|\bMergeConfig\b|agent.&|g' command/agent{,_test}.go gsed -i -e 's|\bReadConfigPaths\b|agent.&|g' command/agent{,_test}.go gsed -i -e 's|\bParseMetaPair\b|agent.&|g' command/agent{,_test}.go gsed -i -e 's|\bSerfLANKeyring\b|agent.&|g' command/agent{,_test}.go gsed -i -e 's|\bSerfWANKeyring\b|agent.&|g' command/agent{,_test}.go gsed -i -e 's|circonus\.agent|circonus|g' command/agent{,_test}.go gsed -i -e 's|logger\.agent|logger|g' command/agent{,_test}.go gsed -i -e 's|metrics\.agent|metrics|g' command/agent{,_test}.go gsed -i -e 's|// agent.Agent|// agent|' command/agent{,_test}.go gsed -i -e 's|a\.agent\.Config|a.Config|' command/agent{,_test}.go gsed -i -e 's|agent\.AppendSliceValue|AppendSliceValue|' command/{configtest,validate}.go gsed -i -e 's|consul/consul|agent/consul|' GNUmakefile gsed -i -e 's|\.\./test|../../test|' agent/consul/server_test.go # fix imports f=$(grep -rl 'github.com/hashicorp/consul/command/agent' * | grep '\.go') gsed -i -e 's|github.com/hashicorp/consul/command/agent|github.com/hashicorp/consul/agent|' $f goimports -w $f f=$(grep -rl 'github.com/hashicorp/consul/consul' * | grep '\.go') gsed -i -e 's|github.com/hashicorp/consul/consul|github.com/hashicorp/consul/agent/consul|' $f goimports -w $f goimports -w command/*.go main.go )	8 years ago
Frank Schroeder	902f4caff2	agent: move watch plans into agent	8 years ago
Frank Schroeder	4a223111d2	log: use prefix [ERR] instead of [ERROR]	8 years ago
Frank Schröder	825f72f5ef	agent: support custom header and method for http checks (#3106) ... This patch adds support for custom headers and method for HTTP checks. Fixes #2474 Fixes #2657 Fixes #3106	8 years ago
James Phillips	240413f5d6	Merge pull request #3105 from hashicorp/test-stability ... Tweaks things for better test stability.	8 years ago
Frank Schroeder	51e0e158f1	agent: fix graceful http server shutdown	8 years ago
Frank Schroeder	34fd31b7b1	agent: move config reloading into the agent	8 years ago
Frank Schroeder	aa1519c9f7	agent: move parseMetaPair to config and export	8 years ago
Frank Schroeder	d977aa1fe7	agent: move retry join into agent	8 years ago
Frank Schroeder	55a513da2e	agent: add GossipEncrypted function ... Remove dead code and expose a GossipEncrypted() method on the agent instead of accessing the internal delegate.	8 years ago
James Phillips	b0b5df579f	Cleans up an unrelated vet error.	8 years ago
Frank Schroeder	4034d0ac0b	agent: use agent logger for consul client and deps	8 years ago
Frank Schroeder	a9451d596f	agent: set tcpKeepAliveListener when there is no error	8 years ago
Frank Schroeder	d6c7404b34	agent: simplify shutdown timeout logging ... Note that we are currently timing out every time. This still needs to be investigated.	8 years ago
Frank Schroeder	30ba712857	agent: set proto to http since we are logging it now	8 years ago
Frank Schroeder	ec729693d7	Address review comments	8 years ago
Frank Schroeder	b6c69ebf5d	agent: refactor DNS and HTTP server ... * refactor DNS server to be ready for multiple bind addresses * drop tcpKeepAliveListener since it is default for the HTTP servers * add startup timeout watcher for HTTP servers identical to DNS server	8 years ago
Frank Schroeder	10540f8d5f	agent: fix logging ... * use agent logger for consul/serf/raft/dns/agent/... * support optional id for concurrent tests	8 years ago
Frank Schroeder	1df74e36bd	agent: print more useful shutdown message	8 years ago
Frank Schroeder	0325a42089	test: fix data race with endpoints	8 years ago
Frank Schroeder	e16589c079	agent: shutdown delegate if created ... When the TestAgent shuts down a half-started agent the delegate may not have been created at this point.	8 years ago
Frank Schroeder	3658d4d428	test: address pull request comments	8 years ago
Frank Schroeder	3865f14a25	agent: simplify agent creation ... This patch creates an agent with just a config struct and allows for other fields to be set as required.	8 years ago
Frank Schroeder	82650f73e3	agent: move http/dns endpoints into agent ... Move the HTTP and DNS endpoints into the agent and control their lifespan via the agent. This removes the requirement to manage HTTP and DNS servers indpendent of the agent since the agent is mostly useless without an endpoint and the endpoints without the agent.	8 years ago
Kyle Havlovitz	62f72f104c	Add settings for upshifting to encrypted gossip (#3079)	8 years ago
Frank Schroeder	8ad66f4bea	agent: support custom check id and name ... This patch adds support for a custom check id and name when registering a service. This is achieved by adding a CheckID and a Name field to the CheckType structure which is used to register checks with a service and when returning health check definitions. CheckDefinition is a superset of CheckType which duplicates some of the fields of CheckType. This patch decouples these two structures by removing the embedding of CheckType in CheckDefinition. Fixes #3047	8 years ago
Frank Schroeder	ad40a855bd	agent: move isAddrANY to separate package	8 years ago
Frank Schroeder	e2c37b47ee	agent: Replace client/server with delegate interface ... This patch adds a new internal interface clientServer which defines the common methods of consul.Client and consul.Server. This allows to replace the following code if a.server != nil { a.server.do() } else { a.client.do() } with a.delegate.do() In case a specific type is required a type check can be performed: if srv, ok := a.delegate.(*consul.Server); ok { srv.doSrv() }	8 years ago
Frank Schroeder	41f01a0cfc	agent: allow "::" as IPv6 bind address ... Fixes #2285	8 years ago
Frank Schroeder	914a83cae0	agent: use bind address as src unless INADDR_ANY ... Use the bind address as source address for outgoing RPC connections unless it is INADDR_ANY. The current code uses the advertise address which will not work in certain environments where the advertise address is not routable in the network of the agent, e.g. NAT environment, container... After all, that is the purpose of the advertise address. See #2822	8 years ago
Frank Schroeder	e6c6f8cedd	agent: use helper for INADDR_ANY	8 years ago
Kyle Havlovitz	5bab68b9bb	Add a path for transitioning to TLS on an existing cluster (#3001) ... Fixes #1705	8 years ago
Frank Schroeder	8c2b261c61	Use bind address as source for outgoing connections (#2822) ... This patch configures consul to use the bind address as the source address for outgoing connections. Fixes #2822	8 years ago
Frank Schroeder	fb83790cb9	Do not modify config after creation II ... Move code for finding the advertise address via a template into consulConfig() so that the config object is not modified after creation.	8 years ago
Frank Schroeder	a235986a28	Do not modify config after creation ... Make sure the RPCAdvertise address is always set so that the configuration does not have to be modified after creation.	8 years ago
Frank Schroeder	d34ba3e823	Cleanup agent config	8 years ago
Kyle Havlovitz	cd56a5ebdd	Add separate option for verifying incoming HTTPS traffic (#2974) ... * Add separate option for verifying incoming HTTPS traffic	8 years ago
Kyle Havlovitz	b70e419aeb	Add TLS cipher suite options and CA path support (#2963) ... This patch adds options to configure the available TLS cipher suites and adds support for a path for multiple CA certificates. Fixes #2959	8 years ago
Frank Schroeder	3e00e36f41	golint: Untangle if blocks with return in else	8 years ago
Frank Schroeder	eddb1af603	Remove duplicate constants ... This patch removes duplicate internal copies of constants in the structs package which are also defined in the api package. The api.KVOp type with all its values for the TXN endpoint and the api.HealthXXX constants are now used throughout the codebase. This resulted in some circular dependencies in the testutil package which have been resolved by copying code and constants and moving the WaitForLeader function into a separate testrpc package.	8 years ago
James Phillips	fa04c24978	Adds a new -disable-host-node-id option to help when testing with containers. ... Fixes #2877.	8 years ago
Alex Dadgar	7f6d95f1c9	Hash host ID so its stable and well distributed ... This PR takes the host ID and runs it through a hash so that it is well distributed. This makes it so that machines that report similar host IDs are easily distinguished. Instances of similar IDs occur on EC2 where the ID is prefixed and on motherboards created in the same batch.	8 years ago
James Phillips	8940d1c3fe	Keeps the service and check tokens around for deregistration. ... We fixed a few related issues while we were in here. We now only let services register checks with a matching token, and we also close out service and check delete operations if the catalog deregister claims it doesn't know about the ID of the service or check being deleted.	8 years ago
Kyle Havlovitz	390f41d8d5	Add advanced autopilot features	8 years ago
James Phillips	26dddb428c	Forces user-supplied node IDs to lower case for consistency.	8 years ago
Kyle Havlovitz	2eefe3ca5b	Add autopilot server health tracking ... This adds two goroutines to perform autopilot tasks on the leader - one to monitor the health of servers and another to periodically clean up dead servers with a limit on removal count. Also adds a new http endpoint, `/v1/operator/autopilot/health`, for querying this information through an operator RPC endpoint.	8 years ago
Kyle Havlovitz	ab6c49ab4c	Merge pull request #2771 from hashicorp/f-autopilot ... Autopilot dead server cleanup, config, and raft version compatibility	8 years ago
Kyle Havlovitz	92c8b9c3a0	Rename DeadServerCleanup and make wording adjustments	8 years ago
Kyle Havlovitz	9221aed856	Remove the RPC client interface and update docs	8 years ago
Kyle Havlovitz	81c7a0299e	Add state store table and endpoints for autopilot	8 years ago
Kyle Havlovitz	b20fd222f6	Add raft version 2/3 compatibility	8 years ago
Kyle Havlovitz	a533e255ab	Merge pull request #2699 from hashicorp/f-tls-min-version ... Add TLSMinVersion to config options	8 years ago
Kyle Havlovitz	07ba3ddb6e	Add TLSMinVersion to config options	8 years ago
Sean Chittenden	fd2ae702c9	Re-cherry-pick 71d807f607 and e2320d69b6.	8 years ago
James Phillips	91f3555dd8	Revert "Adds gopsutil in the loop when trying to make the node ID."	8 years ago
James Phillips	e2320d69b6	Gets rid of a goto.	8 years ago
James Phillips	71d807f607	Adds gopsutil into node ID process and attempts to use host ID, if availabile.	8 years ago
Kyle Havlovitz	a55968f009	Merge branch 'master' into f-prepared-query-nodemeta	8 years ago
Kyle Havlovitz	3f3d7f9891	Add tests for node meta in prepared queries and update docs	8 years ago
James Phillips	bd605e330c	Adds basic support for node IDs.	8 years ago
Kyle Havlovitz	7f91cd12f4	Add -node-meta to agent command line options	8 years ago
Kyle Havlovitz	c9e430c396	Validate metadata config earlier and handle multiple filters	8 years ago
Kyle Havlovitz	03273e4ed2	Fix formatting	8 years ago
Kyle Havlovitz	84504a20fc	Add meta key validations and more tests	8 years ago
Kyle Havlovitz	e44bcb9716	Add tests for node metadata functionality	8 years ago
Kyle Havlovitz	52d6fd831e	Add support for setting node metadata fields	8 years ago
James Phillips	ca7a243b70	Adds ACL management support to the agent.	8 years ago
James Phillips	bcf1ffad99	Adds complete ACL coverage for /v1/coordinate/nodes and Coordinate.Update RPC.	8 years ago
James Phillips	0139bbb963	Adds support for a new "acl_agent_token" which is used for internal ... catalog operations.	8 years ago
James Phillips	66b437ca33	Removes the exception for the "consul" service in the catalog.	8 years ago
Sean Chittenden	830125a8b3	Run all known addresses through go-sockaddr/template. ... The following is now possible: ``` $ consul agent -dev -client="{{GetPrivateIP}}" -bind='{{GetInterfaceIP "en0"}}' ```	8 years ago
Kyle Havlovitz	bd69c6d871	Add reload/leave http endpoints (#2516)	8 years ago
Seth Vargo	4179aacf11	Add an API method for determining the best status ... Given a list of HealthChecks, this determines the "best" status for the collective group. This is useful for nodes and services, which may have multiple checks associated with them.	8 years ago
Kyle Havlovitz	338e36cc5d	Add logWriter to agent Create() method	8 years ago
Kyle Havlovitz	124f907063	Add monitor http endpoint	8 years ago
Kyle Havlovitz	92ce2c9e39	Use uuids in persist temp files to avoid race (#2494)	8 years ago
Kyle Havlovitz	b1760b223e	Improve logging when deregistering a nonexistent service (#2492) ... Log a warning instead of a success message when attempting to deregister a nonexistent service. In Consul 0.8 this can be changed to giving an error outright, but for now we can keep the idempotent delete behavior.	8 years ago
Kyle Havlovitz	83d2f36b54	Merge pull request #2480 from hashicorp/b-atomic-writes ... Atomic writes for persisting service/check state	8 years ago
Kyle Havlovitz	7a3e0f8275	Add a note about not calling sync for persistCheckState	8 years ago
Kyle Havlovitz	e30b289c6f	Call fsync() for saving check/service state	8 years ago
Kyle McCullough	73b281a27c	Add setting to skip ssl certificate verification for HTTP checks (#1984) ... * http check: add setting to skip ssl certificate verification * update http check documentation * fix typo in documentation * Add TLSSkipVerify to agent api	8 years ago
James Phillips	233a3a101b	Supports WAN and LAN Serf Bind Addresses. (#2468) ... * * adding cli config and config file support for specifying the serf wan and lan bind addresses * updating documentation for serf wan and lan options Fixes #2007 * Cleans up some small things from #2380. * Uses the bind default for the agent test for Serf WAN and LAN.	8 years ago
James Phillips	c01a3871c9	Adds support for snapshots and restores. (#2396) ... * Updates Raft library to get new snapshot/restore API. * Basic backup and restore working, but need some cleanup. * Breaks out a snapshot module and adds a SHA256 integrity check. * Adds snapshot ACL and fills in some missing comments. * Require a consistent read for snapshots. * Make sure snapshot works if ACLs aren't enabled. * Adds a bit of package documentation. * Returns an empty response from restore to avoid EOF errors. * Adds API client support for snapshots. * Makes internal file names match on-disk file snapshots. * Adds DC and token coverage for snapshot API test. * Adds missing documentation. * Adds a unit test for the snapshot client endpoint. * Moves the connection pool out of the client for easier testing. * Fixes an incidental issue in the prepared query unit test. I realized I had two servers in bootstrap mode so this wasn't a good setup. * Adds a half close to the TCP stream and fixes panic on error. * Adds client and endpoint tests for snapshots. * Moves the pool back into the snapshot RPC client. * Adds a TLS test and fixes half-closes for TLS connections. * Tweaks some comments. * Adds a low-level snapshot test. This is independent of Consul so we can pull this out into a library later if we want to. * Cleans up snapshot and archive and completes archive tests. * Sends a clear error for snapshot operations in dev mode. Snapshots require the Raft snapshots to be readable, which isn't supported in dev mode. Send a clear error instead of a deep-down Raft one. * Adds docs for the snapshot endpoint. * Adds a stale mode and index feedback for snapshot saves. This gives folks a way to extract data even if the cluster has no leader. * Changes the internal format of a snapshot from zip to tgz. * Pulls in Raft fix to cancel inflight before a restore. * Pulls in new Raft restore interface. * Adds metadata to snapshot saves and a verify function. * Adds basic save and restore snapshot CLI commands. * Gets rid of tarball extensions and adds restore message. * Fixes an incidental bad link in the KV docs. * Adds documentation for the snapshot CLI commands. * Scuttle any request body when a snapshot is saved. * Fixes archive unit test error message check. * Allows for nil output writers in snapshot RPC handlers. * Renames hash list Decode to DecodeAndVerify. * Closes the client connection for snapshot ops. * Lowers timeout for restore ops. * Updates Raft vendor to get new Restore signature and integrates with Consul. * Bounces the leader's internal state when we do a restore.	8 years ago
James Phillips	03ae813bc7	Merge pull request #2389 from hashicorp/jbs-2019 ... Lower Service tag DNS warning to DEBUG for #2019	8 years ago