51 Commits (34e6e23d43b55712486659ade4bab0f5fab05179)

Author	SHA1	Message	Date
Hans Hasselberg	2ad0831b34	agent: fewer file local differences between enterprise and oss (#6820) (#6898) ... * Increase number to test ignore. Consul Enterprise has more flags and since we are trying to reduce the differences between both code bases, we are increasing the number in oss. The semantics don't change, it is just a cosmetic thing. * Introduce agent.initEnterprise for enterprise related hooks. * Sync test with ent version. * Fix import order. * revert error wording.	5 years ago
Matt Keeler	a704ebe639	Add Namespace support to the API module and the CLI commands (#6874) ... Also update the Docs and fixup the HTTP API to return proper errors when someone attempts to use Namespaces with an OSS agent. Add Namespace HTTP API docs Make all API endpoints disallow unknown fields	5 years ago
Mike Morris	65be58703c	connect: remove managed proxies (#6220) ... * connect: remove managed proxies implementation and all supporting config options and structs * connect: remove deprecated ProxyDestination * command: remove CONNECT_PROXY_TOKEN env var * agent: remove entire proxyprocess proxy manager * test: remove all managed proxy tests * test: remove irrelevant managed proxy note from TestService_ServerTLSConfig * test: update ContentHash to reflect managed proxy removal * test: remove deprecated ProxyDestination test * telemetry: remove managed proxy note * http: remove /v1/agent/connect/proxy endpoint * ci: remove deprecated test exclusion * website: update managed proxies deprecation page to note removal * website: remove managed proxy configuration API docs * website: remove managed proxy note from built-in proxy config * website: add note on removing proxy subdirectory of data_dir	5 years ago
Alvin Huang	ef6b80bab2	resolve circleci config conflicts	5 years ago
Christian Muehlhaeuser	7753b97cc7	Simplified code in various places (#6176) ... All these changes should have no side-effects or change behavior: - Use bytes.Buffer's String() instead of a conversion - Use time.Since and time.Until where fitting - Drop unnecessary returns and assignment	5 years ago
R.B. Boyer	67a36e3452	handle structs.ConfigEntry decoding similarly to api.ConfigEntry decoding (#6106) ... Both 'consul config write' and server bootstrap config entries take a decoding detour through mapstructure on the way from HCL to an actual struct. They both may take in snake_case or CamelCase (for consistency) so need very similar handling. Unfortunately since they are operating on mirror universes of structs (api.* vs structs.*) the code cannot be identitical, so try to share the kind-configuration and duplicate the rest for now.	5 years ago
R.B. Boyer	38d76c624e	Allow for both snake_case and CamelCase for config entries written with 'consul config write'. (#6044) ... This also has the added benefit of fixing an issue with passing time.Duration fields through config entries.	6 years ago
Matt Keeler	95d44e0110	Allow MapWalk to handle []interface{} elements that are []uint8 (#5800) ... * Allow MapWalk to handle []interface{} elements that are []uint8 * Ensure ints are left alone.	6 years ago
Matt Keeler	0ac6b6faba	Fix up the MapWalk function so that it properly handles nested map[interface{}]interface{} (#5774)	6 years ago
Paul Banks	8f5b16ebaf	Fix uint8 conversion issues for service config response maps.	6 years ago
Matt Keeler	d0f410cd84	Make a few config entry endpoints return 404s and allow for snake_case and lowercase key names. (#5748)	6 years ago
Kyle Havlovitz	aba54cec55	Add HTTP endpoints for config entry management (#5718)	6 years ago
Matt Keeler	5befe0f5d5	Implement config entry replication (#5706)	6 years ago
Jeff Mitchell	47c390025b	Convert to Go Modules (#5517) ... * First conversion * Use serf 0.8.2 tag and associated updated deps * * Move freeport and testutil into internal/ * Make internal/ its own module * Update imports * Add replace statements so API and normal Consul code are self-referencing for ease of development * Adapt to newer goe/values * Bump to new cleanhttp * Fix ban nonprintable chars test * Update lock bad args test The error message when the duration cannot be parsed changed in Go 1.12 (ae0c435877d3aacb9af5e706c40f9dddde5d3e67). This updates that test. * Update another test as well * Bump travis * Bump circleci * Bump go-discover and godo to get rid of launchpad dep * Bump dockerfile go version * fix tar command * Bump go-cleanhttp	6 years ago
R.B. Boyer	f4a3b9d518	fix typos reported by golangci-lint:misspell (#5434)	6 years ago
Matt Keeler	118adbb123	ACL Token Persistence and Reloading (#5328) ... This PR adds two features which will be useful for operators when ACLs are in use. 1. Tokens set in configuration files are now reloadable. 2. If `acl.enable_token_persistence` is set to `true` in the configuration, tokens set via the `v1/agent/token` endpoint are now persisted to disk and loaded when the agent starts (or during configuration reload) Note that token persistence is opt-in so our users who do not want tokens on the local disk will see no change. Some other secondary changes: * Refactored a bunch of places where the replication token is retrieved from the token store. This token isn't just for replicating ACLs and now it is named accordingly. * Allowed better paths in the `v1/agent/token/` API. Instead of paths like: `v1/agent/token/acl_replication_token` the path can now be just `v1/agent/token/replication`. The old paths remain to be valid. * Added a couple new API functions to set tokens via the new paths. Deprecated the old ones and pointed to the new names. The names are also generally better and don't imply that what you are setting is for ACLs but rather are setting ACL tokens. There is a minor semantic difference there especially for the replication token as again, its no longer used only for ACL token/policy replication. The new functions will detect 404s and fallback to using the older token paths when talking to pre-1.4.3 agents. * Docs updated to reflect the API additions and to show using the new endpoints. * Updated the ACL CLI set-agent-tokens command to use the non-deprecated APIs.	6 years ago
Paul Banks	ef9f27cbc8	connect: tame thundering herd of CSRs on CA rotation (#5228) ... * Support rate limiting and concurrency limiting CSR requests on servers; handle CA rotations gracefully with jitter and backoff-on-rate-limit in client * Add CSR rate limiting docs * Fix config naming and add tests for new CA configs	6 years ago
Matt Keeler	18b29c45c4	New ACLs (#4791) ... This PR is almost a complete rewrite of the ACL system within Consul. It brings the features more in line with other HashiCorp products. Obviously there is quite a bit left to do here but most of it is related docs, testing and finishing the last few commands in the CLI. I will update the PR description and check off the todos as I finish them over the next few days/week. Description At a high level this PR is mainly to split ACL tokens from Policies and to split the concepts of Authorization from Identities. A lot of this PR is mostly just to support CRUD operations on ACLTokens and ACLPolicies. These in and of themselves are not particularly interesting. The bigger conceptual changes are in how tokens get resolved, how backwards compatibility is handled and the separation of policy from identity which could lead the way to allowing for alternative identity providers. On the surface and with a new cluster the ACL system will look very similar to that of Nomads. Both have tokens and policies. Both have local tokens. The ACL management APIs for both are very similar. I even ripped off Nomad's ACL bootstrap resetting procedure. There are a few key differences though. Nomad requires token and policy replication where Consul only requires policy replication with token replication being opt-in. In Consul local tokens only work with token replication being enabled though. All policies in Nomad are globally applicable. In Consul all policies are stored and replicated globally but can be scoped to a subset of the datacenters. This allows for more granular access management. Unlike Nomad, Consul has legacy baggage in the form of the original ACL system. The ramifications of this are: A server running the new system must still support other clients using the legacy system. A client running the new system must be able to use the legacy RPCs when the servers in its datacenter are running the legacy system. The primary ACL DC's servers running in legacy mode needs to be a gate that keeps everything else in the entire multi-DC cluster running in legacy mode. So not only does this PR implement the new ACL system but has a legacy mode built in for when the cluster isn't ready for new ACLs. Also detecting that new ACLs can be used is automatic and requires no configuration on the part of administrators. This process is detailed more in the "Transitioning from Legacy to New ACL Mode" section below.	6 years ago
Paul Banks	c6ef6a61c9	Refactor to use embedded struct.	7 years ago
Paul Banks	32f362bad9	StartupTelemetry => InitTelemetry	7 years ago
Paul Banks	a7038454fd	WIP	7 years ago
Mitchell Hashimoto	e9b8e5d265	lib/file: add tests for WriteAtomic	7 years ago
Mitchell Hashimoto	1e7f253b53	agent/proxy: write pid file whenever the daemon process changes	7 years ago
Seth Vargo	0603cda5ee	Add a helper for generating Consul's user-agent string	7 years ago
Paul Banks	ff37194fc0	Go fmt cleanup	7 years ago
Preetha Appan	fff532cf84	Update serf to pick up clean leave fix	7 years ago
Veselkov Konstantin	7de57ba4de	remove golint warnings	7 years ago
James Phillips	d12e81860f	Moves Serf helper into lib to fix import cycle in consul-enterprise.	7 years ago
James Phillips	fe36ed6412	Bumps freeport's block size. ... We were seeing some rollover artifacts where something would be shut down so a port could be re-used, but it was still being referenced by some running thing. This gives more time before rolling over.	7 years ago
Alex Dadgar	358e6827cd	Update cluster.go	7 years ago
Alex Dadgar	6d0b9f4dac	Integer division rounding to zero for rate scaling ... This fixes an issue in which integer division was scaling down to zero.	7 years ago
Alex Dadgar	0fccef237d	Initialize freeport lazily to avoid runtime issues ... This PR makes freeport initialize lazily rather than using an init method.	7 years ago
Alex Dadgar	17dcbb1912	Make freeport testing friendly ... This PR allows the caller to decide if they would like to have the calling test fail, have the caller panic on error, or handle the errors themselves.	7 years ago
Frank Schroeder	c94751ad43	test: replace porter tool with freeport lib ... This patch removes the porter tool which hands out free ports from a given range with a library which does the same thing. The challenge for acquiring free ports in concurrent go test runs is that go packages are tested concurrently and run in separate processes. There has to be some inter-process synchronization in preventing processes allocating the same ports. freeport allocates blocks of ports from a range expected to be not in heavy use and implements a system-wide mutex by binding to the first port of that block for the lifetime of the application. Ports are then provided sequentially from that block and are tested on localhost before being returned as available.	7 years ago
James Phillips	bb12368eac	Makes RPC handling more robust when rolling servers. (#3561) ... * Adds client-side retry for no leader errors. This paves over the case where the client was connected to the leader when it loses leadership. * Adds a configurable server RPC drain time and a fail-fast path for RPCs. When a server leaves it gets removed from the Raft configuration, so it will never know who the new leader server ends up being. Without this we'd be doomed to wait out the RPC hold timeout and then fail. This makes things fail a little quicker while a sever is draining, and since we added a client retry AND since the server doing this has already shut down and left the Serf LAN, clients should retry against some other server. * Makes the RPC hold timeout configurable. * Reorders struct members. * Sets the RPC hold timeout default for test servers. * Bumps the leave drain time up to 5 seconds. * Robustifies retries with a simpler client-side RPC hold. * Reverts untended delete.	7 years ago
James Phillips	b1a15e0c3d	Adds open source side of network segments (feature is Enterprise-only).	7 years ago
Frank Schroeder	3403cd4372	golint: Fix existing comments ... This needs more work.	8 years ago
James Phillips	7c27ca1f77	Adds missing unit tests and cleans up some router bugs.	8 years ago
James Phillips	1091c7314e	Removes remoteConsuls in favor of the new router. ... This has the next wave of RTT integration with the router and also factors some common RTT-related helpers out to lib. While we were in here we also got rid of the coordinate disable config so we don't need to deal with the complexity in the router (there was never a user-visible way to disable coordinates).	8 years ago
James Phillips	bd605e330c	Adds basic support for node IDs.	8 years ago
Sean Chittenden	d695bcaae6	Use a cryptographically secure seed ... `SeededSecurely` is present if someone or something wants to query the way the library was seeded. Obtained from: nomad	9 years ago
Sean Chittenden	da298f527d	Guard against divide by zero in lib.RandomStagger() ... While I'm at it, add a DurationMinusBufferDomain() function to calculate the min/max for a given call to DurationMinusBuffer() in order to keep the implementation details self-contained.	9 years ago
Sean Chittenden	3a6be9cab0	Add a helper function DurationMinusBuffer() to calculate an interval ... used to schedule a TTL check. e.g. d := lib.DurationMinusBuffer(60 * time.Duration, 10 * time.Second, 16) will return a duration between 46.875s and 50s.	9 years ago
Sean Chittenden	4584e70636	Add lib.AbsInt() helper function	9 years ago
Sean Chittenden	88c42f4056	Move lib's tests to lib_test ... This suite of tests is only testing the exported functions	9 years ago
Sean Chittenden	9fb64ab114	Allow adjusting the number of DNS records in a response... ... Based on work done by @fusiondog in #1583, extend the concept to use an integer instead of a boolean. Fixes: #1583 && #1481	9 years ago
Sean Chittenden	4fec6a9608	Guard against very small or negative rates ... Pointed out by: slackpad	9 years ago
Sean Chittenden	81e1e1c05d	Cull unused function and its unit test. ... Pointed out by: @slackpad	9 years ago
Sean Chittenden	6c1bb78d06	Cull unused function and its unit test. ... Pointed out by: @slackpad	9 years ago
Sean Chittenden	4382c1f7aa	Always seed math/rand on consul startup ... Required for jitter calcs. This could be done in consul/agent, but this makes it clear it is done only once process-wide.	9 years ago