consul

Commit Graph

Author	SHA1	Message	Date
Daniel Nephin	99eb583ebc	Replace goe/verify.Values with testify/require.Equal (#7993 ) * testing: replace most goe/verify.Values with require.Equal One difference between these two comparisons is that go/verify considers nil slices/maps to be equal to empty slices/maps, where as testify/require does not, and does not appear to provide any way to enable that behaviour. Because of this difference some expected values were changed from empty slices to nil slices, and some calls to verify.Values were left. * Remove github.com/pascaldekloe/goe/verify Reduce the number of assertion packages we use from 2 to 1	2020-06-02 12:41:25 -04:00
James Phillips	1333fa57a1	Skips unique node ID check for old versions of Consul. Fixes #3070.	2017-09-05 22:57:29 -07:00

Author

SHA1

Message

Date

Daniel Nephin

99eb583ebc

Replace goe/verify.Values with testify/require.Equal (#7993 )

* testing: replace most goe/verify.Values with require.Equal

One difference between these two comparisons is that go/verify considers
nil slices/maps to be equal to empty slices/maps, where as testify/require
does not, and does not appear to provide any way to enable that behaviour.

Because of this difference some expected values were changed from empty
slices to nil slices, and some calls to verify.Values were left.

* Remove github.com/pascaldekloe/goe/verify

Reduce the number of assertion packages we use from 2 to 1

2020-06-02 12:41:25 -04:00

James Phillips

1333fa57a1

Skips unique node ID check for old versions of Consul.

Fixes #3070.

2017-09-05 22:57:29 -07:00

2 Commits (2e4c9f5330da384c5763e6f0d8b8896b013adaef)