144 Commits (262897469260cc6319ea9369518e20ac2fed3178)

Author	SHA1	Message	Date
Frank Schroeder	1602ac56b5	local state: drop retry loops from tests ... Since the tests are now using synchronous calls for state syncing we no longer need to use retry loops to wait for the changes to propagate.	7 years ago
Frank Schroeder	71c74e62c7	local state: fix anti-entropy state tests ... The anti-entropy tests relied on the side-effect of the StartSync() method to perform a full sync instead of a partial sync. This lead to multiple anti-entropy go routines being started unnecessary retry loops. This change changes the behavior to perform synchronous full syncs when necessary removing the need for all of the time.Sleep and most of the retry loops.	7 years ago
Frank Schroeder	37b95ef98e	local state: fix test with updated error message	7 years ago
Frank Schroeder	b803bf3091	local state: tests compile	7 years ago
Frank Schroeder	0a9ac9749e	local state: replace multi-map state with structs ... The state of the service and health check records was spread out over multiple maps guarded by a single lock. Access to the maps has to happen in a coordinated effort and the tests often violated this which made them brittle and racy. This patch replaces the multiple maps with a single one for both checks and services to make the code less fragile. This is also necessary since moving the local state into its own package creates circular dependencies for the tests. To avoid this the tests can no longer access internal data structures which they should not be doing in the first place. The tests still don't compile but this is a ncessary step in that direction.	7 years ago
Frank Schroeder	6027a9e2a5	local state: move to separate package ... This patch moves the local state to a separate package to further decouple it from the agent code. The code compiles but the tests do not yet.	7 years ago
Frank Schroeder	67a0689f71	Revert "local state: move to separate package" ... This reverts commit d447e823c6.	7 years ago
Frank Schroeder	623e07760a	Revert "local state: replace multi-map state with structs" ... This reverts commit ccbae7da5b.	7 years ago
Frank Schroeder	9ed4b2d631	Revert "local state: tests compile" ... This reverts commit 1af52bf7be.	7 years ago
Frank Schroeder	5ae4c52ca6	Revert "local state: fix test with updated error message" ... This reverts commit e9149f64d9.	7 years ago
Frank Schroeder	67cdfc038e	Revert "local state: fix anti-entropy state tests" ... This reverts commit f8e20cd996.	7 years ago
Frank Schroeder	556bf3f85d	Revert "local state: drop retry loops from tests" ... This reverts commit 2bdba8ab06.	7 years ago
Frank Schroeder	a3aa864d5b	Revert "local state: rename tests" ... This reverts commit ff62eaf063.	7 years ago
Frank Schroeder	39615cb57b	Revert "local state: fix TestAgentAntiEntropy_EnableTagOverride" ... This reverts commit 86f7ea6013.	7 years ago
Frank Schroeder	9fdea75d99	Revert "local state: refactor TestAgentAntiEntropy_EnableTagOverride" ... This reverts commit c28e23eac8.	7 years ago
Frank Schroeder	46641e44d9	Revert "local state: address review comments" ... This reverts commit 1d315075b1.	7 years ago
Frank Schroeder	abd83f2d28	Revert "local state: update comments" ... This reverts commit 42188164f8.	7 years ago
Frank Schroeder	c6e441dd60	Revert "local state: update documentation of updateSyncState" ... This reverts commit e86521e637.	7 years ago
Frank Schroeder	648b4da4f8	Revert "local state: move Metadata methods together" ... This reverts commit 9bc8127728.	7 years ago
Frank Schroeder	fa45a6a547	Revert "local state: rename Add{Check,Service}State to Set{Check,Service}State" ... This reverts commit 9280841a80.	7 years ago
Frank Schroeder	d6f52d9ed1	Revert "local state: use synchronized access to internal maps" ... This reverts commit 39a2d8d25e.	7 years ago
Frank Schroeder	4e862d126d	Revert "local state: clone check to avoid side effect" ... This reverts commit af1243c725.	7 years ago
Frank Schroeder	42af4cdc70	Revert "local state: make test more robust" ... This reverts commit f9267380db.	7 years ago
Frank Schroeder	4ae8317fbf	Revert "local state: remove stale comment" ... This reverts commit 35f4acdddc.	7 years ago
Frank Schroeder	223fae7d92	Revert "fix go vet issue" ... This reverts commit 078e50b635.	7 years ago
Frank Schroeder	078e50b635	fix go vet issue	7 years ago
Frank Schroeder	35f4acdddc	local state: remove stale comment	7 years ago
Frank Schroeder	f9267380db	local state: make test more robust	7 years ago
Frank Schroeder	af1243c725	local state: clone check to avoid side effect	7 years ago
Frank Schroeder	39a2d8d25e	local state: use synchronized access to internal maps	7 years ago
Frank Schroeder	9280841a80	local state: rename Add{Check,Service}State to Set{Check,Service}State	7 years ago
Frank Schroeder	9bc8127728	local state: move Metadata methods together	7 years ago
Frank Schroeder	e86521e637	local state: update documentation of updateSyncState	7 years ago
Frank Schroeder	42188164f8	local state: update comments	7 years ago
Frank Schroeder	1d315075b1	local state: address review comments ... * move non-blocking notification mechanism into ae.Trigger * move Pause/Resume into separate type	7 years ago
Frank Schroeder	c28e23eac8	local state: refactor TestAgentAntiEntropy_EnableTagOverride ... Make intent clearer by being more explicit and adding some comments. Use verify.Values to compare service entries.	7 years ago
Frank Schroeder	86f7ea6013	local state: fix TestAgentAntiEntropy_EnableTagOverride ... The test had a race condition where it relied on the first service to be synced to the remote catalog which sometimes failed.	7 years ago
Frank Schroeder	ff62eaf063	local state: rename tests	7 years ago
Frank Schroeder	2bdba8ab06	local state: drop retry loops from tests ... Since the tests are now using synchronous calls for state syncing we no longer need to use retry loops to wait for the changes to propagate.	7 years ago
Frank Schroeder	f8e20cd996	local state: fix anti-entropy state tests ... The anti-entropy tests relied on the side-effect of the StartSync() method to perform a full sync instead of a partial sync. This lead to multiple anti-entropy go routines being started unnecessary retry loops. This change changes the behavior to perform synchronous full syncs when necessary removing the need for all of the time.Sleep and most of the retry loops.	7 years ago
Frank Schroeder	e9149f64d9	local state: fix test with updated error message	7 years ago
Frank Schroeder	1af52bf7be	local state: tests compile	7 years ago
Frank Schroeder	ccbae7da5b	local state: replace multi-map state with structs ... The state of the service and health check records was spread out over multiple maps guarded by a single lock. Access to the maps has to happen in a coordinated effort and the tests often violated this which made them brittle and racy. This patch replaces the multiple maps with a single one for both checks and services to make the code less fragile. This is also necessary since moving the local state into its own package creates circular dependencies for the tests. To avoid this the tests can no longer access internal data structures which they should not be doing in the first place. The tests still don't compile but this is a ncessary step in that direction.	7 years ago
Frank Schroeder	d447e823c6	local state: move to separate package ... This patch moves the local state to a separate package to further decouple it from the agent code. The code compiles but the tests do not yet.	7 years ago