239 Commits (21118cafeb21b37111e6ff2a3d5e94528a1deaaa)

Author	SHA1	Message	Date
Frank Schröder	21118cafeb	Recursive sanitize (#3505) ... * vendor: add github.com/sergi/go-diff/diffmatchpatch for diff'ing test output * config: refactor Sanitize to recursively clean runtime config and format complex fields * Removes an extra int cast. * Adds a top-level check test case for sanitization.	7 years ago
James Phillips	0190c4a081	Gets rid of flaky clause in stats fetcher unit test. ... Given how the rutine is coded we can still get data so this wasn't a reliable thing to check.	7 years ago
preetapan	4d9fc638b4	Issue 3452 (#3500) ... * Make sure that id and address are set in member created during reaping of catalog nodes that have been removed from serf * Get address from node table in the state store rather than from service address * Fix incorrect lookup by checkname instead of node name * Make sure that serverlookup is called with the right address format, added unit test. * Address code review comments * Tweaks style stuff.	7 years ago
Frank Schröder	e84c2b2edd	Metrics service prefix (#3498) ... * metrics: replace statsite_prefix with service_prefix The metrics prefix isn't statsite specific and is in fact used for all metrics providers. Since we are deprecating fields anyway we should fix this one as well. Fixes #3293 * Updates docs and sorts telemetry section. * Renames to "metrics_prefix" to disambiguate with Consul services. * Updates the change log.	7 years ago
James Phillips	49058fee11	Merge pull request #3501 from hashicorp/snapshot-test-hang ... Cleans up some edge cases in TestSnapshot_Forward_Leader.	7 years ago
James Phillips	5fa2322e0b	Cleans up some edge cases in TestSnapshot_Forward_Leader. ... These could cause the tests to hang.	7 years ago
Kyle Havlovitz	bfa70a10ca	Fix watch error when http & https are disabled (#3493) ... Remove an error in watch reloading that happens when http and https are both disabled, and use an https address for running watches if no http addresses are present. Fixes #3425.	7 years ago
Preetha Appan	3c4a108769	Move Raft protocol version for list peers end point to server side, fix unit tests. This fixes #3449	7 years ago
Frank Schroeder	56e6439be9	fix data race ... Since state.Checks() returns a shallow copy its elements must not be modified. Copying the elements in the handler does not guarantee consistency since that list is guarded by a different lock. Therefore, the only solution is to have state.Checks() return a deep copy.	7 years ago
Frank Schroeder	7bd85792b2	config: do not clobber multiple check and service definitions ... This patch ensures that multiple files with single 'check' or 'service' definitions result in the combination of them.	7 years ago
James Phillips	a75a779469	Renames `enable_ui` to `ui` to keep compatibility with existing configs.	7 years ago
Frank Schröder	1e461110e6	agent: consolidate handling of 405 Method Not Allowed (#3405) ... * agent: consolidate http method not allowed checks This patch uses the error handling of the http handlers to handle HTTP method not allowed errors across all available endpoints. It also adds a test for testing whether the endpoints respond with the correct status code. * agent: do not panic on metrics tests * agent: drop other tests for MethodNotAllowed * agent: align /agent/join with reality /agent/join uses PUT instead of GET as documented. * agent: align /agent/check/{fail,warn,pass} with reality /agent/check/{fail,warn,pass} uses PUT instead of GET as documented. * fix some tests * Drop more tests for method not allowed * Align TestAgent_RegisterService_InvalidAddress with reality * Changes API client join to use PUT instead of GET. * Fixes agent endpoint verbs and removes obsolete tests. * Updates the change log.	7 years ago
preetapan	73951d8319	Merge pull request #3494 from hashicorp/enforce_json_extension ... Enforce json or hcl extension to Consul config files, updated unit tests	7 years ago
James Phillips	45646ac3f4	Bumps default Raft protocol to version 3. (#3477) ... * Changes default Raft protocol to 3. * Changes numPeers() to report only voters. This should have been there before, but it's more obvious that this is incorrect now that we default the Raft protocol to 3, which puts new servers in a read-only state while Autopilot waits for them to become healthy. * Fixes TestLeader_RollRaftServer. * Fixes TestOperator_RaftRemovePeerByAddress. * Fixes TestServer_*. Relaxed the check for a given number of voter peers and instead do a thorough check that all servers see each other in their Raft configurations. * Fixes TestACL_*. These now just check for Raft replication to be set up, and don't care about the number of voter peers. * Fixes TestOperator_Raft_ListPeers. * Fixes TestAutopilot_CleanupDeadServerPeriodic. * Fixes TestCatalog_ListNodes_ConsistentRead_Fail. * Fixes TestLeader_ChangeServerID and adjusts the conn pool to throw away sockets when it sees io.EOF. * Changes version to 1.0.0 in the options doc. * Makes metrics test more deterministic with autopilot metrics possible.	7 years ago
Preetha Appan	a286ad7533	Enforce json or hcl extension to Consul config files, updated unit tests	7 years ago
James Phillips	f42e85ce22	Removes unused imports in agent_test.go.	7 years ago
Preetha Appan	d7e27e67c1	Introduce Code Policy validation via sentinel, with a noop implementation	7 years ago
Frank Schröder	12216583a1	New config parser, HCL support, multiple bind addrs (#3480) ... * new config parser for agent This patch implements a new config parser for the consul agent which makes the following changes to the previous implementation: * add HCL support * all configuration fragments in tests and for default config are expressed as HCL fragments * HCL fragments can be provided on the command line so that they can eventually replace the command line flags. * HCL/JSON fragments are parsed into a temporary Config structure which can be merged using reflection (all values are pointers). The existing merge logic of overwrite for values and append for slices has been preserved. * A single builder process generates a typed runtime configuration for the agent. The new implementation is more strict and fails in the builder process if no valid runtime configuration can be generated. Therefore, additional validations in other parts of the code should be removed. The builder also pre-computes all required network addresses so that no address/port magic should be required where the configuration is used and should therefore be removed. * Upgrade github.com/hashicorp/hcl to support int64 * improve error messages * fix directory permission test * Fix rtt test * Fix ForceLeave test * Skip performance test for now until we know what to do * Update github.com/hashicorp/memberlist to update log prefix * Make memberlist use the default logger * improve config error handling * do not fail on non-existing data-dir * experiment with non-uniform timeouts to get a handle on stalled leader elections * Run tests for packages separately to eliminate the spurious port conflicts * refactor private address detection and unify approach for ipv4 and ipv6. Fixes #2825 * do not allow unix sockets for DNS * improve bind and advertise addr error handling * go through builder using test coverage * minimal update to the docs * more coverage tests fixed * more tests * fix makefile * cleanup * fix port conflicts with external port server 'porter' * stop test server on error * do not run api test that change global ENV concurrently with the other tests * Run remaining api tests concurrently * no need for retry with the port number service * monkey patch race condition in go-sockaddr until we understand why that fails * monkey patch hcl decoder race condidtion until we understand why that fails * monkey patch spurious errors in strings.EqualFold from here * add test for hcl decoder race condition. Run with go test -parallel 128 * Increase timeout again * cleanup * don't log port allocations by default * use base command arg parsing to format help output properly * handle -dc deprecation case in Build * switch autopilot.max_trailing_logs to int * remove duplicate test case * remove unused methods * remove comments about flag/config value inconsistencies * switch got and want around since the error message was misleading. * Removes a stray debug log. * Removes a stray newline in imports. * Fixes TestACL_Version8. * Runs go fmt. * Adds a default case for unknown address types. * Reoders and reformats some imports. * Adds some comments and fixes typos. * Reorders imports. * add unix socket support for dns later * drop all deprecated flags and arguments * fix wrong field name * remove stray node-id file * drop unnecessary patch section in test * drop duplicate test * add test for LeaveOnTerm and SkipLeaveOnInt in client mode * drop "bla" and add clarifying comment for the test * split up tests to support enterprise/non-enterprise tests * drop raft multiplier and derive values during build phase * sanitize runtime config reflectively and add test * detect invalid config fields * fix tests with invalid config fields * use different values for wan sanitiziation test * drop recursor in favor of recursors * allow dns_config.udp_answer_limit to be zero * make sure tests run on machines with multiple ips * Fix failing tests in a few more places by providing a bind address in the test * Gets rid of skipped TestAgent_CheckPerformanceSettings and adds case for builder. * Add porter to server_test.go to make tests there less flaky * go fmt	7 years ago
James Phillips	d84c0b1a01	Robustifies check in TestCatalog_ListNodes_ConsistentRead_Fail test. ... Fixes #3469	7 years ago
James Phillips	828be5771a	Revert "Manages segments list via a pointer." ... This reverts commit c277a42504.	7 years ago
James Phillips	c277a42504	Manages segments list via a pointer.	7 years ago
James Phillips	96a89a3381	Cleans up formatting.	7 years ago
James Phillips	00605c0214	Shows the segment name in the keyring API and command output.	7 years ago
James Phillips	aa5ef4a098	Populates the segment keyrings based on the LAN keyring.	7 years ago
James Phillips	88a150cee1	Moves reconcile loop into segment stub.	7 years ago
James Phillips	5c03cb571d	Takes the skip out of the client check. ... Without this the merge delegate won't check the segment for non-servers a little below here.	7 years ago
James Phillips	3418c7ff93	Merge pull request #3447 from hashicorp/issue-3070 ... Skips unique node ID check for old versions of Consul.	7 years ago
James Phillips	520060e138	Fixes incorrect comment.	7 years ago
James Phillips	084679ab65	Pulls down some code for the check loop.	7 years ago
James Phillips	3535652595	Uses the Raft configuration for the self-add skip check.	7 years ago
Preetha Appan	5f2e1c9b07	Change member join reconcile step to process joining itself, to handle node IP address changes correctly when number of servers < 3	7 years ago
James Phillips	1333fa57a1	Skips unique node ID check for old versions of Consul. ... Fixes #3070.	7 years ago
James Phillips	67b19ac065	Allow _all for WAN as a no-op.	7 years ago
James Phillips	1a117ba0a8	Makes the all segments query explict, and the default for `consul members`.	7 years ago
James Phillips	9258506dab	Adds simple rate limiting for client agent RPC calls to Consul servers. (#3440) ... * Added rate limiting for agent RPC calls. * Initializes the rate limiter based on the config. * Adds the rate limiter into the snapshot RPC path. * Adds unit tests for the RPC rate limiter. * Groups the RPC limit parameters under "limits" in the config. * Adds some documentation about the RPC limiter. * Sends a 429 response when the rate limiter kicks in. * Adds docs for new telemetry. * Makes snapshot telemetry look like RPC telemetry and cleans up comments.	7 years ago
Kyle Havlovitz	220db48aa7	Merge pull request #3431 from hashicorp/network-segments-oss	7 years ago
Kyle Havlovitz	0e33e2ecab	Pass listeners into setupSegments	7 years ago
Kyle Havlovitz	62102a537e	Organize segments for a cleaner split between enterprise and OSS	7 years ago
Kyle Havlovitz	baa501e0c5	Fill in the segment in the QuerySource for prepared query lookups	7 years ago
Kyle Havlovitz	7e565d7338	Fix some inconsistencies with segment logic and comments	7 years ago
Kyle Havlovitz	16aaf27208	Default bind/advertise for segments to BindAddr/AdvertiseAddr	7 years ago
Preetha Appan	2386214655	Wire server provider for raft layer only on protocol version 3 and above, and update changelog	7 years ago
Kyle Havlovitz	21513b0393	Update coord display in ui to account for segments	7 years ago
Kyle Havlovitz	14b027a3c2	Add segment addr field to tags for LAN flood joiner	7 years ago
Kyle Havlovitz	d129767657	Add agent.segment interpolation to prepared queries	7 years ago
Kyle Havlovitz	2ada0439d4	Add rpc_listener option to segment config	7 years ago
Kyle Havlovitz	a30e7657af	Add segment config validation	7 years ago
James Phillips	b1a15e0c3d	Adds open source side of network segments (feature is Enterprise-only).	7 years ago
Preetha Appan	a231eea0e7	More cleanup from code review	7 years ago
Preetha Appan	c6ee9bfa69	Remove copy pasted duplicate line, update documentation.	7 years ago