74 Commits (17d43c63166b4e695b65ce762c6393aba8e71dda)

Author	SHA1	Message	Date
Phil Renaud	de281cbfb7	[ui] codemirror lint removal (#21726) ... * ui: remove json linting dependency * Remove modes from codemirror change hooks * Modes and line numbers re-added, linting still removed, old underscore removed * Changelog added --------- Co-authored-by: dduzgun-security <deniz.duzgun@hashicorp.com>	3 months ago
sarahalsmiller	929d602dbb	ui: Upgrade d3 packages to update color dependency (#21588) ... * upgrade d3 packages to update color dependency * yarn package bump * deps moved into devdeps --------- Co-authored-by: Phil Renaud <phil@riotindustries.com>	4 months ago
Phil Renaud	dce6241869	[ui] File-specified deps for consul-ui (#21378) ... * Namespaced and file-specified deps * Pinning to a specific version of tailwind and setting config for js packages to come from npmjs * Pin glob instead of reverting tailwind or any other (grand)parent dependency * ember-cli-build fixed path resolution for now-namespaced submodules * Dropping the namespace prefix and relying on relative pathing	5 months ago
Chris Hut	75af5b15d9	Cc 7146/convert consul hcp to a simpler component for some upcoming changes (#20344) ... * Convert consul-hcp to a simpler component * update existing test to use envStub helper * Add missing copyright - weird no one yelled about this * remove consul-hcp from load * remove this test that doesn't run anymore	10 months ago
Tyler Wendlandt	e5948e8eb4	CC-5545: Side Nav (#19342) ... * Initial work for sidenav * Use HDS::Text * Add resolution for ember-element-helper * WIP dc selector * Update HCP Home link * DC selector * Hook up remaining selectors * Fix settings and tutorial links * Remove comments * Remove skip-links * Replace auth with new dropdown * Use href-to helper for sidenav links * Changelog * Add description to NavSelector * Wrap version in footer and role * Fix login tests * Add data-test selectors for namespaces * Fix datacenter disclosure menu test * Stop rendering auth dialog if acls are disabled * Update disabled selector state and token selector * Fix logic in ACL selector * Fix HCP Home integration test * Remove toggling the sidenav in tests * Add sidenav to eng docs * Re-add debug navigation for eng docs * Remove ember-in-viewport * Remove unused styles * Upgrade @hashicorp/design-system-componentseee * Add translations for side-nav * Only show back to hcp link if url is present * Disable responsive due to a11y-dialog issue	1 year ago
Chris Hut	ee2f046383	Upgrade Consul UI to Node 18 (#19252) ... * Upgrading node to node 18 * Ensure we're on latest version of yarn as well * add comma to make frontend tests run * Use Node 18 Alpine image in UI build dockerfile * delete package-lock.json --------- Co-authored-by: wenincode <tyler.wendlandt@hashicorp.com> Co-authored-by: Ella Cai <ella.y.cai@gmail.com> Co-authored-by: Ella Cai <ella@hashicorp.com>	1 year ago
Chris Hut	a6c990c6fe	Cc 5545: Upgrade HDS packages and modifiers (#19226) ... * Upgrade @hashicorp/design-system-tokens to 1.9.0 * Upgrade @hashicorp/design-system-components to 1.8.1 * Upgrade @hashicorp/design-system-components and ember-in-viewport * Explicitly install ember-modifier@4.1.0 * rename copy-button * Fix how cleanup is done in with-copyable * Update aria-menu modifier for new structure * Update css-prop modifier to new structure * Convert did-upsert to regular class modifier * Update notification modifier for new structure * Update on-oustside modifier for new structure * Move destroy handler registration in with-copyable * Update style modifier for new structure * Update validate modifier for new structure * Guard against setting on destroyed object * Upgrade @hashicorp/design-system-components to 2.14.1 * Remove debugger * Guard against null in aria-menu * Fix undefined hash in validate addon * Upgrade ember-on-resize-modifier * Fix copy button import, missing import and array destructuring --------- Co-authored-by: wenincode <tyler.wendlandt@hashicorp.com>	1 year ago
Valeriia Ruban	12be12f3a4	add scripts for testing locally consul-ui-toolkit (#16794)	2 years ago
Valeriia Ruban	d75f2ba5da	UI: update Ember to 3.28.6 (#16616) ... --------- Co-authored-by: wenincode <tyler.wendlandt@hashicorp.com>	2 years ago
Tyler Wendlandt	e6aeb31a26	UI: Fix htmlsafe errors throughout the app (#16574) ... * Upgrade ember-intl * Add changelog * Add yarn lock	2 years ago
Tyler Wendlandt	a0862e64a5	UI: Fix rendering issue in search and lists (#16444) ... * Upgrade ember-cli-string-helpers * add extra lock change	2 years ago
Valeriia Ruban	0c66bbf2b4	[UI] CC-4031: change from Action, a and button to hds::Button (#16251)	2 years ago
Valeriia Ruban	663a5642c2	[UI]: update Ember to 3.27 (#16227) ... * Upgrade to 3.25 via ember-cli-update * v3.25.3...v3.26.1 * v3.26.1...v3.27.0 Co-authored-by: Michael Klein <michael@firstiwaslike.com>	2 years ago
wenincode	d1019c25ce	Use FlightIcon component for external sources	2 years ago
wenincode	c450183b4c	Use local-storage service to manage localStorage ... Use local-storage service, prototyped here https://github.com/LevelbossMike/local-storage-service, to manage local storage usage in an octane way. Does not write to local storage in tests by default and is easy to stub out.	2 years ago
wenincode	6c2ca0ba3f	Save agentless node notice dismissal per dc	2 years ago
wenincode	8254f243ca	Move banner to component and make it dismissable	2 years ago
Michael Klein	559fbc2ef4	Pull in vertical-collection ... We want to use a community solution for occlusion rendering for this problem instead of using a custom abstraction.	2 years ago
Michael Klein	3b810469cf	Switch out ember-ref-modifier for ember-ref-bucket ... ember-ref-bucket is the successor of ref-modifier. We weren't using ref-modifier anywhere so switching out is not an issue.	2 years ago
Michael Klein	62a66a32d7	ui: Setup Hashicorp Design System for usage in consul-ui (#14394) ... * Use postcss instead of ember-cli-sass This will make it possible to work with tailwindcss. * configure postcss to compile sass * add "sub-app" css into app/styles tree * pin node@14 via volta Only used by people that use volta * Install tailwind and autoprefixer * Create tailwind config * Use tailwind via postcss * Fix: tailwind changes current styling When adding tailwind to the bottom of app.scss we apparently change the way the application looks. We will import it first to make sure we don't change the current styling of the application right now. * Automatic import of HDS colors in tailwind * Install @hashicorp/design-system-components * install add-on * setup postcss scss pipeline to include tokens css * import add-on css * Install ember-auto-import v2 HDS depends on v2 of ember-auto-import so we need to upgrade. * Upgrade ember-cli-yadda v0.6.0 of ember-cli-yadda adds configuration for webpack. This configuration is incompatible with webpack v5 which ember-auto-import v2 is using. We need to upgrade ember-cli-yadda to the latest version that fixes this incompatability with auto-import v2 * Install ember-flight-icons HDS components are using the addon internally. * Document HDS usage in engineering docs * Upgrade ember-cli-api-double * fix new linting errors	2 years ago
Michael Klein	03a1a86dfe	ui: chore - upgrade ember and friends (#14518) ... * v3.20.2...v3.24.0 * Fix handle undefined outlet in route component * Don't use template helper for optional modal.open Using the optional-helper here will trigger a computation in the same runloop error. This is because we are setting the `modal`-property when the `<Ref>` component gets rendered which will update the `this.modal`-property which will then recompute the `optional`-helper leading to this error. Instead we will create an action that will call the `open`-method on the modal when it is defined. This gets rid of the double computation error as we will not access the modal property twice in the same runloop when `modal` is getting set. * Fix - fn needs to be passed function tab-nav We create functions in the component file instead so that fn-helper stops complaining about the need to pass a function. * Update ember-exam to 6.1 version "Makes it compatible" with ember-qunit v5 * scheduleOnce setMaxHeight paged-collection We need to schedule to get around double-computation error. * Fix - model.data is removed from ember-data This has been private API all along - we need to work around the removal. Reference: https://github.com/emberjs/data/pull/7338/files#diff-9a8746fc5c86fd57e6122f00fef3155f76f0f3003a24b53fb7c4621d95dcd9bfL1310 * Fix `propContains` instead of `deepEqual` policy Recent model.data works differently than iterating attributes. We use `propContains` instead of `deepEqual`. We are only interested in the properties we assert against and match the previous behavior with this change. * Fix `propContains` instead of `deepEqual` token * Better handling single-records repo test-helper `model.data` has been removed we need to handle proxies and model instances differently. * Fix remaining repository tests with propContains We don't want to match entire objects - we don't care about properties we haven't defined in the assertion. * Don't use template helper for optional modal.open Using a template helper will give us a recomputation error - we work around it by creating an explicit action on the component instead. * Await `I $verb the $pageObject object` step * Fix no more customization ember-can No need to customize, the helper handles destruction fine on its own. * Fix - don't pass `optional` functions to fn We will declare the functions on the component instead. This gives us the same behavior but no error from `fn`, which expects a function to be passed. * Fix - handle `undefined` state on validate modifier StateChart can yield out an undefined `state` we need to handle that in the validate modifier * Fix linting errors tests directory * Warn / turn off new ember linting issues We will tackle them one by one and don't want to autofix issues that could be dangerous to auto-fix. * Auto-fix linting issues * More linting configuration * Fix remaining linting issues * Fix linting issues new files after rebase * ui: Remove ember-cli-uglify config now we are using terser (#14574) Co-authored-by: John Cowen <johncowen@users.noreply.github.com>	2 years ago
Michael Klein	3c492ad784	ui: fix - proper await page object step (#14510) ... * Fix await page-object properties properly * Remove "sleep"-hack show-routing test * Fix - change serviceInstacesSelected test order We need to change the order of test as the tab-nav tab-elements are actually clickable and will be triggered via the "see" step. Because we are now properly awaiting these promises we need to change the test order and check if the service-instances tab is selected first, as the following steps will actually click the respective tabs during testing and thus change what is selected on the tab-nav. * Update ember-cli-page-object to latest	2 years ago
Michael Klein	39c5b91272	ui: chore upgrade to ember-qunit v5 (#14430) ... * Refactor remaining `moduleFor`-tests `moduleFor*` will be removed from ember-qunit v5 * Upgrade ember-qunit to v5 * Update how we use ember-sinon-qunit With ember-qunit v5 we need to use ember-sinon-qunit differently. * Fix submit-blank test We can't click on disabled buttons with new test-helpers. We need to adapt the test accordingly. * Make sure we await fill-in with form yaml step We need to await `fill-in`. This changes the reducer function in the step to create a proper await chain. * Fix show-routing test We need to await a tick before visiting again. * Remove redundant `wait one tick`-step * remove unneeded "next Tick" promise from form step * Increase timeout show-routing feature * Comment on pause hack for show-routing test	2 years ago
Michael Klein	a6a79d6811	ui: add deprecation worfklow addon (#13877) ... * add ember-cli-deprecation-workflow * Add deprecation workflow configuration This will silence all deprecations by default reducing noise in the test output significantly. We can tackle deprecations now one by one but won't have to deal with very verbose console logs anymore.	2 years ago
John Cowen	f6edc37d0c	ui: Move peers to a subapplication (#13725)	2 years ago
John Cowen	27e50ae925	ui: Add peer searching and sorting (#13634) ... * ui: Add peer searching and sorting Initial name search and sort only, more to come here * Remove old peerings::search component * Use @model peers * ui: Peer listing with dc/ns/partition/name based unique IDs and polling deletion (#13648) * ui: Add peer repo with listing datasource * ui: Use data-loader component to use the data-source * ui: Remove ember-data REST things and Route.model hook * 10 second not 1 second poll * Fill out Datacenter and Partition * route > routeName * Faker randomised mocks for peering endpoint * ui: Adds initial peer detail page plus address tab (#13651)	2 years ago
Michael Klein	5de75550d3	ui: feature-flagged peering mvp (#13425) ... * add peers route * add peers to nav * use regular app ui patterns peers template * use empty state in peers UI * mock `v1/peerings` request * implement custom adapter/serializer for `peers`-model * index request for peerings on peers route * update peers list to show as proper list * Use tailwind for easier styling * Unique ids in peerings response mock-api * Add styling peerings list * Allow creating empty tooltip To make it easier to iterate over a set of items where some items should not display a tooltip and others should. * Add tooltip Peerings:Badge * Add undefined peering state badge * Remove imported/exported services count peering This won't be included in the initial version of the API response * Implement Peerings::Search * Make it possible to filter peerings by name * Install ember-keyboard For idiomatic handling of key-presses. * Clear peering search input when pressing `Escape` * use peers.index instead of peers for peerings listing * Allow to include peered services in services-query * update services mock to add peerName * add Consul::Peer component To surface peering information on a resource * add PeerName as attribute to service model * surface peering information in service list * Add tooltip to Consul::Peer * Make services searchable by peer-name * Allow passing optional query-params to href-to * Add peer query-param to dc.services.show * Pass peer as query-param services listing * support option peer route-param * set peer-name undefined in services serializer when empty * update peer route-param when navigating to peered service * request sercice with peer-name if need be * make sure to reset peer route-param when leaving service.show * componentize services.peer-info * surface peer info services.show * make sure to reset peer route-param in main nav * fix services breadcrumb services.intentions we need to reset peer route-param here to not break the app * surface peer when querying for it on service api call * query for peer info service-instance api calls * surface peer info service-instance.show * Camelize peer attributes to match rest of app * Refactor peers.index to reflect camelized attributes for peer * Remove unused query-params services.show * make logo href reset peer route-param * Cleanup optional peer param query service-instance * Use replace decorator instead of serializer for empty peerName * make sure to only send peer info when correct qp is passed * Always send qp for querying peers services request * rename with-imports to with-peers * Use css for peer-icon * Refactor bucket-list component to surface peer-info * Remove Consul::Peer component This info is now displayed via the bucket-list component * Fix bucket-list component to surface service again * Update bucket-list docs to reflect peer-info addition * Remove tailwind related styles * Remove consul-tailwind package We won't be using tailwind for now * Fix typo badge scss * Add with-import handling mock-api nodes * Add peerName to node attributes * include peers when querying nodes * reflect api updates node list mock * Create consul::node::peer-info component * Surface peer-info in nodes list * Mock peer response for node request * Make it possible to add peer-name to node request * Update peer route-param when linking to node * Reset peers route-param when leaving nodes.show We need to reset the route-param to not introduce a bug - otherwise subsequent node show request would request with the old peer query-param * Add sourcePeer intentions api mock * add SourcePeer attr to intentions model * Surface peering info on intentions list * Request peered intentions differently intentions.edit * Handle peer info in intentions/exact mock * Surface peering info intention view * Add randomized peer data topology mock * Surface peer info topology view * fix service/peer-info styling We aren't using tailwind anymore - we need to create a custom scss file * Update peerings api mocks * Update peerings::badge with updated styling * cleanup intentions/exact mock * Create watcher component to declaratively register polling * Poll peers in background when on peers route * use existing colors for peering-badge * Add test for requesting service with `with-peers`-query * add imported/exported count to peers model * update mock-api to surface exported/imported count on peers * Show exported/imported peers count on peers list * Use translations for service import/export UI peers * Make sure to ask for nodes with peers * Add match-url step for easier url testing of service urls * Add test for peer-name on peered services * Add test for service navigation peered service * Implement feature-flag handling * Enable peering feature in test and development * Redirect peers to services.index when feature-flag is disabled * Only query for peers when feature is enabled * Only show peers in nav when feature is enabled * Componentize peering service count detail * Handle non-state Peerings::Badge * Use Peerings::ServiceCount in peerings list * Only send peer query for peered service-instances. * Add step to visit url directly * add test for accessing peered service directly * Remove unused service import peers.index * Only query for peer when peer provided node-adapter * fix tests	2 years ago
John Cowen	147476c10d	ui: Disable licensing tab if the UI is running via HCP (#12771) ... Co-authored-by: Evan Rowe <ev.rowe@gmail.com>	3 years ago
Michael Klein	4d36e2b08e	ui: upgrade ember composable helper (#13394) ... Upgrade ember-composable-helpers to version 5.x. This version contains the pick-helper which makes composition in the template layer easier with Octane. {{!-- this is usually hard to do with Octane --}} <input {{on "input" (pick "target.value" this.updateText)}} .../> Version 5.x also fixes a regression with sort-by that according to @johncowen was the reason why the version was pinned to 4.0.0 at the moment. Version 5 of ember-composable-helpers removes the contains-helper in favor of includes which I changed all occurences for.	3 years ago
John Cowen	9b87e6b61c	ui: Adds support for AWS-IAM Auth Methods (#12786) ... * ui: Adds support for AWS-IAM Auth Methods * Changelog	3 years ago
John Cowen	4b8cabce0d	ui: Overview UI Routing (#12493) ... This PR adds routes and an initial landing page for the Cluster Overview page	3 years ago
John Cowen	ee0e8bf500	ui: App-ify Lock Sessions (#12482) ... This commit moves our in-app LockSessions code into an external 'app', which can theoretically be side-loaded but for now it just makes for good isolation/code hygiene. Functionally, there is kind of one change here, and that is we only show the 'Lock Session' tab if you have permissions to see them. Currently as our UI authorization endpoint needs to be changed slightly to suit our usecase, you will always have permissions to see Lock Sessions as we hardcode the session:read to true (obvs this is a frontend thing, not a backend thing), so it doesn't really change anything from a user perspective. Also added very bare docs while I was here. Small note here, ideally we need to add the each individual tab depending on whether an 'app' is enabled or not instead of just permissions, ideally it would be done totally from The Outside rather than a can based conditional on the inside, just something else to be thinking about for the future.	3 years ago
John Cowen	2168a44413	ui: Add CustomElement Transform (#12540) ... This PR adds an Ember-Glimmer/Handlebars transform to drop the documentation copy from the CustomElement component out of the build, therefore it is not bundled into the code either at development time or production build time.	3 years ago
John Cowen	9b22300c59	ui: Start using mermaid state diagrams in our docs (#12350)	3 years ago
John Cowen	417cb8d838	ui: attach-shadow modifier (#12207) ... * ui: attach-shadow modifier * ui: adopt-styles helper (#12208)	3 years ago
John Cowen	6d0a73c0eb	ui: Add selective no-console eslint rule (#11938)	3 years ago
John Cowen	26341f0b05	ui: Move nspace CRUD to use the same approach as partitions (#11633) ... This sounds a bit 'backwards' as the end goal here is to add an improved UX to partitions, not namespaces. The reason for doing it this way is that Namespaces already has a type of 'improved UX' CRUD in that it has one to many relationship in the form when saving your namespaces (the end goal for partitions). In moving Namespaces to use the same approach as partitions we: - Ensure the new approach works with one-to-many forms. - Test the new approach without writing a single test (we already have a bunch of tests for namespaces which are now testing the approach used by both namespaces and partitions) Additionally: - Fixes issue with missing default nspace in the nspace selector - In doing when checking to see that things where consistent between the two, I found a few little minor problems with the Admin Partition CRUD so fixed those up here also. - Removed the old style Nspace notifications	3 years ago
John Cowen	2b8273bc6e	ui: Support for SSO with Admin Partitions (#11604) ... * Upgrade AuthForm and document current state a little better * Hoist SSO out of the AuthForm * Bare minimum admin partitioned SSO also: ui: Tabbed Login with Token or SSO interface (#11619) - I upgraded our super old, almost the first ember component I wrote, to use glimmer/almost template only. This should use slots/contextual components somehow, but thats a bigger upgrade so I didn't go that far. - I've been wanting to upgrade the shape of our StateChart component for a very long while now, here its very apparent that it would be much better to do this sooner rather than later. I left it as is for now, but there will be a PR coming soon with a slight reshaping of this component. - Added a did-upsert modifier which is a mix of did-insert/did-update - Documentation added/amended for all the new things.	3 years ago
John Cowen	baa377ddca	ui: Adds initial CRUD for partitions (#11188) ... * Add `is` and `test` helpers in a similar vein to `can` Adds 2 new helpers in a similar vein to ember-cans can: - `is` allows you to use vocab/phrases such as (is "something model") which calls isSomething() on the models ability. - `test` allows you to use vocab/phrases such as (test "is something model") or (test "can something model")which calls isSomething() / canSomething() on the models ability. Mostly using the is helper and the can helper. It's basically the is/can helper combined. * Adds TextInput component + related modifiers/helpers/machines/services (#11189) Adds a few new components/modifiers/helpers to aid building forms. - state-chart helper, used in lieu of a more generic approach for requiring our statecharts. - A few modifications to our existing disabled modifier. - A new 'validation' modifier, a super small form validation approach built to make use of state charts (optionally). Eventually we should be able to replace our current validation approach (ember-changeset-validations + extra deps) with this. - A new TextInput component, which is the first of our new components specifically to make it easy to build forms with validations. This is still a WIP, I left some comments in pointing out where this one would be progressed, but as we don't need the planned functionality yet, I left it where it was. All of this will be fleshed out more at a later date. Documentation is included for all of ^ * ui: Adds initial CRUD for partitions (#11190) Adds basic CRUD support for partitions. Engineering-wise probably the biggest takeaway here is that we needed to write very little javascript code to add this entire feature, and the little javascript we did need to write was very straightforwards. Everything is pretty much just HTML. Another note to make is that both ember-changeset and ember-data (model layer things) are now completely abstracted away from the view layer of the application. New components: - Consul::Partition::Form - Consul::Partition::List - Consul::Partition::Notifications - Consul::Partition::SearchBar - Consul::Partition::Selector See additional documentation here for more details New Route templates: - index.hbs partition listing/searching/filtering - edit.hbs partition editing and creation Additionally: There is some additional debug work here for better observability and to prevent any errors regarding our href-to usage when a dc is not available in our documentation site. Our softDelete functionality has been DRYed out a little to be used across two repos. isLinkable was removed from our ListCollection component for lists like upstream and service listing, and instead use our new is helper from within the ListCollection, meaning we've added a few more lighterweight templateOnly components. * ui: Exclude all debug-like files from the build (#11211) This PR adds **/*-debug.* to our test/prod excluded files (realised I needed to add test-support.js also so added that here as its more or less the same thing). Conditionally juggling ES6 static imports (specifically debug ones) for this was also getting a little hairy, so I moved it all to use the same approach as our conditional routes. All in all it brings the vendor build back down to ~430kb gzipped.	3 years ago
John Cowen	e088d8674c	ui: Remove legacy ACLs (#11096)	3 years ago
John Cowen	74070c0955	ui: Add intl debug helpers (#10513) ... This commit adds a couple of debug utilities to help us to continue slowly adding i18n support: - We've added a CONSUL_INTL_DEBUG env/cookie variable to turn off variable interpolation within the t helper so you can see which variables are being interpolated. - We've added a CONSUL_INTL_LOCALE env/cookie which currently supports two 'pseudo-locales' - la-fk (fake latin) and - (just dashes) either of which will make it easier to see what has not been localized until we can add prettier rules to prevent adding any copy into templates at all. I would guess if we ever translated the app we would use this for looking at things whilst developing also - but as yet I've not adding anything for that here seeing as we don't translate anything. Both variables are dev-time only and all code for this is removed from the production build.	3 years ago
John Cowen	ddee7afbb9	ui: Fixup prettier for scss files and run (#10296) ... * ui: Ensure prettier makes all our scss files pretty * Run prettier on all our scss files	4 years ago
John Cowen	2e4c9f5330	ui: Support Route optional parameters/segments (#10212) ... Moves our URLs with 'optional namespace segment' into a separately abstracted 'optional URL segment' feature	4 years ago
John Cowen	8301e79c56	ui: Bump node to v14 (#10238)	4 years ago
John Cowen	d1bbe0895f	ui: Use babel plugin to strip calls to runInDebug (#10237)	4 years ago
John Cowen	345765f766	ui: Adds human formatting to nanosecond based session durations (#10062) ... * ui: Adds human formatting to nanosecond based session durations	4 years ago
Kenia	a0d12ff164	ui: Reformat MaxTokenTTL to sortBy as an integer (#9969) ... * Install Duration JS * Use Duration.js to sortBy reformatted MaxTokenTTL * Remove @icholy/duration package * Install parse-duration package * Use parse-duration in auth-method model	4 years ago
John Cowen	0863806769	ui: Dependency Upgrade (#9907) ... * Pin ember-changeset-validations and its dependencies to 3.9 Future versions produce a 'validator is not a function' error * yarn upgrade * Upgrade the majority of user facing deps that don't required add. change not upgraded here due to more changes required: - ember-page-title - ember-href-to * Upgrade ember-page-title which no longer requires ember-cli-head * Upgrade some devtools related dependencies * Upgrade some non ember-core test utils * Upgrade js-yaml which required safeLoad > load * Upgrade some compilation utils * Yarn install from workspace root * Add Python-2.0 to compliance checker	4 years ago
John Cowen	9e715842d9	ui: Improves UI engineering docs (#9875) ... Also fixes some typos in with-overlay	4 years ago
John Cowen	33d0383779	ui: a11y modals (#9819) ... This PR uses the excellent a11y-dialog to implement our modal functionality across the UI. This package covers all our a11y needs - overlay click and ESC to close, controlling aria-* attributes, focus trap and restore. It's also very small (1.6kb) and has good DOM and JS APIs and also seems to be widely used and well tested. There is one downside to using this, and that is: We made use of a very handy characteristic of the relationship between HTML labels and inputs in order to implement our modals previously. Adding a for="id" attribute to a label meant you can control an <input id="id" /> from anywhere else in the page without having to pass javascript objects around. It's just based on using the same string for the for attribute and the id attribute. This allowed us to easily open our login dialog with CSS from anywhere within the UI without having to manage passing around a javascript object/function/method in order to open the dialog. We've PRed #9813 which includes an approach which would make passing around JS modal object easier to do. But in the meantime we've added a little 'hack' here using an additional <input /> element and a change listener which allows us to keep this label/input characteristic of our old modals. I'd originally thought this would be a temporary amend in order to wait on #9813 but the more I think about it, the more I think its quite a nice thing to keep - so longer term we may/may not keep this.	4 years ago