47 Commits (1093212176206eee064b2ecc3fe68fcf03d384e8)

Author	SHA1	Message	Date
John Cowen	2838f7a2e9	ui: Reduce discovery-chain log errors (#8065) ... * ui: Reduce discovery-chain log spam Currently the only way that the UI can know whether connect is enabled or not is whether we get 500 errors from certain endpoints. One of these endpoints we already use, so aswell as recovering from a 500 error, we also remember that connect is disabled for the rest of the page 'session' (so until the page is refreshed), and make no further http requests to the endpoint for that specific datacenter. This means that log spam is reduced to only 1 log per page refresh/dc instead of 1 log per service navigation. Longer term we'll need some way to dynamically discover whether connect is enabled per datacenter without relying on something that will add error logs to consul.	5 years ago
John Cowen	b608ceb815	ui: Test Improvements (#7854) ... * ui: Combine all "see/don't see" steps into one step * Fix up broken tests * Add some test meta data/titles * Test out proxies in the service listing * Remove comments	5 years ago
John Cowen	4bf1daef0a	ui: Logout button (#7604) ... * ui: Logout button This commit adds an easier way to logout of the UI using a logout button Notes: - Added a Logout button to the main navigation when you are logged in, meaning you have easy access to a way to log out of the UI. - Changed all wording to use 'Log in/out' vocabulary instad of 'stop using'. - The logout button opens a panel to show you your current ACL token and a logout button in order to logout. - When using legacy ACLs we don't show the current ACL token as legacy ACLs tokens only have secret values, whereas the new ACLs use a non-secret ID plus a secret ID (that we don't show). - We also added a new `<EmptyState />` component to use for all our empty states. We currently only use this for the ACLs disabled screen to provide more outgoing links to more readind material/documentation to help you to understand and enable ACLs. - The `<DataSink />` component is the sibling to our `<DataSource />` component and whilst is much simpler (as it doesn't require polling support), its tries to use the same code patterns for consistencies sake. - We had a fun problem with ember-data's `store.unloadAll` here, and in the end went with `store.init` to empty the ember-data store instead due to timing issues. - We've tried to use already existing patterns in the Consul UI here such as our preexisting `feedback` service, although these are likely to change in the future. The thinking here is to add this feature with as little change as possible. Overall this is a precursor to a much larger piece of work centered on auth in the UI. We figured this was a feature complete piece of work as it is and thought it was worthwhile to PR as a feature on its own, which also means the larger piece of work will be a smaller scoped PR also.	5 years ago
John Cowen	2413244b77	ui: Add DataSource component (#7448) ... * ui: Add data-source component and related services (#6486) * ui: Add data-source component and related services: 1. DataSource component 2. Repository manager for retrieving repositories based on URIs 3. Blocking data service for injection to the data-source component to support blocking query types of data sources 4. 'Once' promise based data service for injection for potential fallback to old style promise based data (would need to be injected via an initial runtime variable) 5. Several utility functions taken from elsewhere - maybeCall - a replication of code from elsewhere for condition calling a function based on the result of a promise - restartWhenAvailable - used for restarting blocking queries when a tab is brought to the front - ifNotBlocking - to check if blocking is NOT enabled * Move to a different organization based on protocols * Don't call open twice when eager * Workaround new ember error for reading and writing at the same time * Add first draft of a README.mdx file	5 years ago
John Cowen	327aac9fe9	ui: Acceptance test improvements to prepare for more NS tests (#6980) ... * ui: Acceptance test improvements to prepare for more NS tests * ui: Namespace acceptance testing (#7005) * Update api-double and consul-api-double for http.body * Adds places where we missed passing the nspace through * Hardcode nspace CRUD to use the default nspace for policies and roles * Alter test helpers to allow us to control nspaces from the outside * Amends to allow tests to account for namespace, move ns from queryParam 1. We decided to move how we pass the namespace value through to the backend when performing write actions (create, update). Previoulsy we were using the queryParam although using the post body is the preferred method to send the Namespace details through to the backend. 2. Other various amends to take into account testing across multiple namespaced scenarios * Enable nspace testing by default * Remove last few occurances of old style http assertions We had informally 'deprecated' our old style of http assertions that relied on the order of http calls (even though that order was not important for the assertion). Following on from our namespace work we removed the majority of the old occrances of these old style assertions. This commit removes the remaining few, and also then cleans up the assertions/http.js file to only include the ones we are using. This reduces our available step count further and prevents any confusion over the usage of the old types and the new types. * ui: Namespace CRUD acceptance tests (#7016) * Upgrade consul-api-double * Add all the things required for testing: 1. edit and index page objects 2. enable CONSUL_NSPACE_COUNT cookie setting 3. enable mutating HTTP response bodies based on URL * Add acceptance test for nspace edit/delete/list and searching	5 years ago
John Cowen	7044aa52c8	ui: Namespace Support (#6639) ... Adds namespace support to the UI: 1. Namespace CRUD/management 2. Show Namespace in relevant areas (intentions, upstreams) 3. Main navigation bar improvements 4. Logic/integration to interact with a new `internal/acl/authorize` endpoint	5 years ago
John Cowen	a44541a91f	ui: Implements a testable clipboard {{copy-button}} (#5967) ... 1. Remove ember-cli-clipboard dependency 2. Provide a new copy-button component implementing the same interface as ^ but make the clipboard functionality injectable 3. Provide 2 implementations of a Clipboard. One using clipboard.js (as previously) and an additional local storage 'clipboard'. 4. add a BDD step to assert whats in the clipboard (the fake one) Main reason here is that `document.exec` must be called by a user interaction	6 years ago
John Cowen	9013e53ebc	ui: Ensures nested policy forms are reset properly (#5838) ... 1. All {{ivy-codemirror}} components need 'refreshing' when they become visible via our own `didAppear` method on the `{{code-editor}}` component (also see:) - https://github.com/hashicorp/consul/pull/4190#discussion_r193270223 - 73db111db8 (r225264296) 2. On initial investigation, it looks like the component we are using for the code editor doesn't distinguish between setting its `value` programatically and a `keyup` event, i.e. an interaction from the user. We currently pretend that whenever its `value` changes, it is a `keyup` event. This means that when we reset the `value` to `""` programmatically for form resetting purposes, a 'pretend keyup' event would also be fired, which would in turn kick off the validation, which would fail and show an error message for empty values in other fields of the form - something that is perfectly valid if you haven't typed anything yet. We solved this by checking for `isPristine` on fields that are allowed to be empty before you have typed anything.	6 years ago
John Cowen	482426b13e	UI: ACL Roles (#5635) ... Adds support for ACL Roles and Service Identities CRUD, along with necessary changes to Tokens, and the CSS improvements required. Also includes refinements/improvements for easier testing of deeply nested components. 1. ember-data adapter/serializer/model triplet for Roles 2. repository, form/validations and searching filter for Roles 3. Moves potentially, repeated, or soon to to repeated functionality into a mixin (mainly for 'many policy' relationships) 4. A few styling tweaks for little edge cases around roles 5. Router additions, Route, Controller and templates for Roles Also see: * UI: ACL Roles cont. plus Service Identities (#5661 and #5720)	6 years ago
John Cowen	a14a37a078	UI: Add support for blocking queries on the service instance detail page (#5487) ... This commit includes several pieces of functionality to enable services to be removed and the page to present information that this has happened but also keep the deleted information on the page. Along with the more usual blocking query based listing. To enable this: 1. Implements `meta` on the model (only available on collections in ember) 2. Adds new `catchable` ComputedProperty alongside a `listen` helper for working with specific errors that can be thrown from EventSources in an ember-like way. Briefly, normal computed properties update when a property changes, EventSources can additionally throw errors so we can catch them and show different visuals based on that. Also: Add support for blocking queries on the service instance detail page 1. Previous we could return undefined when a service instance has no proxy, but this means we have nothing to attach `meta` to. We've changed this to return an almost empty object, so with only a meta property. At first glance there doesn't seem to be any way to provide a proxy object to templates and be able to detect whether it is actually null or not so we instead change some conditional logic in the templates to detect the property we are using to generate the anchor. 2. Made a `pauseUntil` test helper function for steps where we wait for things. This helps for DRYness but also means if we can move away from setInterval to something else later, we can do it in one place 3. Whilst running into point 1 here, we managed to make the blocking queries eternally loop. Whilst this is due to an error in the code and shouldn't ever happen whilst in actual use, we've added an extra check so that we only recur/loop the blocking query if the previous response has a `meta.cursor` Adds support for blocking queries on the node detail page (#5489) 1. Moves data re-shaping for the templates variables into a repository so they are easily covered by blocking queries (into coordinatesRepo) 2. The node API returns a 404 as signal for deregistration, we also close the sessions and coordinates blocking queries when this happens	6 years ago
John Cowen	cfa4bc264e	UI: Add ember steps:list command for listing available steps (#5255) ... * ui: Add ember steps:list command for listing available steps 1. Adds `command` addon to house the new command 2. Start to organize out the steps themselves, bring a bit more order to things ready to dedupe and cleanup	6 years ago
John Cowen	cb0c5309c9	UI: Add EventSource ready for implementing blocking queries (#5070) ... - Maintain http headers as JSON-API meta for all API requests (#4946) - Add EventSource ready for implementing blocking queries - EventSource project implementation to enable blocking queries for service and node listings (#5267) - Add setting to enable/disable blocking queries (#5352)	6 years ago
John Cowen	c6db97b666	UI: Removes success notification on faking a success response for `self` (#4906) ... In order to continue supporting the legacy ACL system, we replace the 500 error from a non-existent `self` endpoint with a response of a `null` `AccessorID` - which makes sense (a null AccessorID means old API) We then redirect the user to the old ACL pages which then gives a 403 if their token was wrong which then redirects them back to the login page. Due to the multiple redirects and not wanting to test the validity of the token before redirecting (thus calling the same API endpoint twice), it is not straightforwards to turn the 'faked' response from the `self` endpoint into an error (flash messages are 'lost' through multiple redirects). In order to make this a slightly better experience, you can now return a `false` during execution of an action requiring success/failure feedback, this essentially skips the notification, so if the action is 'successful' but you don't want to show the notification, you can. This resolves showing a successful notification when the `self` endpoint response is faked. The last part of the puzzle is to make sure that the global 403 catching error in the application Route also produces an erroneous notification. Please note this can only happen with a ui client using the new ACL system when communicating with a cluster using the old ACL system, and only when you enter the wrong token. Lastly, further acceptance tests have been added around this This commit also adds functionality to avoid any possible double notification messages, to avoid UI overlapping	6 years ago
John Cowen	f65f001675	UI: Catch 500 error on token endpoint and revert to legacy tokens (#4874) ... In some circumstances a consul 1.4 client could be running in an un-upgraded 1.3 or lower cluster. Currently this gives a 500 error on the new ACL token endpoint. Here we catch this specific 500 error/message and set the users AccessorID to null. Elsewhere in the frontend we use this fact (AccessorID being null) to decide whether to present the legacy or the new ACL UI to the user. Also: - Re-adds in most of the old style ACL acceptance tests, now that we are keeping the old style UI - Restricts code editors to HCL only mode for all `Rules` editing (legacy/'half legacy'/new style) - Adds a [Stop using] button to the old style ACL rows so its possible to logout. - Updates copy and documentation links for the upgrade notices	6 years ago
John Cowen	7d89e519a2	UI: New ACLs (#4789) ... UI to accompany the new ACLs APIs	6 years ago
John Cowen	5ea748005c	UI: External Source markers (#4640) ... 1. Addition of external source icons for services marked as such. 2. New %with-tooltip css component (wip) 3. New 'no healthcheck' icon as external sources might not have healthchecks, also minus icon on node cards in the service detail view 4. If a service doesn't have healthchecks, we use the [Services] tabs as the default instead of the [Health Checks] tab in the Service detail page. 5. `css-var` helper. The idea here is that it will eventually be replaced with pure css custom properties instead of having to use JS. It would be nice to be able to build the css variables into the JS at build time (you'd probably still want to specify in config which variables you wanted available in JS), but that's possible future work. Lastly there is probably a tiny bit more testing edits here than usual, I noticed that there was an area where the dynamic mocking wasn't happening, it was just using the mocks from consul-api-double, the mocks I was 'dynamically' setting happened to be the same as the ones in consul-api-double. I've fixed this here also but it wasn't effecting anything until actually made certain values dynamic.	6 years ago
John Cowen	40e71f1b91	UI: Simplify/refactor the actions/notification layer (#4572) + (#4573) ... * Move notification texts to a slightly different layer (#4572) * Further Simplify/refactor the actions/notification layer (#4573) 1. Move the 'with-feedback' actions to a 'with-blocking-action' mixin which better describes what it does 2. Additional set of unit tests almost over the entire layer to prove things work/add confidence for further changes The multiple 'with-action' mixins used for every 'index/edit' combo are now reduced down to only contain the functionality related to their specific routes, i.e. where to redirect. The actual functionality to block and carry out the action and then notify are 'almost' split out so that their respective classes/objects do one thing and one thing 'well'. Mixins are chosen for the moment as the decoration approach used by mixins feels better than multiple levels of inheritence, but I would like to take this fuether in the future to a 'compositional' based approach. There is still possible further work to be done here, but I'm a lot happier now this is reduced down into separate parts.	6 years ago
John Cowen	12811c0844	UI - Refactor Adapter.handleResponse (#4398) ... * Add some tests to check the correct GET API endpoints are called * Refactor adapters 1. Add integration tests for `urlFor...` and majority `handleResponse` methods 2. Refactor out `handleResponse` a little more into single/batch/boolean methods 3. Move setting of the `Datacenter` property into the `handleResponse` method, basically the same place that the uid is being set using the dc parsed form the URL 4. Add some Errors for if you don't pass ids to certain `urlFor` methods	6 years ago
John Cowen	faf813fee2	Add tests that break when you request a folder without a trailing slash	6 years ago
John Cowen	25477761f7	Merge pull request #4343 from hashicorp/bugfix/gh-4336-update-empty-kv ... UI - Bugfix: Saving empty key/value pairs	6 years ago
John Cowen	a5fa27d718	Fix a couple of typos in the comments	6 years ago
John Cowen	67402b3d26	Tests and comments regarding the previous 2 commits	6 years ago
John Cowen	e0f7cdb128	Start purifying page objects	6 years ago
John Cowen	e3ce2a8beb	Lock Session invalidation acceptance test	6 years ago
John Cowen	ed286585e9	Add some low hanging intention tests, basically add intentions to others ... 1. There are various things tests that can just have intentions added into them, like filters and such like, add intentions to these 2. Start thinking about being able to negate steps easily, which will lead on to a cleanup of the steps	6 years ago
John Cowen	b445df39bb	Use html5 oninput instead of onkeyup for native textual inputs ... This enables people to enter things using the mouse to paste for example, plus possible other things. As an aside it also answers my query regarding `fillIn` for testing, nothing needs to be actually _typed_ anymore! Doh	6 years ago
mkeeler	6813a99081	Merge remote-tracking branch 'connect/f-connect'	7 years ago
John Cowen	d61a09ea28	Fix linting typo, caused the selection of future services to break	7 years ago
John Cowen	61e3fa3244	Make sure the dc menu is as useful as possible when things go wrong ... 1. Check the dc's model for both dcs list and the requested dc. 2. If the dc model doesn't exist use and empty array for dcs and a fake dc with the Name 'Error' as we can't even trust what is in the `paramsFor`	7 years ago
John Cowen	fd60f225ec	Merge branch 'master' into feature/ui-node-ports-for-service	7 years ago
John Cowen	b41d19c3c0	Merge pull request #4251 from hashicorp/bugfix/ui-null-tokens ... Ensure a blank/empty token is sent if the localStorage kv doesn't exist	7 years ago
John Cowen	1881ec4824	Add a failing test to show that lock session TTL's are not shown	7 years ago
John Cowen	0f6214d0ce	Make sure token is set to blank if nothing is typed in settings	7 years ago
John Cowen	484f6ccaf2	Add port the service is running on for each node in the service view	7 years ago
John Cowen	8c5416ecaf	Ensure a blank token is sent if the localStorage kv doesn't exist	7 years ago
John Cowen	894667b87a	Merge pull request #4247 from hashicorp/feature/acl-sort-by-name ... UI - Sort ACL tokens by name	7 years ago
John Cowen	4d7f15ce34	Merge branch 'master' into bugfix/gh-4203-multi-tags	7 years ago
John Cowen	6949b22d5f	Sort ACL tokens by name	7 years ago
John Cowen	04435dbdaf	Ensure all tags for a service are listed on the service detail page	7 years ago
John Cowen	bf4bcdd670	Find a way to test pre-ember load ... 1. Also add index.html things to test/index.html 2. Use content-for to hedge against keeping content in sync (requires an addon) 3. Test passes but only when run on its own, as we need to rely on content in the QUnit runner, theoretically it is not running our test in isolation. Skipping the test for the moment so we don't have a filaing test when all run together	7 years ago
John Cowen	62a4c1098e	Add test for not showing the delete button for the first acl... ... Also, change the action group page objects to use data-test attributes instead of last-child which isn't reliable (and stay consistent)	7 years ago
John Cowen	e37136ecae	Prevent being able to submit a create form with empty values	7 years ago
John Cowen	59ce55227c	Explicitly sort by Key after folder/file	7 years ago
John Cowen	d4328ffa09	Remove buts	7 years ago
John Cowen	5e5fffe300	Add some delete testing to KV and ACL	7 years ago
John Cowen	c2bd21d8d9	Move testing bits to hashicorp org, also.. ... Go with `rsync` over `cp` for putting the api double into public for the moment	7 years ago
John Cowen	17ebf96755	WIP: Feature/acceptance tests	7 years ago