consul

Commit Graph

Author	SHA1	Message	Date
John Cowen	8306b2f251	ui: Replaces destroyRecord with unloadRecord for KV 404's (#5837 ) Just because Consul gives us a 404 this doesn't guarantee the KV doesn't exist, it doesn't even mean we don't have access to it. Furthermore we should never destroyRecord's without user interaction (therefore only via the repo.delete method). This switches destroyRecord to unloadRecord which performs the additional legwork to keep ember-data in sync with the actual truth. unloadRecord unloads the record from ember-data rather than sending an API delete request, which would have been the intent here.	2019-06-04 15:56:20 +01:00
John Cowen	bf50beff42	ui: Prefer `cursor` over `index`, add `configuration` option to repos (#5042 )	2019-05-01 18:21:54 +00:00
John Cowen	14aa90e309	ui: Move repo services to repository/ folder and standardize naming (#4694 ) Repositories are a class of services to help with CRUD actions, most of the functionality is reused across various Models. This creates a new repository service that centralizes all this reused functionality. Inheritance via ember `Service.extend` is used as opposed to decorating via Mixins. 1. Move all repository services (and their tests) to a services/repository folder 2. Standardize on a singular name format 'node vs nodes' 3. Create a new 'repository' service to centralize functionality. This should be extended by 'repository' services	2018-10-26 17:36:15 +01:00

Author

SHA1

Message

Date

John Cowen

8306b2f251

ui: Replaces destroyRecord with unloadRecord for KV 404's (#5837 )

Just because Consul gives us a 404 this doesn't guarantee the KV doesn't
exist, it doesn't even mean we don't have access to it. Furthermore we
should never destroyRecord's without user interaction (therefore only via the
repo.delete method).

This switches destroyRecord to unloadRecord which performs the
additional legwork to keep ember-data in sync with the actual truth.

unloadRecord unloads the record from ember-data rather than sending an API
delete request, which would have been the intent here.

2019-06-04 15:56:20 +01:00

John Cowen

bf50beff42

ui: Prefer `cursor` over `index`, add `configuration` option to repos (#5042 )

2019-05-01 18:21:54 +00:00

John Cowen

14aa90e309

ui: Move repo services to repository/ folder and standardize naming (#4694 )

Repositories are a class of services to help with CRUD actions, most of
the functionality is reused across various Models. This creates a new
repository service that centralizes all this reused functionality.
Inheritance via ember `Service.extend` is used as opposed to
decorating via Mixins.

1. Move all repository services (and their tests) to a
services/repository folder
2. Standardize on a singular name format 'node vs nodes'
3. Create a new 'repository' service to centralize functionality. This
should be extended by 'repository' services

2018-10-26 17:36:15 +01:00

3 Commits (0dfae99a1b1000507fc4ecf0f7898433da9aecc7)