12 Commits (add-patches)

Author	SHA1	Message	Date
Giulio Micheloni	4b0eaa4bff	grpc, xds: recovery middleware to return and log error in case of panic ... 1) xds and grpc servers: 1.1) to use recovery middleware with callback that prints stack trace to log 1.2) callback turn the panic into a core.Internal error 2) added unit test for grpc server	3 years ago
Daniel Nephin	1a137c29d6	grpc: fix grpc metrics ... defaultMetrics was being set at package import time, which meant that it received an instance of the original default. But lib/telemetry.InitTelemetry sets a new global when it is called. This resulted in the metrics being sent nowhere. This commit changes defaultMetrics to be a function, so it will return the global instance when called. Since it is called after InitTelemetry it will return the correct metrics instance.	4 years ago
Daniel Nephin	f0ac093fef	agent/grpc: add connection count metrics ... Gauge metrics are great for understanding the current state, but can somtimes hide problems if there are many disconnect/reconnects. This commit adds counter metrics for connections and streams to make it easier to see the count of newly created connections and streams.	4 years ago
Daniel Nephin	5319ba02b0	agent/grpc: rename metrics ... These new names should make it easier to add counter metics with similar prefixes	4 years ago
Daniel Nephin	8a785a351c	agent/grpc: pass metrics to constructor ... Instead of referencing a package var. This does not fix the flaky test, but it seems more correct.	4 years ago
Daniel Nephin	d19657404f	agent/grpc: fix a flaky test by performing more retries ... Instead of using retry.Run, which appears to have problems in some cases where it does not emit an error message, use a for loop. Increase the number of attempts and remove any sleep, since this operation is not that expensive to do in a tight loop	4 years ago
Daniel Nephin	df405ac978	agent/grpc: remove misleading warnings from test output ... Handle shutdown properly in tests so that the tests don't warn about using a closed connection.	4 years ago
Daniel Nephin	e101aa8a74	agent/grpc: fix a flake in TestHandler_EmitsStats	4 years ago
Daniel Nephin	af8a617797	grpc: fix data rate in stats handler test	4 years ago
Daniel Nephin	d0256a0c07	subscribe: add a stateless subscribe service for the gRPC server ... With a Backend that provides access to the necessary dependencies.	4 years ago
Daniel Nephin	636f76f6f1	agent/grpc: make TestHandler_EmitsStats predictable ... Occasionally this test would flake. The flakes were fixed by: 1. Stopping the service and retrying to check on metrics. This way we also include the active_streams going to 0 in the metric calls. 2. Using a reference to the global Metrics. This way when other tests have background goroutines that are still shutting down, they won't emit metrics to the metric instance with the fake Sink. The stats test can patch the local reference to the global, so the existing statHandlers will continue to emit to the global, but the stats test will send all metrics to the replacement.	4 years ago
Daniel Nephin	fd42804063	grpc: Add a simple test service for testing the gRPC server	4 years ago