diff --git a/ui-v2/app/components/consul-service-instance-list/index.hbs b/ui-v2/app/components/consul-service-instance-list/index.hbs index 92270519c4..20f297a2bb 100644 --- a/ui-v2/app/components/consul-service-instance-list/index.hbs +++ b/ui-v2/app/components/consul-service-instance-list/index.hbs @@ -12,23 +12,17 @@ {{#let (reject-by 'ServiceID' '' item.Checks) as |checks|}} {{#let (service/instance-checks checks) as |serviceCheck| }} - {{#if (eq serviceCheck.status 'empty') }} -
  • + {{#if (eq serviceCheck.check 'empty') }} +
  • No service checks
  • {{else}} {{#if (eq serviceCheck.count checks.length)}} - {{#if (eq serviceCheck.status 'warning') }} -
  • - All service checks with {{serviceCheck.status}} -
  • - {{else}} -
  • +
  • All service checks {{serviceCheck.status}}
  • - {{/if}} {{else}} -
  • +
  • {{serviceCheck.count}}/{{checks.length}} service checks {{serviceCheck.status}}
  • {{/if}} @@ -37,23 +31,17 @@ {{/let}} {{#let (filter-by 'ServiceID' '' item.Checks) as |checks|}} {{#let (service/instance-checks checks) as |nodeCheck| }} - {{#if (eq nodeCheck.status 'empty') }} -
  • + {{#if (eq nodeCheck.check 'empty') }} +
  • No node checks
  • {{else}} {{#if (eq nodeCheck.count checks.length)}} - {{#if (eq nodeCheck.status 'warning') }} -
  • - All node checks with {{nodeCheck.status}} -
  • - {{else}} -
  • - All node checks {{nodeCheck.status}} -
  • - {{/if}} +
  • + All node checks {{nodeCheck.status}} +
  • {{else}} -
  • +
  • {{nodeCheck.count}}/{{checks.length}} node checks {{nodeCheck.status}}
  • {{/if}} diff --git a/ui-v2/app/helpers/service/instance-checks.js b/ui-v2/app/helpers/service/instance-checks.js index 3935b9d569..319e82bf17 100644 --- a/ui-v2/app/helpers/service/instance-checks.js +++ b/ui-v2/app/helpers/service/instance-checks.js @@ -24,22 +24,25 @@ export function healthChecks([items], hash) { switch (true) { case ChecksCritical !== 0: return { + check: 'critical', status: 'failing', count: ChecksCritical, }; case ChecksWarning !== 0: return { - status: 'warning', + check: 'warning', + status: 'with warning', count: ChecksWarning, }; case ChecksPassing !== 0: return { + check: 'passing', status: 'passing', count: ChecksPassing, }; default: return { - status: 'empty', + check: 'empty', }; } } diff --git a/ui-v2/app/styles/components/composite-row/skin.scss b/ui-v2/app/styles/components/composite-row/skin.scss index 5772c1088a..32e2bde835 100644 --- a/ui-v2/app/styles/components/composite-row/skin.scss +++ b/ui-v2/app/styles/components/composite-row/skin.scss @@ -27,8 +27,7 @@ @extend %with-alert-triangle-color-mask, %as-pseudo; background-color: $orange-500; } -%composite-row .critical::before, -%composite-row .failing::before { +%composite-row .critical::before { @extend %with-cancel-square-fill-color-mask, %as-pseudo; background-color: $red-500; }