github
/
consul
mirror of https://github.com/hashicorp/consul
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

remove obsolete comments about test parallelization

pull/7932/head
Chris Piraino 2020-06-23 13:48:30 -04:00
parent b3db907bdf
commit f213d3592a
1 changed files with 4 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
agent/structs/config_entry_gateways_test.go
View File

@ -77,10 +77,7 @@ func TestIngressConfigEntry_Normalize(t *testing.T) {
}, },
} }
for _, test := range cases { for _, tc := range cases {
// We explicitly copy the variable for the range statement so that can run
// tests in parallel.
tc := test
t.Run(tc.name, func(t *testing.T) { t.Run(tc.name, func(t *testing.T) {
err := tc.entry.Normalize() err := tc.entry.Normalize()
require.NoError(t, err) require.NoError(t, err)
@ -436,10 +433,7 @@ func TestIngressConfigEntry_Validate(t *testing.T) {
}, },
} }
for _, test := range cases { for _, tc := range cases {
// We explicitly copy the variable for the range statement so that can run
// tests in parallel.
tc := test
t.Run(tc.name, func(t *testing.T) { t.Run(tc.name, func(t *testing.T) {
err := tc.entry.Validate() err := tc.entry.Validate()
if tc.expectErr != "" { if tc.expectErr != "" {
@ -546,10 +540,7 @@ func TestTerminatingConfigEntry_Validate(t *testing.T) {
}, },
} }
for _, test := range cases { for _, tc := range cases {
// We explicitly copy the variable for the range statement so that can run
// tests in parallel.
tc := test
t.Run(tc.name, func(t *testing.T) { t.Run(tc.name, func(t *testing.T) {
err := tc.entry.Validate() err := tc.entry.Validate()
@ -610,10 +601,7 @@ func TestGatewayService_Addresses(t *testing.T) {
}, },
} }
for _, test := range cases { for _, tc := range cases {
// We explicitly copy the variable for the range statement so that can run
// tests in parallel.
tc := test
t.Run(tc.name, func(t *testing.T) { t.Run(tc.name, func(t *testing.T) {
addresses := tc.input.Addresses(tc.argument) addresses := tc.input.Addresses(tc.argument)
require.ElementsMatch(t, tc.expected, addresses) require.ElementsMatch(t, tc.expected, addresses)