github
/
consul
mirror of https://github.com/hashicorp/consul
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

agent: Improve startup message to avoid confusing users when no error occurs (#5896) 

* Improve startup message to avoid confusing users when no error occurs

Several times, some users not very familiar with Consul get confused
by error message at startup:

  `[INFO] agent: (LAN) joined: 1 Err: <nil>`

Having `Err: <nil>` seems weird to many users, I propose to have the
following instead:

* Success: `[INFO] agent: (LAN) joined: 1`
* Error:   `[WARN] agent: (LAN) couldn't join: %d Err: ERROR`
pull/5874/head
Pierre Souchay 2019-05-24 16:50:18 +02:00 committed by Hans Hasselberg
parent 17e74985b0
commit e892981418
1 changed files with 13 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
agent/agent.go
View File

@ -1581,12 +1581,16 @@ func (a *Agent) ShutdownCh() <-chan struct{} {
func (a *Agent) JoinLAN(addrs []string) (n int, err error) { func (a *Agent) JoinLAN(addrs []string) (n int, err error) {
a.logger.Printf("[INFO] agent: (LAN) joining: %v", addrs) a.logger.Printf("[INFO] agent: (LAN) joining: %v", addrs)
n, err = a.delegate.JoinLAN(addrs) n, err = a.delegate.JoinLAN(addrs)
a.logger.Printf("[INFO] agent: (LAN) joined: %d Err: %v", n, err) if err == nil {
if err == nil && a.joinLANNotifier != nil { a.logger.Printf("[INFO] agent: (LAN) joined: %d", n)
if a.joinLANNotifier != nil {
if notifErr := a.joinLANNotifier.Notify(systemd.Ready); notifErr != nil { if notifErr := a.joinLANNotifier.Notify(systemd.Ready); notifErr != nil {
a.logger.Printf("[DEBUG] agent: systemd notify failed: %v", notifErr) a.logger.Printf("[DEBUG] agent: systemd notify failed: %v", notifErr)
} }
} }
} else {
a.logger.Printf("[WARN] agent: (LAN) couldn't join: %d Err: %v", n, err)
}
return return
} }
@ -1598,7 +1602,11 @@ func (a *Agent) JoinWAN(addrs []string) (n int, err error) {
} else { } else {
err = fmt.Errorf("Must be a server to join WAN cluster") err = fmt.Errorf("Must be a server to join WAN cluster")
} }
a.logger.Printf("[INFO] agent: (WAN) joined: %d Err: %v", n, err) if err == nil {
a.logger.Printf("[INFO] agent: (WAN) joined: %d", n)
} else {
a.logger.Printf("[WARN] agent: (WAN) couldn't join: %d Err: %v", n, err)
}
return return
} }