From e743eefbd10496c9b6974ad79d16837e1af401c0 Mon Sep 17 00:00:00 2001 From: malizz Date: Tue, 13 Sep 2022 13:59:44 -0700 Subject: [PATCH] update enforcing consecutive 5xx type to pointer type (#14592) * update enforcing condecutive 5xx type to pointer type * update test --- api/config_entry.go | 2 +- api/config_entry_test.go | 12 +++++++++--- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/api/config_entry.go b/api/config_entry.go index 63115b0a6a..acdb5bfa86 100644 --- a/api/config_entry.go +++ b/api/config_entry.go @@ -200,7 +200,7 @@ type PassiveHealthCheck struct { // EnforcingConsecutive5xx is the % chance that a host will be actually ejected // when an outlier status is detected through consecutive 5xx. // This setting can be used to disable ejection or to ramp it up slowly. - EnforcingConsecutive5xx uint32 `json:",omitempty" alias:"enforcing_consecutive_5xx"` + EnforcingConsecutive5xx *uint32 `json:",omitempty" alias:"enforcing_consecutive_5xx"` } // UpstreamLimits describes the limits that are associated with a specific diff --git a/api/config_entry_test.go b/api/config_entry_test.go index 49b3d0d010..4dc10170f5 100644 --- a/api/config_entry_test.go +++ b/api/config_entry_test.go @@ -452,7 +452,8 @@ func TestDecodeConfigEntry(t *testing.T) { "Name": "redis", "PassiveHealthCheck": { "MaxFailures": 3, - "Interval": "2s" + "Interval": "2s", + "EnforcingConsecutive5xx": 60 } }, { @@ -502,8 +503,9 @@ func TestDecodeConfigEntry(t *testing.T) { { Name: "redis", PassiveHealthCheck: &PassiveHealthCheck{ - MaxFailures: 3, - Interval: 2 * time.Second, + MaxFailures: 3, + Interval: 2 * time.Second, + EnforcingConsecutive5xx: uint32Pointer(60), }, }, { @@ -1381,3 +1383,7 @@ func TestDecodeConfigEntry(t *testing.T) { func intPointer(v int) *int { return &v } + +func uint32Pointer(v uint32) *uint32 { + return &v +}