github
/
consul
mirror of https://github.com/hashicorp/consul
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

ui: chore - fix CI test-suite (#13799) 

* fix linting issue

* Update datacenter selector page-object to not include separator.

* change non-valid li to div for singe dc name
pull/13800/head
Michael Klein 2022-07-19 15:06:11 +02:00 committed by GitHub
parent 067272b53f
commit dc84ea9f85
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
ui/packages/consul-ui/app/components/consul/datacenter/selector/index.hbs
View File

@ -27,6 +27,7 @@
</menu.Separator> </menu.Separator>
{{#each menu.items as |item|}} {{#each menu.items as |item|}}
<menu.Item <menu.Item
data-test-dc-item
aria-current={{if (eq @dc.Name item.Name) 'true'}} aria-current={{if (eq @dc.Name item.Name) 'true'}}
class={{class-map class={{class-map
(array 'is-local' item.Local) (array 'is-local' item.Local)
@ -55,7 +56,9 @@
</disclosure.Menu> </disclosure.Menu>
</DisclosureMenu> </DisclosureMenu>
{{else}} {{else}}
<li class="dc-name" data-test-datacenter-single>{{@dcs.firstObject.Name}}</li> <div class="dc-name" data-test-datacenter-single>
{{@dcs.firstObject.Name}}
</div>
{{/if}} {{/if}}
</li> </li>

2
ui/packages/consul-ui/app/components/hashicorp-consul/pageobject.js
View File

@ -50,7 +50,7 @@ export default (collection, clickable, attribute, is, authForm, emptyState) => s
':checked', ':checked',
'[data-test-nspace-menu] > input[type="checkbox"]' '[data-test-nspace-menu] > input[type="checkbox"]'
); );
page.navigation.dcs = collection('[data-test-datacenter-menu] li', { page.navigation.dcs = collection('[data-test-datacenter-menu] [data-test-dc-item]', {
name: clickable('a'), name: clickable('a'),
}); });
return page; return page;

3
ui/packages/consul-ui/tests/integration/components/hashicorp-consul-test.js
View File

@ -1,7 +1,6 @@
import { module, skip, test } from 'qunit'; import { module, skip } from 'qunit';
import { setupRenderingTest } from 'ember-qunit'; import { setupRenderingTest } from 'ember-qunit';
import hbs from 'htmlbars-inline-precompile'; import hbs from 'htmlbars-inline-precompile';
import { render } from '@ember/test-helpers';
module('Integration | Component | hashicorp consul', function(hooks) { module('Integration | Component | hashicorp consul', function(hooks) {
setupRenderingTest(hooks); setupRenderingTest(hooks);